Pushed via: PR - https://github.com/tianocore/edk2/pull/2181 Commit - https://github.com/tianocore/edk2/commit/b5d4a35d90771ec86ce9cf28727f471ee589fb78
Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > gaoliming > Sent: Thursday, November 4, 2021 2:00 PM > To: mikub...@linux.microsoft.com; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; > Ni, Ray <ray...@intel.com> > Subject: [edk2-devel] 回复: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix > missing DEBUG arguments > > Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > > > -----邮件原件----- > > 发件人: mikub...@linux.microsoft.com <mikub...@linux.microsoft.com> > > 发送时间: 2021年11月3日 23:16 > > 收件人: devel@edk2.groups.io > > 抄送: Jian J Wang <jian.j.w...@intel.com>; Liming Gao > > <gaolim...@byosoft.com.cn>; Hao A Wu <hao.a...@intel.com>; Ray Ni > > <ray...@intel.com> > > 主题: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG > arguments > > > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3662 > > > > Two DEBUG macros in XhciDxe/XhciSched.c are missing the argument that > > should be passed for the print specifier. > > > > In addition, this change updates the print level to "DEBUG_ERROR" > > and prints the status as well. > > > > Cc: Jian J Wang <jian.j.w...@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Hao A Wu <hao.a...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > > --- > > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > index 7cbc9a8502ea..6fcd2be6277c 100644 > > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > @@ -2299,7 +2299,7 @@ XhcInitializeDeviceSlot ( > > DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n", > > DeviceAddress)); > > Xhc->UsbDevContext[SlotId].XhciDevAddr = DeviceAddress; > > } else { > > - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n")); > > + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned > > successfully. Status = %r\n", SlotId, Status)); > > XhcDisableSlotCmd (Xhc, SlotId); > > } > > > > @@ -2512,7 +2512,7 @@ XhcInitializeDeviceSlot64 ( > > DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n", > > DeviceAddress)); > > Xhc->UsbDevContext[SlotId].XhciDevAddr = DeviceAddress; > > } else { > > - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n")); > > + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned > > successfully. Status = %r\n", SlotId, Status)); > > XhcDisableSlotCmd64 (Xhc, SlotId); > > } > > > > -- > > 2.28.0.windows.1 > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83432): https://edk2.groups.io/g/devel/message/83432 Mute This Topic: https://groups.io/mt/86810253/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
