[edk2-devel] [PATCH 0/1] Add EDK2 Redfish JSON C Structure stuff into the build

This commit adds below Redfish JSON C Structure stuff into the build, - edk2 Redfish JSON to C Structure libraries - edk2 Redfish JSON to C Structure DXE drivers There are three relevant commits to this one those were not sent for the review because those are script auto-generated files and too ma

[edk2-devel] [edk2-platforms][PATCH v2 2/2] BoardModulePkg/BoardBdsHookLib: Simplify hotkey registration

Retrieve BootOption of BootManagerMenu for registering F7 hotkey, rather than creating an additional boot option. Tested, both F7 hotkey still opens the list of boot options. Cc: Eric Dong Cc: Liming Gao Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/BoardModulePkg/Librar

[edk2-devel] [edk2-platforms][PATCH v2 1/2] BoardModulePkg/BoardBdsHookLib: Register UiApp as boot option

BootManagerMenuApp is the default PcdBootManagerMenuFile. It allows choosing a boot device, but system configuration is performed in UiApp. Therefore, un-comment and fix UiApp boot option registration. The F2 hotkey can be used to enter UiApp. Cc: Eric Dong Cc: Liming Gao Cc: Nate DeSimone Sig

[edk2-devel] [edk2-platforms][PATCH v2 4/5] Platform/Intel: Early hook-up Acer Aspire VN7-572G

Note that the SKU IDs do not represent register values, they were chosen somewhat arbitrarily. We perform the mapping ourselves, so the definitions can be changed. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Benjamin Doron --- Platform/Intel/KabylakeOpenBoardPkg/Inclu

[edk2-devel] [edk2-platforms][PATCH v2 3/5] KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files

This makes diffing the follow-up board changes in these files easier. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Benjamin Doron --- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/{DxeKabylakeRvp3AcpiTableLib.c => DxeAspireVn7Dash572GAcpi

[edk2-devel] [edk2-platforms][PATCH v2 1/5] KabylakeOpenBoardPkg/BaseEcLib: Add some common EC commands

Add EC read (0x80) and write (0x81) commands, as defined by ACPI. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Benjamin Doron --- Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h | 32 + Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Inc

[edk2-devel] [edk2-platforms][PATCH v2 0/5] KabylakeOpenBoardPkg: Add AspireVn7Dash572G

This patchset adds support for a Acer Aspire VN7-572G (SKL-U laptop) board to KabylakeOpenBoardPkg, based on Kabylake RVP 3. As stated in a later commit message, there is a second, similar board: VN7-792G. - VN7-572G = "Rayleigh". Working, supported. Uses PCH-LP. - VN7-792G = "Newgate". Assumed bro

Re: [edk2-devel] [2021-gsoc-llvm-gnumake]: proposal for building using llvm/gnumake

Hi Steven, Have you considered using the --rtlib switch? It would eliminate the dependency on the system's libgcc, crtbegin/end.o and crti/o.o, for most systems. I don't know exactly how the build system works but I assume there's some way to force a compiler flag. Best regards, Pedro On Fri, 1

Re: [edk2-devel] [Patch 2/2] BaseTools: a new build option for variable default value generation

> On Aug 13, 2021, at 11:31 AM, Sean wrote: > > Bob, > > Given this is a new feature that needs a lot of review and discussion can it > get moved over to the edk2-basetools project. Since the Python Basetools RFC > was accepted months ago and the CI system updated to use those artifacts > (

Re: [edk2-devel] [PATCH v4 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

On 8/13/21 2:47 PM, Sean Brogan wrote: Thanks for the link as i missed that message. To me this just points out more problems with how OVMF is being managed in the edk2 project and the uselessness of edk2 platforms as anything more than just a dumping ground repo to hold sample code.  But t

Re: [edk2-devel] [PATCH v4 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

Thanks for the link as i missed that message. To me this just points out more problems with how OVMF is being managed in the edk2 project and the uselessness of edk2 platforms as anything more than just a dumping ground repo to hold sample code. But that is a problem larger than this patchset

Re: [edk2-devel] [Patch 2/2] BaseTools: a new build option for variable default value generation

Bob, Given this is a new feature that needs a lot of review and discussion can it get moved over to the edk2-basetools project. Since the Python Basetools RFC was accepted months ago and the CI system updated to use those artifacts (instead of the source), that is where Basetools/Source/Pytho

Re: [edk2-devel] [edk2-platforms][PATCH v2] BoardModulePkg/BoardBdsHookLib: Register UiApp as boot option

Actually, mBootMenuOptionNumber could be left alone for this patch, so it would be best to keep the patches separate: get UiApp working, then cleanup BootManagerMenuApp. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79289): https://edk

Re: [edk2-devel] [edk2-platforms][PATCH v2] BoardModulePkg/BoardBdsHookLib: Register UiApp as boot option

Hi Nate, Sure, I can do that. The UiApp boot option can then also be marked hidden. Also, because of the way this patch would change hotkey handling, I'll drop https://edk2.groups.io/g/devel/topic/84671368. Regards, Benjamin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sen

[edk2-devel] [PATCH v1 1/2] ShellPkg: Update Acpiview PCCT parser to ACPI 6.4

Bugzilla: 3563 (https://bugzilla.tianocore.org/show_bug.cgi?id=3563) Update the Acpiview PCCT parser to use Acpi64.h. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c | 46 ++-- ShellPkg/Library/UefiShellAcpiViewCommandLi

[edk2-devel] [PATCH v1 0/2] Support ACPI 6.4 in Acpiview PCCT parser

Bugzilla: 3563 (https://bugzilla.tianocore.org/show_bug.cgi?id=3563) This patch series adds support for ACPI 6.4 to the Acpiview PCCT parser by using Acpi64.h and adding parsing, validation and printing support for the new 'Type 5' subspace structure. The changes can be seen at: https://github.c

[edk2-devel] [PATCH v1 2/2] ShellPkg: Add Type 5 PCC Subspace Structure parser

Bugzilla: 3563 (https://bugzilla.tianocore.org/show_bug.cgi?id=3563) Update the Acpiview PCCT parser with the HW Registers based Communications Subspace Structure (Type 5) as defined in Section 14.1.7 of the ACPI 6.4 specification. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiVi

Re: [edk2-devel] SecCore evacuation in PeiCore?

Hi Marvin, I apologize for the delayed response, I missed this message earlier. The function was called from EvacuateTempRam() in the initial set of patches: [PATCH 1/6] MdeModulePkg/PeiCore: Enable T-RAM evacuation in PeiCore (CVE-2019-11098) (groups.io)

[edk2-devel] [edk2-libc Patch] StdLib/Include/sys/syslimits.h: Increase OPEN_MAX from 20 to 255

From: Jayaprakash Nevara REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3548 A port of Python 3.6.8 interpreter for UEFI uses the standard C Library from the edk2-libc project. The python interpreter fails with the following error when the python interpreter is launched: "IOError: [Errno 2

Re: [edk2-devel] [Patch 2/2] BaseTools: a new build option for variable default value generation

> On Aug 13, 2021, at 4:45 AM, Bob Feng wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3562 > > Create a new build option to enable vfrcompile to generate Json > format EFI variable information file and read it to generate > the EFI variable default value binary file. > > Sig

Re: [edk2-devel] [edk2-platforms PATCH] Platform/RaspberryPi: Remove unnecessary files

Thanks! Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: Marcin Wojtas > Sent: Friday, August 13, 2021 10:42 AM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud > ; Sunny Wang > ; g...@semihalf.com; upstr...@semihalf.com;

[edk2-devel] [edk2-platforms PATCH] Platform/RaspberryPi: Remove unnecessary files

Commit 2f0188b56ef4 ("Revert "Platform/RaspberryPi: Setup option for...") mistakenly introduced to files which are residues from a conflict resolution. Fix that. Signed-off-by: Marcin Wojtas --- Platform/RaspberryPi/RPi4/RPi4.dsc.orig | 760 Platform/RaspberryPi/RPi4/RPi4.ds

[edk2-devel] [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Correct logical for identifying cache type

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3265 Correct the logical for identifying "Direct mapped" cache type. Signed-off-by: Jason Lou Cc: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 2 +- 1 file changed, 1 inse

[edk2-devel] Bug #3522 patch

Hi, Refer to: Bug #3522 There is a problem in RegisterStaticHotkey() of BoardBootOption.c that it still RegisterBootOptionHotkey() for F7 key on Boot if mBootMenuOptionNumber is not assigned. mBootMenuOptionNumber is not assigned (LoadOp

Re: [edk2-devel] [2021-gsoc-llvm-gnumake]: proposal for building using llvm/gnumake

Liming, The MSVC is required only because the Windows SDK Universal C runtime (UCRT) library depends on the MSVC. Please see the dependency description here: “When you install Visual C++, Visual Studio setup installs the subset of the Windows 10 SDK required to use the UCRT.” https://docs.micr

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/CpuCacheInfoLib: Correct logical for identifying cache type

Sure, I will change it in next version patch. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79276): https://edk2.groups.io/g/devel/message/79276 Mute This Topic: https://groups.io/mt/84855450/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH v4 0/6] Ovmf: Disable the TPM2 platform hierarchy

Yao,   do you have any comments on this series? Would SecurityPkg be a better place for it?     Stefan On 8/12/21 12:59 PM, Stefan Berger wrote: This series imports code from the edk2-platforms project related to changing the password of the TPM2 platform hierarchy and uses it to disable t

Re: [edk2-devel] [PATCH V2] RedfishClientPkg/ConvertLib: Common code and header files

Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Friday, August 13, 2021 6:22 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [PATCH V2] RedfishClientPkg/ConvertLib: Common code and header files

[edk2-devel] [Patch 2/2] BaseTools: a new build option for variable default value generation

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3562 Create a new build option to enable vfrcompile to generate Json format EFI variable information file and read it to generate the EFI variable default value binary file. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen --- BaseTool

[edk2-devel] [Patch 1/2] BaseTools: Enable VfrCompile to dump variable default value

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3562 Create new command line option to have VfrCompile generate a Json format file that contains the EFI Variable related information including: 1. The C struct associate the EFI variable 2. The variable vendor Guid, name and attribute 3. The var

[edk2-devel] [Patch 0/2] BaseTools: Generate EFI Variable default value file

For the first time boot, when there is no data in the NvStore area, the platform needs to get the EFI variable default value from somewhere. The current solution to resolve this problem is leveraging the FCE tool, which is under the edk2-staging repo FceFmmt branch, to generate the EFI variable

Re: [edk2-devel] [PATCH] RedfishClientPkg/ConvertLib: Common code and header files

Hi Nickle, V2 patch just sent. I added the function header to each function. However, those files are part of DMTF project thus I didn't follow the edk2 coding standard. Abner > -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Thursday, August 12, 2021 10:18 PM >

[edk2-devel] [PATCH V2] RedfishClientPkg/ConvertLib: Common code and header files

ConverterLib/ is the folder of script-generated JSON to C library for the each Redfish schema. The common code and header files in this patch are used by those libraries. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao --- .../ConverterLib/include/RedfishCsCommon.h| 125 ++ .../

[edk2-devel] Hard Feature Freeze starts now for edk2-stable202108

Hi, all Today, we enter into Hard Feature Freeze phase until edk2-stable202108 tag is created at 2021-08-27. Tag edk2-stable202108-rc1 (6fdd1c13a734609aff68d37e606e995d673d9aeb) has been created for evaluation. In this phase, there is no feature to be pushed. The critical bug fix is still allowe

Re: [edk2-devel] [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot failure

HI Gary Several comment: 1) According to our process, we need a Bugzilla. Would you please file it? 2) I do not understand how HVM direct kernel boot is related to S3 enabling. It seems 1/3/4/5 are for S3, while 2 is for missing driver. Should we split them to 2 patch set? 3) Does the S3 issue o

Re: [edk2-devel] [PATCH V2 0/4] Enable Dynamic ACPI for LS1046AFRWY

Sunny, Apologies for late response. (Not keeping well these days) Ok, PSB my remarks. #1. True, if an entity is independently getting build must be prefixed with Pkg. In my previous discussion with Leif (https://edk2.groups.io/g/devel/message/70090) Leif requested a reason of this kind of setup

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/CpuCacheInfoLib: Correct logical for identifying cache type

> +CacheData[CacheParamLeafIndex].DirectMappedCache = > (UINT8)(!CacheParamEdx.Bits.ComplexCacheIndexing); Instead of using "!", can you please use "CacheParamEdx.Bits.ComplexCacheIndexing == 0"? This is more readable. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages

Re: [edk2-devel] [PATCH] MdePkg/Base.h: Introduce various alignment-related macros

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Marvin > H?user > Sent: Friday, August 13, 2021 4:41 PM > To: devel@edk2.groups.io; Wu, Hao A > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang ; > Wang, Jian J ; Ni, Ray ; Vitaly > Cheptsov > Subject: Re: [edk2-devel] [

Re: [edk2-devel] [PATCH] MdePkg/Base.h: Introduce various alignment-related macros

On 13/08/2021 09:27, Wu, Hao A wrote: -Original Message- From: Marvin Häuser Sent: Monday, August 9, 2021 3:40 AM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Liming Gao ; Liu, Zhiguang ; Wang, Jian J ; Wu, Hao A ; Ni, Ray ; Vitaly Cheptsov Subject: [PATCH] MdePkg/Base.h: Introduce

Re: [edk2-devel] [PATCH] MdePkg/Base.h: Introduce various alignment-related macros

> -Original Message- > From: Marvin Häuser > Sent: Monday, August 9, 2021 3:40 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang ; > Wang, Jian J ; Wu, Hao A ; Ni, > Ray ; Vitaly Cheptsov > Subject: [PATCH] MdePkg/Base.h: Introduce various alignment-rela

Re: [edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Simplify hotkey registration

Hi Benjamin, This patch is unable to apply unless the content of your other patch https://edk2.groups.io/g/devel/message/78309 has already been merged. Accordingly, after you address my feedback on the first patch please send this patch as part of the same patch series so it can be applied clea

Re: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile

Hi Benjamin, It would be good to add a check on the status code returned from PublishAcpiTablesFromFv() to the debug log. Something like this: Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r",

Re: [edk2-devel] [edk2-platforms][PATCH v1 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

Hi Benjamin, It would be good to add a check on the status code returned from PublishAcpiTablesFromFv() to the debug log. Something like this: Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r",

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

Hi Benjamin, It would be good to add a check on the status code returned from PublishAcpiTablesFromFv() to the debug log. Something like this: Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r",

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

Hi Benjamin, It would be good to add a check on the status code returned from PublishAcpiTablesFromFv() to the debug log. Something like this: Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r",