Hi Benjamin,
It would be good to add a check on the status code returned from
PublishAcpiTablesFromFv() to the debug log. Something like this:
Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r",
&gEfiCallerIdGuid, Status));
}
Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile));
if (EFI_ERROR (Status)) {
DEBUG ((
DEBUG_ERROR,
"Error: PublishAcpiTablesFromFv[%g] - %r",
PcdGetPtr (PcdAcpiTableStorageFile),
Status
));
}
I know the original code doesn't do it, but I imagine this will be helpful to
some poor soul who is trying to debug issues with this later on.
Thanks,
Nate
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benjamin Doron
Sent: Wednesday, August 4, 2021 12:59 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L
<nathaniel.l.desim...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; Dong,
Eric <eric.d...@intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi:
MinDsdt also installs all PcdAcpiTableStorageFile
Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI
tables added by board.
Cc: Chasel Chiu <chasel.c...@intel.com>
Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Eric Dong <eric.d...@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doro...@gmail.com>
---
Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 +
Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 2 ++
2 files changed, 3 insertions(+)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
index 9bc222453857..417cccc18b5a 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
@@ -227,6 +227,7 @@ InstallMinDsdt (
Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid); ASSERT_EFI_ERROR
(Status);+ PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile));
return EFI_SUCCESS; }diff --git
a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
index 3437bc489cd3..3e14c4e9a65d 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
@@ -41,6 +41,8 @@
gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase
gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit +
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile+ [Depex]
gEfiAcpiTableProtocolGuid AND gEfiFirmwareVolume2ProtocolGuid--
2.31.1
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78665): https://edk2.groups.io/g/devel/message/78665
Mute This Topic: https://groups.io/mt/84670596/1767664
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub
[nathaniel.l.desim...@intel.com] -=-=-=-=-=-=
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79260): https://edk2.groups.io/g/devel/message/79260
Mute This Topic: https://groups.io/mt/84670596/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
