Re: [edk2-devel] [RFC PATCH 0/7] OVMF: Disable the TPM2 platform hierarchy

2021-08-07 Thread Yao, Jiewen
Thanks for the clarification. Comments below: > -Original Message- > From: Stefan Berger > Sent: Saturday, August 7, 2021 11:04 PM > To: Yao, Jiewen ; Stefan Berger > ; devel@edk2.groups.io > Cc: marcandre.lur...@redhat.com; ler...@redhat.com; > dick_wilk...@phoenix.com > Subject: Re: [R

Re: [edk2-devel] [RFC PATCH 0/7] OVMF: Disable the TPM2 platform hierarchy

2021-08-07 Thread Yao, Jiewen
Hi Marvin There are many factors impacting where to put the feature code - EDKII or EDKII-platform/Feature. I can list some of them: If it is a basic feature v.s. an advanced feature. If it is a mature production feature v.s. immature feature. If it is a generic core feature v.s. a platform specif

[edk2-devel] [Patch v2 3/3] Ext4Pkg: Add .DSC file.

2021-08-07 Thread Pedro Falcato
This file is required to build Ext4Pkg. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Bret Barkelew Signed-off-by: Pedro Falcato --- Features/Ext4Pkg/Ext4Pkg.dsc | 68 1 file changed, 68 insertions(+) create mode 100644 Features/Ext4Pkg/Ext4Pkg.dsc diff --

[edk2-devel] [Patch v2 1/3] Ext4Pkg: Add Ext4Pkg.dec and Ext4Pkg.uni.

2021-08-07 Thread Pedro Falcato
These files are needed to build Ext4Pkg. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Bret Barkelew Signed-off-by: Pedro Falcato --- Features/Ext4Pkg/Ext4Pkg.dec | 17 + Features/Ext4Pkg/Ext4Pkg.uni | 14 ++ 2 files changed, 31 insertions(+) create mode 100644 Feat

[edk2-devel] [Patch v2 0/3] Ext4Pkg: Add Ext4Pkg

2021-08-07 Thread Pedro Falcato
This patch-set adds Ext4Pkg, a package designed to hold various drivers and utilities related to the EXT4 filesystem. Right now, it holds a single read-only UEFI EXT4 driver (Ext4Dxe), which consumes the DISK_IO, BLOCK_IO and DISK_IO2 protocols and produce EFI_FILE_PROTOCOL and EFI_SIMPLE_FILE_SY

[edk2-devel] [edk2-non-osi PATCH] SolidRun/Cn913xCEx7Eval: Add DeviceTree

2021-08-07 Thread Marcin Wojtas
This patch introduces the top device tree for the CN913x CEx7 Evaluation Board, based on the sources which are common for the Cn913x SoCs. Also an .inf file is added to allow its compilation. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/OcteonTx/DeviceTree/T91/Cn913xCEx7Eval.inf | 22 + Sil

[edk2-devel] [edk2-platforms PATCH v2 3/3] SolidRun/Cn913xCEx7Eval: Add platform support

2021-08-07 Thread Marcin Wojtas
This patch adds the required platform description files, along with the hardware configuration libraries, for the SolidRun CN913x CEx7 Evaluation Board. Supported interfaces: * SPI flash & memory-mapped variable storage access * uSD * eMMC * 7x PCIE root complex * USB * Networking: * 1Gbps RGMII

[edk2-devel] [edk2-platforms PATCH v2 2/3] SolidRun/Cn913xCEx7Eval: Add ACPI support

2021-08-07 Thread Marcin Wojtas
This patch adds ACPI tables description for the SolidRun CN913x CEx7 Evaluation Board platform. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xCEx7Eval.inf| 61 +++ Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xCEx7Eval/Dbg2.h | 9

[edk2-devel] [edk2-platforms PATCH v2 1/3] Marvell: Armada7k8k/OcteonTx: Select ACPI description as a default

2021-08-07 Thread Marcin Wojtas
All currently supported platforms based on the Marvell SoCs offer both DT and ACPI. Reverse the default setting and pick ACPI as the main HW description. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Sili

[edk2-devel] [edk2-platforms PATCH v2 0/4] SolidRun CEx7 Evaluation Board support

2021-08-07 Thread Marcin Wojtas
Hi, The second version comes with a minor improvement, which is a result of the TF-A support update and changes around the default IO windows configuration. The patches are also available on public branches: https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/cex7-r20210807 https://g

[edk2-devel] SecCore evacuation in PeiCore?

2021-08-07 Thread Marvin Häuser
Good day everyone, Good day Michael, The commit that introduced T-RAM evacuation [1] also introduced the function "MigrateSecModulesInFv()". It also is explicitly mentioned as part of the control flow in the commit message. As far as I can see, since then till today this function has never bee

Re: [edk2-devel] [PATCH v2 0/4] UefiPayloadPkg: LinuxBoot Support in UefiPayload

2021-08-07 Thread Guo Dong
Hi Cheng-chieh, The Github comments is just for your reference to quick locate the comment place. You could update the PR with new changes and I could comment there. But we still need follow EDII requirement to review the patches by email. Thanks, Guo From: Cheng-Chieh Huang Sent: Saturday, A

[edk2-devel] [PATCH v2 4/4] UefiPayloadPkg: Reserve Payload config in runtime services data

2021-08-07 Thread Cheng-Chieh Huang via groups.io
Signed-off-by: Cheng-Chieh Huang Cc: Cheng-Chieh Huang Cc: Daniel Schaefer Cc: Trammell Hudson Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You --- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 4 1 file changed, 4 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPay

Re: [edk2-devel] [PATCH v2 0/4] UefiPayloadPkg: LinuxBoot Support in UefiPayload

2021-08-07 Thread Cheng-Chieh Huang via groups.io
Hi Guo, I saw you left messages in https://github.com/tianocore/edk2/pull/1820. If it's also possible to upstreaming using github PR. I can just update my old branch. -- Cheng-chieh On Sat, Aug 7, 2021 at 10:51 PM Cheng-Chieh Huang wrote: > These are necessary patches to Support LinuxBoot in U

[edk2-devel] [PATCH v2 3/4] UefiPayloadPkg: Update maximum logic processor to 256

2021-08-07 Thread Cheng-Chieh Huang via groups.io
Signed-off-by: Cheng-Chieh Huang Reviewed-by: Guo Dong Cc: Cheng-Chieh Huang Cc: Daniel Schaefer Cc: Trammell Hudson Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPa

[edk2-devel] [PATCH v2 2/4] UefiPayloadPkg: Use legacy timer in Linuxboot payload

2021-08-07 Thread Cheng-Chieh Huang via groups.io
HPET timer may fail to init after prior linux taking over. Signed-off-by: Cheng-Chieh Huang Reviewed-by: Guo Dong Cc: Cheng-Chieh Huang Cc: Daniel Schaefer Cc: Trammell Hudson Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You --- UefiPayloadPkg/UefiPayloadPkg.dsc | 6 ++ UefiPayloadPkg/Uef

[edk2-devel] [PATCH v2 1/4] UefiPayloadPkg: Add LINUXBOOT payload target

2021-08-07 Thread Cheng-Chieh Huang via groups.io
Initial commit to support linuxboot payload. Signed-off-by: Cheng-Chieh Huang Cc: Cheng-Chieh Huang Cc: Daniel Schaefer Cc: Trammell Hudson Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You --- UefiPayloadPkg/UefiPayloadPkg.dsc | 16 +- UefiPayloadPkg/Library/LbPar

[edk2-devel] [PATCH v2 0/4] UefiPayloadPkg: LinuxBoot Support in UefiPayload

2021-08-07 Thread Cheng-Chieh Huang via groups.io
These are necessary patches to Support LinuxBoot in UefiPayload. With these paches, we can boot to ESXi and Windows from a linux in QEMU. This is second parse. In addition to fixing reviwer's suggestions, I removed the following CLs. * Add DISABLE_MMX_SSE to avoid generating floating points operat

Re: [edk2-devel] [PATCH v1 6/6] UefiPayloadPkg: LinuxBoot: use a text format for the configuration block.

2021-08-07 Thread Cheng-Chieh Huang via groups.io
Thanks for the information. I will drop this patch in Patch set v2 for now and work with Trammell to revise this patch to fit EDK2 style. -- Cheng-Chieh On Wed, Aug 4, 2021 at 11:00 AM Dong, Guo wrote: > > Please run BaseTools\Scripts\PatchCheck.py to make sure it passed the > check. > > Update

Re: [edk2-devel] [RFC PATCH 0/7] OVMF: Disable the TPM2 platform hierarchy

2021-08-07 Thread Stefan Berger
On 8/7/21 2:00 AM, Yao, Jiewen wrote: Hi Stefan It seems this patch series is not a production fix. It is more like a prototype, my personally feeling.] Yes, it's an RFC patch and with the struggles as pointed out below. I don't know how this project would go about importing code from 'edk

Re: [edk2-devel] [RFC PATCH 0/7] OVMF: Disable the TPM2 platform hierarchy

2021-08-07 Thread Marvin Häuser
Hey Jiewen, Hey Stefan, On 07.08.21 08:00, Yao, Jiewen wrote: Hi Stefan It seems this patch series is not a production fix. It is more like a prototype, my personally feeling. A common issue in patch 2, 3, 4, 5, is that using "comment" to remove the code. Please remove the unnecessary code di