[edk2-devel] [PATCH edk2-platform v2 1/1] Hisilicon:Fix header file issues

EDK2 has removed header file ArmLibPrivate.h, so need to use ArmLib.h instead. A new file OemMiscLib.h is added to EDK2, its name is same with the header file in Hisilicon\Include and it will being included first. So changing the name of header file from OemMiscLib.h to OemHisiMiscLib.h. Cc: Leif

[edk2-devel] [PATCH edk2-platform v2 0/1] Hisilicon:Fix header file issues

Main Changes since v1: 1.change the name of header file. Wenyi Xie (1): Hisilicon:Fix header file issues Silicon/Hisilicon/HisiPkg.dec | 2 +- Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.h

Re: [edk2-devel] [PATCH v6 0/6] SEV Live Migration support for OVMF.

Hi I have some questions: 1) May I know what is the usage of this UEFI variable - SevLiveMigrationEnabled? I only see it is created, but I do not see how it is consumed. 2) Is this a full live migration patch, or is this just a startup and there will be more on the way? Thank you Yao Jiewen

回复: [edk2-devel] [PATCH v7 1/3] BaseTools: Remove COMMON section from the GCC discard list

Ard: Chris explains this change in https://edk2.groups.io/g/devel/message/77662. And, he also verifies the patch in OVMF with GCC5 tool chain. Thanks Liming > -邮件原件- > 发件人: Ard Biesheuvel > 发送时间: 2021年8月4日 20:27 > 收件人: Yao, Jiewen > 抄送: devel@edk2.groups.io; christopher.zurc...@outlo

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

Hi all, I plan to come back with the https://github.com/tianocore/edk2-staging/tree/CdePkg end of this year and to unroll the source code of fundamental parts of my C Library and discuss that along the 30. anniversary of “The C Book” https://publications.gbdirect.co.uk/c_book/chapter9 Addition

Re: [edk2-devel] [edk2-platforms] [PATCH V1] PurleyOpenBoardPkg : Add ReadMe document for LinuxBoot

Pushed: https://github.com/tianocore/edk2-platforms/commit/4b8483b -Original Message- From: devel@edk2.groups.io On Behalf Of manickavasakam karpagavinayagam Sent: Wednesday, August 4, 2021 5:00 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; fel...@ami.com; DOPP

Re: [edk2-devel] [edk2-platforms] [PATCH V1] PurleyOpenBoardPkg : Add ReadMe document for LinuxBoot

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of manickavasakam karpagavinayagam Sent: Wednesday, August 4, 2021 5:00 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; fel...@ami.com; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish ; B

Re: [edk2-devel] [edk2-platforms][PATCH] IpmiFeaturePkg: IPMI Transport PPI and Protocol for BIOS/BMC communication

Pushed: https://github.com/tianocore/edk2-platforms/commit/2333ea4 -Original Message- From: manickavasakam karpagavinayagam Sent: Thursday, June 10, 2021 4:44 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; fel...@ami.com; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish

Re: [edk2-devel] [edk2-platforms][PATCH] IpmiFeaturePkg: IPMI Transport PPI and Protocol for BIOS/BMC communication

Reviewed-by: Nate DeSimone -Original Message- From: manickavasakam karpagavinayagam Sent: Thursday, June 10, 2021 4:44 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; fel...@ami.com; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish ; Bobroff, Zachary ; KARPAGAVINAYAGAM,

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

I’d guess I’d also ask the why not NewLib? Especially since Red Hat helps out with edk2…. Thanks, Andrew Fish > On Aug 4, 2021, at 4:03 AM, Leif Lindholm wrote: > > Hi Rebecca, > > I think the truth is we're a bit resigned about edk2-libc in general. > My view is it should be either maintain

Re: [edk2-devel] [EXTERNAL] RE: [edk2-platforms][PATCH V2] PurleyOpenBoardPkg : Support for LINUX Boot

Pushed: https://github.com/tianocore/edk2-platforms/commit/06b6e5e -Original Message- From: Manickavasakam Karpagavinayagam Sent: Thursday, July 29, 2021 5:35 AM To: Desimone, Nathaniel L ; devel@edk2.groups.io Cc: Oram, Isaac W ; Felix Polyudov ; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish

Re: [edk2-devel] [EXTERNAL] RE: [edk2-platforms][PATCH V2] PurleyOpenBoardPkg : Support for LINUX Boot

Hi Manic, That is fair. I see your new patch which add a readme.md explaining that. With that... Reviewed-by: Nate DeSimone -Original Message- From: Manickavasakam Karpagavinayagam Sent: Thursday, July 29, 2021 5:35 AM To: Desimone, Nathaniel L ; devel@edk2.groups.io Cc: Oram, Isaac

Re: [edk2-devel] [PATCH 0/3] reuse the SevEsWork area

HI Brijesh Thanks for the startup. Feedback below: 1) I don't think we need a PCD to indicate the header. gUefiOvmfPkgTokenSpaceGuid.PcdOvmfWorkAreaHeaderSize|4|UINT32|0x51 Instead, if we define a HEADER structure, we can use sizeof() naturally. Otherwise, when we update this header, we need u

[edk2-devel] [edk2-platforms] [PATCH V1] PurleyOpenBoardPkg : Add ReadMe document for LinuxBoot

linux.efi/initrd.cpio.xz are dummy files. These dummy files needs to be replaced by building the Linux Kernel. 1. Follow directions on http://osresearch.net/Building/ to compile the heads kernel and initrd for qemu-system_x86_64 2. Copy the following built files (1) initrd.cpio.xz to L

[edk2-devel] [PATCH] Reallocate TPM Active PCRs based on platform support.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3515 In V2: Add case to RegisterHashInterfaceLib logic RegisterHashInterfaceLib needs to correctly handle registering the HashLib instance supported algorithm bitmap when PcdTpm2HashMask is set to zero. The current implementation of SyncPcrAllo

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

Another thing that was interesting to me is that PcdAcpiTableStorageFile is actually defined in MdeModulePkg and used in MdeModulePkg/Universal/Acpi/AcpiPlatformDxe. Our MinPlatform board packages do not use that driver, we have our own BoardAcpiDxe that varies with each silicon generation. For

[edk2-devel] [PATCH v3 2/2] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Add LINUX_EFI_INITRD_MEDIA_GUID to our collection of GUID definitions, it can be used in a media device path to specify a Linux style initrd that can be loaded by the OS using the LoadFile2 protocol. Move these defines to MdePkg from OvmfPkg as these are relevant to non-OVMF targets as well. Ref:

[edk2-devel] [PATCH v3 1/2] OvmfPkg: Remove Initrd LINUX_EFI_INITRD_MEDIA_GUID

Moving LINUX_EFI_INITRD_MEDIA_GUID to MdePkg, remove it from OvmfPkg. Signed-off-by: Jeff Brasen Reviewed-by: Michael D Kinney Acked-by: Ard Biesheuvel --- OvmfPkg/OvmfPkg.dec| 1 - OvmfPkg/Include/Guid/LinuxEfiInitrdMedia.h | 17 ---

[edk2-devel] [PATCH v3 0/2] Relocate LINUX_EFI_INITRD_MEDIA_GUID to MdePkg

Relocate LINUX_EFI_INITRD_MEDIA_GUID from OvmfPkg to MdePkg as it has use outside of Ovmf applications Jeff Brasen (2): OvmfPkg: Remove Initrd LINUX_EFI_INITRD_MEDIA_GUID MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID MdePkg/MdePkg.dec | 5 OvmfPkg/OvmfP

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

Hi Sai, There may be a requirement to install board-specific ACPI tables. For example, to support an embedded controller in laptops, or other controllers in servers and desktops. In a conversation with Nate about a board port in KabylakeOpenBoardPkg, I said that the options for such boards woul

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

Hi Benjamin, The problem statement is not clear to me. Could you share any background for this change - RFC, Bugzilla etc? Thanks, Sai Chaganty -Original Message- From: Benjamin Doron Sent: Wednesday, August 04, 2021 12:59 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathan

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

On Wed, 4 Aug 2021 at 20:39, Kinney, Michael D wrote: > > Ard, > > The intermediate state should not cause any problems. > > I prefer single patches not modify more than one package. > Fair enough. Jeff: mind splitting this into two patches, one against MdePkg and one against OvmfPkg? You can ca

Re: [edk2-devel] [PATCH] Maintainers.txt: Add new maintainer and reviewer to EmbeddedPkg/

On Wed, 4 Aug 2021 at 22:32, Leif Lindholm wrote: > > +Ard > > On Wed, Aug 04, 2021 at 22:47:24 +0800, Abner Chang wrote: > > Add Abner Chang as the maintainer of EmbeddedPkg/ > > Add Daniel Schaefer as the reviewer of EmbeddedPkg/ > > > > Signed-off-by: Abner Chang > > Cc: Daniel Schaefer > > C

[edk2-devel] [edk2-platforms][PATCH v1 1/2] AcpiDebugFeaturePkg: Modules are DRIVER_ACPITABLE

Fix assert when trying to retrieve the ACPI table. However, now a second bug can be seen: SMM module also calls the DXE module's notification, causing a second ACPI table to be installed with colliding definitions. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Benjamin Doron --- Features/Intel/

[edk2-devel] [edk2-platforms][PATCH v1 2/2] IpmiFeaturePkg: BmcAcpi is DRIVER_ACPITABLE

While I am unable to test IPMI changes, this patch should ensure that the ACPI table can be located. Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Benjamin Doron --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf | 2 +- 1 file changed, 1 insertion(+

[edk2-devel] [edk2-platforms][PATCH v1] BoardModulePkg/BoardBdsHookLib: Simplify hotkey registration

If BootOption free is delayed, hotkey registration can be simplified. There will be no need to register an additional boot option. Tested, both F2 and F7 keys still open the list of boot options. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Benjamin Doron --- Platform/Intel/BoardModulePkg/Libr

[edk2-devel] [edk2-platforms][PATCH v1 3/4] Platform/Intel: Early hook-up Acer Aspire VN7-572G

Note that the SKU IDs do not represent register values, they were chosen somewhat arbitrarily. We perform the mapping ourselves. Signed-off-by: Benjamin Doron --- Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h | 2 ++ Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec |

[edk2-devel] [edk2-platforms][PATCH v1 2/4] KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files

This makes diffing the follow-up board changes in these files easier. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/{DxeKabylakeRvp3AcpiTableLib.c => DxeAspireVn7Dash572GAcpiTableLib.c} | 0

[edk2-devel] [edk2-platforms][PATCH v1 0/4] KabylakeOpenBoardPkg: Add AspireVn7Dash572G

This patchset adds support for a Acer Aspire VN7-572G (SKL-U laptop) board to KabylakeOpenBoardPkg, based on Kabylake RVP 3. As stated in a later commit message, there is a second, similar board: VN7-792G. - VN7-572G = "Rayleigh". Working, supported. Uses PCH-LP. - VN7-792G = "Newgate". Assumed bro

Re: [edk2-devel] [PATCH] Maintainers.txt: Add new maintainer and reviewer to EmbeddedPkg/

+Ard On Wed, Aug 04, 2021 at 22:47:24 +0800, Abner Chang wrote: > Add Abner Chang as the maintainer of EmbeddedPkg/ > Add Daniel Schaefer as the reviewer of EmbeddedPkg/ > > Signed-off-by: Abner Chang > Cc: Daniel Schaefer > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Michael D Kinney Reviewe

[edk2-devel] [PATCH 2/3] OvmfPkg/ResetVector: update SEV support to use new work area format

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Update the SEV support to switch to using the newer work area format. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Signed-off-by: Brijesh Singh --- OvmfPkg/Reset

[edk2-devel] [PATCH 3/3] OvmfPkg/ResetVector: move the GHCB page setup in AmdSev.asm

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 While build the initial page table, the SetCr3ForPageTables64 checks whether SEV-ES is enabled. If so, clear the page encryption mask from the GHCB page. Move the logic to clear the page encryption mask in the AmdSev.asm. Cc: James Bottomley

[edk2-devel] [PATCH 1/3] OvmfPkg: introduce a common work area

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Both the TDX and SEV support needs to reserve a page in MEMFD as a work area. The page will contain meta data specific to the guest type. Currently, the SEV-ES support reserves a page in MEMFD (PcdSevEsWorkArea) for the work area. This page c

[edk2-devel] [PATCH 0/3] reuse the SevEsWork area

Based on the discussion on the mailing list, we agreed that instead of wasting extra page in the MEMFD, we can reuse the SevEsWorkArea buffer for the TDX. To avoid any confusion, lets introduce a OvmfWorkArea that will contains 32 bytes of header followed by the actual workarea. While at it, move

[edk2-devel] [edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt also installs all PcdAcpiTableStorageFile

Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + Platform/Intel/MinPlatformPkg/

[edk2-devel] [edk2-platforms][PATCH v1 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/WhiskeylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 1 + Platform/Intel/WhiskeylakeOpenBoardPkg/Acp

[edk2-devel] [edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Signed-off-by: Benjamin Doron --- Platform/Intel/CometlakeOpenBoardPkg/Acpi/Boa

[edk2-devel] [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile

Follow AcpiPlatformDxe (from which this module is derived) and install all ACPI tables added by board. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Benjamin Doron --- Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 1 + Platform/Intel/KabylakeOpenBoardPkg/Acpi/Boar

[edk2-devel] Please help fix this error in midas

I keep getting an error when making a diags binary for a specific sdk: (Note: I do get a successful build without specifying the DUT sdk, but that build wouldn’t load in iBoot.) (Other note: This was run on a source based off of the latest version of midas on branch main) Command: $ SDK_VERS=

[edk2-devel] [edk2-platforms][PATCH v1] KabylakeOpenBoardPkg/GalagoPro3: Deduplicate PeiSiliconPolicyNotifyLib

GalagoPro3 board has a duplicate copy of PeiSiliconPolicyNotifyLib. Remove it, and use the copy under KabylakeOpenBoardPkg/FspWrapper/ instead. Cc: Jeremy Soller Signed-off-by: Benjamin Doron --- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/PeiSiliconPolicyNotifyLib/PeiPre

[edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Move TpmPlatformHierarchyLib definition

Move library definition inside the Include/Dsc directory, so that boards are not required to explicitly declare this common library. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron --- Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 1 +

Re: [edk2-devel] [PATCH v1 0/2] Fix duplicated GUID

Pushed as 5ba08a9b7516..b3e49860769f Thanks. Regards, Sami Mujawar On 04/08/2021 12:11 PM, Leif Lindholm wrote: On Wed, Jun 23, 2021 at 08:37:29 +0100, pierre.gond...@arm.com wrote: From: Pierre Gondois Some inf modules have a duplicated GUID, triggering an error when running a local CI.

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Ard, The intermediate state should not cause any problems. I prefer single patches not modify more than one package. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Wednesday, August 4, 2021 9:56 AM > To: Kinney, Michael D > Cc: devel@edk2.gr

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

On Wed, 4 Aug 2021 at 18:51, Kinney, Michael D wrote: > > Hi Jeff, > > Yes. This looks good. > > Reviewed-by: Michael D Kinney > Thanks Mike Unless anyone objects, I am going to merge this as a single patch, rather than suggest that adding to MdePkg and removing from OvmfPkg be done as two sep

Re: [edk2-devel] [PATCH] Maintainers.txt: Add new maintainer and reviewer to EmbeddedPkg/

Reviewed by: Andrew Fish > On Aug 4, 2021, at 7:47 AM, Abner Chang wrote: > > Add Abner Chang as the maintainer of EmbeddedPkg/ > Add Daniel Schaefer as the reviewer of EmbeddedPkg/ > > Signed-off-by: Abner Chang > Cc: Daniel Schaefer > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Michael D K

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

Hi Jeff, Yes. This looks good. Reviewed-by: Michael D Kinney Mike From: devel@edk2.groups.io On Behalf Of Jeff Brasen via groups.io Sent: Tuesday, August 3, 2021 11:44 AM To: Ard Biesheuvel Cc: edk2-devel-groups-io ; Ard Biesheuvel ; Kinney, Michael D ; Justen, Jordan L ; Liming Gao (

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Poking this one. 1. It’s a easy review with small, obvious code change. 2. I need some answers on “when is it okay to violate ECC/PatchCheck, if the new code matches the style of the existing code. Should I endeavor to pass the PatchCheck and ECCCheck with this patch only, and leave it in

[edk2-devel] [PATCH] Maintainers.txt: Add new maintainer and reviewer to EmbeddedPkg/

Add Abner Chang as the maintainer of EmbeddedPkg/ Add Daniel Schaefer as the reviewer of EmbeddedPkg/ Signed-off-by: Abner Chang Cc: Daniel Schaefer Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Maintainers.tx

[edk2-devel] [edk2-platforms: PATCH V3] Platform/Intel: Correct CPU APIC IDs.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365 BIOS cannot find correct AcpiProcId in mApicIdMap because of there is no suitable map, that causes ACPI_BIOS_ERROR. Remove mApicIdMap for determing AcpiProcId, uses normal countings instead. Signed-off-by: JackX Lin Cc: Chasel Chiu Cc: Je

[edk2-devel] [edk2-platforms: PATCH V3] Platform/Intel: Correct CPU APIC IDs.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365 BIOS cannot find correct AcpiProcId in mApicIdMap because of there is no suitable map, that causes ACPI_BIOS_ERROR. Remove mApicIdMap for determing AcpiProcId, uses normal countings instead. Signed-off-by: JackX Lin Cc: Chasel Chiu Cc: Je

[edk2-devel] [edk2-platforms: PATCH V3] Platform/Intel: Correct CPU APIC IDs.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365 BIOS cannot find correct AcpiProcId in mApicIdMap because of there is no suitable map, that causes ACPI_BIOS_ERROR. Remove mApicIdMap for determing AcpiProcId, uses normal countings instead. Signed-off-by: JackX Lin Cc: Chasel Chiu Cc: Je

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Update page alignment calculations

I tested this patch on Ampere Altra system. Tested-by: Paul Yang -Original Message- From: Sunny Wang Sent: Monday, July 19, 2021 4:08 PM To: devel@edk2.groups.io Cc: Sunny Wang ; Samer El-Haj-Mahmoud ; G Edhaya Chandran ; Barton Gao ; Sunny Wang Subject: [edk2-test][PATCH v1 1/1] ue

Re: [edk2-devel] [PATCH v1 4/6] UefiPayloadPkg: Reserve Payload config in runtime services data

Hi Guo, Thanks for the review. This is a quick fix for today's PlatformHookLib design. PlatformHookLib (probably via PlatformBootManagerLib) will be linked by BDS and potentially called again in Windows bootloader. If we did not reserve this range of memory, system will crash the system when it wa

Re: [edk2-devel] [PATCH v1 4/6] UefiPayloadPkg: Reserve Payload config in runtime services data

Hi Cheng-Chieh, I see. In order to use same PlatformHookLib to make DebugLib works in both PayloadEntry and DXE phase, the PlatformHookLib gets serial port info from bootloader. In the DXE phase, UniversalPayloadPlatformHookLib will use HOB instead of getting info from bootloader. In the Paylo

Re: [edk2-devel] [RFC PATCH v4 00/27] Add AMD Secure Nested Paging (SEV-SNP) support

See my feedback below. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Brijesh > Singh via groups.io > Sent: Tuesday, August 3, 2021 11:01 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: brijesh.si...@amd.com; James Bottomley ; Xu, Min M > ; Tom Lendacky ; Justen, > Jorda

Re: [edk2-devel] [PATCH V4 3/3] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf

On August 4, 2021 6:01 PM, Erdem Aktas wrote: > I agree with Brijesh on that this patch should be divided into smaller ones. In Brijesh's comments he will help to do following: 1. introduce the updated CcWorkArea structure 2. update the existing code to use the CcWorkArea layout Based on his patch

Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h

> -Original Message- > From: Leif Lindholm [mailto:l...@nuviainc.com] > Sent: Wednesday, August 4, 2021 8:34 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io; Schaefer, Daniel ; > Ard Biesheuvel ; Anup Patel > > Subject: Re: [edk2-devel] [PATCH v1 1/1] Embedded

Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h

Gah, sorry. The original patch landed while I was distracted, and this reminder while I was on holiday. Apart from the typo in the subject line, I guess I'm OK with this. Acked-by: Leif Lindholm However, I have a feeling RISC-V will be updating EmbeddedPkg as frequently as ARM in the near futur

Re: [edk2-devel] 回复: [edk2-platforms PATCH v6 0/4] Secure Boot default keys

On Wed, 4 Aug 2021 at 04:21, gaoliming wrote: > > Sunny: > I am OK to merge the reviewed patched first. > Patches 2-4 merged as 2f0188b56ef4..5ba08a9b7516 Thanks all > > -邮件原件- > > 发件人: Sunny Wang > > 发送时间: 2021年8月3日 22:11 > > 收件人: Grzegorz Bernacki ; devel@edk2.groups.io; > > ardb

Re: [edk2-devel] [PATCH v7 1/3] BaseTools: Remove COMMON section from the GCC discard list

On Wed, 21 Jul 2021 at 13:44, Yao, Jiewen wrote: > > Acked-by: Jiewen Yao > I don't think this is a good idea tbh. We have already identified that EDK2 code often fails to use the STATIC keyword when possible for global variables, and that unrelated variables that happen to have the same name wi

Re: [edk2-devel] [PATCH edk2-Platform v1 1/1] Hisilicon:Fix header file issues

+Rebecca Apologies for slow response, this arrived while I was on holiday. On Tue, Jun 22, 2021 at 20:33:25 +0800, wenyi,xie via groups.io wrote: > EDK2 has removed header file ArmLibPrivate.h, so need to > use ArmLib.h instead. A new file OemMiscLib.h is added > to EDK2, its name is same with th

Re: [edk2-devel] [PATCH v1 0/2] Fix duplicated GUID

On Wed, Jun 23, 2021 at 08:37:29 +0100, pierre.gond...@arm.com wrote: > From: Pierre Gondois > > Some inf modules have a duplicated GUID, triggering an error > when running a local CI. Modify the GUID of the most recent > module. > > The changes can be seen at: > https://github.com/PierreARM/ed

Re: [edk2-devel] "StdLibPkg" branch on edk2-staging

Hi Rebecca, I think the truth is we're a bit resigned about edk2-libc in general. My view is it should be either maintained or deprecated (or replaced). And maintainership *should* mean at least keeping it up to date with security fixes. I personally have no enthusiasm for the topic, but if ther

Re: [edk2-devel] [PATCH V4 3/3] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf

I agree with Brijesh on that this patch should be divided into smaller ones. On Mon, Aug 2, 2021 at 6:18 PM Min Xu wrote: > > +; > +; EBP[6:0] CPU supported GPA width > +; > +and ebp, 0x3f Based on https://software.intel.com/content/dam/develop/external/us/en/documents/tdx-m

Re: [edk2-devel] [PATCH V4 1/3] OvmfPkg: Add Tdx BFV/CFV PCDs and PcdOvmfImageSizeInKb

Reviewed-by: Erdem Aktas On Mon, Aug 2, 2021 at 6:18 PM Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Tdx Virtual Firmware (TDVF) includes one Firmware Volume (FV) known > as the Boot Firmware Volume (BFV). The FV format is defined in the > UEFI Platform Initial

Re: [edk2-devel] [PATCH V2 0/4] Enable Dynamic ACPI for LS1046AFRWY

Hi Vikas, Sorry for the delay and thanks for clarifying. Added my further rcomments below: 1. For your previous discussion with Leif, do you mean this one https://edk2.groups.io/g/devel/message/70090? If my understanding of your previous discussion is correct, the reason why you needed to

Re: [edk2-devel] [PATCH EDK2 v2 1/1] MdeModulePkg/UefiSortLib:Add UefiSortLib unit test

> -Original Message- > From: xiewenyi (A) > Sent: Wednesday, August 4, 2021 4:05 PM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: songdongku...@huawei.com; Wang, Jian J > Subject: Re: [edk2-devel] [PATCH EDK2 v2 1/1] MdeModulePkg/UefiSortLib:Add > UefiSortLib unit test > > > > On 2021/8

Re: [edk2-devel] [PATCH EDK2 v2 1/1] MdeModulePkg/UefiSortLib:Add UefiSortLib unit test

On 2021/8/2 9:56, Wu, Hao A wrote: >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Wu, Hao >> A >> Sent: Thursday, July 29, 2021 4:26 PM >> To: Wenyi Xie ; devel@edk2.groups.io; Wang, Jian >> J >> Cc: songdongku...@huawei.com >> Subject: Re: [edk2-devel] [PATCH EDK2 v2

Re: [edk2-devel] [PATCH V2 3/4] NXP/LS1046aFrwyPkg: Enable ConfigurationManager on LS1046AFRWY

Hi Vikas, Sorry for the delay and thanks for clarifying. 1. OK. I was just curious why we need to override it to include fewer tables. Isn't it better to support more ACPI tables? Anyways, I'm fine with the current change because it is intended. We can discuss this later once we're done with