Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

In today's TianoCore Design Meeting we reviewed the Overview Section (from slide 1 to 20). Thanks much for the valuable feedbacks and comments. The meeting minutes will be sent out soon. To address the concerns of the *one binary* solution in previous discussion, we propose 2 Configurations for

[edk2-devel] [PATCH v1 1/2] MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy

From: Ken Lautner Changed BdsEntry.c to use Variable Policy instead of Variable Lock as Variable Lock will be Deprecated eventually Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Liming Gao Signed-off-by: Kenneth Lautner --- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 4 +++-

[edk2-devel] [PATCH v2 2/2] Fixed Library references

From: Ken Lautner Changed BdsEntry.c to use Variable Policy instead of Variable Lock as Variable Lock will be Deprecated eventually Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Liming Gao Signed-off-by: Kenneth Lautner --- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 1 - Mde

Re: [edk2-devel] 回复: [PATCH v1 1/1] MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy

Liming, I plan on fixing those modules as well. I created a new Bugzilla here: 3449 – VariablePolicy needs to replace VariableLock. (tianocore.org) . On Wed, Jun 9, 2021 at 5:53 PM gaoliming wrote: > Ken: > I add my comment below. Besides,

Re: [edk2-devel] [EXTERNAL] RE: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error

Issac : We defined the macros as these macros are already used in edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg\GenericIpmi\Dxe\IpmiInit.c GetDeviceId() Please let us know who needs to correct the edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg\GenericIpmi\Dx

回复: [edk2-devel] [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error

KARP: I don't find the source code in edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg to consume new struct IPMI_SET_BOOT_OPTIONS_RESPONSE. Can you point which source file depend on new definition? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Oram, Isaac > W >

回复: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Fix incorrect file mask across package matrices

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Kun Qin > 发送时间: 2021年6月10日 9:48 > 收件人: devel@edk2.groups.io > 抄送: Sean Brogan ; Bret Barkelew > ; Michael D Kinney > ; Liming Gao > 主题: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Fix incorrect file mask > across packag

[edk2-devel] 回复: [PATCH v2 2/2] Fixed Library references

Ken: Please combine them into one commit. You just need to update the first patch. Thanks Liming > -邮件原件- > 发件人: kenlautn...@gmail.com > 发送时间: 2021年6月11日 7:48 > 收件人: devel@edk2.groups.io > 抄送: Jian J Wang ; Hao A Wu > ; Zhichao Gao ; Ray Ni > ; Liming Gao > 主题: [PATCH v2 2/2] Fixed Li

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 06/10/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

[edk2-devel] 回复: [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

Reviewed-by: Liming Gao > -邮件原件- > 发件人: Nickle Wang > 发送时间: 2021年6月10日 12:57 > 收件人: devel@edk2.groups.io > 抄送: gaolim...@byosoft.com.cn; jian.j.w...@intel.com; > hao.a...@intel.com; Nickle Wang > 主题: [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in > FreePool() > > Memor

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 06/10/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

On Thu, 2021-06-10 at 21:38 -0400, James Bottomley wrote: > On Fri, 2021-06-11 at 01:36 +, Yao, Jiewen wrote: > > Hi James. > > I attached the invitation and copied all content below: > > > > == > > ## TOPIC > > > > 1. NA > > > > For more info, see here: https

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

On Fri, 2021-06-11 at 01:36 +, Yao, Jiewen wrote: > Hi James. > I attached the invitation and copied all content below: > > == > ## TOPIC > > 1. NA > > For more info, see here: https://www.tianocore.org/design-meeting/ > > --- > ## Microsoft Teams meeting >

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

Hi James. I attached the invitation and copied all content below: == ## TOPIC 1. NA For more info, see here: https://www.tianocore.org/design-meeting/ --- ## Microsoft Teams meeting ### Join on your computer or mobile app [Click here to join the meeting](https

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

On Thu, 2021-06-10 at 22:30 +, Xu, Min M wrote: > Hi, All > Thanks much for the valuable comments and discussion about the > design. > We have updated the slides (v0.9) in below link. If some comments or > concerns are not answered/addressed in the new slides, please don't > hesitate to tell us

[edk2-devel] Happening Now: TianoCore Design Meeting - APAC/NAMO - 06/11/2021 #cal-notice

*TianoCore Design Meeting - APAC/NAMO* *When:* 06/11/2021 9:30am to 10:30am (UTC+08:00) Asia/Shanghai *Where:* Microsoft Teams *Organizer:* Ray Ni ray...@intel.com ( ray...@intel.com?subject=Re:%20Event:%20TianoCore%20Design%20Meeting%20-%20APAC%2FNAMO ) View Event ( https://edk2.groups.io/g/

[edk2-devel] Event: TianoCore Design Meeting - APAC/NAMO - 06/11/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCATION:Asia/Shanghai BEGIN:STANDARD TZNAME:CST TZOFFSETFROM:+

Re: [edk2-devel] [edk2-platforms][Patch 2/3] KabylakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value

Reviewed-by: Chasel Chiu > -Original Message- > From: Kinney, Michael D > Sent: Friday, June 11, 2021 6:46 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][Patch 2/3] KabylakeSiliconPkg/BaseSmbusLib: Fix > SmBusSendByte value > >

Re: [edk2-devel] [edk2-platforms][Patch 1/3] CoffeelakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value

Reviewed-by: Chasel Chiu > -Original Message- > From: Kinney, Michael D > Sent: Friday, June 11, 2021 6:46 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > > Subject: [edk2-platforms][Patch 1/3] CoffeelakeSiliconPkg/BaseSmbusLib: Fix > SmBusSendByte value > >

Re: [edk2-devel] [edk2-platforms][Patch 0/3] Fix SmBusSendByte value

Hi Mike, Please remember to update the copyright year on all 3 files. With that change... Reviewed-by: Nate DeSimone -Original Message- From: Kinney, Michael D Sent: Thursday, June 10, 2021 3:46 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel ; Chaganty, Rangasai

Re: [edk2-devel] [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error

Please comment the following commenting per normal style /* Definitions for Get BMC Execution Context */ Which would co

Re: [edk2-devel] [edk2-platforms][PATCH] IpmiFeaturePkg: IPMI Transport PPI and Protocol for BIOS/BMC communication

Reviewed-by: Isaac Oram -Original Message- From: manickavasakam karpagavinayagam Sent: Thursday, June 10, 2021 4:44 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; fel...@ami.com; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish ; Bobroff, Zachary ; KARPAGAVINAYAGAM, MA

[edk2-devel] [edk2-platforms][Patch 3/3] QuarkSocPkg/SmbusLib: Fix SmBusSendByte value

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3452 Update SmBusSendByte() to write value to Command Register instead of Host Data registers. Cc: Nate DeSimone Signed-off-by: Michael D Kinney --- .../Library/SmbusLib/SmbusLib.c | 27 --- 1 file changed, 18 in

[edk2-devel] [edk2-platforms][Patch 1/3] CoffeelakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3450 Update SmBusSendByte() to write value to Command Register instead of Host Data registers. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael D Kinney --- .../Pch/Library/BaseSmbusLib/BaseSmbusLib.c | 24 +-- 1 fil

[edk2-devel] [edk2-platforms][Patch 2/3] KabylakeSiliconPkg/BaseSmbusLib: Fix SmBusSendByte value

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3451 Update SmBusSendByte() to write value to Command Register instead of Host Data registers. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Michael D Kinney --- .../Pch/Library/BaseSmbusLib/BaseSmbusLib.c | 24 +-- 1 fi

[edk2-devel] [edk2-platforms][Patch 0/3] Fix SmBusSendByte value

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3452 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3451 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3450 Update SmBusSendByte() to write value to Command Register instead of Host Data registers. Cc: Nate DeSimone Cc: Chasel Chiu

Re: [edk2-devel] [PATCH 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmLib.h

On 6/10/21 9:04 AM, Ard Biesheuvel wrote: On Tue, 8 Jun 2021 at 15:54, Rebecca Cran wrote: Many of the cache definitions in ArmLibPrivate.h are being used outside of ArmLib, in Universal/Smbios. Move them into ArmLib.h to make them public, and remove the include of ArmLibPrivate.h from files in

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

Hi, All Thanks much for the valuable comments and discussion about the design. We have updated the slides (v0.9) in below link. If some comments or concerns are not answered/addressed in the new slides, please don't hesitate to tell us. We do want to answer/address all the comments/concerns. But

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

Hi all, Sorry for the late reply. I like to add some clarification on "one binary". I feel like the way everyone uses the term "one binary" in the email threads is causing some confusion. As I have tried to explain before, we are not looking for everything in a single binary. As Laszlo has menti

Re: [edk2-devel] Commit a9d1fb58 - uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent

> On Jun 10, 2021, at 11:05 AM, Heinrich Schuchardt wrote: > > On 6/10/21 7:22 PM, Samer El-Haj-Mahmoud wrote: >> + Mike >> >> I agree with Sunny's evaluation. The original EDK2 patch from Jan had good >> feedback from Mike K.. The exact language from the UEFI spec section 7.1 is: >> >> " C

Re: [edk2-devel] Commit a9d1fb58 - uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent

On 6/10/21 7:22 PM, Samer El-Haj-Mahmoud wrote: + Mike I agree with Sunny's evaluation. The original EDK2 patch from Jan had good feedback from Mike K.. The exact language from the UEFI spec section 7.1 is: " Consequently, there is a fourth TPL, TPL_HIGH_LEVEL, designed for use exclusively by

Re: [edk2-devel] GSOC 2021 EXT4 driver Project

edk2-platforms/Features/Ext4Pkg sounds good to me too. / Leif On Thu, Jun 10, 2021 at 17:38:17 +, Michael D Kinney wrote: > Hi Pedro, > > After thinking about this, I think I would prefer Option (4). > > The proposed landing zone would be a new Ext4Pkg in the edk2-platforms > repositor

Re: [edk2-devel] GSOC 2021 EXT4 driver Project

Hi Pedro, After thinking about this, I think I would prefer Option (4). The proposed landing zone would be a new Ext4Pkg in the edk2-platforms repository in the Features directory. edk2-platforms/Features/Intel/Ext4Pkg All the features in that directory and not specific to Intel. There are ot

Re: [edk2-devel] FtdiUsbSerialDxe

Hi Nathaniel, FYI, I've created a Bugzilla for this issue. https://bugzilla.tianocore.org/show_bug.cgi?id=3444 Thanks, Jack From: Little, Jack Sent: Thursday, May 27, 2021 11:26 AM To: Desimone, Nathaniel L ; devel@edk2.groups.io Cc: Desimone, Ashley E Subject: RE: FtdiUsbSerialDxe You may be

Re: [edk2-devel] qemu: arm: mounting ubifs using nandsim on busybox

On Thu, 10 Jun 2021 at 19:22, Richard Weinberger wrote: > > Pintu, > > - Ursprüngliche Mail - > > Von: "Pintu Agarwal" > >> nandsim works as expected. It creates a new and *erased* NAND for you. > >> So you have no UBI volumes. Therfore UBIFS cannot be mounted. > >> I suggest creating a t

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - 06/10/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - 06/10/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

Re: [edk2-devel] [PATCH 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmLib.h

On Tue, 8 Jun 2021 at 15:54, Rebecca Cran wrote: > > Many of the cache definitions in ArmLibPrivate.h are being used outside > of ArmLib, in Universal/Smbios. Move them into ArmLib.h to make them > public, and remove the include of ArmLibPrivate.h from files in > Universal/Smbios. > > Signed-off-b

Re: [edk2-devel] [PATCH v1 3/3] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header

On Wed, 9 Jun 2021 at 16:39, Laszlo Ersek wrote: > > On 06/09/21 14:18, Dov Murik wrote: > > Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the > > ground to add a warning about the incompatibility with boot verification > > process. > > > > Cc: Laszlo Ersek > > Cc: Ard Biesheuv

Re: [edk2-devel] [PATCH v1 2/3] OvmfPkg/GenericQemuLoadImageLib: Read cmdline from QemuKernelLoaderFs

Hello Dov, On Wed, 9 Jun 2021 at 14:18, Dov Murik wrote: > > Remove the QemuFwCfgLib interface used to read the QEMU cmdline > (-append argument) and the initrd size. Instead, use the synthetic > filesystem QemuKernelLoaderFs which has three files: "kernel", "initrd", > and "cmdline". > > Cc: La

Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Brown > Sent: Thursday, June 10, 2021 6:43 PM > To: devel@edk2.groups.io; mhaeu...@posteo.de; Ni, Ray > Cc: Ma, Maurice ; Dong, Guo ; You, > Benjamin > Subject: Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add

Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload

On 10/06/2021 11:13, Marvin Häuser wrote: On 10.06.21 11:39, Ni, Ray wrote: Maybe for some context, my main issue at first was that the checks are all proper runtime checks with no ASSERTs at all, so I got confused how this situation could happen in a realistic scenario. I needed to trace the Pa

Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload

On 10.06.21 11:39, Ni, Ray wrote: Maybe for some context, my main issue at first was that the checks are all proper runtime checks with no ASSERTs at all, so I got confused how this situation could happen in a realistic scenario. I needed to trace the ParseStatus data flow to understand the idea

Re: [edk2-devel] [Patch V4 0/9] Create multiple Hobs for Universal Payload

Liming, Bugzilla is created at https://bugzilla.tianocore.org/show_bug.cgi?id=3447 Thanks Zhiguang > -Original Message- > From: gaoliming > Sent: Thursday, June 10, 2021 5:14 PM > To: devel@edk2.groups.io; Liu, Zhiguang > Subject: 回复: [edk2-devel] [Patch V4 0/9] Create multiple Hobs fo

Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload

> Maybe for some context, my main issue at first was that the checks are > all proper runtime checks with no ASSERTs at all, so I got confused how > this situation could happen in a realistic scenario. I needed to trace > the ParseStatus data flow to understand the idea is basically the same > as i

回复: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

Dov: Can you submit one BZ for this new feature? I will add it into edk2 202108 stable tag planning. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Laszlo Ersek > 发送时间: 2021年6月9日 21:54 > 收件人: Dov Murik ; devel@edk2.groups.io; Ard > Biesheuvel > 抄送: Tobin Feldman-Fitzthum ; Tob

回复: [edk2-devel] [Patch V4 0/9] Create multiple Hobs for Universal Payload

Zhiguang: Can you submit one BZ for this new feature? I will add it into edk2 202108 stable tag planning. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Zhiguang Liu > 发送时间: 2021年6月10日 9:33 > 收件人: devel@edk2.groups.io > 主题: [edk2-devel] [Patch V4 0/9] Create multiple Hobs for U

[edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg, RegisterFilterLibNull which will be consumed by IoLib and BaseLib was added in MdeLibs.dsc.inc. To build UefiSct with edk2-stable202105 and later, this f

Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload

On 10.06.21 05:40, Ni, Ray wrote: Without the ParseStatus field, callee cannot know whether ParseElfImage() is called. It can by function contracts, the caller guarantees it. I.e. with the PE library I linked, no other function must be called before the init function. Your "ParseElfImage" funct