回复: 回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for RiscV64

2021-05-20 Thread gaoliming
Daniel: Thanks for your information. Acked-by: Liming Gao And, do you request to merge this patch for edk2 stable tag 202105? Thanks Liming 发件人: devel@edk2.groups.io 代表 Daniel Schaefer 发送时间: 2021年5月21日 13:27 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn 抄送: Chang, Abner (HPS S

回复: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

2021-05-20 Thread gaoliming
This patch is reviewed before soft feature freeze. So, I create PR https://github.com/tianocore/edk2/pull/1659 to merge it for this stable tag. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming > 发送时间: 2021年5月16日 16:10 > 收件人: 'Garrett Kirkendall' ; > devel@edk2.groups.io

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype

2021-05-20 Thread Sunny Wang
The change looks good to me. Added some more info for Liming and others reference. For DBG2, https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table Table 3. Debug port types and subtypes 0x0005 Nvidia 16550 For SPCR, https://docs.microsoft.com/en-us/windows-har

[edk2-devel] [PATCH V2] BaseTools: Add -ffat-lto-objects option in GCC5 tool chain

2021-05-20 Thread gaoliming
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3403 Now, some uninitialized warning can't be detected on GCC5 tool chain, but can be detected on GCC49 tool chain. Edk2 CI only covers GCC5 tool chain. So, the merged code may impact GCC49 build. This option is added to expose such uninitializ

回复: [edk2-devel] 回复: [PATCH] MdeModulePkg/PlatformDriOverrideDxe: Fix overflow condition check

2021-05-20 Thread gaoliming
Create PR https://github.com/tianocore/edk2/pull/1658. This patch passed code review before soft feature freeze. So, I merge it for this stable tag. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming > 发送时间: 2021年5月13日 11:14 > 收件人: 'Walon Li' ; devel@edk2.groups.io > 抄送: ni

回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype

2021-05-20 Thread gaoliming
Ashish: Sorry. I miss the patch cover letter. I see this subtype is defined in https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug -port-table. So, I agree this fix. Reviewed-by: Liming Gao Now, we are in Soft Feature Freeze for edk2-stable202105. I will merge t

Re: 回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for RiscV64

2021-05-20 Thread Daniel Schaefer
Great! It is verified I can boot Linux from a virtio ESP using this patch on QEMU virt machine. See: https://github.com/riscv/riscv-edk2-platforms/runs/2618819010?check_suite_focus=true Thanks, Daniel From: devel@edk2.groups.io on behalf of gaoliming Sent: Fr

[edk2-devel] [PATCH v2] IntelSiliconPkg/VTd: Support queued invalidation interface

2021-05-20 Thread Sheng Wei
Add queued invalidation interface support for VTd core driver. For software to invalidate the various caching structures, the architecture supports the following two types of invalidation interfaces. 1. Register-based invalidation interface 2. Queued invalidation interface. BIOS shall check VER_RE

回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype

2021-05-20 Thread gaoliming
Ashish: Is NVIDIA 16550 Subtype defined in the public spec? If yes, can you share the link? Thanks Liming 发件人: devel@edk2.groups.io 代表 Ashish Singhal 发送时间: 2021年5月21日 4:33 收件人: Samer El-Haj-Mahmoud ; devel@edk2.groups.io; michael.d.kin...@intel.com; gaolim...@byosoft.com.cn; zhiguang@i

回复: 回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for RiscV64

2021-05-20 Thread gaoliming
Daniel: Now, it is clear to me. So, I suggest to merge this change when it is verified on generic RISC-V QEMU virt machine. Is it OK? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Daniel > Schaefer > 发送时间: 2021年5月18日 10:35 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn >

回复: 回复: [edk2-devel] [PATCH] BaseTools: Add -ffat-lto-objects option in GCC5 tool chain

2021-05-20 Thread gaoliming
Laszlo: Sure. I will include gcc issue link in the commit message. I will send V2 patch. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Laszlo Ersek > 发送时间: 2021年5月20日 15:27 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: 'Sergei Dmitrouk' ; 'Bob Feng' > ; 'Ard Biesheuvel' > 主题:

Re: 回复: [edk2-devel] GSoC 2021 Qemu OpenBoardPkg Project

2021-05-20 Thread Oram, Isaac W
I think we should patch first and move to a common location later. Looking at some of your changes and comments, I have these comments: * Rather than commenting out things you don’t need in the build, our thinking was to allow some unnecessary building in the interest of reducing porting co

Re: 回复: [edk2-devel] GSoC 2021 Qemu OpenBoardPkg Project

2021-05-20 Thread Daniel Schaefer
Thanks for the answers, that's very helpful, guys! I've started to replace some of my DSC and FDF with the include files mentioned by Michael. Since RISC-V doesn't have I/O registers, SMM and some other things, I had to make some changes but not too many. Maybe for Qemu there would have be some

Re: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add EHL microcode

2021-05-20 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-non-osi/commit/2e8dd46 -Original Message- From: Lim, Jin Jhu Sent: Thursday, May 6, 2021 2:11 AM To: devel@edk2.groups.io Cc: Lim, Jin Jhu ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeS

Re: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add EHL microcode

2021-05-20 Thread Nate DeSimone
Hi Jin Jhu, The only issue is that you forgot to update the copyright year from 2020 to 2021. I'll do that for you during the commit process. Reviewed-by: Nate DeSimone -Original Message- From: Lim, Jin Jhu Sent: Thursday, May 6, 2021 2:11 AM To: devel@edk2.groups.io Cc: Lim, Jin Jhu

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype

2021-05-20 Thread Ashish Singhal
Hello Michael/Gao/Zhiguang, Any update on this? Thanks Ashish From: Samer El-Haj-Mahmoud Sent: Tuesday, May 18, 2021 3:14 PM To: devel@edk2.groups.io ; Ashish Singhal ; michael.d.kin...@intel.com ; gaolim...@byosoft.com.cn ; zhiguang@intel.com Cc: Samer E

Re: [edk2-devel] error CODE: Unknown

2021-05-20 Thread Andrew Fish via groups.io
> On May 20, 2021, at 12:58 PM, Aaron Delaney wrote: > > I'm currently trying to build edk2 on Ubuntu. once I get to the portion of > code "build" and This is the error and messsage I receive and was told to > email this email I have attached a screenshot of the stack trace! > Aaron, Looks

[edk2-devel] error CODE: Unknown

2021-05-20 Thread Aaron Delaney
I'm currently trying to build edk2 on Ubuntu. once I get to the portion of code "build" and This is the error and messsage I receive and was told to email this email I have attached a screenshot of the stack trace! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [External] 回复: [edk2-devel] A plea for help

2021-05-20 Thread Fowler, Eric (Mondo International, LLC) via groups.io
I had no idea I was engaging so many people. The problem has resolved to a Python versioning issue, and has been solved. This was aggravated by the fact that when Python is invoked by issuing a shell command to ‘call’ a *.py file, the mapping to python version follows the Windows shell when one

Re: 回复: [edk2-devel] GSoC 2021 Qemu OpenBoardPkg Project

2021-05-20 Thread Michael Kubacki
Daniel, You will specifically find attempts to consolidate common libraries and modules in DSC and FDF files that can be included into a board package here - https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/MinPlatformPkg/Include. Files are split such that they can be in

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area

2021-05-20 Thread Lendacky, Thomas
On 5/19/21 2:27 AM, Laszlo Ersek wrote: > On 05/17/21 17:03, Lendacky, Thomas wrote: >> On 5/16/21 11:22 PM, Laszlo Ersek wrote: > >>> But now, with SEV-ES enabled, we'll have a separate, discontiguous area >>> -- and neither BackupAndPrepareWakeupBuffer(), nor its counterpart >>> RestoreWakeup

Re: 回复: [edk2-devel] GSoC 2021 Qemu OpenBoardPkg Project

2021-05-20 Thread Oram, Isaac W
Daniel, The MinPlatform spec was intended to be architecture and product independent for a “mainstream” set of products. It is intended to constrain some of the nearly unlimited extensibility and flexibility of UEFI specs and edk2 codebase. We took an 80/20 kind of approach. Base design shou

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area

2021-05-20 Thread Lendacky, Thomas
On 5/18/21 12:17 PM, Laszlo Ersek wrote: > On 05/17/21 17:03, Lendacky, Thomas wrote: >> On 5/16/21 11:22 PM, Laszlo Ersek wrote: >>> On 05/14/21 22:28, Lendacky, Thomas wrote: BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fi

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Remove hardcode 48 address size limitation

2021-05-20 Thread Michael Brown
On 18/05/2021 19:42, Laszlo Ersek wrote: On 05/18/21 09:51, Ni, Ray wrote: Thanks for explaining why you don't think it's a good patch. I thought anytime changing a code, I should try to make it better, functional better, looks better. My only point was that separate concerns should be implem

Re: [edk2-devel] [PATCH v3 00/13] Add GHCBv2 macro and helpers

2021-05-20 Thread Laszlo Ersek
On 05/19/21 20:19, Brijesh Singh wrote: > This series is taken from the SNP RFC. This series defines the GHCBv2 > macros and NAE events. Additionally, it also introduces a helper to > clear the page encryption mask from the Mmio region. > > The series is based on the commit: > 15ee7b76891a Crypto

Re: [edk2-devel] [PATCH v3 08/13] MdePkg/BaseLib: add support for RMPADJUST instruction

2021-05-20 Thread Laszlo Ersek
On 05/19/21 20:19, Brijesh Singh wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The RMPADJUST instruction will be used by the SEV-SNP guest to modify the > RMP permissions for a guest page. See AMD APM volume 3 for further > details. > > Cc: James Bo

Re: [edk2-devel] [PATCH v3 06/13] MdePkg/Register/Amd: define GHCB macros for SNP AP creation

2021-05-20 Thread Laszlo Ersek
On 05/19/21 20:19, Brijesh Singh wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=33275 (1) The bugzilla number is still wrong (just differently wrong from how it was in v2). But I'll fix it up when I merge this, after the stable tag. > > Version 2 of GHCB int

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area

2021-05-20 Thread Laszlo Ersek
On 05/14/21 22:28, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3324 > > The SEV-ES stacks currently share a page with the reset code and data. > Separate the SEV-ES stacks from the reset vector code and data to avoid > possible stack overflows from overwriting the

Re: [edk2-devel] [PATCH 1/1] Update Home.md with the latest stable tag

2021-05-20 Thread Laszlo Ersek
On 05/20/21 06:54, Rebecca Cran wrote: > Update the home page to list the correct latest stable tag of > edk2-stable202102. > > Signed-off-by: Rebecca Cran > --- > Home.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Laszlo Ersek Pushed as commit 9f223b60543f ("Update

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Remove hardcode 48 address size limitation

2021-05-20 Thread Laszlo Ersek
Hi Ray, On 05/20/21 06:28, Ni, Ray wrote: >> >> My only point was that separate concerns should be implemented in >> separate patches, or at least (if they are really difficult, or >> overkill, to isolate) that they should be documented. >> >> Please try to think with your reviewers' mindsets in m

Re: 回复: [edk2-devel] [PATCH] BaseTools: Add -ffat-lto-objects option in GCC5 tool chain

2021-05-20 Thread Laszlo Ersek
On 05/20/21 04:37, gaoliming wrote: > Laszlo: > Here is the discussion https://edk2.groups.io/g/devel/message/75299. > Now, some uninitialized warning can't be detected on GCC5 tool chain, but > can be detected on GCC49 tool chain. > Edk2 CI only covers GCC5 tool chain. So, the merged code