回复: [edk2-devel] [PATCH 00/13] Add GHCBv2 macro and helpers

2021-05-07 Thread gaoliming
Brijesh: The changes in MdePkg is good to me. Reviewed-by: Liming Gao One minor comment is in Patch2. Its title should be MdePkg/Register/Amd: to align other patches. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Brijesh Singh > 发送时间: 2021年5月8日 4:38 > 收件人: devel@edk2.g

[edk2-devel] 回复: [PATCH v2 1/2] MdePkg/BaseRngLib: Add support for ARMv8.5 RNG instructions

2021-05-07 Thread gaoliming
Rebecca: > -邮件原件- > 发件人: Rebecca Cran > 发送时间: 2021年5月7日 22:23 > 收件人: devel@edk2.groups.io; Jiewen Yao ; Jian J > Wang ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Ard Biesheuvel > ; Sami Mujawar > 抄送: Rebecca Cran > 主题: [PATCH v2 1/2] MdePkg/BaseRngLib: Add support for ARMv8.5 R

[edk2-devel] 回复: [PATCH v2 2/2] SecurityPkg: Add support for RngDxe on AARCH64

2021-05-07 Thread gaoliming
Rebecca: > -邮件原件- > 发件人: Rebecca Cran > 发送时间: 2021年5月7日 22:23 > 收件人: devel@edk2.groups.io; Jiewen Yao ; Jian J > Wang ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Ard Biesheuvel > ; Sami Mujawar > 抄送: Rebecca Cran > 主题: [PATCH v2 2/2] SecurityPkg: Add support for RngDxe on AARCH

[edk2-devel] TianoCore Meeting Minutes - May 2021

2021-05-07 Thread Soumya Guptha
Revised minutes: TianoCore Community Meeting May 6, 2021 EVENTS: UEFI Plugfest (update from Dick Wilkins): We are planning a plug fest during the week of April 4th during 2022 in Hillsboro, Oregon. Google Summer of Code (update from Nate Desimone) * Google has reviewed the project submiss

[edk2-devel] TianoCore Meeting Minutes - May 2021

2021-05-07 Thread Soumya Guptha
TianoCore Community Meeting May 6, 2021 EVENTS: UEFI Plugfest (update from Dick Wilkins): We are planning a plug fest during the week of April 4th during 2022 in Hillsboro, Oregon. Google Summer of Code (update from Nate Desimone) * Google has accepted all of our projects. Google will

[edk2-devel] [PATCH 12/13] OvmfPkg/TpmMmioSevDecryptPei: use MemEncryptSevClearMmioPageEncMask()

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask for the Mmio address range. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Akt

[edk2-devel] [PATCH 10/13] OvmfPkg/AmdSevDxe: use MemEncryptSevClearMmioPageEncMask() to clear EncMask

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask for the Mmio and NonExistent address range. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Erse

[edk2-devel] [PATCH 13/13] OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The Flush parameter is used to provide a hint whether the specified range is Mmio address. Now that we have a dedicated helper to clear the memory encryption mask for the Mmio address range, its safe to remove the Flush parameter from MemEncr

[edk2-devel] [PATCH 07/13] MdePkg/BaseLib: add support for PVALIDATE instruction

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The PVALIDATE instruction validates or rescinds validation of a guest page RMP entry. Upon completion, a return code is stored in EAX, rFLAGS bits OF, ZF, AF, PF and SF are set based on this return code. If the instruction completed succesful

[edk2-devel] [PATCH 11/13] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: use Mmio helper to clear enc mask

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask for the Mmio address range. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Akt

[edk2-devel] [PATCH 06/13] MdePkg/Register/Amd: define GHCB macros for SNP AP creation

2021-05-07 Thread Brijesh Singh
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Version 2 of GHCB introduces NAE for creating AP when SEV-SNP is enabled in the guest VM. See the GHCB spec section for additional details. While at it, define the VMSA state save area that are required for creating the

[edk2-devel] [PATCH 04/13] MdePkg/Register/Amd: define GHCB macro for Register GPA structure

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 An SEV-SNP guest is required to perform the GHCB GPA registration. See the GHCB specification for further details. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc

[edk2-devel] [PATCH 03/13] MdePkg/Register/Amd: define GHCB macros for hypervisor feature detection

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Version 2 of GHCB introduces advertisement of features that are supported by the hypervisor. See the GHCB spec section 2.2 for an additional details. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: A

[edk2-devel] [PATCH 05/13] MdePkg/Register/Amd: define GHCB macro for the Page State Change

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The Page State Change NAE exit will be used by the SEV-SNP guest to request a page state change using the GHCB protocol. See the GHCB spec section 4.1.6 and 2.3.1 for more detail on the structure definitions. Cc: James Bottomley Cc: Min Xu

[edk2-devel] [PATCH 02/13] MdePkg/Amd: add white spaces to retain alignment for future expansion

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Version 2 of the GHCB spec introduces several new SNP-specific NAEs. Unfortunately, the names for those NAEs break the alignment. Add some white spaces so that the SNP support patches do not break the alignment. Cc: James Bottomley Cc: Min

[edk2-devel] [PATCH 01/13] MdePkg/Register/Amd: expand the SEV MSR to include the SNP definition

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 Define the SEV-SNP MSR bits. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Erdem Aktas Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by:

[edk2-devel] [PATCH 09/13] OvmfPkg/BaseMemEncryptSevLib: introduce MemEncryptSevClearMmioPageEncMask()

2021-05-07 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The MemEncryptSevClearMmioPageEncMask() helper can be used for clearing the memory encryption mask for the Mmio region. The MemEncryptSevClearMmioPageEncMask() is a simplifies version of MemEncryptSevClearPageEncMask() -- it does not flush t

[edk2-devel] [PATCH 08/13] MdePkg/BaseLib: add support for RMPADJUST instruction

2021-05-07 Thread Brijesh Singh
From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 The RMPADJUST instruction will be used by the SEV-SNP guest to modify the RMP permissions for a guest page. See AMD APM volume 3 for further details. Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc:

[edk2-devel] [PATCH 00/13] Add GHCBv2 macro and helpers

2021-05-07 Thread Brijesh Singh
This series is taken from the SNP RFC. This series defines the GHCBv2 macros and NAE events. Additionally, it also introduces a helper to clear the page encryption mask from the Mmio region. The series is based on the commit: f297b7f20010 UnitTestFrameworkPkg: Sample unit test hangs when running

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: Update SCMI Base Protocol version to 0x20000

2021-05-07 Thread Ard Biesheuvel
Hello Pierre, On Thu, 6 May 2021 at 12:43, wrote: > > From: Nicola Mazzucato > > The SCP-firmware has moved to full support for SCMIv2 which means that > the base protocol can be either compliant with SCMI v1 or v2. > > Allow any version between SCMI v1.0 and SCMI v2.0 to be compatible > with th

Re: [edk2-devel] [PATCH v2 0/2] MdePkg,SecurityPkg: Add support to RngDxe and BaseRngLib for AARCH64 RNDR

2021-05-07 Thread Ard Biesheuvel
On Fri, 7 May 2021 at 16:23, Rebecca Cran wrote: > > Update MdePkg BaseRngLib and SecurityPkg RngDxe to add support for > the AARCH64 RNDR instruction. > > Changes from v1 to v2: > > o Added a PCD, gEfiSecurityPkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm to > specify which algorighm the platfor

Re: [edk2-devel] [PATCH RFC v2 09/28] OvmfPkg/VmgExitLib: Allow PMBASE register access in Dxe phase

2021-05-07 Thread Laszlo Ersek
On 05/07/21 17:19, Brijesh Singh wrote: > > On 5/7/21 10:10 AM, Laszlo Ersek wrote: >> >>> Sounds good. What's your thought if I take out patch 1 - 9 from this RFC >>> series and submit them as non-RFC for the further review and acceptance >>> ? The patch# 1-9 are basically prepatch before we get

Re: [edk2-devel] [PATCH RFC v2 09/28] OvmfPkg/VmgExitLib: Allow PMBASE register access in Dxe phase

2021-05-07 Thread Brijesh Singh
On 5/7/21 10:10 AM, Laszlo Ersek wrote: > >> Sounds good. What's your thought if I take out patch 1 - 9 from this RFC >> series and submit them as non-RFC for the further review and acceptance >> ? The patch# 1-9 are basically prepatch before we get into SNP specific >> bits. > More precisely, th

Re: [edk2-devel] [PATCH RFC v2 09/28] OvmfPkg/VmgExitLib: Allow PMBASE register access in Dxe phase

2021-05-07 Thread Laszlo Ersek
On 05/07/21 15:29, Brijesh Singh wrote: > > On 5/6/21 9:08 AM, Laszlo Ersek wrote: >> On 04/30/21 13:51, Brijesh Singh wrote: >>> BZ: >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C01

[edk2-devel] [PATCH v2 2/2] SecurityPkg: Add support for RngDxe on AARCH64

2021-05-07 Thread Rebecca Cran
AARCH64 support has been added to BaseRngLib via the optional ARMv8.5 FEAT_RNG. Refactor RngDxe to support AARCH64, note support for it in the VALID_ARCHITECTURES line of RngDxe.inf and enable it in SecurityPkg.dsc. Signed-off-by: Rebecca Cran --- SecurityPkg/SecurityPkg.dec

[edk2-devel] [PATCH v2 1/2] MdePkg/BaseRngLib: Add support for ARMv8.5 RNG instructions

2021-05-07 Thread Rebecca Cran
Make BaseRngLib more generic by moving x86 specific functionality from BaseRng.c into Rand/RdRand.c, and adding AArch64/Rndr.c, which supports the optional ARMv8.5 RNG instructions RNDR and RNDRRS that are a part of FEAT_RNG. Add support for the optional ARMv8.5 RNDR and RNDRRS instructions that a

[edk2-devel] [PATCH v2 0/2] MdePkg,SecurityPkg: Add support to RngDxe and BaseRngLib for AARCH64 RNDR

2021-05-07 Thread Rebecca Cran
Update MdePkg BaseRngLib and SecurityPkg RngDxe to add support for the AARCH64 RNDR instruction. Changes from v1 to v2: o Added a PCD, gEfiSecurityPkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm to specify which algorighm the platform supports. o Moved ArmRndr() and ArmRndrrs() into BaseRngLib. o

Re: [edk2-devel] [PATCH RFC v2 09/28] OvmfPkg/VmgExitLib: Allow PMBASE register access in Dxe phase

2021-05-07 Thread Brijesh Singh
On 5/6/21 9:08 AM, Laszlo Ersek wrote: > On 04/30/21 13:51, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C01d3e5c5268043c18bdf08d910987251%7C3dd8961fe4884

Re: [edk2-devel] [PATCH v1 0/5] Dot graph generator for PPTT

2021-05-07 Thread Joey Gouly
> From: Joey Gouly > Sent: 07 May 2021 11:37 > The changes can be seen at > https://github.com/jgouly/edk2/tree/1484_pptt_dot_graph_v1 The CI on github showed some coding style issues with this series. I will fix those locally but wait for more review comments before I send a v2. Thanks, Joe

[edk2-devel] [PATCH v1 2/5] ShellPkg: add a helper function for getting a new file name

2021-05-07 Thread Joey Gouly
From: Marc Moisson-Franckhauser Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) This new helper will not overwrite existing files, by appending a number to the end of the filename. Signed-off-by: Marc Moisson-Franckhauser Signed-off-by: Joey Gouly --- ShellPkg/Library/Ue

[edk2-devel] [PATCH v1 1/5] ShellPkg: Replace 'Trace' parameter with 'ParseFlags'

2021-05-07 Thread Joey Gouly
From: Marc Moisson-Franckhauser Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) This is preparation for adding a second flag to the parsers. Signed-off-by: Marc Moisson-Franckhauser Signed-off-by: Joey Gouly --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h

[edk2-devel] [PATCH v1 4/5] ShellPkg: add dot file generator functions

2021-05-07 Thread Joey Gouly
From: Marc Moisson-Franckhauser Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) These can be used to generate dot files, that can be used to visualise graphs in tables, such as PPTT. Signed-off-by: Marc Moisson-Franckhauser Signed-off-by: Joey Gouly --- ShellPkg/Library/

[edk2-devel] [PATCH v1 3/5] ShellPkg: add a Graph option to the Parser Flags

2021-05-07 Thread Joey Gouly
From: Marc Moisson-Franckhauser Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) This option informs the parser to generate a dot graph of a table. This can be useful to understand or debug a table, such as the PPTT table. Signed-off-by: Marc Moisson-Franckhauser Signed-off

[edk2-devel] [PATCH v1 0/5] Dot graph generator for PPTT

2021-05-07 Thread Joey Gouly
This series adds functionality to print a dot graph of a PPTT table. This helps with understanding and debugging PPTT tables. The dot graph generator functionality is generic and could be used by other tables that would benefit from graph output. Bugzilla: 3378 (https://bugzilla.tianocore.org/show

[edk2-devel] [PATCH v1 5/5] ShellPkg: add PPTT dot file genration

2021-05-07 Thread Joey Gouly
From: Marc Moisson-Franckhauser Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) This generates a dot file from the PPTT table that can be used to visualise the topology of the CPUs and Caches. Signed-off-by: Marc Moisson-Franckhauser Signed-off-by: Joey Gouly --- ShellPk