Brijesh: The changes in MdePkg is good to me. Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
One minor comment is in Patch2. Its title should be MdePkg/Register/Amd: xxxx to align other patches. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Brijesh Singh > 发送时间: 2021年5月8日 4:38 > 收件人: devel@edk2.groups.io > 抄送: Brijesh Singh <brijesh.si...@amd.com>; James Bottomley > <j...@linux.ibm.com>; Min Xu <min.m...@intel.com>; Jiewen Yao > <jiewen....@intel.com>; Tom Lendacky <thomas.lenda...@amd.com>; > Jordan Justen <jordan.l.jus...@intel.com>; Ard Biesheuvel > <ardb+tianoc...@kernel.org>; Laszlo Ersek <ler...@redhat.com>; Erdem > Aktas <erdemak...@google.com>; Michael D Kinney > <michael.d.kin...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; > Zhiguang Liu <zhiguang....@intel.com> > 主题: [edk2-devel] [PATCH 00/13] Add GHCBv2 macro and helpers > > This series is taken from the SNP RFC. This series defines the GHCBv2 > macros and NAE events. Additionally, it also introduces a helper to > clear the page encryption mask from the Mmio region. > > The series is based on the commit: > f297b7f20010 UnitTestFrameworkPkg: Sample unit test hangs when running > in OVMF/QEMU > > Cc: James Bottomley <j...@linux.ibm.com> > Cc: Min Xu <min.m...@intel.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Tom Lendacky <thomas.lenda...@amd.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Erdem Aktas <erdemak...@google.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang....@intel.com> > > Brijesh Singh (11): > MdePkg/Register/Amd: expand the SEV MSR to include the SNP definition > MdePkg/Amd: add white spaces to retain alignment for future expansion > MdePkg/Register/Amd: define GHCB macros for hypervisor feature > detection > MdePkg/Register/Amd: define GHCB macro for Register GPA structure > MdePkg/Register/Amd: define GHCB macro for the Page State Change > MdePkg/BaseLib: add support for PVALIDATE instruction > OvmfPkg/BaseMemEncryptSevLib: introduce > MemEncryptSevClearMmioPageEncMask() > OvmfPkg/AmdSevDxe: use MemEncryptSevClearMmioPageEncMask() to > clear > EncMask > OvmfPkg/QemuFlashFvbServicesRuntimeDxe: use Mmio helper to clear > enc > mask > OvmfPkg/TpmMmioSevDecryptPei: use > MemEncryptSevClearMmioPageEncMask() > OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter > > Tom Lendacky (2): > MdePkg/Register/Amd: define GHCB macros for SNP AP creation > MdePkg/BaseLib: add support for RMPADJUST instruction > > MdePkg/Library/BaseLib/BaseLib.inf | 2 + > MdePkg/Include/Library/BaseLib.h | 80 ++++++++++++ > MdePkg/Include/Register/Amd/Fam17Msr.h | 46 ++++++- > MdePkg/Include/Register/Amd/Ghcb.h | 123 > +++++++++++++++++- > OvmfPkg/Include/Library/MemEncryptSevLib.h | 35 +++-- > .../BaseMemEncryptSevLib/X64/VirtualMemory.h | 33 +++-- > OvmfPkg/AmdSevDxe/AmdSevDxe.c | 13 +- > OvmfPkg/IoMmuDxe/AmdSevIoMmu.c | 6 +- > .../Ia32/MemEncryptSevLib.c | 41 ++++-- > .../X64/MemEncryptSevLib.c | 49 +++++-- > .../X64/PeiDxeVirtualMemory.c | 63 +++++++-- > .../X64/SecVirtualMemory.c | 8 +- > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 3 +- > OvmfPkg/PlatformPei/AmdSev.c | 3 +- > .../FwBlockServiceDxe.c | 5 +- > .../QemuFlashSmm.c | 5 +- > .../TpmMmioSevDecryptPeim.c | 5 +- > MdePkg/Include/X64/Nasm.inc | 16 +++ > MdePkg/Library/BaseLib/X64/Pvalidate.nasm | 42 ++++++ > MdePkg/Library/BaseLib/X64/RmpAdjust.nasm | 40 ++++++ > 20 files changed, 526 insertions(+), 92 deletions(-) > create mode 100644 MdePkg/Library/BaseLib/X64/Pvalidate.nasm > create mode 100644 MdePkg/Library/BaseLib/X64/RmpAdjust.nasm > > -- > 2.17.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74841): https://edk2.groups.io/g/devel/message/74841 Mute This Topic: https://groups.io/mt/82670668/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
