[edk2-devel] [PATCH v2 0/3] Use XADD to avoid lock acquire/release

Patch #1 follows Laszlo's suggestion to add global NASM macros for NASM struc usage. Patch #2 changes all hardcode offset to use struc. Patch #3 doesn't have any change comparing to V1 except 1). dword/qword prefix is added. 2). the comments "program AP stack" is removed. Ray Ni (3): MdePk

[edk2-devel] [PATCH v2 1/3] MdePkg/Nasm.inc: add macros for C types used in structure definition

Signed-off-by: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu --- MdePkg/Include/Ia32/Nasm.inc | 38 MdePkg/Include/X64/Nasm.inc | 38 2 files changed, 76 insertions(+) diff --git a/MdePkg/Include/Ia32/Nas

[edk2-devel] [PATCH v2 2/3] UefiCpuPkg/MpInitLib: Use NASM struc to avoid hardcode offset

In Windows environment, "dumpbin /disasm" is used to verify the disassembly before and after using NASM struc doesn't change. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 5 +- UefiCpuPkg/Library/MpInitLib/Ia32/MpEq

[edk2-devel] [PATCH v2 3/3] UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release

When AP firstly wakes up, MpFuncs.nasm contains below logic to assign an unique ApIndex to each AP according to who comes first: ---NASM--- movedi, esi addedi, MP_CPU_EXCHANGE_INFO_FIELD (Lock) moveax, NotVacantFlag TestLock: xchg [edi], eax cmp

[edk2-devel] [Patch V3 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Maintainers.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 56e16fc48c..34f0b58581 100644 --- a/Maintainers.txt +++ b/Ma

[edk2-devel] [Patch V3 39/40] TigerlakeSiliconPkg: Add package DSC files

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/SiPkgBuildOption.dsc| 122 +

[edk2-devel] [Patch V3 38/40] TigerlakeSiliconPkg/Fru: Add Fru DSC files

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following DSC files: * Fru/TglCpu * Fru/TglPch Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Fru/TglCpu/CommonLib.dsc | 11 +++ Silicon/Intel/TigerlakeSiliconPkg/Fr

[edk2-devel] [Patch V3 37/40] TigerlakeSiliconPkg/SystemAgent: Add SystemAgent modules

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * SystemAgent/SaInit/Dxe * SystemAgent/SaInit/Smm Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/SystemAgent/SaInit/Dxe/SaAcpi.c | 431 ++

[edk2-devel] [Patch V3 35/40] TigerlakeSiliconPkg/Fru/TglCpu: Add CpuPcieRp and Vtd library instances

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * Fru/TglCpu/CpuPcieRp/Library/PeiDxeSmmCpuPcieInfoFruLib * Fru/TglCpu/Vtd/LibraryPrivate/DxeVtdInitLib Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Fru/

[edk2-devel] [Patch V3 32/40] TigerlakeSiliconPkg/Pch: Add Pch common library instances

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * Pch/Library/BasePchPciBdfLib * Pch/Library/BaseResetSystemLib * Pch/Library/DxePchPolicyLib * Pch/Library/PeiDxeSmmPchCycleDecodingLib * Pch/Library/PeiDxeSmmPchInfoLib Cc: Sai Chaganty Cc: Nate DeSimo

[edk2-devel] [Patch V3 34/40] TigerlakeSiliconPkg/SystemAgent: Add Acpi Tables and library instances

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * SystemAgent/AcpiTables * SystemAgent/Library/DxeSaPolicyLib * SystemAgent/Library/PeiDxeSmmSaPlatformLib Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/

[edk2-devel] [Patch V3 33/40] TigerlakeSiliconPkg/Pch: Add Pch private library instances

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * Pch/LibraryPrivate/BaseSiScheduleResetLib * Pch/LibraryPrivate/SmmPchPrivateLib Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Pch/LibraryPrivate/BaseSiS

[edk2-devel] [Patch V3 29/40] TigerlakeSiliconPkg/IpBlock: Add Spi component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Spi/IncludePrivate * IpBlock/Spi/Library * IpBlock/Spi/LibraryPrivate * IpBlock/Spi/Smm Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBloc

[edk2-devel] [Patch V3 31/40] TigerlakeSiliconPkg/Library: Add package common library instances

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * Library/BasePciSegmentMultiSegLibPci * Library/BaseSiConfigBlockLib * Library/PeiDxeSmmMmPciLib Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Library/

[edk2-devel] [Patch V3 30/40] TigerlakeSiliconPkg/IpBlock: Add Vtd component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Vtd/IncludePrivate * IpBlock/Vtd/Library * IpBlock/Vtd/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/IncludePrivate

[edk2-devel] [Patch V3 28/40] TigerlakeSiliconPkg/IpBlock: Add Smbus component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Smbus/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Smbus/IncludePrivate/Register/SmbusRegs.h | 50 +++

[edk2-devel] [Patch V3 27/40] TigerlakeSiliconPkg/IpBlock: Add SerialIo component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/SerialIo/IncludePrivate * IpBlock/SerialIo/Library * IpBlock/SerialIo/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Se

[edk2-devel] [Patch V3 19/40] TigerlakeSiliconPkg/IpBlock: Add Hda component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Hda/IncludePrivate * IpBlock/Hda/Library * IpBlock/Hda/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Hda/IncludePrivate

[edk2-devel] [Patch V3 25/40] TigerlakeSiliconPkg/IpBlock: Add Psf component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Psf/IncludePrivate * IpBlock/Psf/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Psf/IncludePrivate/Library/PsfLib.h

[edk2-devel] [Patch V3 26/40] TigerlakeSiliconPkg/IpBlock: Add Sata component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Sata/Library Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Sata/Library/PeiDxeSmmSataLib/PeiDxeSmmSataLibVer2.inf | 32 +

[edk2-devel] [Patch V3 24/40] TigerlakeSiliconPkg/IpBlock: Add Pmc component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Pmc/IncludePrivate * IpBlock/Pmc/Library * IpBlock/Pmc/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Pmc/IncludePrivate

[edk2-devel] [Patch V3 23/40] TigerlakeSiliconPkg/IpBlock: Add PcieRp component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/PcieRp/IncludePrivate * IpBlock/PcieRp/Library * IpBlock/PcieRp/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/In

[edk2-devel] [Patch V3 22/40] TigerlakeSiliconPkg/IpBlock: Add PchDmi component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/PchDmi/IncludePrivate * IpBlock/PchDmi/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PchDmi/IncludePrivate/Library/PchDmi

[edk2-devel] [Patch V3 21/40] TigerlakeSiliconPkg/IpBlock: Add P2sb component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/P2sb/IncludePrivate * IpBlock/P2sb/Library * IpBlock/P2sb/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/P2sb/IncludePri

[edk2-devel] [Patch V3 20/40] TigerlakeSiliconPkg/IpBlock: Add HostBridge component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/HostBridge/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/HostBridge/IncludePrivate/HostBridgeDataHob.h | 25 ++

[edk2-devel] [Patch V3 15/40] TigerlakeSiliconPkg/IpBlock: Add Espi component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Espi/Library Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Espi/Library/PeiDxeSmmEspiLib/EspiLib.c | 469

[edk2-devel] [Patch V3 16/40] TigerlakeSiliconPkg/IpBlock: Add Gbe component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Gbe/IncludePrivate * IpBlock/Gbe/Library * IpBlock/Gbe/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/IncludePrivate

[edk2-devel] [Patch V3 13/40] TigerlakeSiliconPkg/IpBlock: Add Cnvi component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Cnvi/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Cnvi/IncludePrivate/CnviConfigHob.h | 27 +++ 1

[edk2-devel] [Patch V3 14/40] TigerlakeSiliconPkg/IpBlock: Add CpuPcieRp component

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/CpuPcieRp/Include * IpBlock/CpuPcieRp/IncludePrivate * IpBlock/CpuPcieRp/Library * IpBlock/CpuPcieRp/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel

[edk2-devel] [Patch V3 12/40] TigerlakeSiliconPkg/Fru: Add TglPch/IncludePrivate headers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Fru/TglPch/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Fru/TglPch/IncludePrivate/Register/PchPcrRegs.h | 66 +

[edk2-devel] [Patch V3 11/40] TigerlakeSiliconPkg/Fru: Add TglPch/Include headers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Fru/TglPch/Include Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Fru/TglPch/Include/PchBdfAssignment.h | 326 +

[edk2-devel] [Patch V3 06/40] TigerlakeSiliconPkg/Pch: Add IncludePrivate headers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Pch/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Pch/IncludePrivate/Library/SiScheduleResetLib.h | 47 +++

[edk2-devel] [Patch V3 07/40] TigerlakeSiliconPkg/SystemAgent: Add include headers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * SystemAgent/Include Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/SystemAgent/Include/ConfigBlock/MemoryDxeConfig.h | 123 +

[edk2-devel] [Patch V3 10/40] TigerlakeSiliconPkg/Fru: Add TglCpu/IncludePrivate headers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Fru/TglCpu/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Fru/TglCpu/IncludePrivate/Library/VtdInitFruLib.h | 18 ++

[edk2-devel] [Patch V3 09/40] TigerlakeSiliconPkg/Fru: Add TglCpu/Include headers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Fru/TglCpu/Include Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Fru/TglCpu/Include/Library/CpuPcieInfoFruLib.h | 57

[edk2-devel] [Patch V3 08/40] TigerlakeSiliconPkg/SystemAgent: Add IncludePrivate headers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * SystemAgent/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/SystemAgent/IncludePrivate/Protocol/SaIotrapSmi.h | 42 +

[edk2-devel] [Patch V3 03/40] TigerlakeSiliconPkg/Include: Add Pins, Register and other include headers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Include/Pins * Include/Register * Include/*.h Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Include/ConfigBlock.h| 53

[edk2-devel] [Patch V3 05/40] TigerlakeSiliconPkg/Pch: Add include headers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Pch/Include Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Pch/Include/ConfigBlock/FlashProtectionConfig.h | 55

[edk2-devel] [Patch V3 04/40] TigerlakeSiliconPkg/Cpu: Add Include headers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds header files common to CPU modules. Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Cpu/Include/ConfigBlock/CpuConfig.h | 83 +++

Re: [edk2-devel] [Patch V2 07/40] TigerlakeSiliconPkg/SystemAgent: Add include headers

Please remove EFI_HOB_GUID_TYPE and EFI_HOB_GENERIC_HEADER data structures below this comment. +// @todo remove and use the MdePkg\Include\Pi\PiHob.h With that Reviewed-by: Sai Chaganty -Original Message- From: Luo, Heng Sent: Thursday, February 04, 2021 12:49 AM To: devel@edk2.group

[edk2-devel] Uefi functions AddUnicodeString2() and LookupUnicodeString2() are returning EFI_UNSUPPORTED incorrectly

Hi, The library functions AddUnicodeString2() and LookupUnicodeString2() defined in UefiLib.c are returning EFI_UNSUPPORTED incorrectly. These functions are returning EFI_UNSUPPORTED because of not finding the given "Language" in "SupportedLanguages", even though it is part of it. Actually the f

[edk2-devel] Help needed for ": error C0DE: Tools code failure"

Hi there, I'm trying to build ADL code but always run into the failure as below log. I follow the message to send this mail to you. Can you please point me what's wrong? Building ... d:\ext\adlv2017\Intel\ClientOneSiliconPkg\Fsp\FspEndOfPei2\FspEndOfPei2Peim.inf [IA32] Fd File Name:FSP (D:\E

Re: [edk2-devel] [PATCH v2 2/2] Maintainers.txt: Change Jordan Justen to a reviewer for OvmfPkg

On 02/04/21 20:49, Jordan Justen wrote: > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Jordan Justen > --- > Maintainers.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 96e792ab66..e384971238 100644 > --- a/Mainta

答复: [edk2-devel] How can I receive EAP packets?

Do you have any examples or documentation of using MNP? Best regards Yufei liang -邮件原件- 发件人: 梁宇飞 [mailto:yufei.li...@jumple.com] 发送时间: 2021年2月5日 8:48 收件人: 'Fu, Siyuan'; 'Laszlo Ersek'; 'devel@edk2.groups.io' 抄送: 'Maciej Rabeda'; 'Wu, Jiaxin' 主题: 答复: [edk2-devel] How can I receive EAP pack

Re: [edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface

Thanks Kun, If my understanding is correct, this proposed library will not have any consumer until the implementation of blocking the access of unregistered memory access in MM is made. If this is the case, my take for this sent patch is that it is a RFC to the SMM drivers owners on the library

Re: [edk2-devel] [Patch V2 06/40] TigerlakeSiliconPkg/Pch: Add IncludePrivate headers

Reviewed-by: Sai Chaganty -Original Message- From: Luo, Heng Sent: Thursday, February 04, 2021 12:49 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [Patch V2 06/40] TigerlakeSiliconPkg/Pch: Add IncludePrivate headers REF: https://bugzilla.tianoc

Re: [edk2-devel] [Patch V2 05/40] TigerlakeSiliconPkg/Pch: Add include headers

Reviewed-by: Sai Chaganty -Original Message- From: Luo, Heng Sent: Thursday, February 04, 2021 12:49 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [Patch V2 05/40] TigerlakeSiliconPkg/Pch: Add include headers REF: https://bugzilla.tianocore.org

Re: [edk2-devel] [Patch V2 04/40] TigerlakeSiliconPkg/Cpu: Add Include headers

Reviewed-by: Sai Chaganty -Original Message- From: Luo, Heng Sent: Thursday, February 04, 2021 12:49 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [Patch V2 04/40] TigerlakeSiliconPkg/Cpu: Add Include headers REF: https://bugzilla.tianocore.

Re: [edk2-devel] [Patch V2 03/40] TigerlakeSiliconPkg/Include: Add Pins, Register and other include headers

Reviewed-by: Sai Chaganty -Original Message- From: Luo, Heng Sent: Thursday, February 04, 2021 12:49 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [Patch V2 03/40] TigerlakeSiliconPkg/Include: Add Pins, Register and other include headers REF:

Re: [edk2-devel] [Patch V2 02/40] TigerlakeSiliconPkg/Include: Add Library, PPI and Protocol include headers

Reviewed-by: Sai Chaganty -Original Message- From: Luo, Heng Sent: Thursday, February 04, 2021 12:49 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [Patch V2 02/40] TigerlakeSiliconPkg/Include: Add Library, PPI and Protocol include headers R

Re: [edk2-devel] EDK2

Tony, This build failure should be caused by one of your c or header files have non-ascii characters. You may need to change the basetools’ code to see which file has non-ascii characters Change C:\edk2\BaseTools\Source\Python\AutoGen\StrGather.py, Line 536 except: EdkLogge

Re: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add microcode header verification.

Pushed. > -Original Message- > From: Ni, Ray > Sent: Thursday, February 4, 2021 1:44 PM > To: Fu, Siyuan ; Li, Aaron ; > devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: RE: [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add > microcode header verification. > > Reviewed-by:

Re: [edk2-devel] [PATCH v3] MdeModulePkg/Library: Add HiiGetStringEx to UefiHiiLib for EDK2 Redfish

Thanks Liming From: gaoliming [mailto:gaolim...@byosoft.com.cn] Sent: Friday, February 5, 2021 11:52 AM To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) ; dandan...@intel.com Cc: 'Dong, Eric' ; Wang, Nickle (HPS SW) Subject: 回复: [edk2-devel] [PATCH v3] MdeModulePkg/Library: Add H

Re: [edk2-devel] TianoCore Community Meeting Minutes - 2/4

TianoCore Community Meeting Minutes (APAC/NMO) February 4, 2021 EVENTS: No new updates. STABLE TAG: edk2-stable202102 - Feature Planning freeze on 2/15 https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning STEWARDS DOWNLOAD (Mike Kinney) * Design meetin

回复: [edk2-devel] [PATCH v3] MdeModulePkg/Library: Add HiiGetStringEx to UefiHiiLib for EDK2 Redfish

I am OK for any option. Reviewed-by: Liming Gao Thanks LIming 发件人: bounce+27952+71277+4905953+8761...@groups.io 代表 Abner Chang 发送时间: 2021年2月5日 9:51 收件人: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) ; dandan...@intel.com 抄送: 'Dong, Eric' ; Wang, Nickle (HPS SW) 主题: Re: [edk2-

Re: [edk2-devel] EDK2

Hi Andrew, If the character is part of the code (not a comment), the ignoring the codec error could silently produce the incorrect FW behavior. I prefer a failure with a correct identification of the file/line # so the file can be fixed. The EDK II CI checks will not allow files in with these

[edk2-devel] TianoCore Community Meeting - APAC/NAMO - Thu, 02/04/2021 7:30pm-8:30pm #cal-reminder

*Reminder:* TianoCore Community Meeting - APAC/NAMO *When:* Thursday, 4 February 2021, 7:30pm to 8:30pm, (GMT-08:00) America/Los Angeles *Where:* https://intel.webex.com/intel/j.php?MTID=m36627c5ee595f86f0257d9a52bb86044 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1057049 )

[edk2-devel] TianoCore Community Meeting - APAC/NAMO - Thu, 02/04/2021 7:30pm-8:30pm #cal-reminder

*Reminder:* TianoCore Community Meeting - APAC/NAMO *When:* Thursday, 4 February 2021, 7:30pm to 8:30pm, (GMT-08:00) America/Los Angeles *Where:* https://intel.webex.com/intel/j.php?MTID=m36627c5ee595f86f0257d9a52bb86044 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1057049 )

Re: [edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface

Hi Hao, As mentioned in the cover letter and in BZ-3168, VariableStandaloneMm and Tcg2Smm would need this capability to unblock certain regions in order to access either variable runtime cache or NVS region patched into ACPI table, if non-MMRAM region is blocked for access. Just as a preview (

Re: [edk2-devel] [Bug 3187] FaultTolerantWriteDxe defect will cause NVRAM not recovered after number of WorkSpaceRefresh().

Hi Marlboro, How about use non-volatile EFI variable instead of CMOS? Not sure all platforms support CMOS. Regards, From: devel@edk2.groups.io On Behalf Of Chuang, Marlboro via groups.io Sent: Thursday, February 4, 2021 3:08 PM To: gaoliming ; devel@edk2.groups.io Subject: Re: [edk2-devel] [B

Re: [edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Sean > Sent: Friday, February 5, 2021 10:37 AM > To: devel@edk2.groups.io; Wu, Hao A ; > ku...@outlook.com; Yao, Jiewen > Cc: Wang, Jian J ; Dong, Eric ; > Ni, Ray > Subject: Re: [edk2-devel] [PATCH v1 0/1] Introduce > DxeMmU

Re: [edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface

Hao wu, I agree that for reviewing this change that would provide more confidence. The real issue is that there is no x64 mm standalone solution that blocks memory access in edk2 today. So implementing this interface in edk2 doesn't make sense. It would just rot with no users, validation, or

Re: [edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib Interface

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Kun Qin > Sent: Wednesday, February 3, 2021 6:16 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Dong, Eric ; Ni, Ray ; Yao, Jiewen > > Subject: [edk2-devel] [PATCH v1 0/1] Introduce DxeMmUnblockMemoryLib > In

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Add YAML file generation support

Reviewed-by: Chasel Chiu > -Original Message- > From: Loo Tung Lun > Sent: Thursday, February 4, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Loo, Tung Lun ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Subject: [PATCH v2] IntelFsp2Pkg: Add YAML file gene

Re: [edk2-devel] [PATCH v3] MdeModulePkg/Library: Add HiiGetStringEx to UefiHiiLib for EDK2 Redfish

Hi Liming, Do you agree to keep the one Dandan suggested? Regards, Abner From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang Sent: Thursday, February 4, 2021 4:36 PM To: devel@edk2.groups.io; dandan...@intel.com Cc: 'Dong, Eric' ; Wang, Nickle (HPS SW) Subject: Re

[edk2-devel] TianoCore Design Meeting - APAC/NAMO - Fri, 02/05/2021 #cal-notice

"TianoCore Design Meeting - APAC/NAMO" When: Friday, 5 February 2021 9:30am to 10:30am (GMT+08:00) Asia/Chongqing Where: https://intel.webex.com/intel/j.php?MTID=me894224717bbf0af843f2ff7502c98cb Organizer: ray...@intel.com Description: ## TOPIC * Open discussion on ECC: owne

Re: [edk2-devel] [Patch 1/1 V2] BaseTools: fix the split output files root dir

Reviewed-by: Yuwei Chen > -Original Message- > From: Feng, Bob C > Sent: Monday, February 1, 2021 6:29 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Chen, Christine > > Subject: [Patch 1/1 V2] BaseTools: fix the split output files root dir > > If the output file path is a relative pa

[edk2-devel] TianoCore Design Meeting - APAC/NAMO - Fri, 02/05/2021 9:30am-10:30am #cal-reminder

*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Friday, 5 February 2021, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://intel.webex.com/intel/j.php?MTID=me894224717bbf0af843f2ff7502c98cb View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=963098 ) *Organizer:

[edk2-devel] 回复: [PATCH] BaseTools: Fix BrotliCompress run issue on Linux

Reviewed-by: Liming Gao > -邮件原件- > 发件人: Yunhua Feng > 发送时间: 2021年2月4日 16:54 > 收件人: devel@edk2.groups.io > 抄送: Bob Feng ; Liming Gao > ; Yuwei Chen > 主题: [PATCH] BaseTools: Fix BrotliCompress run issue on Linux > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3210 > BrotliCompres

Re: [edk2-devel] [Patch V2 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers

Reviewed-by: Sai Chaganty -Original Message- From: Luo, Heng Sent: Thursday, February 04, 2021 4:39 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [Patch V2 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers REF: https://bugzilla.tianoc

答复: [edk2-devel] How can I receive EAP packets?

Thank you for your reply. I will try to use MNP protocol. >>Not sure if this is the "hybrid mode" you asking about. Sorry, it's wrong. It should be "Promiscuous mode". Best regards Yufei liang -邮件原件- 发件人: Fu, Siyuan [mailto:siyuan...@intel.com] 发送时间: 2021年2月4日 22:10 收件人: Laszlo Ersek; de

[edk2-devel] [Patch V2 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Maintainers.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 56e16fc48c..34f0b58581 100644 --- a/Maintainers.txt +++ b/Ma

Re: [edk2-devel] EDK2

> On Feb 4, 2021, at 3:58 PM, Michael D Kinney > wrote: > > Hi Tony, > > I suspect that one of your UNI files being processed by StrGather has an > invalid Unicode character in it. Can you review the UNI files in the module > that is being build when this error is generated? > > I would be

Re: [edk2-devel] EDK2

Hi Tony, I suspect that one of your UNI files being processed by StrGather has an invalid Unicode character in it. Can you review the UNI files in the module that is being build when this error is generated? I would be better if this code identified the file/line number with the issue, so tha

Re: [edk2-devel] [edk2-rfc] [RFC] Request for new git repository for EdkRepo

Hi Nate, I have created the following Tianocore repositories: * edk2-edkrepo * edk2-edkrepo-manifest I have added you and Ashley to the EDK II Tools Maintainers team with write access to both of these new repositories. The EDK II Maintainers team has also been grated write access to the edk2-

[edk2-devel] EDK2

Hi, I have a problem with build.py (Python 3.9.1 on win32) Traceback (most recent call last): File "C:\edk2\BaseTools\Source\Python\build\build.py", line 2635, in Main MyBuild.Launch() File "C:\edk2\BaseTools\Source\Python\build\build.py", line 2433, in Launch self._BuildModule() Fi

Re: [edk2-devel] [Patch V2 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers

Hi Heng, Thank you again for all your hard work on this! For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Thursday, February 4, 2021 12:49 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [Patch V

[edk2-devel] [PATCH v2 2/2] Maintainers.txt: Change Jordan Justen to a reviewer for OvmfPkg

Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Jordan Justen --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 96e792ab66..e384971238 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -423,9 +423,9 @@ R: Siyua

[edk2-devel] [PATCH v2 1/2] Maintainers.txt: Remove Jordan Justen from EmulatorPkg

Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Jordan Justen Reviewed-by: Andrew Fish --- Maintainers.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 2cd356551e..96e792ab66 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -197,7 +197,6 @@ M: Ard B

Re: [edk2-devel] [PATCH 2/2] Maintainers.txt: Remove Jordan Justen from OvmfPkg

Hi Jordan, On 02/02/21 21:35, Jordan Justen wrote: > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Jordan Justen > --- > Maintainers.txt | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 96e792ab66..e986a3680c 100644 > --- a/Maintainers

Re: [edk2-devel] [edk2-announce] Reminder: Community meeting this week - please see updates

Hi Folks, Since we had Webex issues this morning, I will be rescheduling the community meeting morning call (EMEA/NAMO) to next week, Thursday 11th, 9-10am (PST). We will continue to keep the evening community call with APAC/NAMO today. I will update the WebEx link for the APAC. Please resync yo

Re: [edk2-devel] ARM ltd. platform maintainership

Hi Leif, I can take up the maintenance for these packages. Please let me know if you want me to send a patch to update the maintainership. Regards, Sami Mujawar From: Leif Lindholm Sent: 04 February 2021 01:10 PM To: edk2-devel-groups-io Cc: Sami Mujawar ; Thomas Abraham ; Ard Biesheuvel Sub

Re: [edk2-devel] [edk2-announce] Reminder: Community meeting this week - please resync your calendar

Bridge for this morning's 9am call - please see below. previous meeting invite isn't working. When it's time, join your Webex meeting here. Meeting number (access code): 130 576 2005 Meeting password: HntHxcu$733 Join

Re: [edk2-devel] [PATCH v2 1/1] ArmPkg/Library: prevent endless reboot loop with emulated NV varstore

On Thu, Feb 04, 2021 at 16:49:03 +0100, Ard Biesheuvel wrote: > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable > > >gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > > >gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate > > >gEfiMdePkgTokenSpaceGuid.PcdUartDefault

Re: [edk2-devel] [edk2-announce] Reminder: Community meeting this week - please resync your calendar

Folks, There seems to be an error in the invite. please give me 5 mins, I will send you a new invite. Thanks, Soumya On 2/2/21, 4:34 PM, "annou...@edk2.groups.io on behalf of Soumya Guptha" wrote: Dear Community members, Tianocore community meeting is coming up this week, on 2/4 fr

[edk2-devel] TianoCore Community Meeting - EMEA / NAMO - Thu, 02/04/2021 9:00am-10:00am #cal-reminder

*Reminder:* TianoCore Community Meeting - EMEA / NAMO *When:* Thursday, 4 February 2021, 9:00am to 10:00am, (GMT-08:00) America/Los Angeles *Where:* https://intel.webex.com/intel/j.php?MTID=mab17cedce04bdd38b3d532c3b4125dee View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1057046

[edk2-devel] TianoCore Community Meeting - EMEA / NAMO - Thu, 02/04/2021 9:00am-10:00am #cal-reminder

*Reminder:* TianoCore Community Meeting - EMEA / NAMO *When:* Thursday, 4 February 2021, 9:00am to 10:00am, (GMT-08:00) America/Los Angeles *Where:* https://intel.webex.com/intel/j.php?MTID=mab17cedce04bdd38b3d532c3b4125dee View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1057046

Re: [edk2-devel] [PATCH v2 1/1] ArmPkg/Library: prevent endless reboot loop with emulated NV varstore

On Thu, 4 Feb 2021 at 15:17, Laszlo Ersek wrote: > > On 02/04/21 15:06, Leif Lindholm wrote: > > If no valid boot options were found, PlatformBootManagerLib refreshes a > > set of sane default options and then reboots. However, if there is in > > fact no persistent varstore, the same thing happens

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use NASM struc to avoid hardcode offset

On 02/04/21 15:27, Ni, Ray wrote: >>> >>> (1) please align the "res*" on the other lines with this >>> >>> (in the X64 file too) >>> > > OK. > +movsi, MP_CPU_EXCHANGE_INFO_OFFSET + MP_CPU_EXCHANGE_INFO.BufferStart >>> >>> (2) please introduce a macro for this; in my opinio

[edk2-devel] Updated Event: TianoCore Design Meeting - APAC/NAMO - Friday, 5 February 2021 #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCATION:Asia/Shanghai BEGIN:STANDARD TZNAME:CST TZOFFSETFROM:+

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use NASM struc to avoid hardcode offset

> > > > (1) please align the "res*" on the other lines with this > > > > (in the X64 file too) > > OK. > >> +movsi, MP_CPU_EXCHANGE_INFO_OFFSET + > >> MP_CPU_EXCHANGE_INFO.BufferStart > > > > (2) please introduce a macro for this; in my opinion, with the currently > > proposed chang

Re: [edk2-devel] [PATCH v2 1/1] ArmPkg/Library: prevent endless reboot loop with emulated NV varstore

On 02/04/21 15:06, Leif Lindholm wrote: > If no valid boot options were found, PlatformBootManagerLib refreshes a > set of sane default options and then reboots. However, if there is in > fact no persistent varstore, the same thing happens again on next boot, > and we end up in an endlessly rebooti

Re: [edk2-devel] How can I receive EAP packets?

> -Original Message- > From: Laszlo Ersek > Sent: 2021年2月4日 17:56 > To: devel@edk2.groups.io; yufei.li...@jumple.com > Cc: Maciej Rabeda ; Fu, Siyuan > ; Wu, Jiaxin > Subject: Re: [edk2-devel] How can I receive EAP packets? > > On 02/03/21 04:20, 梁宇飞 wrote: > > Hi,everyone, I am using ed

[edk2-devel] [PATCH v2 1/1] ArmPkg/Library: prevent endless reboot loop with emulated NV varstore

If no valid boot options were found, PlatformBootManagerLib refreshes a set of sane default options and then reboots. However, if there is in fact no persistent varstore, the same thing happens again on next boot, and we end up in an endlessly rebooting loop. So when PcdEmuVariableNvModeEnable is

Re: [edk2-devel] [PATCH 1/1] ArmPkg/Library: prevent endless reboot loop with emulated NV varstore

On Thu, Feb 04, 2021 at 14:06:01 +0100, Laszlo Ersek wrote: > On 02/04/21 13:54, Leif Lindholm wrote: > > If no valid boot options were found, PlatformBootManagerLib refreshes a > > set of sane default options and then reboots. However, if there is in > > fact no persistent varstore,the same thing

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release

> > (1) For more clarity, I would suggest > > lock xadd dword [edi], ebx > > (even though "ebx" already specifies the width, yes) > > Applies to the X64 version too. OK. > > > > +incebx ; EBX is CpuNumber > > > > +; program stack > > (2) Thi

[edk2-devel] ARM ltd. platform maintainership

Hi Sami, Thomas, I would like to step down from the maintainership of the ARM ltd. platforms in edk2-platforms ( F: Platform/ARM/ F: Silicon/ARM/ ). Can ARM provide a replacement maintainer? Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group

Re: [edk2-devel] [PATCH 1/1] ArmPkg/Library: prevent endless reboot loop with emulated NV varstore

On 02/04/21 13:54, Leif Lindholm wrote: > If no valid boot options were found, PlatformBootManagerLib refreshes a > set of sane default options and then reboots. However, if there is in > fact no persistent varstore,the same thing happens again on next boot, > and we end up in an endlessly rebootin

[edk2-devel] [PATCH 1/1] ArmPkg/Library: prevent endless reboot loop with emulated NV varstore

If no valid boot options were found, PlatformBootManagerLib refreshes a set of sane default options and then reboots. However, if there is in fact no persistent varstore,the same thing happens again on next boot, and we end up in an endlessly rebooting loop. So when PcdEmuVariableNvModeEnable is T

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release

On 02/04/21 12:24, Zeng, Star wrote: > Hi All, > > Do you think it worth or not to also update MpFuncs.nasm in > Edk2\UefiCpuPkg\PiSmmCpuDxeSmm? I haven't done any measurements, so I couldn't say... -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Rep

  1   2   >