> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean > Sent: Friday, February 5, 2021 10:37 AM > To: devel@edk2.groups.io; Wu, Hao A <hao.a...@intel.com>; > ku...@outlook.com; Yao, Jiewen <jiewen....@intel.com> > Cc: Wang, Jian J <jian.j.w...@intel.com>; Dong, Eric <eric.d...@intel.com>; > Ni, Ray <ray...@intel.com> > Subject: Re: [edk2-devel] [PATCH v1 0/1] Introduce > DxeMmUnblockMemoryLib Interface > > Hao wu, > > I agree that for reviewing this change that would provide more confidence. > The real issue is that there is no x64 mm standalone solution that blocks > memory access in edk2 today. So implementing this interface in > edk2 doesn't make sense. It would just rot with no users, validation, or > maintenance. > > The interface is needed because this is a compatibility point in other > drivers. > Without it, those other drivers need to be forked and then maintained and > that is not in the best interest of anyone.
Thanks Sean. Sorry for a question, do you have an example for the drivers with potential compatibility opens? It would be helpful to have a better understanding of the purpose of this library. Best Regards, Hao Wu > > To push a new standalone x64 mm model up that blocks dxe memory space > is not small task and we are working on it and are happy to contribute it to > edk2 / open source but it will not happen quickly. So step 1 is get a > compatible abstraction/interface added. Step 2 is work to upstream the core > modules. > > We may be able to share the core modules with you if you want to see them > for review purposes but we need more dev work before upstreaming the > change to edk2. > > Thanks > Sean > > > > > On 2/4/2021 6:17 PM, Wu, Hao A wrote: > >> -----Original Message----- > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun > >> Qin > >> Sent: Wednesday, February 3, 2021 6:16 AM > >> To: devel@edk2.groups.io > >> Cc: Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao A > >> <hao.a...@intel.com>; Dong, Eric <eric.d...@intel.com>; Ni, Ray > >> <ray...@intel.com>; Yao, Jiewen <jiewen....@intel.com> > >> Subject: [edk2-devel] [PATCH v1 0/1] Introduce > DxeMmUnblockMemoryLib > >> Interface > >> > >> The interface proposed in this patch series intends to provide an > >> abstraction layer for DXE drivers to request certain memory regions > >> to be accessible from inside MM environment that applies total memory > blockage. > >> > >> This abstraction could pave way for models such as Standalone MM to > >> manage memory resources without having knowledge of DXE memory > map > >> inside MM environment. > >> > >> Example usages of it can be NVS region in Tcg2Smm and runtime > >> variable cache regions in VariableSmmRuntimeDxe. > > > > > > My thought is that it might be more helpful if the whole > > implementation proposal to address BZ-3168 can be provided before > > reviewing the interfaces for the new library (or the library itself). > > > > Hello Jiewen, > > > > Do you have comments on the approach on implementing the BZ-3168 > > (https://bugzilla.tianocore.org/show_bug.cgi?id=3168) feature? > > Thanks in advance. > > > > Best Regards, > > Hao Wu > > > > > >> > >> Patch v1 branch: > https://github.com/kuqin12/edk2/tree/unblock_mem_v1 > >> > >> Cc: Jian J Wang <jian.j.w...@intel.com> > >> Cc: Hao A Wu <hao.a...@intel.com> > >> Cc: Eric Dong <eric.d...@intel.com> > >> Cc: Ray Ni <ray...@intel.com> > >> Cc: Jiewen Yao <jiewen....@intel.com> > >> > >> Kun Qin (1): > >> MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null > >> instance > >> > >> > >> > MdeModulePkg/Library/DxeMmUnblockMemoryLib/DxeMmUnblockMemo > >> ryLibNull.c | 40 ++++++++++++++++++++ > >> MdeModulePkg/Include/Library/DxeMmUnblockMemoryLib.h > | > >> 40 ++++++++++++++++++++ > >> > >> > MdeModulePkg/Library/DxeMmUnblockMemoryLib/DxeMmUnblockMemo > >> ryLibNull.inf | 29 ++++++++++++++ > >> MdeModulePkg/MdeModulePkg.dec > >> | 5 +++ > >> MdeModulePkg/MdeModulePkg.dsc > >> | 2 + > >> 5 files changed, 116 insertions(+) > >> create mode 100644 > >> > MdeModulePkg/Library/DxeMmUnblockMemoryLib/DxeMmUnblockMemo > >> ryLibNull.c > >> create mode 100644 > >> MdeModulePkg/Include/Library/DxeMmUnblockMemoryLib.h > >> create mode 100644 > >> > MdeModulePkg/Library/DxeMmUnblockMemoryLib/DxeMmUnblockMemo > >> ryLibNull.inf > >> > >> -- > >> 2.30.0.windows.1 > >> > >> > >> > >> > >> > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71281): https://edk2.groups.io/g/devel/message/71281 Mute This Topic: https://groups.io/mt/80339609/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
