Re: [edk2-devel] [edk2-platforms] [RFC] Compatibility Expectations in edk2-platforms

2020-10-05 Thread Laszlo Ersek
On 10/06/20 00:36, Michael Kubacki wrote: > Hi all, > > First, I'd like to clarify that I completely support the development of > open source edk2 platforms and this observation is only intended to > suggest an improvement for interoperability with edk2 development and > not to detract from the gr

Re: [EXTERNAL] [edk2-devel] VSCode EDK II Syntax Highlighting

2020-10-05 Thread Bret Barkelew via groups.io
Some members of our team were writing one at one point in conjunction with Surface. I don’t know if it ever saw the light of day, but Matthew might be able to clean it up for release if the community were interested. - Bret From: Nate DeSimone via groups.io

Re: [edk2-devel] [edk2-rfc] [RFC] Request to move MinPlatformPkg out of the Intel folder

2020-10-05 Thread Nate DeSimone
Hey Leif, On 10/4/20, 3:00 PM, Leif Lindholm wrote: > > On Sun, Oct 04, 2020 at 20:46:50 +, Desimone, Nathaniel L wrote: > > Hey Hot, > > > > On 10/1/20, 9:20 PM, Tian, Hot wrote: > > > > > > Why not move to edk2 repo? > > > > Edk2 would be a good place as well. > > If it is being used by

[edk2-devel] TianoCore Community Meeting this week - using Webex, please resync your calendar

2020-10-05 Thread Soumya Guptha
Dear Community members, I have updated our October community meeting with Webex. Please resync your calendar so you have the latest meeting invite. Some of them have experienced issues with blue jeans, hence I am trying Webex for our meeting this week. We have tried Webex for TianoCore Bug triage

Re: [edk2-rfc] [edk2-devel] [RFC] Request to move MinPlatformPkg out of the Intel folder

2020-10-05 Thread Nate DeSimone
Hey Bret, On 10/5/20, 12:35 PM, Bret Barkelew wrote: > > Perhaps this is the time we get EdkRepo and Stuart to join forces and > become the one-true-repo-management solution for EDK. I'm not opposed to that idea, but it sounds like a totally different RFC 😊. We also need to be cognizant that t

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix invalid memory access in AArch64 SetJump/LongJump

2020-10-05 Thread Michael D Kinney
No concerns. Acked-by: Michael D Kinney Mike > -Original Message- > From: Ard Biesheuvel > Sent: Monday, October 5, 2020 7:33 AM > To: Jan Bobek ; devel@edk2.groups.io; Kinney, Michael D > ; Liming Gao > > Cc: Leif Lindholm ; Liu, Zhiguang > ; Jeff Brasen ; Ashish Singhal > > Subje

[edk2-devel] VSCode EDK II Syntax Highlighting

2020-10-05 Thread Nate DeSimone
Hi Everyone, I just noticed that there is a vscode extension for adding syntax highlighting to DEC/DSC/FDF/INF/UNI/VFR files: https://marketplace.visualstudio.com/items?itemName=walonli.edk2-vscode Along with the following: https://marketplace.visualstudio.com/items?itemName=Thog.vscode-asl ht

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Adding performance option

2020-10-05 Thread Bjorge, Erik C
This new option will display the execution time of a successful command. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge --- edkrepo/commands/arguments/edkrepo_cmd_args.py | 3 ++- edkrepo/commands/comp

[edk2-devel] Updated Event: TianoCore Community Meeting - APAC/NAMO - Thursday, 8 October 2020 #cal-invite

2020-10-05 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZOFFSETFROM:-0800 TZOFFSETTO:-0700 TZ

[edk2-devel] Updated Event: TianoCore Community Meeting - EMEA / NAMO - Thursday, 8 October 2020 #cal-invite

2020-10-05 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZOFFSETFROM:-0800 TZOFFSETTO:-0700 TZ

[edk2-devel] [edk2-platforms] [RFC] Compatibility Expectations in edk2-platforms

2020-10-05 Thread Michael Kubacki
Hi all, First, I'd like to clarify that I completely support the development of open source edk2 platforms and this observation is only intended to suggest an improvement for interoperability with edk2 development and not to detract from the great work happening in open source platforms. The

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Correct issue with memory protection enabled.

2020-10-05 Thread Jeff Brasen
Are we looking for any other reviews on this? Thanks, Jeff From: Samer El-Haj-Mahmoud Sent: Tuesday, September 29, 2020 8:05 AM To: devel@edk2.groups.io; Jeff Brasen ; Laszlo Ersek Cc: eric@intel.com; G Edhaya Chandran ; Samer El-Haj-Mahmoud Subject: RE: [edk2-devel] [PATCH] uefi-sct/Sct

Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

2020-10-05 Thread Jeff Brasen
Are we looking for any other reviews on this? Thanks, Jeff From: Jeff Brasen Sent: Tuesday, September 22, 2020 4:13 PM To: Bi, Dandan ; devel@edk2.groups.io Cc: Dong, Eric Subject: Re: [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string Thanks Dandan, are we waiting for any additiona

Re: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section

2020-10-05 Thread Bret Barkelew via groups.io
I’m assuming this is used across multiple packages? If so, Reviewed-by: Bret Barkelew - Bret From: Sami Mujawar via groups.io Sent: Friday, October 2, 2020 2:14 PM To: devel@edk2.groups.io Cc: Sami Mujawar

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Add timing for commands

2020-10-05 Thread Nate DeSimone
Its not a bad idea to move it a little deeper anyway since we have multiple entry points that make EdkRepo work regardless of whether you are using virtualenv, or -m, or Python launcher for Windows, etc... > -Original Message- > From: Bjorge, Erik C > Sent: Friday, October 2, 2020 1:34

Re: [edk2-devel] [RFC] Request to move MinPlatformPkg out of the Intel folder

2020-10-05 Thread Bret Barkelew via groups.io
I think that to support anything larger that proofs of concept – in other words, to support the actual platforms that we WANT to consume this trusted, common code – we already have to support recursive submodules. Our team HIGHLY recommends that platforms submodule edk2 rather than forking it,

Re: [EXTERNAL] [edk2-devel] [RedfishPkg PATCH v4 3/4] .azurepipelines/templates: Add RedfishPkg to target build

2020-10-05 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Abner Chang via groups.io Sent: Sunday, October 4, 2020 9:13:45 PM To: devel@edk2.groups.io Cc: Sean Brogan ; Bret Barkelew ; Kinney, Michael D ; Liming Gao ; Nickle Wang Subject: [E

Re: [EXTERNAL] [edk2-devel] [RedfishPkg PATCH v4 2/4] .pytool: Add CI on RedfishPkg

2020-10-05 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: Abner Chang via groups.io Sent: Sunday, October 4, 2020 9:58 PM To: devel@edk2.groups.io Cc: Sean Brogan; Bret Barkelew

Re: [edk2-devel] [PATCH v1 1/1] UefipayloadPkg: Protect coreboot tables

2020-10-05 Thread Marcello Sylvester Bauer
On Thu, Oct 1, 2020 at 12:24 PM Laszlo Ersek wrote: > On 09/14/20 19:32, Guo Dong wrote: > > > > OK. Let me merge this patch firstly. /Guo > > The PR at failed 17 days > ago and there have been no updates since, as far as I can tell. I've > closed the

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix invalid memory access in AArch64 SetJump/LongJump

2020-10-05 Thread Ard Biesheuvel
On 10/1/20 6:15 PM, Jan Bobek wrote: Correct the memory offsets used in REG_ONE/REG_PAIR macros to synchronize them with definition of the BASE_LIBRARY_JUMP_BUFFER structure on AArch64. The REG_ONE macro declares only a single 64-bit register be read/written; however, the subsequent offset is 16

Re: [edk2-devel] [PATCH] Platform/Qemu/Sbsa: Fix build break due to need for RngLib

2020-10-05 Thread Ard Biesheuvel
On 10/5/20 1:26 PM, Andrew Goodbody wrote: Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool") introduced RngLib dependency for OpensslLib and caused QEMU platforms build to break for lack of an RngLib instance. Add the reference to RngLib to the SbsaQemu.d

Re: [edk2-devel] [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4

2020-10-05 Thread Ard Biesheuvel
On 10/5/20 2:07 PM, Pete Batard wrote: With Andrei's reply, that's an RB for me: On 2020.09.29 15:01, Samer El-Haj-Mahmoud wrote: Thanks Pete and Andrei. Should we count these as RB or AB for the patch? Reviewed-by: Samer El-Haj-Mahmoud *From:* devel@edk2.groups.io *On Behalf Of *Andrei Wa

[edk2-devel] [Patch V1 1/1] \Silicon\Intel\Tools\FitGen: Add extra parameter to the Fit Gen Tool to input the Higher Flash Address

2020-10-05 Thread cbduggap
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981 Add extra parameter to the Fit Gen Tool to input the Higher Address. Default Address should be 4GB and if some one inputs new address, tool must consume that address instead of Default address (4GB). Signed-off-by: cbduggap --- Silicon/Int

[edk2-devel] [Patch V4 1/1] Tools\FitGen: Add extra parameter to input the Higher Flash Address

2020-10-05 Thread cbduggap
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981 Add extra parameter to the Fit Gen Tool to input the Higher Address. Default Address should be 4GB and if some one inputs new address, tool must consume that address instead of Default address (4GB). Signed-off-by: cbduggap Cc: Bob Feng Cc

[edk2-devel] [Patch V5 1/1] Tools\FitGen: Add extra parameter to input the Top Flash Address

2020-10-05 Thread cbduggap
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981 Add extra parameter to the Fit Gen Tool to input the Top Flash Address. Default Address should be 4GB and if some one inputs new address, tool must consume that address instead of Default address (4GB). Signed-off-by: cbduggap Cc: Bob Feng

Re: [edk2-devel] [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4

2020-10-05 Thread Pete Batard
With Andrei's reply, that's an RB for me: On 2020.09.29 15:01, Samer El-Haj-Mahmoud wrote: Thanks Pete and Andrei. Should we count these as RB or AB for the patch? Reviewed-by: Samer El-Haj-Mahmoud *From:* devel@edk2.groups.io *On Behalf Of *Andrei Warkentin via groups.io *Sent:* Monday, S

[edk2-devel] [PATCH] Platform/Qemu/Sbsa: Fix build break due to need for RngLib

2020-10-05 Thread Andrew Goodbody
Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool") introduced RngLib dependency for OpensslLib and caused QEMU platforms build to break for lack of an RngLib instance. Add the reference to RngLib to the SbsaQemu.dsc file Signed-off-by: Andrew Goodbody ---

Re: [edk2-devel] [PATCH v5 01/15] PcAtChipsetPkg: Add MMIO Support to RTC driver

2020-10-05 Thread Ard Biesheuvel
On 10/2/20 11:13 PM, Sami Mujawar wrote: Some virtual machine managers like Kvmtool emulate the MC146818 RTC controller in the MMIO space so that architectures that do not support I/O Mapped I/O can use the RTC. This patch adds MMIO support to the RTC controller driver. The PCD PcdRtcUseMmio has

Re: [edk2-devel] [PATCH 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump

2020-10-05 Thread Philippe Mathieu-Daudé
On 10/1/20 8:37 PM, Leif Lindholm wrote: > Both in SetJump and in InternalLongJump, 32-bit w register views were > used for the UINTN return value. In SetJump, this did not cause errors; > it was only counterintuitive. But in InternalLongJump, it meant the top Typo "counter-intuitive". > 32 bits

Re: [edk2-devel] [PATCH 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations

2020-10-05 Thread Philippe Mathieu-Daudé
On 10/1/20 8:37 PM, Leif Lindholm wrote: > There may be architectures on which there are benefits to > eor r0, r0(, r0) > but ARM was never one of them. =) Reviewed-by: Philippe Mathieu-Daude > Change to more readable > mov r0, #0 > instead. > > Signed-off-by: Leif Lindholm > --- > MdePk