On 10/5/20 2:07 PM, Pete Batard wrote:
With Andrei's reply, that's an RB for me:
On 2020.09.29 15:01, Samer El-Haj-Mahmoud wrote:
Thanks Pete and Andrei. Should we count these as RB or AB for the patch?
Reviewed-by: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>
*From:* devel@edk2.groups.io <devel@edk2.groups.io> *On Behalf Of
*Andrei Warkentin via groups.io
*Sent:* Monday, September 21, 2020 4:01 PM
*To:* Pete Batard <p...@akeo.ie>; Jeff Booher-Kaeding
<jeff.booher-kaed...@arm.com>; devel@edk2.groups.io
*Cc:* Ard Biesheuvel <ard.biesheu...@arm.com>; Leif Lindholm
<l...@nuviainc.com>
*Subject:* Re: [edk2-devel] [PATCH v1 1/1]
Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4
Hi folks,
No objection at all. IIRC the original pin selection was driven by an
article I read about using OpenOCD with Pi 3.
A
------------------------------------------------------------------------
*From:*Pete Batard <p...@akeo.ie <mailto:p...@akeo.ie>>
*Sent:* Tuesday, September 15, 2020 7:26 AM
*To:* Jeff Booher-Kaeding <jeff.booher-kaed...@arm.com
<mailto:jeff.booher-kaed...@arm.com>>; devel@edk2.groups.io
<mailto:devel@edk2.groups.io> <devel@edk2.groups.io
<mailto:devel@edk2.groups.io>>
*Cc:* Ard Biesheuvel <ard.biesheu...@arm.com
<mailto:ard.biesheu...@arm.com>>; Leif Lindholm <l...@nuviainc.com
<mailto:l...@nuviainc.com>>; Andrei Warkentin <awarken...@vmware.com
<mailto:awarken...@vmware.com>>
*Subject:* Re: [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG
Pinout for Pi3/4
Copying Andrei on this, as the existing JTAG pinout is not technically
incorrect, since GPIO pin 4 can be used for TDI in ALT5 mode, and we are
using the relevant ALT mode in the existing code. See
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsysprogs.com%2FVisualKernel%2Ftutorials%2Fraspberry%2Fjtagsetup%2F&data=02%7C01%7Cawarkentin%40vmware.com%7C1c1badf5e6f1433b44b508d859728a32%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637357695767996220&sdata=rGIzM4Io36gFJrAK%2F4xZs0fm0DpXVvamhOYYXfc09ek%3D&reserved=0
As far as I'm concerned, I think it makes sense to use the same ALT mode
and have all the JTAG pins grouped, but I'd like to confirm whether we
deliberately chose not to use GPIO 26 in order to leave it available for
some other purpose, before I approve this patch.
If Andrei says he's okay with it, then I see no objection to this change.
Regards,
/Pete
On 2020.09.14 22:32, Jeff Booher-Kaeding wrote:
> Updated the pinout to match the Pi4 datasheet, tested with the
RPi4, Pi3 Datasheet has same pinout.
>
> Signed-off-by: Jeff Booher-Kaeding <jeff.booher-kaed...@arm.com
<mailto:jeff.booher-kaed...@arm.com>>
>
> Cc: Ard Biesheuvel <ard.biesheu...@arm.com
<mailto:ard.biesheu...@arm.com>>
> Cc: Leif Lindholm <l...@nuviainc.com <mailto:l...@nuviainc.com>>
> Cc: Pete Batard <p...@akeo.ie <mailto:p...@akeo.ie>>
Pushed as fc49849a8ebc..8ef23e848b76
Thanks all,
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65891): https://edk2.groups.io/g/devel/message/65891
Mute This Topic: https://groups.io/mt/76854132/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
