Re: [edk2-devel] [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add PCD for shadowing all microcode.

MpInitLib already contains logic to shadow microcode to memory. Is this still needed? > -Original Message- > From: Li, Aaron > Sent: Wednesday, August 12, 2020 3:55 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Fu, Siyuan > Subject: [PATCH v1 1/1] IntelSiliconPkg

Re: [edk2-devel] [EXTERNAL] [PATCH v8 00/14] Add the VariablePolicy feature

To whom it may concern, This is as done as it’s going to get. Thank you all for your help! - Bret From: Bret Barkelew Sent: Tuesday, September 22, 2020 11:08 PM To: devel@edk2.groups.io Cc: Yao, Jiewen; Dandan Bi

Re: [edk2-devel] [PATCH v8 11/14] SecurityPkg: Allow VariablePolicy state to delete authenticated variables

Reviewed-by: Jiewen Yao > -Original Message- > From: Bret Barkelew > Sent: Wednesday, September 23, 2020 2:08 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Chao Zhang ; Bret Barkelew > ; Bi, Dandan > Subject: [PATCH v8 11/14] SecurityPkg: Allow VariablePolicy state

[edk2-devel] [PATCH v8 14/14] MdeModulePkg: Add a shell-based functional test for VariablePolicy

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 To verify that VariablePolicy is correctly integrated on platforms, add a Shell-based functional test to confirm expected behavior. NOTE: This test assumes that VariablePolicy is built with PcdAllowVariablePolicyEnforcement

[edk2-devel] [PATCH v8 12/14] MdeModulePkg: Change TCG MOR variables to use VariablePolicy

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 These were previously using VarLock, which is being deprecated. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Cc: Bret Barkelew Signed-off-by: Bret Barkelew Reviewed-by: Dandan Bi Acked-by: Jian J Wang --- MdeModulePk

[edk2-devel] [PATCH v8 07/14] ArmVirtPkg: Add VariablePolicy engine to ArmVirtPkg platform

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Bret Barkelew Signed-off-by: Bret Barkelew Reviewed-by: Laszlo Ersek --- ArmVirtPkg/ArmVirt.dsc.inc | 4 1 file changed, 4 insertions(+) diff --git a/Arm

[edk2-devel] [PATCH v8 09/14] MdeModulePkg: Connect VariablePolicy business logic to VariableServices

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add connective code to publish the VariablePolicy protocol and wire it to either the SMM communication interface or directly into the VariableP

[edk2-devel] [PATCH v8 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Cc: Bret Barkelew Signed-off-by: Bret Barkelew Reviewed-by: Maurice Ma --- UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 4 UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 4 +

[edk2-devel] [PATCH v8 11/14] SecurityPkg: Allow VariablePolicy state to delete authenticated variables

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Causes AuthService to check IsVariablePolicyEnabled() before enforcing write protections to allow variable deletion when policy engine is disabled. Only allows deletion, not modification. Cc: Jiewen Yao Cc: Jian J Wang C

[edk2-devel] [PATCH v8 10/14] MdeModulePkg: Allow VariablePolicy state to delete protected variables

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 TcgMorLockSmm provides special protections for the TCG MOR variables. This will check IsVariablePolicyEnabled() before enforcing them to allow variable deletion when policy engine is disabled. Only allows deletion, not modi

[edk2-devel] [PATCH v8 13/14] MdeModulePkg: Drop VarLock from RuntimeDxe variable driver

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Now that everything should be moved to VariablePolicy, drop support for the deprecated VarLock SMI interface and associated functions from variable RuntimeDxe. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Cc: Bret Barkele

[edk2-devel] [PATCH v8 06/14] EmulatorPkg: Add VariablePolicy engine to EmulatorPkg platform

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Cc: Bret Barkelew Signed-off-by: Bret Barkelew Reviewed-by: Ray Ni --- EmulatorPkg/EmulatorPkg.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/EmulatorPkg/Emulat

[edk2-devel] [PATCH v8 03/14] MdeModulePkg: Define the VariablePolicyHelperLib

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add the VariablePolicyHelperLib library, containing several functions to help with the repetitive process of creating a correctly structured an

[edk2-devel] [PATCH v8 04/14] MdeModulePkg: Define the VarCheckPolicyLib and SMM interface

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. This is an instance of a VarCheckLib that is backed by the VariablePolicyLib business logic. It also publishes the SMM calling interface for me

[edk2-devel] [PATCH v8 05/14] OvmfPkg: Add VariablePolicy engine to OvmfPkg platform

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Bret Barkelew Signed-off-by: Bret Barkelew Reviewed-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc| 5 + OvmfPkg/OvmfPkgIa32X64.dsc | 5 + OvmfPkg/Ov

[edk2-devel] [PATCH v8 01/14] MdeModulePkg: Define the VariablePolicy protocol interface

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add the VariablePolicy protocol interface header and add to the MdeModulePkg.dec file. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Cc: Bret

[edk2-devel] [PATCH v8 00/14] Add the VariablePolicy feature

The 14 patches in this series add the VariablePolicy feature to the core, deprecate Edk2VarLock (while adding a compatibility layer to reduce code churn), and integrate the VariablePolicy libraries and protocols into Variable Services. Since the integration requires multiple changes, including add

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

> -Original Message- > From: Ni, Ray > Sent: Wednesday, September 23, 2020 11:41 AM > To: Wu, Hao A ; devel@edk2.groups.io; > patrick.h...@hpe.com > Cc: Wang, Jian J > Subject: RE: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/XhciDxe: Fix > Broken Timeouts > > Hao, > Yes the behavior should

Re: [edk2-rfc] [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

> -Original Message- > From: Yao, Jiewen [mailto:jiewen@intel.com] > Sent: Wednesday, September 23, 2020 11:25 AM > To: Chang, Abner (HPS SW/FW Technologist) ; > r...@edk2.groups.io; devel@edk2.groups.io; bret.barke...@microsoft.com > Cc: Wang, Nickle (HPS SW) ; Chen, Aaron > ; Fu, S

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

Hao, Yes the behavior should not be changed. Can we keep the original behavior while still not creating the timer when infinite-loop is needed? Thanks, Ray > -Original Message- > From: Wu, Hao A > Sent: Tuesday, September 15, 2020 9:28 AM > To: devel@edk2.groups.io; patrick.h...@hpe.com

Re: [edk2-rfc] [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

Good to know. Then I recommend we document assumption in the design. I prefer to change "As the design, any BIOS to Redfish communicate should be done before End of DXE and with SecureBoot is enabled." to "As the design, any BIOS to Redfish communication MUST be done before End of DXE and with

Re: [edk2-rfc] [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

> -Original Message- > From: r...@edk2.groups.io [mailto:r...@edk2.groups.io] On Behalf Of Yao, > Jiewen > Sent: Wednesday, September 23, 2020 10:30 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > ; r...@edk2.groups.io; > bret.barke...@microsoft.com > Cc: Wang, Nic

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

It's a good optimization. Can you eliminate the GetApResetStackSize() and embed the check and calculation in GetApResetVectorSize()? Reason: GetApResetStackSize() is only called in one place. Removing the additional layer of function call makes the code easier to read. Thanks, Ray > -Origi

Re: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg/host: fix overflow in Mult

OK, Thanks. Regards Wenyi On 2020/9/23 10:48, Ni, Ray wrote: > Reviewed-by: Ray Ni > > Pull request was created: https://github.com/tianocore/edk2/pull/951 > > If you see any failures, please send updated patch to fix. > >> -Original Message- >> From: devel@edk2.groups.io On Behalf O

Re: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg/host: fix overflow in Mult

Reviewed-by: Ray Ni Pull request was created: https://github.com/tianocore/edk2/pull/951 If you see any failures, please send updated patch to fix. > -Original Message- > From: devel@edk2.groups.io On Behalf Of wenyi,xie > via groups.io > Sent: Tuesday, September 22, 2020 11:43 AM > To

Re: [edk2-devel] [PATCH v7 06/14] EmulatorPkg: Add VariablePolicy engine to EmulatorPkg platform

Reviewed-by: Ray Ni -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65485): https://edk2.groups.io/g/devel/message/65485 Mute This Topic: https://groups.io/mt/76468130/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk

Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/OpensslLib: Add native instruction support for X64

For GCC, please refer to https://github.com/tianocore/tianocore.github.io/wiki/Using-EDK-II-with-Native-GCC For LLVM, please refer to https://github.com/tianocore/tianocore.github.io/wiki/CLANG9-Tools-Chain Thank you Yao Jiewen > -Original Message- > From: Zurcher, Christopher J > Sen

Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: add crypto algorithms needed by variable protection

Reviewed-by: Jiewen Yao > -Original Message- > From: Wang, Jian J > Sent: Tuesday, August 18, 2020 10:54 AM > To: devel@edk2.groups.io > Cc: Lu, XiaoyuX ; Yao, Jiewen ; > Jiang, Guomin ; Mistry, Nishant C > > Subject: [PATCH] CryptoPkg/BaseCryptLib: add crypto algorithms needed by > var

Re: [edk2-rfc] [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

Thank you, Abner. I look forward to the design review in next week. :-) I notice that the last RedfishPkg update is still 2 years ago. In order to move staging to master, we need ensure the code meet production quality, including but not limited to unit test, system test and security test. I ch

Re: [edk2-rfc] [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

That would take time to run through the process of publishing this tool (make it as public) on DMTF. I just created the reference of source code which generated by tool on my personal GitHub (not the tool itself) https://github.com/changab/Redfish-JSON-C-Struct-Converter-Lib . The branch "Master

回复: [edk2-devel] [PATCH v2 1/1] Tools/FitGen: Fix microcode alignment support

Aaron: Merge this patch @4efd9ab2cfabdcbd6ca410f870bc889e76f18d85 on edk2-platforms. Please change BZ status to fixed with the commit hash. Thanks Liming > -邮件原件- > 发件人: bounce+27952+65428+4905953+8761...@groups.io > 代表 gaoliming > 发送时间: 2020年9月22日 14:15 > 收件人: devel@edk2.groups.io; aa

回复: [edk2-devel] [PATCH 1/1] BaseTools: Copy PACKED definition from MdePkg Base.h

Mike: PACKED definition is still required in BaseTools/Source/C/Include/Common/BaseTypes.h, because PACKED is used in MdePkg\Include\IndustryStandard\Acpi10.h. After Include directory is changed, MdePkg Acpi10.h will be included. Then, this definition is required. C source tools include

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 09/22/2020 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 22 September 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://meetingsamer34.webex.com/meetingsamer34/j.php?MTID=m623b1dceab0c6dc62d56b2508fa50f39 View Event ( https://edk2.groups.io/g/devel/viewevent?event

Re: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option ROMs

Marcello, If the assumption in this env is that PCI enumeration has already been done, would it make more sense for the component that performed PCI enumeration to collect the PCI Option ROM contents and pass them into the UefiPayLoadPkg in memory buffers and have the PCI Platform Protocol prov

Re: [edk2-devel] [PATCH 1/1] BaseTools: Copy PACKED definition from MdePkg Base.h

Liming, Is this change still required if you change the orders of includes? I agree that defining PACKED for BaseTools include usage makes sense, but does not seem to be related to this BZ. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming > Sent: Tuesday, S

Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

Thanks Dandan, are we waiting for any additional reviews on this change? Thanks, Jeff From: Bi, Dandan Sent: Monday, September 14, 2020 8:15 AM To: Jeff Brasen ; devel@edk2.groups.io Cc: Dong, Eric Subject: RE: [PATCH] MdeModulePkg/HiiDatabase: Do not modify

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Correct issue with memory protection enabled.

Any comments on this change? Thanks, Jeff From: Jeff Brasen Sent: Friday, September 11, 2020 11:23 AM To: devel@edk2.groups.io Cc: Jeff Brasen Subject: [PATCH] uefi-sct/SctPkg: Correct issue with memory protection enabled. On systems with memory protection e

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correct EFI_BLOCK_IO_PROTOCOL_REVISION3 value

Liming, I agree with this approach. Changing the UEFI spec does not seem like a good option because there can be other implementations of the UEFI Spec or portions of it. Fixing the EDK II implementation and working with the community and all downstream consumers should be the focus to make s

Re: [edk2-devel] [edk2-test][PATCH v1 1/4] uefi-sct/SctPkg: Add SCT User Guide PDF

Reviewed-by: G Edhaya Chandran Upstreamed by Commit ID: https://github.com/tianocore/edk2-test/commit/2eaa6232f3258ec802e244018818c9eca0b27711 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65472): https://edk2.groups.io/g/devel/message

[edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

From: Tom Lendacky The AP reset vector stack allocation is only required if running as an SEV-ES guest. Since the reset vector allocation is below 1MB in memory, eliminate the requirement for bare-metal systems and non SEV-ES guests to allocate the extra stack area, which can be large if the PcdC

[edk2-devel] [PATCH v3 1/1] ShellPkg/AcpiView: HMAT Parser

From: Marc Moisson-Franckhauser Add a new parser for the Heterogeneous Memory Attribute Table. The parser also validates some fields for this table. The HMAT table is used to describe the memory attributes such as memory side cache attributes and bandwidth and latency details related to memory p

Re: [edk2-devel] [PATCH] OvmfPkg/README: HTTPS Boot: describe host-side TLS cipher suites forwarding

On 09/22/20 12:49, Ard Biesheuvel wrote: > On 9/22/20 11:23 AM, Laszlo Ersek wrote: >> On 09/22/20 11:18, Laszlo Ersek wrote: >>> In QEMU commit range 4abf70a661a5..69699f3055a5 (later fixed up in QEMU >>> commit 4318432ccd3f), Phil implemented a QEMU facility for exposing the >>> host-side TLS cip

Re: [edk2-devel] [PATCH v7 00/14] Add the VariablePolicy feature

Bret, If someone has given same comments as below, please just ignore them. Sorry for the late feedback. Patch 09: LockVariablePolicy () is called inside a debug macro. In release build it will be replaced with empty. If this is really what you want, please add comments in code to explain your

Re: [edk2-devel] [PATCH 00/22] .mailmap: add mappings after edk2-stable202008

On 09/07/20 21:30, Laszlo Ersek wrote: > Repo: https://pagure.io/lersek/edk2.git > Branch: update_mailmap_edk2stable202008 > > If you (singular) are on the CC list of this email (and you are not > Phil), then the output of the following command: > > $ git shortlog edk2-stable201905..edk2-stable

Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/OpensslLib: Add native instruction support for X64

I have unit tested SHA1, SHA512, and AES as well. I do not have the build environment available to test GCC and LLVM. -- Christopher Zurcher > -Original Message- > From: Jiang, Guomin > Sent: Wednesday, September 16, 2020 02:17 > To: devel@edk2.groups.io; Yao, Jiewen ; Zurcher, > Christo

Re: [edk2-devel] [PATCH v1 7/7] DynamicTablesPkg: SsdtSerialPortFixupLib fix ECC errors

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65464): https://edk2.groups.io/g/devel/message/65464 Mute This Topic: https://groups.io/mt/77014345/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 0/7] DynamicTablesPkg: Fix assert ordering and ECC reported issues

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65465): https://edk2.groups.io/g/devel/message/65465 Mute This Topic: https://groups.io/mt/77014349/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 5/7] DynamicTablesPkg: AmlLib\AmlDbgPrint fix ECC error

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65462): https://edk2.groups.io/g/devel/message/65462 Mute This Topic: https://groups.io/mt/77014342/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 6/7] DynamicTablesPkg: AmlEncoding change debug macro

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65463): https://edk2.groups.io/g/devel/message/65463 Mute This Topic: https://groups.io/mt/77014351/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 4/7] DynamicTablesPkg: AmlLib fix ECC errors

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65461): https://edk2.groups.io/g/devel/message/65461 Mute This Topic: https://groups.io/mt/77014344/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 3/7] DynamicTablesPkg: AcpiSratLibArm fix ECC error

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65460): https://edk2.groups.io/g/devel/message/65460 Mute This Topic: https://groups.io/mt/77014350/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 2/7] DynamicTablesPkg: SsdtSerialPortLibArm fix ECC error

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65459): https://edk2.groups.io/g/devel/message/65459 Mute This Topic: https://groups.io/mt/77014347/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 1/2] MdePkg: Definitions for Extended Interrupt Flags

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65456): https://edk2.groups.io/g/devel/message/65456 Mute This Topic: https://groups.io/mt/77013535/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 1/7] DynamicTablesPkg: Fix order of assert checks

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65458): https://edk2.groups.io/g/devel/message/65458 Mute This Topic: https://groups.io/mt/77014348/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 2/2] DynamicTablesPkg: Add SSDT CMN-600 Table generator

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65457): https://edk2.groups.io/g/devel/message/65457 Mute This Topic: https://groups.io/mt/77013539/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 0/2] Support for dynamic CMN-600 AML generation

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65455): https://edk2.groups.io/g/devel/message/65455 Mute This Topic: https://groups.io/mt/77013536/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

[edk2-devel] [PATCH v1 0/7] DynamicTablesPkg: Fix assert ordering and ECC reported issues

This patch series fixes an assert ordering issue and the following issues reported by the ECC tool. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 in Comment, - <@param [in]> does NOT have [in, out] - does

[edk2-devel] [PATCH v1 6/7] DynamicTablesPkg: AmlEncoding change debug macro

Change the AML_DEBUG_STR() macro to AML_OPCODE_DEF() that takes a string and the AML OpCode as input so that the text description and the AML OpCode are grouped. The AML_OPCODE_DEF() macro also strips the string description for release builds. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Lib

[edk2-devel] [PATCH v1 1/7] DynamicTablesPkg: Fix order of assert checks

Reordered the asserts to first check if the pointer is valid before de-referencing the pointer. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DynamicT

[edk2-devel] [PATCH v1 5/7] DynamicTablesPkg: AmlLib\AmlDbgPrint fix ECC error

Fix ECC error 8001 reported errors in AmlDbgPrint. [8001] Only capital letters are allowed to be used for #define declarations. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 1 + DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPr

[edk2-devel] [PATCH v1 3/7] DynamicTablesPkg: AcpiSratLibArm fix ECC error

Fix the following ECC reported error in AcpiSratLibArm. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 Comment does NOT have tail **/ Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/Sra

[edk2-devel] [PATCH v1 2/7] DynamicTablesPkg: SsdtSerialPortLibArm fix ECC error

Fix the following ECC reported error in SsdtSerialPortLibArm. - [5007] There should be no initialization of a variable as part of its declaration Variable Name. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c |

[edk2-devel] [PATCH v1 4/7] DynamicTablesPkg: AmlLib fix ECC errors

Fix the following ECC reported errors in AmlLib. - [1008] File has invalid Non-ACSII char. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 Comment does NOT have tail **/ Signed-off-by: Sami Mujawar --- DynamicTablesP

[edk2-devel] [PATCH v1 7/7] DynamicTablesPkg: SsdtSerialPortFixupLib fix ECC errors

Fix the following ECC reported errors in SsdtSerialPortFixupLib. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 in Comment, <@param [in]> does NOT have [in, out] Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Librar

[edk2-devel] [PATCH v1 2/2] DynamicTablesPkg: Add SSDT CMN-600 Table generator

From: Pierre Gondois The Generic ACPI for Arm Components 1.0 Platform Design Document, s2.6.4 "ASL code examples" provides information to describe an Arm CoreLink CMN-600 Coherent Mesh Network using an ASL definition block table. The SSDT CMN-600 Table Generator uses the Configuration Manager pr

[edk2-devel] [PATCH v1 1/2] MdePkg: Definitions for Extended Interrupt Flags

Add Interrupt Vector Flag definitions for Extended Interrupt Descriptor, and macros to test the flags. Ref: ACPI specification 6.4.3.6 Signed-off-by: Sami Mujawar --- MdePkg/Include/IndustryStandard/Acpi10.h | 85 1 file changed, 85 insertions(+) diff --git a/MdePkg/Include

[edk2-devel] [PATCH v1 0/2] Support for dynamic CMN-600 AML generation

The 'Generic ACPI for Arm Components 1.0 Platform Design Document' provides a standard description for an 'Arm CoreLink CMN-600 Coherent Mesh Network'. This patch series adds: - definition for extended interrupt flags. - support for generating SSDT table(s) describing the CMN-600 mesh(es) usin

[edk2-devel] [PATCH] BaseTools: Add RISCV64 binding

- Add RISCV64 ProcessorBind.h - Add RISCV64 to Makefiles Signed-off-by: Nikita Ermakov --- BaseTools/Source/C/GNUmakefile| 3 + .../Source/C/Include/RiscV64/ProcessorBind.h | 85 +++ BaseTools/Source/C/Makefiles/header.makefile | 6 ++ 3 files changed, 94 ins

Re: [edk2-devel] [PATCH 02/22] .mailmap: add entry for Ching JenX Cheng

On 09/22/20 11:38, Philippe Mathieu-Daudé wrote: > On 9/22/20 9:22 AM, Laszlo Ersek wrote: >> On 09/17/20 18:45, Philippe Mathieu-Daudé wrote: >> >>> OK I didn't know the format has to follow the English name order. >>> I used the Chinese name order because I found somewhere in the >>> EDK2 archive

[edk2-devel] [Patch] BaseTools: Set section alignment as zero if its type is Auto

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2881 Currently, the build tool try to read the section alignment from efi file if the section alignment type is Auto. If there is no efi generated, the section alignment will be set to zero. This behavior causes the Makefile to be different betwe

Re: [edk2-devel] [PATCH] OvmfPkg/README: HTTPS Boot: describe host-side TLS cipher suites forwarding

On 9/22/20 11:23 AM, Laszlo Ersek wrote: On 09/22/20 11:18, Laszlo Ersek wrote: In QEMU commit range 4abf70a661a5..69699f3055a5 (later fixed up in QEMU commit 4318432ccd3f), Phil implemented a QEMU facility for exposing the host-side TLS cipher suite configuration to OVMF. The purpose is to cont

[edk2-devel] [Patch V2 1/1] Tools\FitGen: Add extra parameter to input the Higher Flash Address

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981 Add extra parameter to the Fit Gen Tool to input the Higher Address. Default Address should be 4GB and if some one inputs new address, tool must consume that address instead of Default address (4GB). Signed-off-by: cbduggap Cc: Bob Feng Cc

[edk2-devel] [Patch V1 1/1] \Silicon\Intel\Tools\FitGen: Add extra parameter to the Fit Gen Tool to input the Higher Flash Address

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981 Add extra parameter to the Fit Gen Tool to input the Higher Address. Default Address should be 4GB and if some one inputs new address, tool must consume that address instead of Default address (4GB). Signed-off-by: cbduggap --- Silicon/Int

Re: [edk2-devel] [PATCH 02/22] .mailmap: add entry for Ching JenX Cheng

On 9/22/20 9:22 AM, Laszlo Ersek wrote: > On 09/17/20 18:45, Philippe Mathieu-Daudé wrote: > >> OK I didn't know the format has to follow the English name order. >> I used the Chinese name order because I found somewhere in the >> EDK2 archives some posts signed as "Cheng Ching Jen", so I took >>

Re: [edk2-devel] [PATCH] OvmfPkg/README: HTTPS Boot: describe host-side TLS cipher suites forwarding

On 9/22/20 11:18 AM, Laszlo Ersek wrote: > In QEMU commit range 4abf70a661a5..69699f3055a5 (later fixed up in QEMU > commit 4318432ccd3f), Phil implemented a QEMU facility for exposing the > host-side TLS cipher suite configuration to OVMF. The purpose is to > control the permitted ciphers in the g

Re: [edk2-devel] [PATCH] OvmfPkg/README: HTTPS Boot: describe host-side TLS cipher suites forwarding

On 09/22/20 11:18, Laszlo Ersek wrote: > In QEMU commit range 4abf70a661a5..69699f3055a5 (later fixed up in QEMU > commit 4318432ccd3f), Phil implemented a QEMU facility for exposing the > host-side TLS cipher suite configuration to OVMF. The purpose is to > control the permitted ciphers in the gue

[edk2-devel] [Patch V1 1/1] \Silicon\Intel\Tools\FitGen: Add extra parameter to the Fit Gen Tool to input the Higher Flash Address

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981 Add extra parameter to the Fit Gen Tool to input the Higher Address. Default Address should be 4GB and if some one inputs new address, tool must consume that address instead of Default address (4GB). Signed-off-by: cbduggap --- Silicon/Int

[edk2-devel] [PATCH] OvmfPkg/README: HTTPS Boot: describe host-side TLS cipher suites forwarding

In QEMU commit range 4abf70a661a5..69699f3055a5 (later fixed up in QEMU commit 4318432ccd3f), Phil implemented a QEMU facility for exposing the host-side TLS cipher suite configuration to OVMF. The purpose is to control the permitted ciphers in the guest's UEFI HTTPS boot. This complements the forw

Re: [edk2-devel] [PATCH 02/22] .mailmap: add entry for Ching JenX Cheng

On 09/17/20 18:45, Philippe Mathieu-Daudé wrote: > OK I didn't know the format has to follow the English name order. > I used the Chinese name order because I found somewhere in the > EDK2 archives some posts signed as "Cheng Ching Jen", so I took > this order to respect the author preference. Th

Re: [edk2-devel] [PATCH 02/22] .mailmap: add entry for Ching JenX Cheng

On 09/17/20 18:45, Philippe Mathieu-Daudé wrote: > On 9/17/20 5:28 PM, Laszlo Ersek wrote: >> On 09/17/20 16:47, Philippe Mathieu-Daudé wrote: >>> On 9/7/20 9:30 PM, Laszlo Ersek wrote: ... for git-shortlog purposes. Cc: Ching JenX Cheng Cc: Philippe Mathieu-Daudé Signed-