Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

Jiewen, On 09/17/20 04:31, Yao, Jiewen wrote: > Hi Laszlo, Liming, and Mike > > I appreciate your effort to setup rule and document this *complex* EDK II > Development Process. > > I am thinking if we can have a way (a tool) to mandate these process and > check if there is any violation. If pe

Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

On 09/16/20 23:51, Dong, Guo wrote: > > Thanks Laszlo for all these information. > It looks it is not well communicated on the merge requirements. > This is the first time for me to merge a patch set and I had thought > it is same with merging a single patch (no cover letter). > As UefiPayloadPkg

[edk2-devel] [PATCH v1 1/1] Tools/FitGen: Fix microcode alignment support

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2971 This patch is to fix a issue that "-A" option would only support 2^n Byte alignment of microcode. Signed-off-by: Aaron Li Cc: Bob Feng Cc: Liming Gao --- Silicon/Intel/Tools/FitGen/FitGen.c | 2 +- Silicon/Intel/Tools/FitGen/FitGen.h | 4

Re: 回复: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

Liming, On 09/17/20 03:49, gaoliming wrote: > Guo: > On pull request, > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process#the-maintainer-process-for-the-edk-ii-project > section 7 gives the requirement. > If is a patch series, then copy the patch #0 summary > in

Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

Hi Laszlo, Liming, and Mike I appreciate your effort to setup rule and document this *complex* EDK II Development Process. I am thinking if we can have a way (a tool) to mandate these process and check if there is any violation. If people makes mistake, he/she knows he/she is making mistake an

Re: [edk2-devel] [PATCH v12 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Hi Vladimir, Change Liming's email address. I have created one P-R for the patch to see the open-CI result. Seems it still some error about the coding style: 1. No doxygen tags in comment 2. mismatch parameters between comments and function definition 3. Comment description should end with '.' .

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg/AcpiView: HMAT Parser

Hi Sami, Please see below comment. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sami > Mujawar > Sent: Tuesday, August 25, 2020 7:07 PM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; Ni, Ray ; Gao, > Zhichao ; marc.moisson-franckhau...@arm.com; > guillaume.letell...@ar

回复: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

Guo: On pull request, https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process#the-maintainer-process-for-the-edk-ii-project section 7 gives the requirement. If is a patch series, then copy the patch #0 summary into the pull request description. Laszlo: I think we can

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

OK, abandoning this patch set. The BZ can stay open as we will still have to migrate the existing files to EVP eventually. -- Christopher Zurcher > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, September 16, 2020 18:34 > To: Zurcher, Christopher J ; Laszlo Ersek > ; devel@

Re: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option ROMs

Another comment: In your UefiPayloadPkg change, you have an assumption that the option ROM BAR still contain the correct base address. Is it always true in real world? Do you think maybe the boot loader should supply a MMIO space range so UeifPayloadPkg can use for option rom decoding? Thanks,

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

Thanks to ask this question Christopher. When we create the CryptoPkg, our goal is to pick openssl as implementation choice. We don’t want to mandate any EDKII consumer use openssl. The EDKII consumer shall have freedom to choose whatever crypto library they want to use. Even Intel IPP and mebd

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

Jiewen, This patch set assumes that EDK2 is linked with OpenSSL for the foreseeable future. The end goal would be to move all applicable Crypto access to the EVP interface and remove the individual modules we maintain for each algorithm. The primary benefit here is reducing complexity and code

Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

Abner, Are there RedFish dependencies in the REST EX Driver from your package? If not, perhaps it should be in the NetworkPkg, not in the RedFishPkg. From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang Sent: Monday, September 14, 2020 11:12 PM To: devel@edk2.groups.

Re: [edk2-devel] 回复: [edk2-devel] [PATCH v10 0/5] Use RngLib instead of TimerLib for OpensslLib

Hey Liming! I added the two reviewed by and pushed to the PR here: https://github.com/tianocore/edk2/pull/933 Feel free to use that PR to merge in -- - Matthew Carlson -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65342): https://edk2

Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

Thanks Laszlo for all these information. It looks it is not well communicated on the merge requirements. This is the first time for me to merge a patch set and I had thought it is same with merging a single patch (no cover letter). As UefiPayloadPkg maintainer, most time I worked on bootloaders.

Re: [edk2-devel] [PATCH v7 11/14] SecurityPkg: Allow VariablePolicy state to delete authenticated variables

These are both great points and I’ll make both changes. Thanks! - Bret From: Yao, Jiewen via groups.io Sent: Tuesday, September 15, 2020 7:52 PM To: Yao, Jiewen; gaoliming; devel@edk2.groups.io

Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

On 09/16/20 19:30, Dong, Guo wrote: > > Hi Laszlo, > > The patchset includes 3 patches, and all of them had been reviewed by package > owners. > The patch submitter has a pull request > https://github.com/tianocore/edk2/pull/885, I rebased the patch to latest > master, and merged it by adding

[edk2-devel] update edk2-platforms Vlv2TbltDevicePkg

Hi Mike, recently I have updated my CdePkg project from https://github.com/tianocore/edk2-staging.git. It seems that the ValleyView Package (MinnowBoard) in edk2-platforms/Platform/Int

Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

Hi Laszlo, The patchset includes 3 patches, and all of them had been reviewed by package owners. The patch submitter has a pull request https://github.com/tianocore/edk2/pull/885, I rebased the patch to latest master, and merged it by adding reviewed-by found from emails. I also make sure it p

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

On 09/16/20 16:17, Yao, Jiewen wrote: > Thank you Laszlo. > You forced me to read the code again and more carefully. :-) > > I believe I understand why you use NULL to free the context now - to support > error path. > > First, I did have some new thought for EVP API. Let’s consider 3 cases, 1)

[edk2-devel] [PATCH v2] EmulatorPkg: Enable support for Secure Boot

SECURE_BOOT_ENABLE feature flag is introduced to enable Secure Boot. The following gets enabled with this patch: o Secure Boot Menu in "Device Manager" for enrolling keys o Storage space for Authenticated Variables o Authenticated execution of 3rd party images Signed-off-by: Divneil Rai Wadhawan

Re: [edk2-devel] [PATCH] EmulatorPkg: Enable support for Secure Boot

Hi Ray, I have fixed the review comments. I will push a v2 of the patch. Regards, Divneil -Original Message- From: Ni, Ray Sent: Wednesday, September 16, 2020 2:16 PM To: gaoliming ; devel@edk2.groups.io; Wadhawan, Divneil R Cc: 'Andrew Fish' ; Justen, Jordan L ; Kinney, Michael D

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

On 09/16/20 14:56, Yao, Jiewen wrote: > I try to understand what is the use case to EvpMdFinal without DigestValue > and only Free the EvpMdContext. Error paths. You got some hashing going, detect an error condition (related to the hashing itself, or to something else), and want to abort / clean

Re: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize IncLines as empty list

Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Wednesday, September 16, 2020 8:21 PM To: devel@edk2.groups.io; gaolim...@byosoft.com.cn Cc: Desimone, Nathaniel L ; Zeng, Star Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize IncLines as empty

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

Thank you Laszlo. You forced me to read the code again and more carefully. :-) I believe I understand why you use NULL to free the context now - to support error path. First, I did have some new thought for EVP API. Let’s consider 3 cases, 1) Hash all data one time, 2) Hash update data multiple

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/AcpiView: PCCT Parser

Hi Zhichao, Thank you for the feedback. Please find my response inline marked [SAMI]. Regards, Sami Mujawar -Original Message- From: devel@edk2.groups.io On Behalf Of Gao, Zhichao via groups.io Sent: 16 September 2020 03:44 AM To: devel@edk2.groups.io; Sami Mujawar Cc: Ni, Ray ; Mar

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

On 09/16/20 13:44, Yao, Jiewen wrote: > Hi Laszlo > I disagree to put OPTIONAL for DigestValue, just because NULL is checked. > If we need follow this, then we need add OPTIONAL to almost all pointer, > which is unnecessary. I'm not suggesting OPTIONAL *only* because NULL is checked. I'm suggesti

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

On 09/16/20 14:39, Laszlo Ersek wrote: > On 09/16/20 14:07, Yao, Jiewen wrote: >> I overlooked the behavior that NULL DigestValue will take side effect to >> free Context. >> >> Hi Christopher >> May I understand why we need free the context? >> This does not align with other existing HASH or HMAC

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

I try to understand what is the use case to EvpMdFinal without DigestValue and only Free the EvpMdContext. A normal usage will be: 1) EvpMdHashAll (Digest) - get digest. 2) EvpMdInit, EvpMdUpdate, EvpMdUpdate, ... , EvpMdFinal (Digest) - get digest Why we need support the case to use EvpMdFinal

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

On 09/16/20 14:07, Yao, Jiewen wrote: > I overlooked the behavior that NULL DigestValue will take side effect to free > Context. > > Hi Christopher > May I understand why we need free the context? > This does not align with other existing HASH or HMAC functions. I requested that. It makes no se

Re: [edk2-devel] development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver]

Right. Now I understand why this is not enforced before - We do support Unicode in some content. Unfortunately, I don’t think you can enforce the contributor's keyboard device. We sometime write different document with different context, and switch between English and other language. It is not

Re: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize IncLines as empty list

Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming > Sent: Wednesday, September 16, 2020 5:58 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt

Re: [edk2-devel] development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver]

On 09/16/20 11:31, Yao, Jiewen wrote: > Hi Laszlo > Thanks. I agree 1, 2, 3. I take the blame. It is my fault. > > For 4, it is out of my scope. I cannot find this by my eyes. Everything works > well on my side. > Can we improve patch checker to catch this in CI ? > I don’t think I can find any U

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

I overlooked the behavior that NULL DigestValue will take side effect to free Context. Hi Christopher May I understand why we need free the context? This does not align with other existing HASH or HMAC functions. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

Hi Laszlo I disagree to put OPTIONAL for DigestValue, just because NULL is checked. If we need follow this, then we need add OPTIONAL to almost all pointer, which is unnecessary. > +BOOLEAN > +EFIAPI > +EvpMdFinal ( > + IN OUT VOID *EvpMdContext, > + OUT UINT8 *DigestValue (3) DigestVa

Re: [edk2-devel] [PATCH v3 1/3] CryptoPkg/BaseCryptLib: Add EVP (Envelope) Digest interface

Hello Christopher, On 09/16/20 02:59, Zurcher, Christopher J wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2545 > > The EVP interface should be used in place of discrete digest function > calls. > > Cc: Laszlo Ersek > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Signed-of

[edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize IncLines as empty list

IncLines as empty list for the case when InputHeaderFile is not specified. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Liming Gao --- IntelFsp2Pkg/Tools/GenCfgOpt.py | 1 + 1 file changed, 1 insertion(+) diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py b/IntelFsp2Pkg/Tools/Gen

Re: [edk2-devel] [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM driver

Patch is merged. The pull request was https://github.com/tianocore/edk2/pull/930 and the commit range is a62fb4229d14..7bcb021a6d54. Thank you Yao Jiewen > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, September 15, 2020 2:21 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ;

Re: [edk2-devel] development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver]

Hi Laszlo Thanks. I agree 1, 2, 3. I take the blame. It is my fault. For 4, it is out of my scope. I cannot find this by my eyes. Everything works well on my side. Can we improve patch checker to catch this in CI ? I don’t think I can find any Unicode in code or commit message easily. I prefer to

Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/OpensslLib: Add native instruction support for X64

Hi Zurcher, > [Jiewen] Since you also add other sha (sha1, sha512) and aesni, I think those > need unit test for them too. Can you update the status about it? > [Jiewen] I think we need support build with GCC and LLVM, and with X64. It is better to support the GCC and LLVM. Thanks Guomin > --

[edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

Guo, On 08/18/20 10:24, Marcello Sylvester Bauer wrote: > Support arbitrary platforms with different or even no MMCONF space. > Fixes crash on platforms not exposing 256 buses. > > Tested on: > * AMD Stoney Ridge > > Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg-MMCONF > PR: ht

Re: [edk2-devel] [PATCH] EmulatorPkg: Enable support for Secure Boot

1. I prefer to not duplicate the HobLib/PcdLib/.../TimerLib in DSC for runtime drivers just because they need to link a different CryptLib. 2. Why the DSC requires UEFI_DRIVER and UEFI_APPLICATION modules use RuntimeCryptLib? It should cause build failures because RuntimeCryptLib only can suppor

[edk2-devel] development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver]

Jiewen, Chasel, On 09/15/20 08:21, Qi Zhang wrote: > Some open board are TPM disabled. So the boot may hang because > these PPIs can't arrive. And gEdkiiTcgPpiGuid will be notified where > it is used. So we need to remove these PPIs from Depex for Fsp wrapper > PEI and PeiTpmMeasurementLib. >

Re: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option ROMs

Why running it will disable the ability of PciPlatform code to scan for ROMs? I guess it is because the PciIoDevice->AllOpRomProcessed is set which causes GetPciRom() is skipped. Can you explain more in the code comment? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ma

Re: [edk2-devel] [PATCH] EmulatorPkg: Enable support for Authenticated Variables

I assume you did the test. Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wadhawan, > Divneil R > Sent: Thursday, September 3, 2020 1:44 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Wadhawan, Divneil R > > Subject: [edk2-devel] [PATCH] Em

Re: [edk2-devel] [PATCH] OvmfPkg/README: HTTPS Boot: describe host-side TLS cipher suites forwarding

On 09/15/20 19:09, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 9/10/20 8:02 AM, Laszlo Ersek wrote: >> On 09/09/20 18:21, Philippe Mathieu-Daudé wrote: >>> On 9/7/20 6:18 PM, Laszlo Ersek wrote: In QEMU commit range 4abf70a661a5..69699f3055a5, Phil implemented a QEMU facility for e