Reviewed-by: Star Zeng <[email protected]> -----Original Message----- From: Chiu, Chasel <[email protected]> Sent: Wednesday, September 16, 2020 8:21 PM To: [email protected]; [email protected] Cc: Desimone, Nathaniel L <[email protected]>; Zeng, Star <[email protected]> Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize IncLines as empty list
Reviewed-by: Chasel Chiu <[email protected]> > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of > gaoliming > Sent: Wednesday, September 16, 2020 5:58 PM > To: [email protected] > Cc: Chiu, Chasel <[email protected]>; Desimone, Nathaniel L > <[email protected]>; Zeng, Star <[email protected]> > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize > IncLines as empty list > > IncLines as empty list for the case when InputHeaderFile is not specified. > > Cc: Chasel Chiu <[email protected]> > Cc: Nate DeSimone <[email protected]> > Cc: Star Zeng <[email protected]> > Signed-off-by: Liming Gao <[email protected]> > --- > IntelFsp2Pkg/Tools/GenCfgOpt.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py > b/IntelFsp2Pkg/Tools/GenCfgOpt.py index e9de128e..bcced590 100644 > --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py > +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py > @@ -1177,6 +1177,7 @@ EndList > UpdSignatureCheck = ['FSPT_UPD_SIGNATURE', > 'FSPM_UPD_SIGNATURE', 'FSPS_UPD_SIGNATURE'] > ExcludedSpecificUpd = ['FSPT_ARCH_UPD', 'FSPM_ARCH_UPD', > 'FSPS_ARCH_UPD'] > > + IncLines = [] > if InputHeaderFile != '': > if not os.path.exists(InputHeaderFile): > self.Error = "Input header file '%s' does not exist" > % InputHeaderFile > -- > 2.27.0.windows.1 > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65332): https://edk2.groups.io/g/devel/message/65332 Mute This Topic: https://groups.io/mt/76884308/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
