> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gao,
> Zhichao
> Sent: Wednesday, August 12, 2020 9:21 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> ; Ni, Ray ; Gary Lin
> ; Andrew Fish
> Subject: [edk2-devel] [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Rever
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gao,
> Zhichao
> Sent: Wednesday, August 12, 2020 9:21 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> ; Ni, Ray ; Gary Lin
> ; Andrew Fish
> Subject: [edk2-devel] [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Rever
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gao,
> Zhichao
> Sent: Wednesday, August 12, 2020 9:21 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> ; Ni, Ray ; Gary Lin
> ; Andrew Fish
> Subject: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Put t
> -Original Message-
> From: Gao, Zhichao
> Sent: Wednesday, August 12, 2020 9:21 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> ; Ni, Ray ; Gary Lin
> ; Andrew Fish
> Subject: [PATCH V2 3/3] MdeModulePkg/PartitionDxe: Fix the incorrect LBA
> size in child hander
>
> REF:
On Wed, Aug 12, 2020 at 09:21:21AM +0800, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2843
>
> Refer to the UEFI spec 2.8, Section 13.3.2:
> A block device should be scanned as below order:
> 1. GPT
> 2. ISO 96
AsBuiltInf can be created during AutoGen phase. Move CreateAsBuiltInf
into AutoGenWorker to make this step run in parallel.
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 2 +-
BaseTools/Source/Python/build/build.py | 4 +-
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gao, Zhichao
> Sent: Wednesday, August 12, 2020 9:21 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ; Ni,
> Ray ; Gary Lin
> ; Andrew Fish
> Subject: [edk2-devel] [PATCH V2 2/3] MdeModulePk
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gao, Zhichao
> Sent: Wednesday, August 12, 2020 9:21 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ; Ni,
> Ray ; Gary Lin
> ; Andrew Fish
> Subject: [edk2-devel] [PATCH V2 1/3] MdeModulePk
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Zhang, Qi1
> Sent: Thursday, August 06, 2020 8:34 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 ; Yao, Jiewen ;
> Wang, Jian J ; Kumar, Rahul1
> Subject: [PATCH v2 9/9] SecurityPkg/Tcg2: handle PRE HASH and LOG ONL
Qi,
Comments below.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Qi Zhang
> Sent: Thursday, August 06, 2020 8:34 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
> ; Zhang, Qi1
> Subject: [edk2-devel] [PATCH v2 6/9]
Thank you for the helpful comments Lazlo!
I sent out an updated series (v5) that fixes the things you mentioned. I added
more description, so hopefully that helps.
Sorry I didn't notice BhyvePkg, I thought you couldn't have packages under
other packages, so I didn't think to check for other DSC
Thanks Guomin!
I sent out a version 5 of this series.
--
- Matthew Carlson
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64040): https://edk2.groups.io/g/devel/message/64040
Mute This Topic: https://groups.io/mt/76119011/21656
Group Ow
From: Matthew Carlson
Added a new RngLib that provides random numbers from the TimerLib
using the performance counter. This is meant to be used for OpenSSL
to replicate past behavior. This should not be used in production as
a real source of entropy.
Ref: https://github.com/tianocore/edk2/pull/8
From: Matthew Carlson
Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the
TimerLib. This is due to a later change that adds TimerLib as a dependency
for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL
previously and it is recommended to switch to a better s
From: Matthew Carlson
Updates the DSC's for Ovmf based platforms to add a RngLib that uses the
TimerLib. This is due to a later change that adds TimerLib as a dependency
for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL
previously and it is recommended to switch to a better so
From: Matthew Carlson
Ref: https://github.com/tianocore/edk2/pull/845
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
Changes OpenSSL to no longer depend on TimerLib and instead use RngLib.
This allows platforms to decide for themsevles what sort of entropy source
they provide to OpenSS
From: Matthew Carlson
This adds a RngLib that uses the RngProtocol to provide randomness.
This means that the RngLib is meant to be used with DXE_DRIVERS.
Ref: https://github.com/tianocore/edk2/pull/845
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
Cc: Michael D Kinney
Cc: Liming Ga
From: Matthew Carlson
Hello all,
This patch contains a fix for Bugzilla 1871.
There's been a good bit of community discussion around the topic,
so below follows a general overview of the discussion and what this patch does.
Back in Devel message#40590 (https://edk2.groups.io/g/devel/message/405
Qi,
Some typos below.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Qi Zhang
> Sent: Thursday, August 06, 2020 8:34 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
> ; Zhang, Qi1
> Subject: [edk2-devel] [PATCH v2 5/
Qi,
This patch is similar to patch 3. Please refer to comments in that one.
Regards,
Jian
> -Original Message-
> From: Zhang, Qi1
> Sent: Thursday, August 06, 2020 8:34 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Zhang, Qi1
> Subject: [PATCH v2 4/9] SecurityPkg/P
Qi,
Comments below.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Qi Zhang
> Sent: Thursday, August 06, 2020 8:34 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Zhang, Qi1
> Subject: [edk2-devel] [PATCH v2 3/9] SecurityPkg/DxeTpmMeasurementLib: Add
>
Thanks. Good enough!
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gao, Zhichao
> Sent: Wednesday, August 12, 2020 8:45 AM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Gary Lin ; Andrew Fish
>
> Subject: Re: [edk2-devel] [PATCH 1/3] MdeModuleP
Qi,
Some typos. See inline comments below.
> -Original Message-
> From: Zhang, Qi1
> Sent: Thursday, August 06, 2020 8:34 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Wu, Hao A ; Zhang, Qi1
> Subject: [PATCH v2 2/9] MdeModulePkg/NullTpmMeasurementLib: Add new API.
Hi Qi,
Some typos. See inline comments below.
> -Original Message-
> From: Zhang, Qi1
> Sent: Thursday, August 06, 2020 8:34 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Wu, Hao A ; Zhang, Qi1
> Subject: [PATCH v2 1/9] MdeModulePkg/TpmMeasurementLib: Add new API to
Hi Laszlo,
Sorry for that. I removed it by mistake. I'll re-add it into the patch.
Thanks,
Shenglei
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, August 11, 2020 11:36 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> Cc: Feng, Bob C ; Br
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823
Refer to UEFI spec 2.8, Section 13.3.2, a block device should
be scanned as below order:
1. GPT
2. ISO 9660 (El Torito) (UDF should aslo be here)
3. MBR
4. no partition found
Note: UDF is using the same boot method as CD, so put it in
the sa
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2843
PartitionInstallChildHandle's parameters Start and End is counted
by the BlockSize, but in the implementation it uses the parent
device's BlockSize to calculate the new Start, End and LastBlock.
It would cause the driver report incorrect blo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823
Revert "MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM"
Follow the spec definition, the ISO 9660 (and UDF) would be
checked before the MBR. So it is not required to skip such
MBR talbe that contian the entire block device.
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2843
Refer to the UEFI spec 2.8, Section 13.3.2:
A block device should be scanned as below order:
1. GPT
2. ISO 9660 (El Torito) (UDF should aslo be here)
4. MBR
5. no partition found
But
*Reminder:* TianoCore Bug Triage - APAC / NAMO
*When:* Tuesday, 11 August 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los
Angeles
*Where:* https://bluejeans.com/889357567?src=join_info
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816386 )
*Organizer:* Brian Richardson brian.ri
Tested-by: Liming Gao
Reviewed-by: Liming Gao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael Kubacki
Sent: 2020年8月12日 8:24
To: devel@edk2.groups.io
Cc: Gao, Liming ; Kinney, Michael D
; Jiang, Guomin ; Xu, Wei6
Subject: [edk2-devel] [PATCH v1 1/1] FmpDevicePkg/Fmp
Reviewed-by: Liming Gao
-Original Message-
From: Zhang, Shenglei
Sent: 2020年8月11日 15:02
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Bret Barkelew
; Kinney, Michael D ;
Gao, Liming ; Sean Brogan
Subject: [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci
REF: https:
OK. I would put the detail in next version patch. Let me put a sample here:
With patch #3 but without patch #1, the MBR table of ISO 9660 image can be
handled correctly, i.e. it would be treat as MBR block device. We can find the
bootable image thru MBR path FAT filesystem. When boot Linux Distr
I am fine with that. BTW, it is better to add a BZ for this change. BZ would
make a good history of the discussion on this feature or bug fix.
Consumers may not aware of the discussion thru devel@edk2.groups.io, but they
will always find the record in BZ link.
Thanks,
Zhichao
> -Original Me
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2887
The local Private pointer variable in SetTheImage() is initialized
based on the caller provided This pointer argument. The cleanup
label path uses the Private pointer which will not be
initialized if This is NULL.
Thi
On 8/11/20 5:55 PM, Laszlo Ersek wrote:
> On 08/11/20 20:09, Cole Robinson wrote:
>> Googling for 'edk2 pull request' did not find this wiki page:
>>
>> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
>>
>> Add it to CONTRIBUTING.md for more discoverability
>>
>> Si
On 08/11/20 20:09, Cole Robinson wrote:
> Googling for 'edk2 pull request' did not find this wiki page:
>
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
>
> Add it to CONTRIBUTING.md for more discoverability
>
> Signed-off-by: Cole Robinson
> ---
> I tried su
On 08/11/20 16:40, Tom Lendacky wrote:
> I'm trying to run this tool on my Ubuntu installs (both 18.04 and 20.04)
> and it consistently fails trying to execute a git command:
>
> $ python3 BaseTools/Scripts/EccCheck.py
> usage: git [--version] [--help] [-C ] [-c =]
>
Upstreamed by Commit ID: cf364d100690e635897f48ade769583d19a78ed0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64013): https://edk2.groups.io/g/devel/message/64013
Mute This Topic: https://groups.io/mt/75912028/21656
Group Owner: devel+
Reviewed-by: G Edhaya Chandran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64012): https://edk2.groups.io/g/devel/message/64012
Mute This Topic: https://groups.io/mt/75912028/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: h
I realized there is room for misinterpretation of the macros
LAST_ATTEMPT_STATUS_DRIVER_ERROR_COUNT and
LAST_ATTEMPT_STATUS_DEPENDENCY_ERROR_COUNT based on name.
If there's no further feedback on the topic, I'll change them to
LAST_ATTEMPT_STATUS_DRIVER_ERROR_RANGE_LENGTH and
LAST_ATTEMPT_STA
Reviewed-by: G Edhaya Chandran
Upstreamed by Commit: 57280728e277c66d7803592cf071d87a21654d09
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64010): https://edk2.groups.io/g/devel/message/64010
Mute This Topic: https://groups.io/mt/75759
Reviewed-by: G Edhaya Chandran
Upstreamed by Commit: fd5996f2d060a090c0d4bb0107a8790221539eb9
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64009): https://edk2.groups.io/g/devel/message/64009
Mute This Topic: https://groups.io/mt/75759
Upstreamed by Commit: 5588ebe78620e7ee99bc56a08e964499af52a63b
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64008): https://edk2.groups.io/g/devel/message/64008
Mute This Topic: https://groups.io/mt/75759593/21656
Group Owner: devel+ow.
Upstreamed by Commits ID
57280728e277c66d7803592cf071d87a21654d09
fd5996f2d060a090c0d4bb0107a8790221539eb9
5588ebe78620e7ee99bc56a08e964499af52a63b
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64007): https://edk2.groups.io/g/devel/mess
Reviewed-by: G Edhaya Chandran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64006): https://edk2.groups.io/g/devel/message/64006
Mute This Topic: https://groups.io/mt/75759594/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: h
Googling for 'edk2 pull request' did not find this wiki page:
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
Add it to CONTRIBUTING.md for more discoverability
Signed-off-by: Cole Robinson
---
I tried submitting a PR to edk2: https://github.com/tianocore/edk2/p
#1: In v3, I'm going to split it such that the defines are in the public
header and the enum specifying the internal driver and dependency ranges
are in a private header to FmpDevicePkg.
Here's the current set of v3 changes to agree upon before sending a series:
1. Move the defines for the rang
python3.9 changed/fixed codec.register behavior to always replace
hyphen with underscore for passed in codec names:
https://bugs.python.org/issue37751
So the custom Ucs2Search needs to be adapted to handle 'ucs_2' in
addition to existing 'ucs-2' for back compat.
This fixes test failures on pyt
In python3, array.array.tostring() was a compat alias for tobytes().
tostring() was removed in python 3.9.
Convert this to use tolist() which should be valid for all python
versions.
This fixes this build error on python3.9:
(Python 3.9.0b5 on linux) Traceback (most recent call last):
File
"/
These patches fix two issues running the BaseTools test suite
on python 3.9 from Fedora rawhide. See patches for individual details
Cole Robinson (2):
BaseTools: fix ucs-2 lookup on python 3.9
BaseTools: Work around array.array.tostring() removal in python 3.9
BaseTools/Source/Python/AutoGen
Hi Qi,
Two common comments here. More specific comments will be given separately
in each patch email later.
c1. SecurityPkg/Library/DxeTpmMeasurementLib/EventLogRecord.c and
SecurityPkg/Library/PeiTpmMeasurementLib/EventLogRecord.c are almost
the same. Consider consolidating the code
On 8/11/20 9:49 AM, Laszlo Ersek wrote:
> On 08/11/20 03:12, Gao, Liming wrote:
>> Tom:
>> I run ECC plugin
>> (https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F63271&data=02%7C01%7Cthomas.lendacky%40amd.com%7C9c0fb2b16af248090fdb08d83e05c8
On 08/11/20 04:21, Matthew Carlson wrote:
> From: Matthew Carlson
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Anthony Perard
> Cc: Julien Grall
> Signed-off-by: Matthew Carlson
> ---
> OvmfPkg/OvmfPkgIa32.dsc| 1 +
> OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
> OvmfPkg/O
On 08/11/20 04:21, Matthew Carlson wrote:
> From: Matthew Carlson
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Signed-off-by: Matthew Carlson
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPk
Hi Ard!
On 08/11/20 10:22, Ard Biesheuvel wrote:
> On 8/11/20 4:21 AM, matthewfcarl...@gmail.com wrote:
>> From: Matthew Carlson
>>
>
> How am I supposed to review this change? The commit log is empty and I
> was not cc'ed on the cover letter.
Cover letter:
[edk2-devel] [PATCH v4 0/5] Use Rng
Hello Shenglei,
(+Ard)
On 08/11/20 09:01, Zhang, Shenglei wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
> As planed we will enable Ecc check for edk2 on open ci. And they are
> ready now. I appreciate receiving feedback and comments if someone
> find errors or false positive i
Hi Samer,
Comments included below.
Mike
> -Original Message-
> From: Samer El-Haj-Mahmoud
> Sent: Monday, August 10, 2020 11:37 AM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> r...@edk2.groups.io
> Cc: Laszlo Ersek ; Andrew Fish ; Leif
> Lindholm ; Samer El-Haj-
> Mahmoud
> Subj
On 08/11/20 03:12, Gao, Liming wrote:
> Tom:
> I run ECC plugin (https://edk2.groups.io/g/devel/message/63271) in my local
> machine. It reports below issues. Can you help update the patches to fix them?
> I use the standalone EccCheck from
> https://github.com/shenglei10/edk2/tree/ecc_script
On 8/10/20 8:12 PM, Gao, Liming wrote:
> Tom:
> I run ECC plugin
> (https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F63271&data=02%7C01%7Cthomas.lendacky%40amd.com%7Ce7a200ac9bfb47bff77e08d83d93abe6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C
Hi Bret,
Sorry for the delayed response.
Some more comments here:
1. Currently I see the LockVaribePolicy is called at ReadyToBoot by variable
driver, could we update it to be called at EndOfDxe? We should prevent
malicious code registering policy after EndOfDxe for security concern. And
coul
I prefer to directly revert the patch. It simplifies the change history.
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, August 11, 2020 4:29 PM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Wang, Jian J ; Wu, Hao A ;
> Gary Lin ; Andrew Fish
> Subject: RE: [edk2-devel] [PATCH 2/
> > This would also solve the issue that ISO image with MBR would be treat
> > as MBR device instead of CD/DVD. That would make the behavior of the
> > image boot different.
Can you please explain this in detail?
It's ok to not provide the "root" cause of why the image boot behavior is
different.
Hi Zhichao,
Some patches in this series need reworking.
Example - For '[PATCH v3 1/8] ShellPkg/AcpiView: Extract configuration struct'
& '[PATCH v3 2/8] ShellPkg/AcpiView: Declutter error counters'
I feel accessor methods offer a better design and should be retained.
Other patches in the series
Reminder for review of this series
Thanks,
--Samer
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Samer
> El-Haj-Mahmoud via groups.io
> Sent: Monday, July 20, 2020 2:17 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Pete Batard ; Andrei
> Warkentin (awarken...@vmwar
Thanks Pete.
Ard, Leif,
If there are no concerns, can you please push this patch, along with the other
series that are reviews:
https://edk2.groups.io/g/devel/message/63042
https://edk2.groups.io/g/devel/message/62790
Thanks,
--Samer
> -Original Message-
> From: devel@edk2.groups.io
It is slight complex, I will review it by 9/11/2020.
Thanks.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zurcher,
> Christopher J
> Sent: Tuesday, August 4, 2020 8:24 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J
> ; Lu, XiaoyuX ; Ard
> Biesheuvel
> Su
I will review the patch by next week(8/21).
Thanks
Guomin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Matthew Carlson
> Sent: Tuesday, August 11, 2020 10:22 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for
> Open
Reviewed-by: Guomin Jiang
Thanks
Guomin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Tuesday, August 11, 2020 3:02 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX
>
> Subject: [edk2-devel] [PATCH v9 05/16] CryptoPkg/CryptoPkg.c
+Hao, Ray,
Hi Libo, thanks for your explanation.
So I think the patch is improvement for current logic.
Hi Hao and Ray,
Can you give some comments for the change.
Hi Jeremy,
It may be helpful for the ASSERT issue
https://edk2.groups.io/g/devel/message/62651,can you try it?
Best Regards
Guom
Hello, Mr. Jiang,
Thank for the review.
The original enumeration steps in the function of UsbEnumerateNewDev of file
UsbEnumer.c: 1 reset the port, 2 set the usb device address, 3 get the Max
Packet Size, 4 get the full device descriptor. However, when plugging a USB
PenDisk with Innostor US
Ray,
The MBR info is correct. The order change is to avoid the MBR being checked
before UDF/ISO 9660 check.
That is why I make the patch #3 in the last of the patch set.
Thanks,
Zhichao
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, August 11, 2020 4:04 PM
> To: Gao, Zhichao ; d
I also add some variables to calculate StartingLBA and SizeInLBA instead of
calculate them when they are needed.
I am fine to revert the whole changes. Just make you aware of this.
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Tuesday, Au
Hi Guomin,
I'd suggest that you add a section to describe clearly the required steps to
enable this feature in a platform. I just noticed that SecMigrationPei.inf is
not mentioned for doing this.
Regards,
Jian
> -Original Message-
> From: Jiang, Guomin
> Sent: Tuesday, August 11, 2020 1
On 8/11/20 4:21 AM, matthewfcarl...@gmail.com wrote:
From: Matthew Carlson
How am I supposed to review this change? The commit log is empty and I
was not cc'ed on the cover letter.
In general, please try to muster up the energy to write at least one
sentence that describes *why* the patch
On 8/11/20 9:01 AM, Shenglei Zhang wrote:
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Shenglei Zhang
Reviewed-by: Liming Gao
Acked-by: Ar
Reviewed-by: Ray Ni
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, August 11, 2020 2:43 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ; Ni,
> Ray ; Gary Lin
> ; Andrew Fish
> Subject: [PATCH 3/3] MdeModulePkg/PartitionDxe: Fix the incorrect LBA size in
> chi
Zhichao,
Can you please just revert the fix you recently added?
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, August 11, 2020 2:43 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ; Ni,
> Ray ; Gary Lin
> ; Andrew Fish
> Subject: [PATCH 2/3] MdeModulePkg/Partiti
Zhichao,
Can you also add notes in the commit message describing that for some ISOs
(better with more specific ISO info), the MBR information is not correct?
Thanks,
Ray
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, August 11, 2020 2:43 PM
> To: devel@edk2.groups.io
> Cc:
On Tue, Aug 11, 2020 at 02:42:59PM +0800, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2843
>
> Refer to the UEFI spec 2.8, Section 13.3.2:
> A block device should be scanned as below order:
> 1. GPT
> 2. ISO 96
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
Reviewed-by: Liming Gao
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 12 ++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck is a plugin to report Ecc issues for code in pull request
, which will be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now. I appreciate receiving feedback and comments if someone
find errors or false positive issues.
I created a pipline of EccCheck for my forked edk2. Welcome everyon
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Besides, add submodule path in IgnoreFiles section.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 14 +
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Reviewed-by: Guomin Jiang
Reviewed-by: Liming Gao
---
FatPkg/FatPkg.ci.yaml | 12
1 file changed, 12 insertions(
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Besides, add submodule path in IgnoreFiles section.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Shenglei Zhang
---
CryptoPkg/CryptoPkg.ci.yaml | 13 +
1 f
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
Reviewed-by: Liming Gao
---
MdePkg/MdePkg.ci.yaml | 12
1 file changed, 12 insertions(+
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
Reviewed-by: Liming Gao
---
ShellPkg/ShellPkg.ci.yaml | 12
1 file changed, 12
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Besides, add submodule path in IgnoreFiles section.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Shenglei Zhang
---
UnitTestFrameworkPkg/Unit
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
Reviewed-by: Jian J Wang
Reviewed-by: Liming Gao
---
SecurityPkg/SecurityPkg.ci.yaml | 1
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
Reviewed-by: Liming Gao
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 13 +
1 file changed, 13 ins
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
Reviewed-by: Maciej Rabeda
Reviewed-by: Liming Gao
---
NetworkPkg/NetworkPkg.ci.yaml | 1
antlr4-python3-runtime is a lib to support Ecc run with Py3.x.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
Reviewed-by: Liming Gao
---
pip-requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/pip-requirements.txt b/pip-
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
Reviewed-by: Eric Dong
Acked-by: Laszlo Ersek
Reviewed-by: Liming Gao
---
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
Acked-by: Ray Ni
Reviewed-by: Liming Gao
---
EmulatorPkg/EmulatorPkg.ci.yaml | 12 +++
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Shenglei Zhang
Acked-by: Laszlo Ersek
Reviewed-by: Liming Gao
---
OvmfPkg/OvmfPkg.ci.yaml | 12
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Shenglei Zhang
Reviewed-by: Liming Gao
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 12
1 fi
97 matches
Mail list logo
