Hi Qi, Some typos. See inline comments below.
> -----Original Message----- > From: Zhang, Qi1 <qi1.zh...@intel.com> > Sent: Thursday, August 06, 2020 8:34 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > Wu, Hao A <hao.a...@intel.com>; Zhang, Qi1 <qi1.zh...@intel.com> > Subject: [PATCH v2 1/9] MdeModulePkg/TpmMeasurementLib: Add new API to > TpmMeasurmentLib. > > From: Jiewen Yao <jiewen....@intel.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 > > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Qi Zhang <qi1.zh...@intel.com> > Signed-off-by: Jiewen Yao <jiewen....@intel.com> > --- > .../Include/Library/TpmMeasurementLib.h | 48 ++++++++++++++++++- > 1 file changed, 47 insertions(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Include/Library/TpmMeasurementLib.h > b/MdeModulePkg/Include/Library/TpmMeasurementLib.h > index ddf6723f03..5a0f97d208 100644 > --- a/MdeModulePkg/Include/Library/TpmMeasurementLib.h > +++ b/MdeModulePkg/Include/Library/TpmMeasurementLib.h > @@ -1,7 +1,7 @@ > /** @file > > This library is used by other modules to measure data to TPM. > > > > -Copyright (c) 2012, Intel Corporation. All rights reserved. <BR> > > +Copyright (c) 2012 - 2020, Intel Corporation. All rights reserved. <BR> > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -35,4 +35,50 @@ TpmMeasureAndLogData ( > IN UINT64 HashDataLen > > ); > > > > +/** > > + Mesure a FirmwareBlob. 'Mesure' -> 'Measure' > > + > > + @param[in] PcrIndex PCR Index. > > + @param[in] Descrption Description for this FirmwareBlob. 'Descrption' -> 'Description' > > + @param[in] FirmwareBlobBase Base address of this FirmwareBlob. > > + @param[in] FirmwareBlobLength Size in bytes of this FirmwareBlob. > > + > > + @retval EFI_SUCCESS Operation completed successfully. > > + @retval EFI_UNSUPPORTED TPM device not available. > > + @retval EFI_OUT_OF_RESOURCES Out of memory. > > + @retval EFI_DEVICE_ERROR The operation was unsuccessful. > > +*/ > > +EFI_STATUS > > +EFIAPI > > +MeasureFirmwareBlob ( > > + IN UINT32 PcrIndex, > > + IN CHAR8 *Description OPTIONAL, > > + IN EFI_PHYSICAL_ADDRESS FirmwareBlobBase, > > + IN UINT64 FirmwareBlobLength > > + ); > > + > > +/** > > + Mesure a HandoffTable. 'Mesure' -> 'Measure' > > + > > + @param[in] PcrIndex PcrIndex of the measurment. 'measurment' -> 'measurement' > > + @param[in] Descrption Description for this HandoffTable. 'Descrption' -> 'Description' > > + @param[in] TableGuid GUID of this HandoffTable. > > + @param[in] TableAddress Base address of this HandoffTable. > > + @param[in] TableLength Size in bytes of this HandoffTable. > > + > > + @retval EFI_SUCCESS Operation completed successfully. > > + @retval EFI_UNSUPPORTED TPM device not available. > > + @retval EFI_OUT_OF_RESOURCES Out of memory. > > + @retval EFI_DEVICE_ERROR The operation was unsuccessful. > > +*/ > > +EFI_STATUS > > +EFIAPI > > +MeasureHandoffTable ( > > + IN UINT32 PcrIndex, > > + IN CHAR8 *Description OPTIONAL, > > + IN EFI_GUID *TableGuid, > > + IN VOID *TableAddress, > > + IN UINTN TableLength > > + ); > > + > > #endif > > -- > 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64028): https://edk2.groups.io/g/devel/message/64028 Mute This Topic: https://groups.io/mt/76019582/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
