[edk2-devel] [edk2-staging/EdkRepo] [PATCH V1 0/2] EdkRepo: Add support for SUBST drives

EdkRepo currently does not handle virtual drives created using the SUBST command. Specifically, when cloning or syncing a project to a subst drive the includeIf statements that redirect submodule fetches to mirror servers will be generated with the subst drive information.  This causes git to not

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V1 2/2] EdkRepo: Add support for subst drives

get_workspace_path() now converts a virtual drive path to a real path before any git repo operations are done. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Nate DeSimone --- edkrepo/commands/clone_command.py |

Re: [edk2-devel] [Patch 0/4] Update licenses

for the series, Acked-by: Ard Biesheuvel From: Michael D Kinney Sent: Tuesday, August 4, 2020 21:10 To: devel@edk2.groups.io Cc: Andrew Fish ; Laszlo Ersek ; Leif Lindholm ; Ard Biesheuvel ; Jian J Wang ; Hao A Wu ; Liming Gao Subject: [Patch 0/4] Update lic

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.

I will review it by next weekend(8/14). Thanks. From: devel@edk2.groups.io On Behalf Of Feng Libo Sent: Thursday, August 6, 2020 9:25 AM To: Feng Libo ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration. Hello, could anyone review

Re: [edk2-devel] question about MSFT compiler/link option

> On Aug 5, 2020, at 8:31 PM, Tiger Liu(BJ-RD) wrote: > > Hi, Michael: > I wrote this sentence in C file: > pTmp = (VOID*)& PdataStructTable; > Tiger, Working around optimization is complicated. You likely added a statement that got optimized away as the value of pTmp could be ignored and y

Re: [edk2-devel] question about MSFT compiler/link option

Hi, Michael: I wrote this sentence in C file: pTmp = (VOID*)& PdataStructTable; tried to reference the table being generated to prevent the optimizer from removing the data structure from the executable. But it is still being optimized away. I used MSTF VS2015. Thanks -邮件原件- 发件人: devel

[edk2-devel] [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp

For the implementation which utilizes libfdt provided in EmbeddedPkg however it uses strncmp function in the libfdt helper library, libfdt_env.h should provide the macro implied with edk2 strncmp implementation. The example is RISC-V OpenSBI library. edk2 RISC-V port uses OpenSBI library and incor

Re: [edk2-devel] [Patch 4/4] Readme.rst: List submodules and links to licenses

On 08/04/20 21:10, Michael D Kinney wrote: > Update list of content that is covered by a license other than > the BSD-2-Clause Plus Patent License and break out list of > content that is included as a git submodule from upstream > projects. > > * Use alphabetic order of content > * Remove referenc

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Add bhyve reviewers

On 08/02/20 05:42, Rebecca Cran wrote: > Bhyve files are under OvmfPkg, in OvmfPkg/Bhyve and > various files in OvmfPkg/Library and OvmfPkg/Include. > > Update Maintainers.txt to indicate reviewers for all > bhyve-specific files. > > Signed-off-by: Rebecca Cran > Cc: Andrew Fish > Cc: Laszlo Er

Re: [edk2-devel] [edk2-platforms] [PATCH] IntelSiliconPkg: IOMMU generic bug fix

Hi Liming, I’ve update the name Thanks, Lorena From: Gao, Liming Sent: Friday, July 31, 2020 2:30 AM To: De Leon Vasquez, Lorena R ; devel@edk2.groups.io; Lohr, Paul A ; Yao, Jiewen Cc: Kinney, Michael D Subject: RE: [edk2-devel] [edk2-platforms] [PATCH] IntelSiliconPkg: IOMMU generic bug fi

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.

Hello, could anyone review this PATCH? We encountered the USB enumeration problem and the patch is based on the Microsoft post as below. https://techcommunity.microsoft.com/t5/microsoft-usb-blog/how-does-usb-stack-enumerate-a-device/ba-p/270685#:~:text=%20How%20does%20USB%20stack%20enumerate%20

Re: [edk2-devel] [PATCH v2 6/9] IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib.

Hi Qi, Please see my comments below inline. Thanks, Chasel > -Original Message- > From: Zhang, Qi1 > Sent: Thursday, August 6, 2020 8:34 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Zhang, > Qi1 > Subject: [PATCH v2 6/9] I

Re: [edk2-devel] [PATCH V3] Maintainers.txt: Add reviewer for serial and disk

Reviewed-by: Ray Ni > -Original Message- > From: Zeng, Star > Sent: Monday, August 3, 2020 2:37 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Liming ; Ni, Ray > ; Bi, Dandan ; Zeng, Star > > Subject: RE: [edk2-devel] [PATCH V3] Maintainers.txt: A

[edk2-devel] [PATCH v2 7/9] IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 Cc: Jiewen Yao Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Qi Zhang Signed-off-by: Jiewen Yao --- .../FspmWrapperPeim/FspmWrapperPeim.c | 90 ++- .../FspmWrapperPeim/FspmWrapperPeim.i

[edk2-devel] [PATCH v2 5/9] IntelFsp2WrapperPkg/FspMeasurementLib: Add header file.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 Cc: Jiewen Yao Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Qi Zhang Signed-off-by: Jiewen Yao --- .../Include/Library/FspMeasurementLib.h | 39 +++ 1 file changed, 39 insertions(+) cre

[edk2-devel] [PATCH v2 6/9] IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 Cc: Jiewen Yao Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Qi Zhang Signed-off-by: Jiewen Yao --- .../BaseFspMeasurementLib.inf | 54 +++ .../BaseFspMeasurementLib/FspMeasurementLib.c | 349

[edk2-devel] [PATCH v2 4/9] SecurityPkg/PeiTpmMeasurementLib: Add new API.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Signed-off-by: Jiewen Yao --- .../PeiTpmMeasurementLib/EventLogRecord.c | 218 ++ .../PeiTpmMeasurementLib.inf | 4 + 2 files changed,

[edk2-devel] [PATCH v2 8/9] IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and PcdFspMeasurementConfig.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 Cc: Jiewen Yao Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Qi Zhang Signed-off-by: Jiewen Yao --- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 17 + IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.d

[edk2-devel] [PATCH v2 9/9] SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Qi Zhang --- SecurityPkg/Include/Ppi/Tcg.h | 5 + SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 12 +++- 2 files changed, 12 insertions(+), 5 deletions(-

[edk2-devel] [PATCH v2 2/9] MdeModulePkg/NullTpmMeasurementLib: Add new API.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 Cc: Jiewen Yao Cc: Jian J Wang Cc: Hao A Wu Cc: Qi Zhang Signed-off-by: Jiewen Yao --- .../TpmMeasurementLibNull.c | 61 ++- .../TpmMeasurementLibNull.inf | 6 +- 2

[edk2-devel] [PATCH v2 0/9] Need add a FSP binary measurement

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 The EDKII BIOS calls FSP API in FSP Wrapper Pkg. This FSP code need to be measured into TPM. We need add a generic module in FSP Wrapper Pkg code to measure: 1) FSP-T, FSP-M, FSP-S in API mode. 2) FSP-T in Dispatch-mode. The FSP-M and FSP-S

[edk2-devel] [PATCH v2 3/9] SecurityPkg/DxeTpmMeasurementLib: Add new API.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Signed-off-by: Jiewen Yao --- .../DxeTpmMeasurementLib.inf | 6 +- .../DxeTpmMeasurementLib/EventLogRecord.c | 218 ++ 2 files changed

[edk2-devel] [PATCH v2 1/9] MdeModulePkg/TpmMeasurementLib: Add new API to TpmMeasurmentLib.

From: Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2376 Cc: Jian J Wang Cc: Hao A Wu Cc: Qi Zhang Signed-off-by: Jiewen Yao --- .../Include/Library/TpmMeasurementLib.h | 48 ++- 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/MdeModulePk

Re: [edk2-devel] [PATCH v1 7/7] FmpDevicePkg/FmpDxe: Improve function parameter validation

Hi Mike, There's quite a few discrepancies at the moment between functions in FmpDxe that implement EFI_FIRMWARE_MANAGEMENT_PROTOCOL and the corresponding description in the UEFI spec. For example: UEFI Spec 2.8B - EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo(): Status Codes Returned EFI_

Re: [edk2-devel] [PATCH v1 7/7] FmpDevicePkg/FmpDxe: Improve function parameter validation

Michael, That is a good point. I missed that behavior in some of the APIs. What I also missed was that these APIs are defined in the UEFI Spec and the description of the return codes is from there and should match the UEFI Spec. The implementation should be conformant with the UEFI Spec. If yo

[edk2-devel] [PATCH v2 2/7] FmpDevicePkg/FmpDependencyLib: Fix "exression" typo

From: Michael Kubacki Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney Reviewed-by: Guomin Jiang Reviewed-by: Wei6 Xu --- FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | 2 +- 1 file changed, 1 insert

[edk2-devel] [PATCH v2 7/7] FmpDevicePkg/FmpDxe: Improve function parameter validation

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2869 Makes some minor improvements to function parameter validation in FmpDxe, in particular to externally exposed functions such as those that back EFI_FIRMWARE_MANAGEMENT_PROTOCOL. Cc: Liming Gao Cc: Michael D Kinney C

[edk2-devel] [PATCH v2 6/7] FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName

From: Michael Kubacki Updates the debug error message to include the GUID of the FMP instance that encountered the issue to help the user better isolate the problem. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney

[edk2-devel] [PATCH v2 3/7] FmpDevicePkg/FmpDependencyLib: Handle version string overflow

From: Michael Kubacki This change recognizes the condition of the DEPEX version string extending beyond the end of the dependency expression as an error. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney Reviewed-b

[edk2-devel] [PATCH v2 4/7] FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle failure

From: Michael Kubacki CheckFmpDependency () will currently return that dependencies are satisfied if the initial call in the function to locate handles that have gEfiFirmwareManagementProtocolGuid installed fails. This change updates the error handling to return FALSE (dependencies are not satis

[edk2-devel] [PATCH v2 0/7] FmpDevicePkg Minor Fixes

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2869 This patch series makes minor fixes and enhancements in FmpDevicePkg. None of the issues impact functionality in a major way. These are smaller sets of changes that are being submitted prior to a larger future patch s

[edk2-devel] [PATCH v2 5/7] FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig

From: Michael Kubacki A user may fall through to the case they depend on the PcdFmpDeviceImageTypeIdGuid value to get the ImageTypeId GUID value. The default PCD value is 0 (NULL) so the code would further fall back on the gEfiCallerIdGuid value. This change modifies the print error level for th

[edk2-devel] [PATCH v2 1/7] FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency() documentation

From: Michael Kubacki Modifies the return value documentation to state that the BOOLEAN value indicates whether a given dependency expression is valid not a capsule. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney

Re: [edk2-devel] [PATCH v1 7/7] FmpDevicePkg/FmpDxe: Improve function parameter validation

Hi Mike, Some of those functions currently return EFI_SUCCESS if ImageIndex is invalid. Example: https://github.com/tianocore/edk2/blob/master/FmpDevicePkg/FmpDxe/FmpDxe.c#L851 Given the request to update the EFI_INVALID_PARAMETER text for those other functions, I'm assuming you'd like me to

Re: [EXTERNAL] Re: [edk2-devel] [PATCH edk2-platforms 2/3] Silicon/NXP: Add support for reserving a chunk from RAM

Agreed with your gut feeling. - Bret From: Leif Lindholm via groups.io Sent: Wednesday, August 5, 2020 8:12 AM To: Pankaj Bansal Cc: Meenakshi Aggarwal; devel@edk2.groups.io

[edk2-devel] [PATCH v2 1/2] .pytool/Plugin: Enable BUILDREPORT on server CI builds

Update the CI invocable that builds host-based unit tests to make sure that BUILDREPORT is built for all tests. This is useful for determining which libraries were consumed in the build. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Bret Barkelew --- .p

[edk2-devel] [PATCH v2 2/2] .azurepipelines: Add BUILD_REPORT to collected artifacts

Make sure that the BUILD_REPORT is collected on server builds following the PR gate steps. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Bret Barkelew --- .azurepipelines/templates/pr-gate-steps.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.a

[edk2-devel] [PATCH v2 0/2] Add BUILDREPORT to server builds

Update CI plugins to generate a BUILDREPORT on build steps. This is especially useful for HostBased tests which are often run locally and which use unique library combinations. Helps to figure out which libraries were standard and which were for unit tests. Bret Barkelew (2): .pytool/Plugin: Ena

Re: [edk2-devel] [PATCH v1 7/7] FmpDevicePkg/FmpDxe: Improve function parameter validation

Hi Michael, A few minor comments included below. With those updates, Reviewed-bv: Michael D Kinney Mike > -Original Message- > From: michael.kuba...@outlook.com > Sent: Thursday, July 30, 2020 8:15 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > > Subject: [PA

Re: [edk2-devel] [PATCH v1 1/7] FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency() documentation

Reviewed-by: Michael D Kinney > -Original Message- > From: michael.kuba...@outlook.com > > Sent: Thursday, July 30, 2020 8:15 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael > D > Subject: [PATCH v1 1/7] FmpDevicePkg/FmpDependencyLib: > Correct ValidateDependency() doc

Re: [edk2-devel] [PATCH v1 6/7] FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Michael Kubacki > Sent: Thursday, July 30, 2020 8:15 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael > D > Subject: [edk2-devel] [PATCH v1 6/7] > FmpDevicePkg/FmpDxe: Indicat

Re: [edk2-devel] [PATCH v1 4/7] FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle failure

Reviewed-by: Michael D Kinney > -Original Message- > From: michael.kuba...@outlook.com > > Sent: Thursday, July 30, 2020 8:15 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael > D > Subject: [PATCH v1 4/7] > FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied > on han

Re: [edk2-devel] [PATCH v1 5/7] FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig

Reviewed-by: Michael D Kinney > -Original Message- > From: michael.kuba...@outlook.com > > Sent: Thursday, July 30, 2020 8:15 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael > D > Subject: [PATCH v1 5/7] FmpDevicePkg/FmpDxe: Better warn > of potential ImageTypeId misco

Re: [edk2-devel] [PATCH v1 3/7] FmpDevicePkg/FmpDependencyLib: Handle version string overflow

Reviewed-by: Michael D Kinney > -Original Message- > From: michael.kuba...@outlook.com > > Sent: Thursday, July 30, 2020 8:15 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael > D > Subject: [PATCH v1 3/7] FmpDevicePkg/FmpDependencyLib: > Handle version string overflow >

Re: [edk2-devel] [PATCH v1 2/7] FmpDevicePkg/FmpDependencyLib: Fix "exression" typo

Reviewed-by: Michael D Kinney > -Original Message- > From: michael.kuba...@outlook.com > > Sent: Thursday, July 30, 2020 8:15 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael > D > Subject: [PATCH v1 2/7] FmpDevicePkg/FmpDependencyLib: > Fix "exression" typo > > From:

Re: [edk2-devel] [Patch 4/4] Readme.rst: List submodules and links to licenses

Hi Leif, Thank you for the reviews! For generated files, I think there are two categories 1) Files generated as part of the build process that are placed in the build output directly and are never checked into a repository. 2) Files that are generated from a tool used by a developer,

Re: [edk2-devel] question about MSFT compiler/link option

Hi, I think you are seeing the impact of compiler optimizations. If a global variable is never referenced after optimizing the code, then the global variable will be optimized away. This type of optimization is important for size constrained environment like firmware. By using the /Gw- flag,

Re: [edk2-devel] [edk2-platforms PATCH 1/5] Silicon/Synopsys/DesignWare: Import DesignWare USB3 peripheral driver

Hi Leif, Sorry I missed your mail. For License issue I will update it later. I know there are some DesignWare USB controller driver, but most of them are for USB Host Mode. The driver "UsbDeviceDxe" is for USB Device Mode (i.e. peripheral). Usually it can be as the driver to support Android Fast

Re: [edk2-devel] [PATCH edk2-platforms 2/3] Silicon/NXP: Add support for reserving a chunk from RAM

On Wed, Jul 08, 2020 at 00:19:32 -0500, Pankaj Bansal wrote: > From: Pankaj Bansal > > Some NXP SOCs have some specialized IP blocks (like MC), which > require DDR memory to operate. This DDR memory should not be managed > by OS or UEFI. > > Moreover to ensure that these IP blocks always get mem

Re: [edk2-devel] [PATCH edk2-platforms 3/3] Silicon/NXP: Add Support for git commit info print

On Wed, Jul 08, 2020 at 00:19:33 -0500, Pankaj Bansal wrote: > From: Pankaj Bansal > > This patch adds the Support for printing the git commit information > in linux build environment. > > Ideal place of retrieving this information should be python script in > BaseTools. > > A Feature request f

Re: [edk2-devel] [PATCH edk2-platforms 1/3] Silicon/NXP: Use runtime safe version of DebugLib

On Wed, Jul 08, 2020 at 00:19:31 -0500, Pankaj Bansal wrote: > From: Pankaj Bansal > > For DXE_RUNTIME_DRIVER runtime safe version of DebugLib should be > used. Otherwise, any DEBUG print in code can result in abort in OS. > > Signed-off-by: Pankaj Bansal For this patch: Reviewed-by: Leif Lind

Re: [edk2-devel] [Patch 4/4] Readme.rst: List submodules and links to licenses

Hi Mike, For the series: Reviewed-by: Leif Lindholm Recent events make me think though - should we have an explicit statement regarding those files we have that are generated without an explicit license? / Leif On Tue, Aug 04, 2020 at 12:10:10 -0700, Michael D Kinney wrote: > Update list o

Re: [edk2-devel] [PATCH edk2-platforms v1 0/3] Casts to avoid void* pointer arithmetic

On Thu, Jul 30, 2020 at 20:15:08 +0100, PierreGondois wrote: > These patches cast void* pointers to UINTN, preventing to do > void* pointer arithmetc. > > Pierre Gondois (3): > Silicon/Marvell/Drivers: Casts to avoid void* pointer arithmetic > Silicon/Socionext/SynQuacer: Casts to avoid void*