Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com>
> -----Original Message-----
> From: michael.kuba...@outlook.com
> <michael.kuba...@outlook.com>
> Sent: Thursday, July 30, 2020 8:15 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming....@intel.com>; Kinney, Michael
> D <michael.d.kin...@intel.com>
> Subject: [PATCH v1 4/7]
> FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied
> on handle failure
>
> From: Michael Kubacki <michael.kuba...@microsoft.com>
>
> CheckFmpDependency () will currently return that
> dependencies are
> satisfied if the initial call in the function to locate
> handles
> that have gEfiFirmwareManagementProtocolGuid installed
> fails.
>
> This change updates the error handling to return FALSE
> (dependencies
> are not satisfied) if this handle search fails.
>
> Cc: Liming Gao <liming....@intel.com>
> Cc: Michael D Kinney <michael.d.kin...@intel.com>
> Signed-off-by: Michael Kubacki
> <michael.kuba...@microsoft.com>
> ---
>
> FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependency
> CheckLib.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependen
> cyCheckLib.c
> b/FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependen
> cyCheckLib.c
> index 5e0241b25957..02ed600e0e95 100644
> ---
> a/FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependen
> cyCheckLib.c
> +++
> b/FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependen
> cyCheckLib.c
> @@ -2,6 +2,7 @@
> Provides FMP capsule dependency check services when
> updating the firmware
> image of a FMP device.
>
> + Copyright (c) Microsoft Corporation.<BR>
> Copyright (c) 2020, Intel Corporation. All rights
> reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -75,6 +76,7 @@ CheckFmpDependency (
> );
> if (EFI_ERROR (Status)) {
> DEBUG ((DEBUG_ERROR, "CheckFmpDependency: Get
> Firmware Management Protocol failed. (%r)", Status));
> + IsSatisfied = FALSE;
> goto cleanup;
> }
>
> --
> 2.27.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#63732): https://edk2.groups.io/g/devel/message/63732
Mute This Topic: https://groups.io/mt/75900907/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
