Re: [edk2-devel] question about MSFT compiler/link option

2020-08-04 Thread Tiger Liu(BJ-RD)
Hi, Liming: Thanks for your reply! I checked map file, not find this global data array. I found if added this build option in this PEIM's inf, then it seems ok. [BuildOptions] MSFT:*_*_IA32_CC_FLAGS = /Gw- Thanks -邮件原件- 发件人: devel@edk2.groups.io 代表 Liming Gao 发送时间: 2020年8月4日 23:21 收件

[edk2-devel] [PATCH 1/2] MdePkg: Remove code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES

2020-08-04 Thread Zhang, Shenglei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2777 Code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES is deprecated. So remove it. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- MdePkg/Library/BaseLib/String.c| 626 - MdePkg/Library/B

[edk2-devel] [PATCH 0/2] Remove code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES

2020-08-04 Thread Zhang, Shenglei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2777 Code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES is deprecated. So remove it from MdePkg and MdeModulePkg. Cc: Jian J Wang Cc: Hao A Wu Cc: Michael D Kinney Cc: Liming Gao Shenglei Zhang (2): MdePkg: Remove code wrapped by DISABLE_NEW

[edk2-devel] [PATCH 2/2] MdeModulePkg: Remove code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES

2020-08-04 Thread Zhang, Shenglei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2777 Code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES is deprecated. So remove it. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Shenglei Zhang --- .../DxePrintLibPrint2Protocol/PrintLib.c | 145 -- MdeModulePkg/Universal/

Re: [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes

2020-08-04 Thread Guomin Jiang
Reviewed-by: Guomin Jiang for the patch series. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, August 5, 2020 3:12 AM > To: devel@edk2.groups.io; Gao, Liming ; Kinney, > Michael D > Subject: Re: [edk2-devel] [PATCH v1 0/7] FmpDevicePk

Re: [edk2-devel] [Patch 2/4] MdeModulePkg/PeCoffImageEmulator.h: Apply BSD-2-Clause-Patent

2020-08-04 Thread Wu, Hao A
> -Original Message- > From: Kinney, Michael D > Sent: Wednesday, August 5, 2020 3:10 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Leif Lindholm ; Ard Biesheuvel > > Subject: [Patch 2/4] MdeModulePkg/PeCoffImageEmulator.h: Apply BSD-2- > Clause-Patent > > Change licen

Re: [edk2-devel] [Patch] BaseTools/VolInfo: Fix spelling mistake

2020-08-04 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Kinney, Michael D Sent: Saturday, August 1, 2020 6:28 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [Patch] BaseTools/VolInfo: Fix spelling mistake REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2349 Cc: Bob Fen

Re: [edk2-devel] [Patch] BaseTools/GenSec: Fix spelling mistake

2020-08-04 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Michael D Kinney Sent: Saturday, August 1, 2020 9:25 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [Patch] BaseTools/GenSec: Fix spelling mistake REF: https://bugzilla.tia

[edk2-devel] Topics for this week's Community meeting

2020-08-04 Thread Soumya Guptha
Dear Community Members, Our monthly community meeting is coming up on Thursday (Aug 6) of this week. We will cover our standard topics - download from Stewards call, Stable tag updates, ARs/updates if any etc.. If you have any topics that you like to bring in, please let me know and I can add you

Re: [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes

2020-08-04 Thread Michael Kubacki
I saw one R-b for the series from Wei6 Xu. Could the remaining reviewers please help with review? I have a larger series that is based on it that I'd like to send once this series is merged. Thanks, Michael On 7/30/2020 8:14 PM, Michael Kubacki wrote: From: Michael Kubacki REF:https://bug

[edk2-devel] [Patch 1/4] EmbeddedPkg/NonCoherentIoMmuDxe: Apply BSD-2-Clause-Patent

2020-08-04 Thread Michael D Kinney
Change license to BSD-2-Clause-Patent using an SPDX-License-Identifier statement. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Michael D Kinney --- .../Drivers/NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.c | 9 + .../NonCoherentIoMmuDxe/NonCoherentIoMmuDxe.inf| 10 +---

[edk2-devel] [Patch 3/4] MdePkg/BaseMemoryLibOptDxe: Apply BSD-2-Clause-Patent

2020-08-04 Thread Michael D Kinney
Change license to BSD-2-Clause-Patent using an SPDX-License-Identifier statement. Cc: Liming Gao Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Michael D Kinney --- .../BaseMemoryLibOptDxe/AArch64/CompareGuid.S | 24 + .../BaseMemoryLibOptDxe/AArch64/CompareMem.S | 24 +

[edk2-devel] [Patch 2/4] MdeModulePkg/PeCoffImageEmulator.h: Apply BSD-2-Clause-Patent

2020-08-04 Thread Michael D Kinney
Change license to BSD-2-Clause-Patent using an SPDX-License-Identifier statement. Cc: Jian J Wang Cc: Hao A Wu Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Michael D Kinney --- MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h | 9 + 1 file changed, 1 insertion(+), 8 deletio

[edk2-devel] [Patch 0/4] Update licenses

2020-08-04 Thread Michael D Kinney
Update licenses that may have been missed in the conversion to the BSD-2-Clause-Patent using SPDX identifiers. Also update list of licenses in Readme.rst and list git submodule license in their own list. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Jian J Wang Cc

[edk2-devel] [Patch 4/4] Readme.rst: List submodules and links to licenses

2020-08-04 Thread Michael D Kinney
Update list of content that is covered by a license other than the BSD-2-Clause Plus Patent License and break out list of content that is included as a git submodule from upstream projects. * Use alphabetic order of content * Remove references to IntelFrameworkModulePkg * Add reference for UnitTes

Re: [edk2-devel] [PATCH] Check return status on calls to GetTime()

2020-08-04 Thread Grant Likely
On 01/08/2020 14:54, Heinrich Schuchardt wrote: On 7/31/20 7:19 PM, Grant Likely wrote: [...]>> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBo

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-04 Thread Vladimir Olovyannikov via groups.io
Hi Laszlo, Thank you for the comments. I agree with them, and as you suggest, I will address them along with comments from maintainers. Thank you, Vladimir > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Monday, July 27, 2020 3:08 PM > To: devel@edk2

Re: [edk2-devel] [PATCH edk2-test 1/1] SctPkg: fix page alignment calculations

2020-08-04 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63703): https://edk2.groups.io/g/devel/message/63703 Mute This Topic: https://groups.io/mt/75299798/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] question about MSFT compiler/link option

2020-08-04 Thread Liming Gao
If this global variable is used by code, it will be linked into the final EFI image. You can check whether the generate map file includes it. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Tiger > Liu(BJ-RD) > Sent: Tuesday, August 4, 2020 5:34 PM > To: devel@edk2.group

[edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Fix GUID of EfiCompliant test

2020-08-04 Thread Samer El-Haj-Mahmoud
The GUID of one of the EfiCompliant test cases is incorrect. The GUID is defined in test case 5.22.1.2.12 in section 2.1.2 of UEFI_SCTII_Case_Spec_2_6_A.pdf, which is available from UEFI Forum: http://www.uefi.org/sites/default/files/resources/ UEFI2.6SCTII_Final_Release.zip The GUID value is corr

Re: [edk2-devel] [PATCH edk2-test 1/1] SctPkg: fix page alignment calculations

2020-08-04 Thread Samer El-Haj-Mahmoud
I verified that this works on multiple platforms Tested-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Samer > El-Haj-Mahmoud via groups.io > Sent: Thursday, July 23, 2020 10:33 PM > To: Pankaj Bansal ; devel@edk2.groups.io; > Eric Jin ; G Edhaya

Re: [edk2-devel] [PATCH] Check return status on calls to GetTime()

2020-08-04 Thread Samer El-Haj-Mahmoud
Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: Grant Likely > Sent: Friday, July 31, 2020 1:20 PM > To: devel@edk2.groups.io > Cc: nd ; Grant Likely ; G Edhaya > Chandran ; Heinrich Schuchardt > ; Samer El-Haj-Mahmoud mahm...@arm.com> > Subject: [PATCH] Check return stat

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: typo Verity in TimeServicesBBTestFunction

2020-08-04 Thread Samer El-Haj-Mahmoud
Picking up old SCT patches that were missed Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heinrich > Schuchardt via Groups.Io > Sent: Sunday, December 8, 2019 10:51 AM > To: EDK II Development > Cc: Eric Jin ; Supreeth Venkatesh > ; St

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

2020-08-04 Thread Samer El-Haj-Mahmoud
Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heinrich > Schuchardt via groups.io > Sent: Monday, July 27, 2020 1:53 PM > To: EDK II Development > Cc: Eric Jin ; G Edhaya Chandran > ; Heinrich Schuchardt > Subject: [edk2-devel] [edk2-t

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: EFI_RNG_PROTOCOL.GetInfo check size != 0

2020-08-04 Thread Samer El-Haj-Mahmoud
Picking old SCT patches that were missed Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heinrich > Schuchardt via Groups.Io > Sent: Saturday, December 28, 2019 10:37 AM > To: EDK II Development > Cc: Eric Jin ; Supreeth Venkatesh > ; H

Re: [edk2-devel] [Patch 5/6] SecurityPkg: Fix spelling mistake for occurred

2020-08-04 Thread Maciej Rabeda
Reviewed-by: Maciej Rabeda On 01-Aug-20 03:04, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2361 Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Michael D Kinney --- .../Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 2 +- 1 file changed, 1 inser

[edk2-devel] question about MSFT compiler/link option

2020-08-04 Thread Tiger Liu(BJ-RD)
Hi, Experts: I have a question about MSFT compiler/link option. I wrote a PEIM, which had a large global data array definition in a C file. Such as: PRI_DATA_STRUCT PdataStructTable[] = { {01, 0x75,0xF0, 0x0, 0x0, 0x0 }, {02, 0x77,0xF0, 0x0, 0x0,

Re: [edk2-devel] [Patch] BaseTools: Improve the method of checking queue empty

2020-08-04 Thread Liming Gao
Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: 2020年8月3日 10:04 To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Lucy Yan Subject: [edk2-devel] [Patch] BaseTools: Improve the method of checking queue empty Fr