Reviewed-by: Guomin Jiang <guomin.ji...@intel.com> for the patch series.
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael > Kubacki > Sent: Wednesday, August 5, 2020 3:12 AM > To: devel@edk2.groups.io; Gao, Liming <liming....@intel.com>; Kinney, > Michael D <michael.d.kin...@intel.com> > Subject: Re: [edk2-devel] [PATCH v1 0/7] FmpDevicePkg Minor Fixes > > I saw one R-b for the series from Wei6 Xu. > > Could the remaining reviewers please help with review? > > I have a larger series that is based on it that I'd like to send once this > series is > merged. > > Thanks, > Michael > > On 7/30/2020 8:14 PM, Michael Kubacki wrote: > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2869 > > > > This patch series makes minor fixes and enhancements in FmpDevicePkg. > > None of the issues impact functionality in a major way. > > > > These are smaller sets of changes that are being submitted prior to a > > larger future patch series that will cover functional changes for > > BZ2802. > > > > Please check the git notes in patch 3 and patch 5. > > > > Cc: Liming Gao <liming....@intel.com> > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > > > > Michael Kubacki (7): > > FmpDevicePkg/FmpDependencyLib: Correct ValidateDependency() > > documentation > > FmpDevicePkg/FmpDependencyLib: Fix "exression" typo > > FmpDevicePkg/FmpDependencyLib: Handle version string overflow > > FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle > > failure > > FmpDevicePkg/FmpDxe: Better warn of potential ImageTypeId misconfig > > FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName > > FmpDevicePkg/FmpDxe: Improve function parameter validation > > > > FmpDevicePkg/FmpDxe/FmpDxe.c | 62 > ++++++++++++++++---- > > > FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib > .c | 2 + > > FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c | > 8 ++- > > FmpDevicePkg/FmpDxe/FmpDxe.h | 10 > > ++-- > > FmpDevicePkg/Include/Library/FmpDependencyLib.h | 5 +- > > 5 files changed, 67 insertions(+), 20 deletions(-) > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63716): https://edk2.groups.io/g/devel/message/63716 Mute This Topic: https://groups.io/mt/75900877/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-