Guomin,
Just one minor comment below.
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guomin
> Jiang
> Sent: Thursday, July 09, 2020 9:57 AM
> To: devel@edk2.groups.io
> Cc: Michael Kubacki ; Dong, Eric
> ; Ni, Ray ; Laszlo Ersek
> ; Kumar, Rahul1 ; De,
> De
> +//
> +// If the MBR with partition entry contains itself, i.e. start with LBA0,
> +// and have the same size with the media, we treat it as a El Torito
> partition.
> +//
> +if ((StartingLBA == 0) &&
> +(SizeInLBA != 0) &&
1. Can this check "SizeInLBA != 0" be remove
Guomin,
See my 16 comments embedded below.
About PcdMigrateTemporaryRamFirmwareVolumes, I think we need more
discussions on its use scenario along with PcdShadowPeimOnBoot and
PcdShadowPeimOnS3Boot. Currently it need all of them enabled to make
this solution work, which is a bit complex and confu
1. Can you rename LastBlock to LastSector and remove the MediaSize local
variable?
2. Can you add comments to describe that sector size is 512?
3. Can you explain why this fix is needed in the commit message?
Thanks,
Ray
> -Original Message-
> From: Gao, Zhichao
> Sent: Wednesday, Jul
On 7/12/20 11:43 PM, Gao, Liming wrote:
PatchCheck change is tracked in BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=2833.
Thanks. I think that also, the change "[edk2-devel] [PATCH 1/2] Revert
"BaseTools/PatchCheck.py: Add LicenseCheck"" will allow this changeset
to be committed.
Rebecca:
PatchCheck change is tracked in BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=2833.
Thanks
Liming
-Original Message-
From: Rebecca Cran
Sent: 2020年7月13日 13:42
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Andrew Fish ;
Leif Lindholm ; Justen, Jordan L
; Kinney, Michael
This depends on the pending changes to PatchCheck.py
Rebecca Cran (1):
Add BhyvePkg, to support the bhyve hypervisor
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 251 +++
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 77 +
.../Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 65 +
OvmfPkg
Guomin,
> -Original Message-
> From: Jiang, Guomin
> Sent: Thursday, July 09, 2020 9:57 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Laszlo Ersek
> Subject: [PATCH v5 1/9] MdeModulePkg: Add new PCD to control the evacuate
> temporary memory feature (CVE-2019-11098)
>
Reviewed-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Saturday, July 11, 2020 10:09 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Sean Brogan ; Bret Barkelew
; Yao, Jiewen
Subject: [Patch v3 01/16] BaseTools/Python: Allow HOST_APPLICATION to use NULL
l
> On Jul 11, 2020, at 10:17 PM, Wasim Khan wrote:
>
> Hello
>
> Any comments ?
>
I don’t see IoLibArm.c in master? I see IoLibNoIo.c.
The MMIO function look like ARM assembler with the correct barrier
instructions. The IO operations in this lib are the x86 in/out instructions, so
they j
Hi Mike,
the link https://indy.fulgan.com/SSL/openssl-1.0.2r-x64_86-win64.zip from your
script
https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel/Vlv2TbltDevicePkg/Readme.md#download-and-build-minnowmax-using-windowsvisual-studio
is not available anymore.
Do you know if anyon
Hi Zach,
I have fixed "Error 4000" EDK II Build Issue in my MinnowBoard reference
project CdePkg that you can find at edk2-staging:
https://github.com/tianocore/edk2-staging/tree/CdePkg
https://github.com/tianocore/edk2-staging/commit/5c2c7662f52cabc741464218b35282b7829a7908
The problem is, th
This patch series refactors the error logging in the AcpiView
functionality to a newly created logging facility.
The new error logging facility in AcpiViewLog.[ch] contains
helper functions to log messages of various types and severities,
enumerations of known error types as well as common abstrac
Refactor logging using the AcpiViewLog facility.
Trim some of the source to more elegant state.
Change-Id: I98b2c49b155e8c8b91aaf9bbd2ab21ebad5b36f0
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 225 --
.../UefiShellAc
Remove accessor method bloat by creating a configuration
struct that is linked using an extern symbol in the config header
file. Directly reference the config struct for all read
and write accesses in the entire module.
Rationalise the remaining methods in the config header and source.
Change-Id:
The tests for checking specific constraints and checking
for buffer overflows have been simplified to use a standard
set of templates defined in the logging facility.
This regularises some of the error handling and makes
it easier to write more tests like this in the future.
Change-Id: Ica35c9ca1
Extract error and warning logging into separate methods. Fold
highlighting and other output properties into the logging methods.
Change-Id: I46bba2afc6fe8d7bc0c92ec7054f2af2d2254441
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 5 +-
The dump variable helper functions are refactored into
a separate header file as inline functions to declutter code.
Change-Id: I9c43c9ce1e9809813949b4f45b1b19b6265e18c4
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 212 --
The AcpiView core method is refactored to take format
and parameters rather than a fully formatted string. This
allows for far more flexible parser writing.
Change-Id: I02c30939f2c5ad98da7174303ae241839d2c8eba
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewComma
Modify the DumpFile error message to be more in line
with the rest of the error messages in the same file.
Change-Id: I8f074178154e13db06a67f2158448fc625ee4216
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 4 +---
1 fi
Remove superfluous accessor methods for error and warning
counters.
Change-Id: I23df0aa10cfc757f37d83dee7ecce8a188a3ad1c
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 54 ++-
.../UefiShellAcpiViewCommandLib/AcpiParser.
21 matches
Mail list logo
