Thanks Guomin for the comments!
Below is the main scenario for the proposed change:
- Device Manufacturer provides the devices with UEFI preinstalled in non-secure
state and no hard-coded keys ( PcdFmpDevicePkcs7CertBufferXdr).
- Customer (not End-User) enrolls their own keys in trusted environ
Hi Tomas,
I already reopen then pull request and add the push label. It would be merged
after passing the open-CI check.
Thanks,
Zhichao
From: devel@edk2.groups.io On Behalf Of Tomas Pilar
(tpilar)
Sent: Monday, June 29, 2020 10:25 PM
To: devel@edk2.groups.io; Tomas Pilar
Cc: Ni, Ray ; Gao,
Looks good to me, but I would like to (personally) first test on CM3 (which has
eMMC), before this is merged. Stay tuned...
And thanks again for working on this. I like the approach taken.
A
From: Pete Batard
Sent: Monday, June 29, 2020 1:36 PM
To: devel@edk2.gr
*Reminder:* TianoCore Bug Triage - APAC / NAMO
*When:* Tuesday, 30 June 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles
*Where:* https://bluejeans.com/889357567?src=join_info
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816014 )
*Organizer:* Brian Richardson brian.richa
Hi Huang,
>From issue statement, I guess that
1. AutoUpdateLangVariable() invoked, and it will invoke FindVariable() first,
at the same time, reclaim occur and Variable.CurrPtr is invalid, it return with
success
2. UpdateVariable() is invoked when The old Lang's State is valid and the new
Lang'
Two additional questions/comments with this patch set.
1. Is this package not compatible with MSVC toolchain? From the readme
update it looks like GCC/Ubuntu only. From the DSC it looks like
ARM|AARCH64 only? Is there any reason this isn't compatible?
2. You need one more patch to get this r
* Add GpioPinSet () function to set a GPIO pin value
* Add GpioPinGet () function to read a GPIO pin value
* Add GpioSetPull () function to set pullup/down state of a GPIO pin
GpioSetPull () supports both the legacy method used on Bcm283[5-7]
as well as the new method used on Bcm2711.
Each of the
The Raspberry Pi 3 and Pi 4 platforms (with latest EEPROM) can boot
straight from USB, without the need for an SD card being present.
However, the IsCardPresent () calls from the ArasanMmcHost and SdHost
drivers are currently hardwired to return TRUE, which results in
straight to USB boot failing d
Hi Sean,
I realised that the INF files were not listed in the components section, and
this is causing the 'DscCompleteCheck' to fail.
I will submit an update patch series with this fixed.
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sean via
groups
Mostly curious but why are there modules not built during ci (The files
listed in the DscCompleteCheck[IgnoreInf] list)?
Thanks
Sean
On 6/29/2020 6:27 AM, Sami Mujawar wrote:
The TianoCore EDKII project has introduced a Core CI infrastructure
using TianoCore EDKII Tools PIP modules:
* ht
The dump variable helper functions are refactored into
a separate header file as inline functions to declutter code.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 212 ---
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 13
The AcpiView core method is refactored to take format
and parameters rather than a fully formatted string. This
allows for far more flexible parser writing.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 30
.../UefiSh
This patch series refactors the error logging in the AcpiView
functionality to a newly created logging facility.
The new error logging facility in AcpiViewLog.[ch] contains
helper functions to log messages of various types and severities,
enumerations of known error types as well as common abstrac
Refactor logging using the AcpiViewLog facility.
Trim some of the source to more elegant state.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 224 --
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 6 +-
.../AcpiTabl
The tests for checking specific constraints and checking
for buffer overflows have been simplified to use a standard
set of templates defined in the logging facility.
This regularises some of the error handling and makes
it easier to write more tests like this in the future.
Cc: Ray Ni
Cc: Zhich
Extract error and warning logging into separate methods. Fold
highlighting and other output properties into the logging methods.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 5 +-
.../UefiShellAcpiViewCommandLib/AcpiViewLog.c | 230
Modify the DumpFile error message to be more in line
with the rest of the error messages in the same file.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --gi
Remove accessor method bloat by creating a configuration
struct that is linked using an extern symbol in the config header
file. Directly reference the config struct for all read
and write accesses in the entire module.
Rationalise the remaining methods in the config header and source.
Cc: Ray Ni
Remove superfluous accessor methods for error and warning
counters.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 54 ++-
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 4 ++
.../UefiShellAcpiViewCommandLib/AcpiView.
Hello Bob,
I actually found more files having a LF line ending by running the following
command:
for file in `git ls-files`; do if [ "${file##*.}" != bin ] && [ "${file##*.}"
!= bmp ] && [ "${file##*.}" != a ] && [ "${file##*.}" != lib ] && [
"${file##*.}" != cer ] && [ "${file##*.}" != pyd ] &&
Oh, it looks like any pull requests created by non-maintainers get auto-closed
by mergify. Nevermind then.
From: devel@edk2.groups.io On Behalf Of Tomas Pilar
(tpilar) via groups.io
Sent: 29 June 2020 15:11
To: devel@edk2.groups.io
Cc: Ray Ni ; Zhichao Gao ; Sami
Mujawar
Subject: [edk2-devel]
Hi Ray, Zhichao,
I've created a pull request with the standalone acpiview patches for your
convenience. Could you please merge it once it passes the CI checks?
Cheers,
Tom
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are no
The TianoCore EDKII project has introduced a Core CI infrastructure
using TianoCore EDKII Tools PIP modules:
* https://pypi.org/project/edk2-pytool-library/
* https://pypi.org/project/edk2-pytool-extensions/
The edk2\.pytool\Readme.md provides information to configure the
environment and to ru
The TianoCore EDKII project has introduced a Core CI infrastructure
using TianoCore EDKII Tools PIP modules.
This patch series adds support for building DynamicTablesPkg using
the EKDII Core CI.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/839_dynamictablespkg_ci_v1
Sami
Update pytools configuration to enable DynamicTablesPkg
and update package status in documentation.
Signed-off-by: Sami Mujawar
---
.pytool/CISettings.py | 2 ++
.pytool/Readme.md | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings
The TianoCore EDKII project has introduced a Core CI infrastructure
using TianoCore EDKII Tools PIP modules:
* https://pypi.org/project/edk2-pytool-library/
* https://pypi.org/project/edk2-pytool-extensions/
More information on configuring the environment and running the
builds can be found in edk
From: Wasim Khan
Enable PlatformDxe driver for LX2160aRdbPkg
Signed-off-by: Wasim Khan
Reviewed-by: Leif Lindholm
---
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 2 ++
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 3 +++
2 files changed, 5 insertions(+)
diff --git a/Platform/NXP/LX2160aR
From: Wasim Khan
Enable NetworkPkg for LX2160aRdbPkg Platform to
enable networking stack and test PCIe ethernet NIC.
Signed-off-by: Wasim Khan
---
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 11 +++
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 5 +
2 files changed, 16 inserti
From: Wasim Khan
PCIe Layerscape controller in LX2160A-Rev2 is not completely
ECAM-compliant. It is non-ECAM only for the root bus (bus 0)
and for any other bus underneath the root bus it does support
ECAM access.
One approach can be to setup the controller in firmware and
expose bus[0x1-0xff] to
From: Wasim Khan
Define PCIe related PCDs for LX2160A.
Signed-off-by: Wasim Khan
Reviewed-by: Leif Lindholm
---
Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 +
1 file changed, 5 insertions(+)
diff --git a/Silicon/NXP/LX2160A/LX2160A.dsc.inc
b/Silicon/NXP/LX2160A/LX2160A.dsc.inc
index fe8ed40
From: Wasim Khan
Enable generic PCIe drivers and Wire up PciHostBridgeLib,
PciSegmentLib and PciCpuIo2Dxe.
Signed-off-by: Wasim Khan
Reviewed-by: Leif Lindholm
---
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 9 +
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 7 +++
2 files cha
From: Wasim Khan
Add PlatformDxe to do platform specific work.
At present it sets PCDs for PCIe controller based on
SoC version, which are used later during initialization
of PCIe controller.
Signed-off-by: Wasim Khan
---
Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf | 35
From: Wasim Khan
LX2160-Rev1 and LX2160-Rev2 has different PCIe controller.
This patch series adds PCIe support for LX2160aRdbPkg which includes
- Add PCIe space in VirtualMemoryMap
- Platform driver to check SoC version and sets PCDs for PCIe controller, which
are used by PciHostBridgeLib and
From: Wasim Khan
LX2160A SoC has 6 PCIe controllers with 32GB space available
for each controller. A platform may have different PCIe controllers
enabled based on the RCW used to boot platform.
Add space for all PCIe controllers in VirtualMemoryMap.
Signed-off-by: Wasim Khan
---
Platform/NXP/L
34 matches
Mail list logo
