Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

“But we do have tools that insert the Bugzilla number in all the commits of the series, assist with the squash, etc.” Are these internal-only, or are they something we could evaluate when we move to the PR process? If not, are they based on anything we could leverage? I believe that the plan is

Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

You know what… That’s fair. Apologies to the community. - Bret From: Laszlo Ersek Sent: Wednesday, May 20, 2020 2:53 PM To: devel@edk2.groups.io; Bret Barkelew; Desimone, Nathaniel L

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

> On May 21, 2020, at 6:30 AM, Laszlo Ersek wrote: > > On 05/20/20 00:25, Sean wrote: >> On 5/19/2020 1:41 PM, Laszlo Ersek wrote: > >>> Your proposal to "don't exclude squash merge workflows" is a trap. If >>> we tolerate that option -- which is obviously the sloppy, and hence >>> more conve

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

> On May 20, 2020, at 10:21 AM, Sean wrote: > > When this is done in a PR with branch protections this works out differently > and in my view your concerns are mitigated. > > 1. There isn't a partial squash operation. All reviewers know that the final > output of the PR is going to 1 commi

Re: [edk2-devel] [PATCH v3 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform

Reviewed-by: Maurice Ma > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Thursday, May 21, 2020 15:43 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, Benjamin ; Bret Barkelew > > Subject: [edk2-devel] [PATCH v3 08/14] UefiPayload

[edk2-devel] [PATCH v3 12/14] MdeModulePkg: Change TCG MOR variables to use VariablePolicy

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 These were previously using VarLock, which is being deprecated. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Cc: Bret Barkelew Signed-off-by: Michael Kubacki --- MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockDxe

[edk2-devel] [PATCH v3 05/14] OvmfPkg: Add VariablePolicy engine to OvmfPkg platform

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Bret Barkelew Signed-off-by: Michael Kubacki --- OvmfPkg/OvmfPkgIa32.dsc| 8 OvmfPkg/OvmfPkgIa32X64.dsc | 8 OvmfPkg/OvmfPkgX64.dsc |

[edk2-devel] [PATCH v3 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Cc: Bret Barkelew Signed-off-by: Michael Kubacki --- UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 7 +++ UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 7 +++ 2 files chan

[edk2-devel] [PATCH v3 13/14] MdeModulePkg: Drop VarLock from RuntimeDxe variable driver

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Now that everything should be moved to VariablePolicy, drop support for the deprecated VarLock SMI interface and associated functions from variable RuntimeDxe. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Cc: Bret Barkele

[edk2-devel] [PATCH v3 10/14] MdeModulePkg: Allow VariablePolicy state to delete protected variables

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 TcgMorLockSmm provides special protections for the TCG MOR variables. This will check IsVariablePolicyEnabled() before enforcing them to allow variable deletion when policy engine is disabled. Only allows deletion, not modi

[edk2-devel] [PATCH v3 14/14] MdeModulePkg: Add a shell-based functional test for VariablePolicy

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 To verify that VariablePolicy is correctly integrated on platforms, add a Shell-based functional test to confirm expected behavior. NOTE: This test assumes that VariablePolicy is built with PcdAllowVariablePolicyEnforcement

[edk2-devel] [PATCH v3 07/14] ArmVirtPkg: Add VariablePolicy engine to ArmVirtPkg platform

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Bret Barkelew Signed-off-by: Michael Kubacki --- ArmVirtPkg/ArmVirt.dsc.inc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ArmVirtPkg/ArmVirt.dsc.in

[edk2-devel] [PATCH v3 11/14] SecurityPkg: Allow VariablePolicy state to delete authenticated variables

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Causes AuthService to check IsVariablePolicyEnabled() before enforcing write protections to allow variable deletion when policy engine is disabled. Only allows deletion, not modification. Cc: Jiewen Yao Cc: Jian J Wang C

[edk2-devel] [PATCH v3 06/14] EmulatorPkg: Add VariablePolicy engine to EmulatorPkg platform

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Cc: Bret Barkelew Signed-off-by: Michael Kubacki --- EmulatorPkg/EmulatorPkg.dsc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/Emul

[edk2-devel] [PATCH v3 09/14] MdeModulePkg: Connect VariablePolicy business logic to VariableServices

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add connective code to publish the VariablePolicy protocol and wire it to either the SMM communication interface or directly into the VariableP

[edk2-devel] [PATCH v3 02/14] MdeModulePkg: Define the VariablePolicyLib

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add the VariablePolicyLib library that implements the portable business logic for the VariablePolicy engine. Also add host-based CI test cases

[edk2-devel] [PATCH v3 03/14] MdeModulePkg: Define the VariablePolicyHelperLib

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add the VariablePolicyHelperLib library, containing several functions to help with the repetitive process of creating a correctly structured an

[edk2-devel] [PATCH v3 04/14] MdeModulePkg: Define the VarCheckPolicyLib and SMM interface

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. This is an instance of a VarCheckLib that is backed by the VariablePolicyLib business logic. It also publishes the SMM calling interface for me

[edk2-devel] [PATCH v3 00/14] Add the VariablePolicy feature

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2522 The 14 patches in this series add the VariablePolicy feature to the core, deprecate Edk2VarLock (while adding a compatibility layer to reduce code churn), and integrate the VariablePolicy libraries and protocols into V

[edk2-devel] [PATCH v3 01/14] MdeModulePkg: Define the VariablePolicy protocol interface

From: Bret Barkelew https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add the VariablePolicy protocol interface header and add to the MdeModulePkg.dec file. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Cc: Bret

Re: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: connect handles on registration

On 5/21/20 11:12 PM, Laszlo Ersek via groups.io wrote: Hi Ard, On 05/21/20 13:10, Ard Biesheuvel wrote: The way EDK2 invokes the UEFI driver model assumes that PCI I/O protocol instances exist for all PCI I/O controllers in the system. For instance, UefiBootManagerLib connects the short-form U

Re: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: connect handles on registration

Hi Ard, On 05/21/20 13:10, Ard Biesheuvel wrote: > The way EDK2 invokes the UEFI driver model assumes that PCI I/O > protocol instances exist for all PCI I/O controllers in the system. > > For instance, UefiBootManagerLib connects the short-form USB device > path of the console input by looking fo

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On 05/21/20 16:16, Leif Lindholm wrote: > OK, then I would vote *for* merging the patch regardless. We know how > long some toolchain versions can stick around simply because they were > mentioned in some blog post somewhere that ended up high in search > rankings. > > Once gcc 10.2 is released (

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/Tcg2ConfigPei: clean up some lib class dependencies

On 5/21/20 8:04 PM, Laszlo Ersek wrote: Hi Phil, On 05/21/20 12:29, Philippe Mathieu-Daudé wrote: On 5/21/20 12:58 AM, Laszlo Ersek wrote: Commit 89236992913f introduced an explicit Tpm12CommandLib dependency to Tcg2ConfigPei. In reality this lib class is not consumed by Tcg2ConfigPei at all

[edk2-devel] [PATCH v2 6/6] ShellPkg/AcpiView: Add application wrapper

Simple application wrapper that invokes the shell command wrapper for acpiview. This allows the AcpiView functionality to be used on platforms with older specifications of the UEFI shell or where the 'acpiview' command is not built in due to platform build configuration. Furthermore, this app can

[edk2-devel] [PATCH v2 4/6] ShellPkg/AcpiView: Move parameter parsing

Parsing command line parameters is done in the shell command wrapper. This declutters the core code and improves modular design. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Tomas Pilar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c| 205 -

[edk2-devel] [PATCH v2 5/6] ShellPkg/AcpiView: Refactor DumpAcpiTableToFile

Method is refactored into two parts. A new method is created that dumps arbitrary buffers into a newly created file. This method is called from core code after the core code determined the appropriate filename to be used. This improves the modular design. Cc: Ray Ni Cc: Zhichao Gao Signed-off-b

[edk2-devel] [PATCH v2 3/6] ShellPkg/AcpiView: Move table count reset

The table count module level symbols are now reset when executing the core method, rather than the shell command wrapper. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Tomas Pilar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions

[edk2-devel] [PATCH v2 2/6] ShellPkg/AcpiView: Refactor configuration

A new file and header (AcpiViewConfig.[ch]) is created that houses the user configuration. This declutters the core code and improves modularity of the design. The module level symbols for verbosity, table selection, and highlighting are refactored into the new file. Cc: Ray Ni Cc: Zhichao Gao

[edk2-devel] [PATCH v2 0/6] Standalone AcpiView Application

This patchset adds a new application module to the ShellPkg with the functionality of the 'acpiview' command. The existing code is tidied and a clean boundary between the UEFI shell command wrapper and the acpiview functionality is created. Then, a new application wrapper is added. The motivatio

[edk2-devel] [PATCH v2 1/6] ShellPkg/AcpiView: Move log reset to main method

The error and warning counters are reset in the AcpiView main method. This improves reusability of the main method. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Tomas Pilar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) d

Re: [edk2-devel] [PATCH v1 4/6] ShellPkg/AcpiView: Move parameter parsing

Well, it looks like the settings for send-email don't Just Work (tm), I'll clean up the series and resubmit. Apologies for spamming the list. Tom -Original Message- From: devel@edk2.groups.io On Behalf Of Tomas Pilar (tpilar) via groups.io Sent: 21 May 2020 19:16 To: devel@edk2.groups.

[edk2-devel] [PATCH v1 4/6] ShellPkg/AcpiView: Move parameter parsing

Parsing command line parameters is done in the shell command wrapper. This declutters the core code and improves modular design. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Tomas Pilar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c| 205 -

[edk2-devel] [PATCH v1 2/6] ShellPkg/AcpiView: Refactor configuration

A new file and header (AcpiViewConfig.[ch]) is created that houses the user configuration. This declutters the core code and improves modularity of the design. The module level symbols for verbosity, table selection, and highlighting are refactored into the new file. Cc: Ray Ni Cc: Zhich

[edk2-devel] [PATCH v1 0/6] Standalone AcpiView Application

This patchset adds a new application module to the ShellPkg with the functionality of the 'acpiview' command. The existing code is tidied and a clean boundary between the UEFI shell command wrapper and the acpiview functionality is created. Then, a new application wrapper is added. The motivation

[edk2-devel] [PATCH v1 3/6] ShellPkg/AcpiView: Move table count reset

The table count module level symbols are now reset when executing the core method, rather than the shell command wrapper. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Tomas Pilar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions

[edk2-devel] [PATCH v1 6/6] ShellPkg/AcpiView: Add application wrapper

Simple application wrapper that invokes the shell command wrapper for acpiview. This allows the AcpiView functionality to be used on platforms with older specifications of the UEFI shell or where the 'acpiview' command is not built in due to platform build configuration. Furthermore, this

[edk2-devel] [PATCH v1 5/6] ShellPkg/AcpiView: Refactor DumpAcpiTableToFile

Method is refactored into two parts. A new method is created that dumps arbitrary buffers into a newly created file. This method is called from core code after the core code determined the appropriate filename to be used. This improves the modular design. Cc: Ray Ni Cc: Zhichao Gao Sig

[edk2-devel] [PATCH v1 1/6] ShellPkg/AcpiView: Move log reset to main method

The error and warning counters are reset in the AcpiView main method. This improves reusability of the main method. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Tomas Pilar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) d

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/Tcg2ConfigPei: clean up some lib class dependencies

Hi Phil, On 05/21/20 12:29, Philippe Mathieu-Daudé wrote: > On 5/21/20 12:58 AM, Laszlo Ersek wrote: >> Commit 89236992913f introduced an explicit Tpm12CommandLib dependency to >> Tcg2ConfigPei. >> >> In reality this lib class is not consumed by Tcg2ConfigPei at all (such a >> dependency is not ev

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

Laszlo, I appreciate the back and forth. I find email a challenge for this type of discussion because it leaves so much to individual interpretation and bias. Anyway Thank you for having the discussion. I hope others with opinions feel empowered to chime in and help this RFC go in the dire

Re: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: connect handles on registration

On 5/21/20 1:16 PM, Leif Lindholm wrote: On Thu, May 21, 2020 at 13:10:28 +0200, Ard Biesheuvel wrote: The way EDK2 invokes the UEFI driver model assumes that PCI I/O protocol instances exist for all PCI I/O controllers in the system. For instance, UefiBootManagerLib connects the short-form USB

Re: [edk2-devel] [PATCH v8 13/46] OvmfPkg/VmgExitLib: Add support for IOIO_PROT NAE events

On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a IOIO_PROT intercept generates a #VC exception. VMGEXIT > must be used to allow the hypervisor to handle this intercept. > > Add support to construct the required GHCB values to

Re: [edk2-devel] [PATCH v8 12/46] OvmfPkg/VmgExitLib: Implement library support for VmgExitLib in OVMF

On 5/21/20 11:52 AM, Laszlo Ersek wrote: On 05/19/20 23:50, Lendacky, Thomas wrote: The base VmgExitLib library provides a default limited interface. As it does not provide full support, create an OVMF version of this library to begin the process of providing full support of SEV-ES within OVMF.

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On 5/21/20 7:02 PM, Ard Biesheuvel wrote: On 5/21/20 6:59 PM, Philippe Mathieu-Daudé wrote: On 5/21/20 6:45 PM, Ard Biesheuvel wrote: On 5/21/20 6:40 PM, Philippe Mathieu-Daudé via groups.io wrote: On 5/20/20 2:37 PM, Philippe Mathieu-Daudé wrote: Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel w

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On 5/21/20 6:59 PM, Philippe Mathieu-Daudé wrote: On 5/21/20 6:45 PM, Ard Biesheuvel wrote: On 5/21/20 6:40 PM, Philippe Mathieu-Daudé via groups.io wrote: On 5/20/20 2:37 PM, Philippe Mathieu-Daudé wrote: Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit ca

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On 5/21/20 6:45 PM, Ard Biesheuvel wrote: On 5/21/20 6:40 PM, Philippe Mathieu-Daudé via groups.io wrote: On 5/20/20 2:37 PM, Philippe Mathieu-Daudé wrote: Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outl

[edk2-devel] [PATCH edk2-platforms 1/1] Silicon/ChaosKeyDxe: don't rely on connect all controllers

The ChaosKey driver implements the UEFI driver model, and so it is not guaranteed that any controllers will be attached to this driver unless it is connected explicitly. On many platforms today, this is taken care of by the ConnectAll() call that occurs in the BDS, but this is not something we shou

Re: [edk2-devel] [PATCH v8 12/46] OvmfPkg/VmgExitLib: Implement library support for VmgExitLib in OVMF

On 05/19/20 23:50, Lendacky, Thomas wrote: > The base VmgExitLib library provides a default limited interface. As it > does not provide full support, create an OVMF version of this library to > begin the process of providing full support of SEV-ES within OVMF. > > SEV-ES support is only provided f

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On 5/21/20 6:40 PM, Philippe Mathieu-Daudé via groups.io wrote: On 5/20/20 2:37 PM, Philippe Mathieu-Daudé wrote: Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10

Re: [edk2-devel] [PATCH v8 09/46] OvmfPkg: Prepare OvmfPkg to use the VmgExitLib library

On 05/19/20 23:50, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Various CpuExceptionHandlerLib libraries will updated to use the new > VmgExitLib library. To prevent any build breakage, update the OvmfPkg > DSC files that use a form of the CpuExceptionHandl

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On 5/20/20 2:37 PM, Philippe Mathieu-Daudé wrote: Hi Ard, On 5/20/20 1:44 PM, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10 introduces new intrinsics, and even though it would be possible

Re: [edk2-devel] [PATCH v3 2/2] ArmPlatformPkg: Fix comparison of constants warning

On 5/21/20 5:20 PM, Sami Mujawar wrote: The VS2017 compiler reports 'warning C6326: potential comparison of a constant with another constant' when a fixed PCD value is compared with a constant value. The faulting code is as marked by '-->' below: --> if (FixedPcdGet32 (PL011UartInteger) != 0) {

[edk2-devel] [PATCH v3 2/2] ArmPlatformPkg: Fix comparison of constants warning

The VS2017 compiler reports 'warning C6326: potential comparison of a constant with another constant' when a fixed PCD value is compared with a constant value. The faulting code is as marked by '-->' below: --> if (FixedPcdGet32 (PL011UartInteger) != 0) { Integer = FixedPcdGet32 (PL011UartI

[edk2-devel] [RFC edk2-platforms v1 1/3] Silicon/Hisilicon: Change updating dsdt in ready to boot event

The better time for updating dsdt is in ready to boot event, so change the updating time. Signed-off-by: Ming Huang --- Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 60 ++-- 1 file changed, 56 insertions(+), 4 deletions(-) diff --git a/Silicon/Hisilicon/Drivers/Ac

[edk2-devel] [RFC edk2-platforms v1 3/3] Silicon/Hisilicon: Rename EthMac files

As not only update mac address feature in EthMac files, so rename them to UpdateDsdt. Signed-off-by: Ming Huang --- Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +- Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 8 +- Silicon/Hisilicon/Drivers/AcpiPlatfo

[edk2-devel] [RFC edk2-platforms v1 0/3] Improve D0x

Main Changes: Add update sas address feature in AcpiPlatformDxe. Ming Huang (3): Silicon/Hisilicon: Change updating dsdt in ready to boot event Silicon/Hisilicon/Acpi: Add update sas address feature Silicon/Hisilicon: Rename EthMac files Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatfo

[edk2-devel] [RFC edk2-platforms v1 2/3] Silicon/Hisilicon/Acpi: Add update sas address feature

The updating sas address feature is similar with apdating mac address. Modify updating dsdt flow for add this feature. Signed-off-by: Ming Huang --- Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +- Silicon/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c | 200 +++-

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On Thu, May 21, 2020 at 15:31:44 +0200, Ard Biesheuvel wrote: > > > That does mean you would need GCC 10.2 at least, or you get the error, > > > unless we merge this patch as well. That would mean the intrinsics are > > > never > > > used in practice, but using a compiler that does use them will n

Re: [edk2-devel] [Patch v9 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test

Ack-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Thursday, May 21, 2020 4:10 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ard Biesheuvel > ; Bret Barkelew ; > Brian J . Johnson ; Chiu, Chasel > ; Justen, Jordan L ; > Las

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On 5/21/20 3:16 PM, Leif Lindholm wrote: On Thu, May 21, 2020 at 14:58:56 +0200, Ard Biesheuvel wrote: Reviewed-by: Leif Lindholm Thanks! Apparently, GCC 10 is getting fixed so that we can set a #pragma in MdePkg/Include/AArch64/ProcessorBind.h, and be done with it. That does mean you would

Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

On 05/20/20 00:25, Sean wrote: > On 5/19/2020 1:41 PM, Laszlo Ersek wrote: >> Your proposal to "don't exclude squash merge workflows" is a trap. If >> we tolerate that option -- which is obviously the sloppy, and hence >> more convenient, option for some maintainers and some contributors, >> to th

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On Thu, May 21, 2020 at 14:58:56 +0200, Ard Biesheuvel wrote: > > Reviewed-by: Leif Lindholm > > Thanks! > > > > Apparently, GCC 10 is getting fixed so that we can set a #pragma in > MdePkg/Include/AArch64/ProcessorBind.h, and be done with it. > > That does mean you would need GCC 10.2 at least

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On 5/21/20 1:23 PM, Leif Lindholm via groups.io wrote: On Wed, May 20, 2020 at 13:44:48 +0200, Ard Biesheuvel wrote: Gary reports the GCC 10 will emit calls to atomics intrinsics routines unless -mno-outline-atomics is specified. This means GCC-10 introduces new intrinsics, and even though it wo

Re: [edk2-devel] [PATCH 0/3] OvmfPkg/Tcg2ConfigPei: fix ARM/AARCH64 build failure

On 05/21/20 00:58, Laszlo Ersek wrote: > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2728 > Repo: https://pagure.io/lersek/edk2.git > Branch: restrict_tpm12_to_x86_bz_2728 > > Another regression fix for edk2-stable202005. > > End of February 2020, Ard and Marc-André worked on two TPM

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On Wed, May 20, 2020 at 13:44:48 +0200, Ard Biesheuvel wrote: > Gary reports the GCC 10 will emit calls to atomics intrinsics routines > unless -mno-outline-atomics is specified. This means GCC-10 introduces > new intrinsics, and even though it would be possible to work around this > by specifying

Re: [edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: connect handles on registration

On Thu, May 21, 2020 at 13:10:28 +0200, Ard Biesheuvel wrote: > The way EDK2 invokes the UEFI driver model assumes that PCI I/O > protocol instances exist for all PCI I/O controllers in the system. > > For instance, UefiBootManagerLib connects the short-form USB device > path of the console input

[edk2-devel] [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: connect handles on registration

The way EDK2 invokes the UEFI driver model assumes that PCI I/O protocol instances exist for all PCI I/O controllers in the system. For instance, UefiBootManagerLib connects the short-form USB device path of the console input by looking for PCI I/O controllers that have the 'USB host controller' c

Re: [edk2-devel] [PATCH 0/3] OvmfPkg/Tcg2ConfigPei: fix ARM/AARCH64 build failure

On 05/21/20 11:12, Laszlo Ersek wrote: > On 05/21/20 10:26, Laszlo Ersek wrote: >> On 05/21/20 00:58, Laszlo Ersek wrote: >>> Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2728 >>> Repo: https://pagure.io/lersek/edk2.git >>> Branch: restrict_tpm12_to_x86_bz_2728 >>> >>> Another regressio

Re: [edk2-devel] [PATCH 3/3] OvmfPkg/Tcg2ConfigPei: skip TPM-1.2 detection when building for ARM/AARCH64

On 5/21/20 12:58 AM, Laszlo Ersek wrote: Dating back to commits f5cb3767038e and ddd34a818315d, the "ArmVirtPkg/ArmVirtQemu.dsc" platform includes the "OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf" module when the TPM2_ENABLE build flag is defined. This was regressed in commit 89236992913f, which ad

Re: [edk2-devel] [PATCH 2/3] OvmfPkg/Tcg2ConfigPei: factor out InternalTpm12Detect()

On 5/21/20 12:58 AM, Laszlo Ersek wrote: Move the calls to the Tpm12RequestUseTpm() and Tpm12SubmitCommand() Tpm12DeviceLib functions to a separate C file, so that we can override these actions in a subsequent patch. This code movement requires moving the TPM_RSP_GET_TICKS / TestTpm12() helper s

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/Tcg2ConfigPei: clean up some lib class dependencies

On 5/21/20 12:58 AM, Laszlo Ersek wrote: Commit 89236992913f introduced an explicit Tpm12CommandLib dependency to Tcg2ConfigPei. In reality this lib class is not consumed by Tcg2ConfigPei at all (such a dependency is not even inherited from other lib instances). Simplify the module by dropping t

Re: [edk2-devel] [PATCH edk2-platforms 7/8] Platform/NXP: Add LX2160ARDB Platform

Hi Pankaj, This set is looking really good - I only have one comment at this stage: gPlatformGetClockPpi is used in a patch earlier in the series before it's defined here. While there is no .dsc to permit building before this patch, it is still counterintuitive (and complicates review). So can you

Re: [edk2-devel] [PATCH 0/3] OvmfPkg/Tcg2ConfigPei: fix ARM/AARCH64 build failure

On 05/21/20 10:26, Laszlo Ersek wrote: > On 05/21/20 00:58, Laszlo Ersek wrote: >> Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2728 >> Repo: https://pagure.io/lersek/edk2.git >> Branch: restrict_tpm12_to_x86_bz_2728 >> >> Another regression fix for edk2-stable202005. >> >> End of Febru

Re: [edk2-devel] [PATCH 0/3] OvmfPkg/Tcg2ConfigPei: fix ARM/AARCH64 build failure

On 05/21/20 10:37, Ard Biesheuvel wrote: > On 5/21/20 12:58 AM, Laszlo Ersek wrote: >> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2728 >> Repo:   https://pagure.io/lersek/edk2.git >> Branch: restrict_tpm12_to_x86_bz_2728 >> >> Another regression fix for edk2-stable202005. >> >> End of F

Re: [edk2-devel] [PATCH 0/3] OvmfPkg/Tcg2ConfigPei: fix ARM/AARCH64 build failure

On 5/21/20 12:58 AM, Laszlo Ersek wrote: Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2728 Repo: https://pagure.io/lersek/edk2.git Branch: restrict_tpm12_to_x86_bz_2728 Another regression fix for edk2-stable202005. End of February 2020, Ard and Marc-André worked on two TPM-related f

Re: [edk2-devel] [PATCH 0/3] OvmfPkg/Tcg2ConfigPei: fix ARM/AARCH64 build failure

On 05/21/20 00:58, Laszlo Ersek wrote: > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2728 > Repo: https://pagure.io/lersek/edk2.git > Branch: restrict_tpm12_to_x86_bz_2728 > > Another regression fix for edk2-stable202005. > > End of February 2020, Ard and Marc-André worked on two TPM