Re: [edk2-devel] [PATCH v1 0/3] Enable RISC-V architecture for RISC-V EDK2 CI.

2020-04-24 Thread Sean via groups.io
Please run a a test PR with this patchset?  I would like to see how it impacts the build times. Patche series look fine to me. Reviewed-by: Sean Brogan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58126): https://edk2.groups.io/g/dev

[edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the description table after Reset Device

2020-04-24 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2694 When the USB fail and then Reset Device, it should rebuild description. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 5 + 1 file changed, 5 insertions(+) diff --

Re: [edk2-devel] [PATCH v1 0/2] Drop FrameworkHandle param from SaveFrameworkState()

2020-04-24 Thread brbarkel via groups.io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58124): https://edk2.groups.io/g/devel/message/58124 Mute This Topic: https://groups.io/mt/73179709/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

[edk2-devel] [PATCH] ShellPkg: smbiosview - print field values as unsigned integers

2020-04-24 Thread Rebecca Cran
This prevents overflow when printing DWORD fields such as the type 17 tables's extended DIMM size. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Rebecca Cran --- .../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Shel

[edk2-devel] [PATCH] OvmfPkg: replace old EFI_D_ debug levels with new DEBUG_ ones

2020-04-24 Thread Rebecca Cran
Signed-off-by: Rebecca Cran Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel --- OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 8 +- OvmfPkg/AcpiPlatformDxe/PciDecoding.c | 10 +-- OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 32 OvmfPkg/Csm/BiosThunk/VideoDxe/BiosV

[edk2-devel] [PATCH v3 4/7] OvmfPkg: Add Platform CI and configuration for Core CI

2020-04-24 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add new Azure Pipeline definitions to build and run OvmfPkg with: * Ubuntu GCC5 * Windows VS2019 Add PyTool based build of OvmfPkg Add extdep for managing the iasl dependency Add OvmfPkg.ci.yaml for Core CI Add ReadMe.

[edk2-devel] [PATCH v3 5/7] .pytool: Update CI Settings to support Emulator, ArmVirt, and Ovmf packages

2020-04-24 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Update pytools configuration to enable EmulatorPkg, ArmVirtPkg, and OvmfPkg. Update documentation for the status of those packages. Remove future work items that are now complete. Cc: Sean Brogan Cc: Bret Barkelew Cc:

[edk2-devel] [PATCH v3 6/7] .azurepipelines: Update Core CI build matrix to include platforms

2020-04-24 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add ArmVirtPkg to Core CI matrix Add EmulatorPkg to Core CI matrix Add OvmfPkg to Core CI matrix Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Sean Brogan Signed-off-by: Michael

[edk2-devel] [PATCH v3 3/7] EmulatorPkg: Add Platform CI and configuration for Core CI

2020-04-24 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add new Azure Pipeline definitions to build and run EmulatorPkg with: * Ubuntu GCC5 * Windows VS2019 Add PyTool based build of EmulatorPkg Add EmulatorPkg.ci.yaml for Core CI Add ReadMe.md for details and instructions

[edk2-devel] [PATCH v3 0/7] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-24 Thread Michael Kubacki
From: Michael Kubacki Attention: Reviewed-by is still needed from some package maintainers. * 0002-ArmVirtPkg-Add-Platform-CI-and-configuration-for-Cor.patch * Laszlo Ersek * Ard Biesheuvel * Leif Lindholm * 0003-EmulatorPkg-Add-Platform-CI-and-configuration-for-Co.patch * Jordan Juste

[edk2-devel] [PATCH v3 2/7] ArmVirtPkg: Add Platform CI and configuration for Core CI

2020-04-24 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add new Azure Pipeline definitions to build and run ArmVirtPkg with: * Ubuntu GCC5 Add PyTool based build of ArmVirtPkg Add extdep for managing the iasl dependency Add ArmVirtPkg.ci.yaml for Core CI Add ReadMe.md for det

[edk2-devel] [PATCH v3 1/7] .azurepipelines: Add Platform CI template

2020-04-24 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add template for Platform CI steps for a Pytools based build. Add README to describe the template and how to use it. Add helpful information for working with azurepipelines, templates, and lessons learned. Cc: Sean Brogan

[edk2-devel] [PATCH v3 7/7] ReadMe: Convert to rst and add Platform CI Status

2020-04-24 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Convert workspace root Readme.md to reStructuredText ReStructuredText supports building tables with syntax that is easier to read in plain-text. Rename as ReadMe.rst. Add Platform CI Status Tables Cc: Andrew Fish Cc: Las

Re: [EXTERNAL] [edk2-devel] [PATCH v2 3/6] EmulatorPkg: Add Platform CI and configuration for Core CI

2020-04-24 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Michael Kubacki via groups.io Sent: Monday, April 20, 2020 12:12:13 PM To: devel@edk2.groups.io Cc: Jordan Justen ; Andrew Fish ; Ray Ni Subject: [EXTERNAL] [edk2-devel] [PATCH v2 3/6

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

2020-04-24 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Laszlo Ersek via groups.io Sent: Monday, April 20, 2020 4:08:53 AM To: Rebecca Cran ; devel@edk2.groups.io ; Sean Brogan Cc: Ard Biesheuvel ; Kinney, Michael D Subject: [EXTERNAL] Re

Re: [edk2-devel] [EXTERNAL] [PATCH v2 5/6] .pytool: Update CI Settings to support Emulator, ArmVirt, and Ovmf packages

2020-04-24 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: michael.kuba...@outlook.com Sent: Monday, April 20, 2020 12:12:15 PM To: devel@edk2.groups.io Cc: Sean Brogan ; Bret Barkelew ; Kinney, Michael D ; Liming Gao Subject: [EXTERNAL] [PATCH v2 5/6] .pytool: Update CI Setti

Re: [edk2-devel] [EXTERNAL] [PATCH v2 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-24 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: michael.kuba...@outlook.com Sent: Monday, April 20, 2020 12:12:10 PM To: devel@edk2.groups.io Cc: Andrew Fish ; Ard Biesheuvel ; Bret Barkelew ; Jordan Justen ; Laszlo Ersek ; Leif Lindholm ; Liming Gao ; Kinney, Micha

Re: [edk2-devel] [PATCH v2 3/6] EmulatorPkg: Add Platform CI and configuration for Core CI

2020-04-24 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Ni, Ray via groups.io Sent: Tuesday, April 21, 2020 7:43:29 AM To: devel@edk2.groups.io ; michael.kuba...@outlook.com Cc: Justen, Jordan L ; Andrew Fish Subject: [EXTERNAL] Re: [edk2-

Re: [EXTERNAL] [edk2-devel] [PATCH v2 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

2020-04-24 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Michael Kubacki via groups.io Sent: Monday, April 20, 2020 12:12:12 PM To: devel@edk2.groups.io Cc: Laszlo Ersek ; Ard Biesheuvel ; Leif Lindholm Subject: [EXTERNAL] [edk2-devel] [PAT

Re: [EXTERNAL] [edk2-devel] [PATCH v2 1/6] .azurepipelines: Add Platform CI template

2020-04-24 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Michael Kubacki via groups.io Sent: Monday, April 20, 2020 12:12:11 PM To: devel@edk2.groups.io Cc: Sean Brogan ; Bret Barkelew ; Kinney, Michael D ; Liming Gao Subject: [EXTERNAL] [

Re: [edk2-devel] [PATCH v2 3/6] EmulatorPkg: Add Platform CI and configuration for Core CI

2020-04-24 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Liming Gao via groups.io Sent: Tuesday, April 21, 2020 7:36:29 AM To: devel@edk2.groups.io ; michael.kuba...@outlook.com ; Ni, Ray Cc: Justen, Jordan L ; Andrew Fish Subject: [EXTERNA

Re: [edk2-devel] [EXTERNAL] [PATCH v2 6/6] .azurepipelines: Update Core CI build matrix to include platforms

2020-04-24 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: michael.kuba...@outlook.com Sent: Monday, April 20, 2020 12:12:16 PM To: devel@edk2.groups.io Cc: Sean Brogan ; Bret Barkelew ; Kinney, Michael D ; Liming Gao Subject: [EXTERNAL] [PATCH v2 6/6] .azurepipelines: Update

Re: [edk2-devel] [EXTERNAL] Re: [PATCH v2 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-24 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Laszlo Ersek via groups.io Sent: Friday, April 24, 2020 7:33:11 AM To: Sean Brogan ; michael.kuba...@outlook.com ; devel@edk2.groups.io Cc: Andrew Fish ; Ard Biesheuvel ; Bret Barkele

[edk2-devel] [PATCH v4 3/6] OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h

2020-04-24 Thread Rebecca Cran
bhyve uses the older VESA BIOS Extensions 2.0, so add the mode info structure to IndustryStandard/LegacyVgaBios.h Signed-off-by: Rebecca Cran Acked-by: Laszlo Ersek --- .../Include/IndustryStandard/LegacyVgaBios.h | 38 +++ 1 file changed, 38 insertions(+) diff --git a/OvmfPkg

[edk2-devel] [PATCH v4 5/6] BhyvePkg: Add PlatformPei

2020-04-24 Thread Rebecca Cran
Make a copy of OvmfPkg/PlatformPei under BhyvePkg with the changes that are needed to support the bhyve hypervisor. Signed-off-by: Rebecca Cran --- BhyvePkg/License.txt | 4 + BhyvePkg/PlatformPei/AmdSev.c | 106 + BhyvePkg/PlatformPei/ClearCache.c | 111 +

[edk2-devel] [PATCH v4 0/6] Add BhyvePkg, to support the bhyve hypervisor

2020-04-24 Thread Rebecca Cran
- Updated License.txt - Added copyright headers for myself - Changed license from BSD-2-Clause to BSD-2-Clause-Patent following email from Leif indicating that such relicensing is valid without contacting all original authors - Fixed BhyveFwCtlLib bug: due to Hdr being UINTN instead of UINT32

[edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull

2020-04-24 Thread Rebecca Cran
Add a null implementation library for QemuFwCfgLib, in order to support building PciHostBridgeLib for bhyve. Signed-off-by: Rebecca Cran --- .../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 37 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c | 209 ++ 2 files changed, 246 inse

[edk2-devel] [PATCH v4 6/6] BhyvePkg: Add AcpiPlatformDxe

2020-04-24 Thread Rebecca Cran
Make a copy of OvmfPkg/AcpiPlatformDxe under BhyvePkg, with the changes needed to support the bhyve hypervisor. Signed-off-by: Rebecca Cran --- BhyvePkg/AcpiPlatformDxe/AcpiPlatform.c | 251 +++ BhyvePkg/AcpiPlatformDxe/AcpiPlatform.h | 77 ++ BhyvePkg/AcpiPlatform

[edk2-devel] [PATCH v4 1/6] OvmfPkg: Add bhyve support into AcpiTimerLib

2020-04-24 Thread Rebecca Cran
On bhyve, the ACPI timer is located at a fixed IO address; it need not be programmed into, nor fetched from, the PMBA -- power management base address -- register of the PCI host bridge. Signed-off-by: Rebecca Cran Reviewed-by: Laszlo Ersek --- OvmfPkg/Include/IndustryStandard/Bhyve.h | 16

Re: [edk2-devel] [PATCH v2 5/5] OvmfPkg/OvmfXen: Introduce DEBUG_ON_HYPERVISOR_CONSOLE build flag

2020-04-24 Thread Laszlo Ersek
On 04/23/20 11:53, Anthony PERARD wrote: > Introduce DEBUG_ON_HYPERVISOR_CONSOLE build flag to enable logging > debug output to the Xen console. > > This will work with both Xen HVM guest and Xen PVH guest whereas the > default PlatformDebugLibIoPort works only in HVM when QEMU is present. > > Si

Re: [edk2-devel] [PATCH v5 03/12] OvmfPkg/MptScsiDxe: Report name of driver

2020-04-24 Thread Carsey, Jaben
I don't remember reviewing this previously (not recently at least), maybe the RB should be CC? One comment inline below. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nikita > Leshenko > Sent: Friday, April 24, 2020 10:59 AM > To: devel@edk2.groups.io > Cc: Nikita Leshe

Re: [edk2-devel] [PATCH v2 4/5] OvmfPkg/PlatformDebugLibIoPort: Introduce a Nocheck variant

2020-04-24 Thread Laszlo Ersek
On 04/23/20 11:53, Anthony PERARD wrote: > Introduce PlatformRomDebugLibIoPortNocheck which doesn't try to detect > the debug IO port. Instead, debug logs are always written to the IO port. > > Signed-off-by: Anthony PERARD > --- > ...f => PlatformRomDebugLibIoPortNocheck.inf} | 15 ++- >

Re: [edk2-devel] [PATCH] MdeModulePkg/DeviceManagerUiLib: connect all before creating menu page

2020-04-24 Thread Ard Biesheuvel
On 4/19/20 10:06 AM, Bi, Dandan wrote: Ok, thanks Ard! Reviewed-by: Dandan Bi for this patch. Hao, Jian, I intend to merge this patch next week, unless you have any objections. Thanks, Ard. -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of

[edk2-devel] [PATCH v5 05/12] OvmfPkg/MptScsiDxe: Install stubbed EXT_SCSI_PASS_THRU

2020-04-24 Thread Nikita Leshenko
Support dynamic insertion and removal of the protocol Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Laszlo Ersek --- OvmfPkg/MptScsiDxe/MptScsi.c | 181 +- OvmfPkg/MptScsiDxe/MptScsiDxe.inf | 5 +- 2 files

[edk2-devel] [PATCH v5 02/12] OvmfPkg/MptScsiDxe: Install DriverBinding Protocol

2020-04-24 Thread Nikita Leshenko
In order to probe and connect to the MptScsi device we need this protocol. Currently it does nothing. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Laszlo Ersek Reviewed-by: Liran Alon --- OvmfPkg/MptScsiDxe/MptScsi.c | 67 +++

[edk2-devel] [PATCH v5 12/12] OvmfPkg/MptScsiDxe: Reset device on ExitBootServices()

2020-04-24 Thread Nikita Leshenko
This causes the device to forget about the reply frame. We allocated the reply frame in EfiBootServicesData type memory, and code executing after ExitBootServices() is permitted to overwrite it. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: L

[edk2-devel] [PATCH v5 00/12] OvmfPkg: Support booting from Fusion-MPT SCSI controllers

2020-04-24 Thread Nikita Leshenko
This series adds driver support for: - LSI53C1030 - SAS1068 - SAS1068E These controllers are widely supported by QEMU, VirtualBox and VMWare. This work is part of the more general agenda of enhancing OVMF boot device support to have feature parity with SeaBIOS. I pushed a copy of these patches to

[edk2-devel] [PATCH v5 06/12] OvmfPkg/MptScsiDxe: Report targets and one LUN

2020-04-24 Thread Nikita Leshenko
The controller supports up to 8 targets in practice (Not reported by the controller, but based on the implementation of the virtual device), report them in GetNextTarget and GetNextTargetLun. The firmware will then try to communicate with them and create a block device for each one that responds.

[edk2-devel] [PATCH v5 11/12] OvmfPkg/MptScsiDxe: Implement the PassThru method

2020-04-24 Thread Nikita Leshenko
Machines should be able to boot after this commit. Tested with different Linux distributions (Ubuntu, CentOS) and different Windows versions (Windows 7, Windows 10, Server 2016). Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko --- .../Include/IndustryStand

[edk2-devel] [PATCH v5 01/12] OvmfPkg/MptScsiDxe: Create empty driver

2020-04-24 Thread Nikita Leshenko
In preparation for implementing LSI Fusion MPT SCSI devices, create a basic scaffolding for a driver. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Liran Alon Reviewed-by: Laszlo Ersek --- Maintainers.txt | 3 ++- OvmfPk

[edk2-devel] [PATCH v5 10/12] OvmfPkg/MptScsiDxe: Initialize hardware

2020-04-24 Thread Nikita Leshenko
Reset and send the IO controller initialization request. The reply is read back to complete the doorbell function but it isn't useful to us because it doesn't contain relevant data or status codes. See "LSI53C1030 PCI-X to Dual Channel Ultra320 SCSI Multifunction Controller" technical manual for m

[edk2-devel] [PATCH v5 09/12] OvmfPkg/MptScsiDxe: Set and restore PCI attributes

2020-04-24 Thread Nikita Leshenko
Enable the IO Space and Bus Mastering and restore the original values when the device is stopped. This is a standard procedure in PCI drivers. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Liran Alon Reviewed-by: Laszlo Ersek --- OvmfPkg/M

[edk2-devel] [PATCH v5 04/12] OvmfPkg/MptScsiDxe: Probe PCI devices and look for MptScsi

2020-04-24 Thread Nikita Leshenko
The MptScsiControllerSupported function is called on handles passed in by the ConnectController() boot service and if the handle is the lsi53c1030 controller the function would return success. A successful return value will attach our driver to the device. Ref: https://bugzilla.tianocore.org/show_

[edk2-devel] [PATCH v5 03/12] OvmfPkg/MptScsiDxe: Report name of driver

2020-04-24 Thread Nikita Leshenko
Install Component Name protocols to have a nice display name for the driver in places such as UEFI shell. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Laszlo Ersek Reviewed-by: Jaben Carsey Reviewed-by: Liran Alon --- OvmfPkg/MptScsiDxe/

[edk2-devel] [PATCH v5 08/12] OvmfPkg/MptScsiDxe: Open PciIo protocol for later use

2020-04-24 Thread Nikita Leshenko
This will give us an exclusive access to the PciIo of this device after it was started and until is will be stopped. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Liran Alon Reviewed-by: Laszlo Ersek --- OvmfPkg/MptScsiDxe/MptScsi.c | 30 +

[edk2-devel] [PATCH v5 07/12] OvmfPkg/MptScsiDxe: Build and decode DevicePath

2020-04-24 Thread Nikita Leshenko
Used to identify the individual disks in the hardware tree. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Liran Alon Reviewed-by: Laszlo Ersek --- OvmfPkg/MptScsiDxe/MptScsi.c | 61 ++-- 1 file changed, 59 i

Re: [edk2-devel] [PATCH v2 3/5] OvmfPkg/PlatformDebugLibIoPort: factor out debug port detection

2020-04-24 Thread Laszlo Ersek
On 04/23/20 11:53, Anthony PERARD wrote: > Factor out debug port detection in PlatformDebugLibIoPort. > > Signed-off-by: Anthony PERARD > --- > .../PlatformDebugLibIoPort.inf| 1 + > .../PlatformRomDebugLibIoPort.inf | 1 + > .../PlatformDebugLibIoPort/DebugLibDetec

Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg/PlatformDebugLibIoPort: Reword QEMU to hypervisor

2020-04-24 Thread Laszlo Ersek
On 04/23/20 11:53, Anthony PERARD wrote: > We are going to reuse PlatformDebugLibIoPort to use debug IO port from > hypervisors that aren't QEMU, so reword "QEMU" to "hypervisor" in the > descriptions. > > Signed-off-by: Anthony PERARD > --- > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetec

Re: [edk2-devel] [PATCH 1/2] OvmfPkg: Add DxeResetSystemLibBhyve

2020-04-24 Thread Laszlo Ersek
On 04/23/20 05:02, Rebecca Cran wrote: > Introduce the DxeResetSystemLibBhyve library to support powering off > bhyve guests. (1) Please replace all "DxeResetSystemLibBhyve" references in the patch (code, commit message, subject line, file names) with "BaseResetSystemLibBhyve". The reason is that

Re: [edk2-devel] [PATCH v4 11/13] OvmfPkg/MptScsiDxe: Implement the PassThru method

2020-04-24 Thread Nikita Leshenko
> On 20 Apr 2020, at 20:30, Laszlo Ersek wrote: > > On 04/14/20 19:38, Nikita Leshenko wrote: >> Machines should be able to boot after this commit. Tested with different >> Linux distributions (Ubuntu, CentOS) and different Windows >> versions (Windows 7, Windows 10, Server 2016). >> >> Ref:

Re: [edk2-devel] [PATCH 2/2] BhyvePkg: Update BhyvePkgX64.dsc to use DxeResetSystemLibBhyve

2020-04-24 Thread Laszlo Ersek
On 04/23/20 05:02, Rebecca Cran wrote: > bhyve uses a different method for powering off guests than OVMF, so > use the new DxeResetSystemLibBhyve library to support that. > > Signed-off-by: Rebecca Cran > Cc: Peter Grehan > --- > BhyvePkg/BhyvePkgX64.dsc | 2 +- > 1 file changed, 1 insertion(+)

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/MpInitLib: Avoid ApInitReconfig in PEI.

2020-04-24 Thread Laszlo Ersek
On 04/22/20 11:01, Dong, Eric wrote: > From: "Dong, Eric" > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683 > > In PEI phase, AP already been waked up through ApInitConfig, > so it can directly wake up it through change wakup buffer > instead of use ApInitReconfig flag. It can save so

Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs.

2020-04-24 Thread Laszlo Ersek
On 04/22/20 13:47, Ni, Ray wrote: > Eric, > It's natural to use the volatile registers value derived from BSP in > ApInitReconfig path. > So I still prefer to use the code I suggested in the review comment to the v1 > patch. > > We can remove the below line that specially for ApInitReconfig path

Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs.

2020-04-24 Thread Laszlo Ersek
On 04/22/20 11:01, Dong, Eric wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683 > > This patch fixes an assertion because AP can't find the CpuMpData. > When AP is waken up through Init-Sipi-Sipi, AP's IDT should > be restored to pre-allocated buffer so AP can get the CpuMpData > t

Re: [edk2-devel] [PATCH v1 1/1] INF Spec: Add file dependency to [Sources] syntax

2020-04-24 Thread PierreGondois
Hello Bob, Thank you for your answer, and I understand you need time to discuss before approving a solution. I have two suggestions: 1. About the third option you described, it seems one of the issues is that the dependency depicted in the INF file is not accurate. To solve this, we could modif

Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Add LicenseCheck

2020-04-24 Thread Leif Lindholm
On Fri, Apr 24, 2020 at 18:13:58 +0200, Laszlo Ersek wrote: > On 04/22/20 18:01, Liming Gao wrote: > > Mike: > > The checker purpose is to make sure the correct license be used for new > > added file. If the file has the different license, it should be reviewed > > carefully. > > > > I re

Re: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Add LicenseCheck

2020-04-24 Thread Laszlo Ersek
On 04/22/20 18:01, Liming Gao wrote: > Mike: > The checker purpose is to make sure the correct license be used for new > added file. If the file has the different license, it should be reviewed > carefully. > > I remember we still have one open for third party non bsd+patent code (the >

Re: [edk2-devel] [PATCH v3 4/6] Add BhyvePkg, to support the bhyve hypervisor

2020-04-24 Thread Rebecca Cran
> On Apr 24, 2020, at 4:11 AM, Laszlo Ersek wrote: > > So, if you are *completely* sure you didn't change anything on those > copies, relative to their fork-off point originals, then I guess it's OK > to not add your (C). Okay. There are some that are really simple, since I did re-sync them:

Re: [edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

2020-04-24 Thread Leif Lindholm
On Fri, Apr 24, 2020 at 02:42:13 +, Pankaj Bansal (OSS) wrote: > > > > Why would multiple modules need to initialize the serial port? > > > > > > That's how the DebugLib has been designed. > > > DebugLib is used by all modules to print info on console. > > > BaseDebugLibSerialPortConstructor ca

Re: [edk2-devel] [EXTERNAL] Re: [PATCH v2 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-24 Thread Laszlo Ersek
On 04/23/20 02:45, Sean Brogan wrote: > I was hoping that because it wasn't "HTML tag soup" that build status could > be front and center in the package readme as I find that more in line with > expectations on github based projects. Nesting it deeper in the package > just means less people fi

[edk2-devel] [edk2-platforms][PATCH v1 0/4] Platform: Add initial support for N1SDP board

2020-04-24 Thread Pranav Madhu
Arm's N1SDP is a Arm v8.2-A Neoverse N1 CPU based reference design platform primariliy intended for development on Arm64 based platform. This patch series adds initial platform support for this board. The first two patches in this series adds the platform libary implementation and the required edk

[edk2-devel] [edk2-platforms][PATCH v1 2/4] Platform/ARM/N1SDP: Add EDK2 build system files

2020-04-24 Thread Pranav Madhu
From: Deepak Pandey Add EDK Build system files for Neoverse N1 System Development Platform. Signed-off-by: Pranav Madhu --- Platform/ARM/N1SdpPkg/N1SdpPlatform.dec | 31 +++ Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc | 222 Platform/ARM/N1SdpPkg/N1SdpPlatform.fdf | 272 +

[edk2-devel] [edk2-platforms][PATCH v1 4/4] Platform/ARM/N1SDP: Enable devices connected over PCIe

2020-04-24 Thread Pranav Madhu
From: Deepak Pandey N1SDP platform includes a PCIe root complex to which a AHCI, GbE and USB controllers are attached as an endpoint. So implement the PciHostBridgeLib glue layer and enable support for PCIe controller and all the devices connected over the PCIe bus. Signed-off-by: Pranav Madhu

[edk2-devel] [edk2-platforms][PATCH v1 3/4] Platform/ARM/N1SDP: Implement n1sdp specific PciExpressLib

2020-04-24 Thread Pranav Madhu
From: Deepak Pandey A slave error is generated when host accesses the config space of non-available device or unimplemented function on a given bus. So implement a n1sdp specific PciExpressLib library with a workaround to return 0x for all such access. Signed-off-by: Pranav Madhu --- P

[edk2-devel] [edk2-platforms][PATCH v1 1/4] Platform/ARM/N1SDP: Add platform library implementation

2020-04-24 Thread Pranav Madhu
From: Deepak Pandey N1SDP (Neoverse N1 System Development Platform) platform library support. This includes the virtual memory map and helper functions for platform intialization. Signed-off-by: Pranav Madhu --- Platform/ARM/N1SdpPkg/Library/PlatformLib/PlatformLib.inf | 52 Platfor

Re: [edk2-devel] [PATCH 1/1] BaseTools: convert diff.order to LF-only

2020-04-24 Thread Laszlo Ersek
On 04/22/20 17:46, Leif Lindholm wrote: > SetupGit.py sets the git config option diff.orderFile to > {edk2 directory}/BaseTools/Conf/diff.order, to override the default order > in which files are shown in a diff/patch/whatever. This is in imitation > of what is done manually in Laszlo's Unkempt Gui

Re: [edk2-devel] [PATCH V2 0/7] CryptoPkg: Retire the deprecated functions

2020-04-24 Thread Laszlo Ersek
Hi Zhichao, On 04/23/20 10:46, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 > > Retire below deprecated functions: > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1 > > Update the Crypto Driver's version to indicate the binary change. > > Cc: Jian J Wang > C

Re: [edk2-devel] [PATCH v2 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-24 Thread Ard Biesheuvel
On 4/24/20 2:12 PM, Laszlo Ersek wrote: On 04/24/20 07:55, Sean Brogan wrote: Thanks for providing feedback. My V10 branch is up which will be sent to the mailing list tomorrow as the V3 patch set unless there are any changes requested. This now includes a 7th patch which converts the edk2 Rea

Re: [edk2-devel] [PATCH v3 4/6] Add BhyvePkg, to support the bhyve hypervisor

2020-04-24 Thread Laszlo Ersek
On 04/24/20 07:54, Rebecca Cran wrote: > >> On Apr 23, 2020, at 3:42 AM, Laszlo Ersek wrote: >> >> BUt, I *think* the language seen in "OvmfPkg/License.txt" should >> accommodate that too. It goes: >> >> Some files are subject to the following license, the [...] license. >> Those files are loca

Re: [edk2-devel] [PATCH v2 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-24 Thread Laszlo Ersek
On 04/24/20 14:12, Laszlo Ersek wrote: > On 04/24/20 07:55, Sean Brogan wrote: >> Thanks for providing feedback. >> My V10 branch is up which will be sent to the mailing list tomorrow as the >> V3 patch set unless there are any changes requested. >> >> This now includes a 7th patch which convert

Re: [edk2-devel] [PATCH v2 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-24 Thread Laszlo Ersek
On 04/24/20 07:55, Sean Brogan wrote: > Thanks for providing feedback. > My V10 branch is up which will be sent to the mailing list tomorrow as the V3 > patch set unless there are any changes requested. > > This now includes a 7th patch which converts the edk2 ReadMe.md to ReadMe.rst > and sho

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/NXP: rework IoAccessLib to use single function pointer struct

2020-04-24 Thread Leif Lindholm
On Thu, Apr 23, 2020 at 14:16:28 +, Pankaj Bansal wrote: > > > > -Original Message- > > From: Leif Lindholm > > Sent: Thursday, April 23, 2020 3:39 PM > > To: devel@edk2.groups.io > > Cc: Meenakshi Aggarwal ; Pankaj Bansal > > > > Subject: [PATCH edk2-platforms 1/1] Silicon/NXP: rew

Re: [edk2-devel] [PATCH edk2-platforms v3 01/24] Silicon/NXP: Add I2c lib

2020-04-24 Thread Leif Lindholm
On Fri, Apr 24, 2020 at 06:53:15 +, Pankaj Bansal (OSS) wrote: > > > +/** > > > + Early init I2C for reading the sysclk from I2c slave device. > > > + I2c bus clock is determined from the clock input to I2c controller. > > > + The clock input to I2c controller is derived from the sysclk. > >

Re: [edk2-devel] [PATCH edk2-platforms v3 21/24] Platform/NXP: Use FV rules from ArmVirtPkg

2020-04-24 Thread Leif Lindholm
On Fri, Apr 24, 2020 at 06:24:55 +, Pankaj Bansal (OSS) wrote: > > ArmVirtPkg > > > > On Wed, Apr 15, 2020 at 17:43:39 +0530, Pankaj Bansal wrote: > > > From: Pankaj Bansal > > > > > > FVRules.fdf.inc is being replaced by the ArmVirtPkg/ArmVirtRules.fdf.inc > > > at commit hash 746c5b6238f1ee

Re: [edk2-devel] [PATCH v3 0/6] Add BhyvePkg, to support the bhyve hypervisor

2020-04-24 Thread Laszlo Ersek
On 04/22/20 18:48, Rebecca Cran wrote: > On 4/22/20 9:21 AM, Laszlo Ersek wrote: > >> OK, that makes sense -- but, without the ResetSystemLib instance, are >> you able to boot the BhyvePkg platform firmware in a bhyve guest? Does >> (for example) the "reset -c" UEFI Shell command work? > > "reset

Re: [edk2-devel] [PATCH v3 4/6] Add BhyvePkg, to support the bhyve hypervisor

2020-04-24 Thread Laszlo Ersek
On 04/23/20 22:08, Rebecca Cran wrote: > >> On Apr 23, 2020, at 3:19 AM, Laszlo Ersek wrote: >> >> (2) If you are contributing this new file in "Pluribus Networks, Inc" >> colors, then please extend the year to 2020 on that line. Otherwise, if >> you are contributing this on your own behalf (as w

Re: [edk2-devel] FW: Discussion: Basetools a separate repo

2020-04-24 Thread Laszlo Ersek
On 04/22/20 21:30, macarl via [] wrote: > I think you've got it. The version of basetools will be carried via a > pip-requirements file. > > Where would "pip install -r pip-requirements.txt" *fetch* the required > basetools version from? > I believe that it has a cache internal to pip. But if yo

Re: [edk2-devel] [PATCH v4 3/3] BaseTools: BaseTools changes for RISC-V platform.

2020-04-24 Thread Bob Feng
Hi Abner, I found the BaseTools build failure with GCC5 and this patch break Intel internal CI. Would you please have a check? make[1]: Entering directory '/opt/TCAgent/work/184220821286c462/Edk2/BaseTools/Source/C/Common' gcc -c -I .. -I ../Include/Common -I ../Include/ -I ../Include/Indust

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Add support for input with separately reported modifiers

2020-04-24 Thread Laszlo Ersek
On 04/22/20 18:55, vit9696 wrote: > In fact, there are really many mistakes in UEFI spec even besides > this one, but we do not know where to report them. E.g. last thing we > saw was ByRegisterNotify description in LocateHandleBuffer, which was > mistakingly copy-pasted from LocateHandle. Please

[edk2-devel] [PATCH] NetworkPkg/IScsiDxe: Enhance the check for array boundary

2020-04-24 Thread Zhang, Shenglei
Array 'TargetUrl' of size 255 may use index value(s) 255 and 256. So enhance the boundary check to ensure the index is valid. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Shenglei Zhang --- NetworkPkg/IScsiDxe/IScsiDhcp.c | 2 +- NetworkPkg/IScsiDxe/IScsiDhcp6.c | 2 +- 2 fil

Re: [edk2-devel] [PATCH 1/7] OvmfPkg: introduce QemuFwCfgSimpleParserLib

2020-04-24 Thread Philippe Mathieu-Daudé
On 4/24/20 9:53 AM, Laszlo Ersek wrote: We already parse some boolean and integer values from named fw_cfg files (usually into PCDs), and we're going to cover more. Add a dedicated library for centralizing the parsing logic. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Per Sundstrom Cc: Philippe

Re: [edk2-devel] [PATCH 0/7] OvmfPkg, ArmVirtPkg: control PXE v4/v6 boot support from the QEMU cmdline

2020-04-24 Thread Ard Biesheuvel
On 4/24/20 9:53 AM, Laszlo Ersek wrote: Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2681 Repo: https://pagure.io/lersek/edk2.git Branch: pxe_fw_cfg With this series applied, the QEMU command line options listed below control whether the guest firmware supports PXEv4 / PXEv6 boot. An

Re: [edk2-devel] [PATCH 3/7] OvmfPkg/PlatformPei: use QemuFwCfgParseBool in UPDATE_BOOLEAN_PCD_FROM_...

2020-04-24 Thread Philippe Mathieu-Daudé
On 4/24/20 9:53 AM, Laszlo Ersek wrote: The UPDATE_BOOLEAN_PCD_FROM_FW_CFG() macro currently calls the module-private helper function GetNamedFwCfgBoolean(). Replace the latter with QemuFwCfgParseBool() from QemuFwCfgSimpleParserLib. This change is compatible with valid strings accepted previous

Re: [edk2-devel] [PATCH 2/7] OvmfPkg/PlatformPei: parse "X-PciMmio64Mb" with QemuFwCfgSimpleParserLib

2020-04-24 Thread Philippe Mathieu-Daudé
On 4/24/20 9:53 AM, Laszlo Ersek wrote: Replace the - QemuFwCfgFindFile(), - QemuFwCfgSelectItem(), - QemuFwCfgReadBytes(), - AsciiStrDecimalToUint64() sequence in the GetFirstNonAddress() function with a call to QemuFwCfgSimpleParserLib. This change is compatible with valid strings accepted p

[edk2-devel] [PATCH v3 2/2] UefiCpuPkg/MpInitLib: Avoid ApInitReconfig in PEI.

2020-04-24 Thread Dong, Eric
From: "Dong, Eric" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683 In PEI phase, AP already been waked up through ApInitConfig, so it can directly wake up it through change wakup buffer instead of use ApInitReconfig flag. It can save some time. Change code to only use ApInitReconfig fl

[edk2-devel] [PATCH v3 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP procedure

2020-04-24 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683 This patch serial used to fix an ASSERT issue. Because AP can't find the CpuMpData through IDT, it raised the ASSERT. V3: 1. Remove invalid save Volatile Registers process. Refine restore Volatile Registers process. V2: 1. Enhance cod

[edk2-devel] [PATCH v3 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs.

2020-04-24 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683 This patch fixes an assertion because AP can't find the CpuMpData. When AP is waken up through Init-Sipi-Sipi, AP's IDT should be restored to pre-allocated buffer so AP can get the CpuMpData through the IDT base address. Current code already

[edk2-devel] [PATCH 2/7] OvmfPkg/PlatformPei: parse "X-PciMmio64Mb" with QemuFwCfgSimpleParserLib

2020-04-24 Thread Laszlo Ersek
Replace the - QemuFwCfgFindFile(), - QemuFwCfgSelectItem(), - QemuFwCfgReadBytes(), - AsciiStrDecimalToUint64() sequence in the GetFirstNonAddress() function with a call to QemuFwCfgSimpleParserLib. This change is compatible with valid strings accepted previously. Cc: Ard Biesheuvel Cc: Jordan

[edk2-devel] [PATCH 4/7] OvmfPkg/QemuFwCfgDxeLib: allow UEFI_DRIVER modules

2020-04-24 Thread Laszlo Ersek
We don't distribute UEFI_DRIVER modules stand-alone that were built as part of an OVMF platform. OVMF's UEFI_DRIVERs are allowed to inherit platform dependencies. By enabling UEFI_DRIVERs to consume QemuFwCfgDxeLib, we can hook fw_cfg-based NULL class libraries into UEFI drivers, e.g. in order to

[edk2-devel] [PATCH 7/7] ArmVirtPkg: control PXEv4 / PXEv6 boot support from the QEMU command line

2020-04-24 Thread Laszlo Ersek
Port the DSC file changes from the similarly titled OvmfPkg patch in this series to ArmVirtPkg. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Per Sundstrom Cc: Philippe Mathieu-Daudé Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2681 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/ArmVirtQemu.ds

[edk2-devel] [PATCH 0/7] OvmfPkg, ArmVirtPkg: control PXE v4/v6 boot support from the QEMU cmdline

2020-04-24 Thread Laszlo Ersek
Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2681 Repo: https://pagure.io/lersek/edk2.git Branch: pxe_fw_cfg With this series applied, the QEMU command line options listed below control whether the guest firmware supports PXEv4 / PXEv6 boot. And correspondingly, whether UefiBootManager

[edk2-devel] [PATCH 5/7] OvmfPkg: control PXEv4 / PXEv6 boot support from the QEMU command line

2020-04-24 Thread Laszlo Ersek
Add a minimal, NULL class library called "PxeBcPcdProducerLib" for setting the "PcdIPv4PXESupport" and "PcdIPv6PXESupport" PCDs of NetworkPkg, from fw_cfg. These PCDs control whether the UefiPxeBcDxe driver supports PXEv4 / PXEv6 boot. If a PXE version is disabled, the corresponding LoadFile proto

[edk2-devel] [PATCH 6/7] ArmVirtPkg/QemuFwCfgLib: allow UEFI_DRIVER modules

2020-04-24 Thread Laszlo Ersek
We don't distribute UEFI_DRIVER modules stand-alone that were built as part of an ArmVirtQemu* platform. ArmVirtQemu* UEFI_DRIVERs are allowed to inherit platform dependencies. By enabling UEFI_DRIVERs to consume QemuFwCfgLib, we can hook fw_cfg-based NULL class libraries into UEFI drivers, e.g. i

[edk2-devel] [PATCH 3/7] OvmfPkg/PlatformPei: use QemuFwCfgParseBool in UPDATE_BOOLEAN_PCD_FROM_...

2020-04-24 Thread Laszlo Ersek
The UPDATE_BOOLEAN_PCD_FROM_FW_CFG() macro currently calls the module-private helper function GetNamedFwCfgBoolean(). Replace the latter with QemuFwCfgParseBool() from QemuFwCfgSimpleParserLib. This change is compatible with valid strings accepted previously. Cc: Ard Biesheuvel Cc: Jordan Justen

[edk2-devel] [PATCH 1/7] OvmfPkg: introduce QemuFwCfgSimpleParserLib

2020-04-24 Thread Laszlo Ersek
We already parse some boolean and integer values from named fw_cfg files (usually into PCDs), and we're going to cover more. Add a dedicated library for centralizing the parsing logic. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Per Sundstrom Cc: Philippe Mathieu-Daudé Ref: https://bugzilla.tiano

Re: [edk2-devel] [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove temporary build workaround

2020-04-24 Thread Heng Luo
Dear all, I combined 2 patches into one following Eric's suggestion, new patch have been sent out, please help to review. Thanks, Heng > -Original Message- > From: Ni, Ray > Sent: Friday, April 24, 2020 1:03 PM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Michael Kubacki ; Gao, Liming >

Re: [edk2-devel] [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver

2020-04-24 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, April 22, 2020 4:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > ; Agyeman, Prince > ; Michael Kubacki > > S

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks

2020-04-24 Thread Wasim Khan
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, April 24, 2020 11:38 AM > To: devel@edk2.groups.io; Wasim Khan ; Ard > Biesheuvel > Cc: Varun Sethi ; Wu, Hao A ; Ni, Ray > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem > and PMem Limit Checks >

[edk2-devel] [PATCH] Remove temporary build workaround in Features/Intel/AdvancedFeaturePkg

2020-04-24 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2688 Remove Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround, Add Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc to support Feature PCDs. Use AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc instead of AdvancedFeatu

Re: [edk2-devel] [edk2-platforms: PATCH V1] MinPlatformPkg/PlatformInitPei: Create Library Instance of ReportCpuHobLib.

2020-04-24 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu mailto:chasel.c...@intel.com>> From: Kumar, Chandana C Sent: Friday, April 24, 2020 1:19 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-platforms: PATCH V1] MinPlatformPkg/Pla

  1   2   >