For files to be added to the tree, this feature will check
whether it has BSD license.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
BaseTools/Scripts/PatchCheck.py | 52 -
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/BaseTools/S
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2632
Both PEI and DXE instances of the MpInitLib are using PcdLib APIs, but
none of them list the dependency of the PcdLib in INF & header files.
This commit will explicitly add such dependency in .H and .INF files.
Test done:
Library level buil
Sure, I will do it next time. Thanks for the advice.
> -Original Message-
> From: Liu, Zhiguang [mailto:zhiguang@intel.com]
> Sent: Tuesday, April 21, 2020 4:52 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Cc: Chen, Gilbert ; Schaefer, Daniel (DualStudy)
Reviewed-by: Nate DeSimone
On 4/21/20, 2:47 PM, "Desimone, Ashley E" wrote:
Updates the implementation for pull_latest_manifest_repo to
call pull_single_manifest repo.
Removes definitions of strings used by pull_latest_manifest_repo
from common/humble.py and from the imports of
Reviewed-by: Nate DeSimone
On 4/21/20, 2:47 PM, "Desimone, Ashley E" wrote:
Add a directory to edkrepo/common to store workspace management
functionatlity.
Add edkrepo/common/workspace_mgmt/humble directory to store
related strings and included manifest_repos_mgmt_humble.py
Hi Vitaly,
I don’t know how to deal with such spec ambiguous issue. So I consult Michael
Rothman who is one of the owner of the UEFI spec.
BTW, you can’t change the firmware, why don’t you provide a specific shell spec
build by yourselves to fix the issue. Is there any limitation?
Michael Rothm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683
This patch used to fix a ASSERT because AP can't find the CpuMpData.
When AP been waked up through Init-Sipi-Sipi, the IDT should
been restore to preallcated buffer to make it can get the
CpuMpData through IDT base address.
Not when CpuMpDa
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683
This patch serial used to fix an ASSERT issue. Because AP can't find
the CpuMpData through IDT, it raised the ASSERT.
Eric Dong (2):
UefiCpuPkg/MpInitLib: Restore IDT context for APs.
UefiCpuPkg/MpInitLib: Avoid ApInitReconfig in PEI.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683
In PEI phase, AP already been waked up through ApInitConfig,
so it can directly wake up it through change wakup buffer
instead of use ApInitReconfig flag. It can save some time.
Change code to only use ApInitReconfig flag in DXE phase
which
Reviewed-by: Ashley DeSimone
-Original Message-
From: Bjorge, Erik C
Sent: Tuesday, April 21, 2020 4:27 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Desimone, Ashley E
; Pandya, Puja ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Imp
Hey Lazlo,
This is a great point of discussion. Just to make sure we're on the same page,
let me paraphrase your scenario. Two features at the same time or a improperly
tested new feature were committed in BaseTools and a new release was spun out.
EDK2 was updated to have it's pip-requirements.
The AlwaysExclude XML tag has existed but only removed entries from the
list of sparse objects. Now items in the AlwaysExclude tag will be
actively removed by prefixing '!' to the entry.
Signed-off-by: Erik Bjorge
Cc: Nate DeSimone
Cc: Ashley DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret
On 4/17/20 2:55 AM, Laszlo Ersek wrote:
In this patch, we should follow the pattern seen in patch#1 -- new,
bhyve-specific library instance.
However, this library has hugely bit-rotted, and it needs some serious
scrubbing before we can do that. Let me look into a patch series for
that. I'll con
Updates the implementation for pull_latest_manifest_repo to
call pull_single_manifest repo.
Removes definitions of strings used by pull_latest_manifest_repo
from common/humble.py and from the imports of
common_repo_functions.py
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Adds initial support for manifest repository management while
retaining support for commands to use the existing edkrepo.cfg
format and manifest repo support functions.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
As
Add a directory to edkrepo/common to store workspace management
functionatlity.
Add edkrepo/common/workspace_mgmt/humble directory to store
related strings and included manifest_repos_mgmt_humble.py
Add edkrepo/common/workspace_mgmt/manifest_repos_mgmt.py
to support the management of multiple manif
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added a DXE driver that registers the minimum platform
BDS hook points, to WhiskeylakeURvp board.
These hooks are triggered on the BDS hook events
What was done:
* Included an instance of BdsHookLib and BoardBootManagerLib
from BoardModule
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Since the original BDS Hook Points patch series was filed
(https://edk2.groups.io/g/devel/message/5) there have been
two new Minimum Platform BoardPkg implementations added:
WhiskeyLakeOpenBoardPkg/UpXtreme and CometlakeOpenBoardPkg.
Th
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added a DXE driver that registers the minimum platform
BDS hook points, to WhiskeylakeURvp board.
These hooks are triggered on the BDS hook events
What was done:
* Included an instance of BdsHookLib and BoardBootManagerLib
from BoardModule
This patch series has gotten very old and the review comments were minor and
cosmetic. Since this is a good new feature, I have made the cosmetic fixes and
pushed the patch series as 765cbda6~..5a60c2de.
Thanks,
Nate
-Original Message-
From: devel@edk2.groups.io On Behalf Of Agyeman, P
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2612
Simplifies the SaveFrameworkState() interface by removing the
FrameworkHandle parameter. The expectation is that this API is called
from within a test suite prior to test case completion such as a reboot.
The active fr
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2612
The framework handle can be retrieved from GetActiveFrameworkHandle()
internal to SaveFrameworkState() so this change removes the parameter
from the function signature.
Cc: Bret Barkelew
Cc: Liming Gao
Cc: Michael D
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2612
Removes the FrameworkHandle parameter from SaveFrameworkState() in the
UnitTestLib library instance and updates callers of the function in the
library to use the new function signature.
Cc: Bret Barkelew
Cc: Sean Bro
On 4/21/20 7:27 PM, Laszlo Ersek wrote:
Phil,
On 04/17/20 17:37, Laszlo Ersek wrote:
In preparation for introducing DxeResetSystemLib, rename the current
(only) ResetSystemLib instance to BaseResetSystemLib.
In the DSC files, keep the ResetSystemLib resolution in the same
[LibraryClasses] sect
On 4/17/20 9:37 AM, Laszlo Ersek wrote:
Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Repo: https://pagure.io/lersek/edk2.git
Branch: rsl_cleanup
Rebecca's
[PATCH 02/13] OvmfPkg: support powering off bhyve guests
at
https://edk2.groups.io/g/devel/message/57450
e4e9b
Reviewed-by: Ashley DeSimone
-Original Message-
From: Desimone, Nathaniel L
Sent: Monday, April 20, 2020 8:44 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [PATCH] EdkRepo: Fix Linux install failures
In
.. Skipped..
> Thanks Vladimir for the explanation.
>
> Wondering what is more useful to users:
>
> 1- Having the 'http' and 'tftp' commands share a common interface to
> make
> it easier to script using either tool/protocol (as explained below)
> Or
> 2- Having a more natural support for URIs
Phil,
On 04/17/20 17:37, Laszlo Ersek wrote:
> In preparation for introducing DxeResetSystemLib, rename the current
> (only) ResetSystemLib instance to BaseResetSystemLib.
>
> In the DSC files, keep the ResetSystemLib resolution in the same
> [LibraryClasses] section, but move it near the TimerLi
On 4/19/20 3:04 AM, Desimone, Nathaniel L wrote:
For the addition of Comet Lake to the Intel platforms list...
Reviewed-by: Nate DeSimone
For the other changes, I'm not involved in those platforms and can't give good
feedback.
Reviewed-by: Ard Biesheuvel
Pushed as 2aace58ce553..ecb29e93f
On 4/20/20 3:57 AM, Laszlo Ersek wrote:
It would be great if Peter could post formal R-b's or A-b's in response
to (some of) the patches on edk2-devel.
Alternatively, you could mention Peter's review somewhere in the commit
messages, in natural language.
Again, not a "hard requirement" from my
On 4/21/20 10:54 AM, Wu, Hao A wrote:
-Original Message-
From: Samer El-Haj-Mahmoud [mailto:sa...@elhajmahmoud.com]
Sent: Friday, April 10, 2020 11:29 PM
To: devel@edk2.groups.io
Cc: Bi, Dandan; Gao, Liming; Wang, Jian J; Wu, Hao A; Leif Lindholm; Ard
Biesheuvel
Subject: [edk2][PATCH v2 1
Thanks Vladimir for the explanation.
Wondering what is more useful to users:
1- Having the 'http' and 'tftp' commands share a common interface to make it
easier to script using either tool/protocol (as explained below)
Or
2- Having a more natural support for URIs in 'http' command, similar
Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Nathaniel L
Sent: Monday, April 20, 2020 8:44 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [PATCH] EdkRepo: Fix Linux install failures
Instal
On 04/20/20 20:23, Sean Brogan wrote:
> Laszlo,
>
> PIP vs Submodules:
> The issue with submodule and not using python packages (pip is really just a
> super convenient helper to install that consistently) is that it requires the
> paradigm of file system python path management. Think of this a
On Debian 10 (Buster), when running PatchCheck.py with python2, a
backtrace is printed, starting from:
File "../edk2/BaseTools/Scripts/PatchCheck.py", line 595, in find_patch_pieces
parts = email.header.decode_header(pmail.get('subject'))
AttributeError: 'module' object has no attribute 'h
On 4/21/20 9:27 AM, Laszlo Ersek wrote:
(1) For example, I can't find the patch that adds
"BhyvePkg/BhyvePkgX64.dsc", in spite of the file being listed in the
cumulative diffstat below.
That's in the "Add BhyvePkg" patch.
(2) I also don't really understand why v2 / v3 have been posted, give
Hi Rebecca,
On 04/21/20 05:09, Rebecca Cran wrote:
> I noticed a few things wrong with the v2 series:
>
> o BhyveFwCtlLibNull is no longer used, and could be deleted.
> o Some changes from the v1 AcpiPlatformDxe patch were left in OvmfPkg.
> o BhyvePkg/License.txt still referred to OvmfPkg. I've
Acked-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael Kubacki
> Sent: Tuesday, April 21, 2020 3:12 AM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L ; Andrew Fish
> ; Ni, Ray
> Subject: [edk2-devel] [PATCH v2 3/6] EmulatorPkg: Add Platform CI and
>
Sean:
I see some comments on Ovmf. If you make the change in Ovmf, please also
update EmulatorPkg. I would like to keep the consistent style in
EmulatorPkg/OvmfPkg.
This change is good to me. Reviewed-by: Liming Gao
Ray:
If you have no comment, can you give Ack-by for this change?
Thank
Guomin:
I find this parameter name doesn't match the one in function description. Can
you make them be same? With this change, Reviewed-by: Liming Gao
@param File A pointer to the device path of the file that is
being dispatched. This will optionally
On 04/20/20 21:12, michael.kuba...@outlook.com wrote:
> ArmVirtPkg/ReadMe.rst | 139 ++
> EmulatorPkg/README.rst| 175 +
> OvmfPkg/README.rst| 211
> +++
On 04/20/20 18:29, Anthony PERARD wrote:
> Introduce XenDebugLibIoPort which is enabled with
> DEBUG_ON_HYPERVISOR_CONSOLE which send the debug output to Xen's
> console.
>
> It's a copy PlatformDebugLibIoPort which always write to the IO port.
> It works with both Xen HVM guest and Xen PVH guest
On 04/20/20 18:29, Anthony PERARD wrote:
> Remove support for DEBUG_ON_SERIAL_PORT because OvmfXen can't be build
> with it due to a circular dependency:
> DebugLib: BaseDebugLibSerialPort ->
> SerialPortLib : XenConsoleSerialPortLib ->
> XenHypercallLib : XenHypercallLib ->
> Deb
On 4/21/20 1:30 PM, Pete Batard wrote:
Note: This commit depends on an "Update TF-A binaries to v2.3" patch
having been applied to edk2-non-osi.
With the update of non-osi TF-A binaries to latest, we can switch to
using the single bl31.bin instead of the now removed bl31_pl011.bin.
Signed-off-b
On 04/20/20 16:13, Gerd Hoffmann wrote:
> Hi,
>
>> So I would say that the symptom you see is a QEMU v4.1.0 regression.
>> The QemuRamfbGraphicsOutputSetMode() function in the OVMF ramfb
>> driver certainly needs the QemuFwCfgWriteBytes() call to work, for
>> changing the resolution.
>
> Oh? Qem
Hi All,
There was some effort to include this as part of the UEFI shell Debug 1
profile. This goes back a while when we introduced Acpiview, see
https://mantis.uefi.org/mantis/view.php?id=1784
However, Acpiview has changed significantly since then. I am happy to
contribute for updating the spec
On 4/21/20 2:29 PM, Pete Batard wrote:
Hi Ard,
On 2020.04.21 13:20, Ard Biesheuvel wrote:
On 4/21/20 1:29 PM, Pete Batard wrote:
With the v2.3 release of TF-A, that integrates automatic PL011 vs
miniUART
switching, we can remove the dual bl31 binaries we were using for RPi4,
and of course, we
Hi Ard,
On 2020.04.21 13:20, Ard Biesheuvel wrote:
On 4/21/20 1:29 PM, Pete Batard wrote:
With the v2.3 release of TF-A, that integrates automatic PL011 vs
miniUART
switching, we can remove the dual bl31 binaries we were using for RPi4,
and of course, we also take this opportunity to update th
On 4/21/20 1:29 PM, Pete Batard wrote:
With the v2.3 release of TF-A, that integrates automatic PL011 vs miniUART
switching, we can remove the dual bl31 binaries we were using for RPi4,
and of course, we also take this opportunity to update the RPi3 binaries
to the latest.
Note that these binari
Note: This commit depends on an "Update TF-A binaries to v2.3" patch
having been applied to edk2-non-osi.
With the update of non-osi TF-A binaries to latest, we can switch to
using the single bl31.bin instead of the now removed bl31_pl011.bin.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi
* device_tree_address/end was incorrect for RPi3.
* Link to TF-A Readme.md in non-osi was broken.
* RPi4 now uses TF-A binaries built from official source.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/Readme.md | 15 ---
Platform/RaspberryPi/RPi4/Readme.md | 13 +-
With the v2.3 release of TF-A, that integrates automatic PL011 vs miniUART
switching, we can remove the dual bl31 binaries we were using for RPi4,
and of course, we also take this opportunity to update the RPi3 binaries
to the latest.
Note that these binaries were built in an open and verifiable m
Sean, Bret,
Cross platform features for Intel platforms are supposed to put under
edk2-platforms/Features/Intel.
These features are optional to a platform.
Then why cannot Redfish components be placed in edk2-platforms/Features/Intel
or edk2-platforms/Features/Common?
Thanks,
Ray
From: devel@e
> -Original Message-
> From: Samer El-Haj-Mahmoud [mailto:sa...@elhajmahmoud.com]
> Sent: Friday, April 10, 2020 11:29 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan; Gao, Liming; Wang, Jian J; Wu, Hao A; Leif Lindholm; Ard
> Biesheuvel
> Subject: [edk2][PATCH v2 1/2] MdeModulePkg:
> PcdAcp
Reviewed-by: Zhiguang Liu
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abner Chang
Sent: Tuesday, April 21, 2020 3:53 PM
To: devel@edk2.groups.io
Cc: abner.ch...@hpe.com; Gilbert Chen ; Leif Lindholm
; Kinney, Michael D ;
Gao, Liming
Subject: [edk2-devel] [PATCH v2 5/9]
For the patch series,
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guomin
> Jiang
> Sent: Thursday, April 16, 2020 3:34 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL
>
>
Reviewed-by: Zhiguang Liu
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abner Chang
Sent: Tuesday, April 21, 2020 3:53 PM
To: devel@edk2.groups.io
Cc: abner.ch...@hpe.com; Gilbert Chen ; Leif Lindholm
; Kinney, Michael D ;
Gao, Liming
Subject: [edk2-devel] [PATCH v2 8/9]
Hi Abner
Thanks very much for the contribution.
According to the process, if you want to update your patch, please re-send all
the patch in the same patch set with the version updated.
If some patch already get reviewed-by, you can update the commit message.
Thanks
Zhiguang
The code change is goo
Laszlo:
I understand Module reviewer R-B is enough for the patch.
R: Package Reviewer: Cc address for patches and questions. Reviewers help
maintainers review code, but don't have push access. A designated Package
Reviewer is reasonably familiar with the Package (or some modules
On 04/21/20 06:56, Bi, Dandan wrote:
> Hi Laszlo,
>
> I think it should be Ok.
> But if can get ACK/R-B from the maintainer of MdeModulePkg, that would be
> better, which follows process more.
Yes, I agree, but Jian and Hao are not responding. Could you poke them
internally at Intel, please?
Th
Support RISC-V cache related functions.
Signed-off-by: Abner Chang
Co-authored-by: Gilbert Chen
Reviewed-by: Leif Lindholm
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Gilbert Chen
---
.../BaseSynchronizationLib.inf| 5 ++
.../RiscV64/Synchronization.S
RISC-V MMIO library instance.
IoLibArm.c in fact implements a generic Mmio-only (and ANSI
C compliant), so rename it to better reflect this.
Signed-off-by: Abner Chang
Co-authored-by: Gilbert Chen
Reviewed-by: Leif Lindholm
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Gilbert C
Sure, the patch sent.
> -Original Message-
> From: Liu, Zhiguang [mailto:zhiguang@intel.com]
> Sent: Tuesday, April 21, 2020 2:36 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Cc: Chen, Gilbert ; Leif Lindholm
> ; Kinney, Michael D
> ; Gao, Liming
> Subject
Tools definitions template file changes for building EDK2 RISC-V platform.
Signed-off-by: Abner Chang
Co-authored-by: Gilbert Chen
Co-authored-by: Daniel Helmut Schaefer
Reviewed-by: Leif Lindholm
Cc: Bob Feng
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Gilbert Chen
---
BaseTools/Conf/tools_def
64 matches
Mail list logo
