Guomin: I find this parameter name doesn't match the one in function description. Can you make them be same? With this change, Reviewed-by: Liming Gao <liming....@intel.com>
@param File A pointer to the device path of the file that is being dispatched. This will optionally be used for logging. Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guomin Jiang > Sent: Thursday, April 16, 2020 3:34 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > <liming....@intel.com> > Subject: [edk2-devel] [PATCH v2 6/6] MdePkg/Security2: Mark the File > parameter as OPTIONAL. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 > > According to the description, the File is OPTIONAL and can be NULL. > > Signed-off-by: Guomin Jiang <guomin.ji...@intel.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <liming....@intel.com> > --- > MdePkg/Include/Protocol/Security2.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Protocol/Security2.h > b/MdePkg/Include/Protocol/Security2.h > index 2d85b4ba9f..6a63009956 100644 > --- a/MdePkg/Include/Protocol/Security2.h > +++ b/MdePkg/Include/Protocol/Security2.h > @@ -80,7 +80,7 @@ typedef struct _EFI_SECURITY2_ARCH_PROTOCOL > EFI_SECURITY2_ARCH_PROTOCOL; > **/ > > typedef EFI_STATUS (EFIAPI *EFI_SECURITY2_FILE_AUTHENTICATION) ( > > IN CONST EFI_SECURITY2_ARCH_PROTOCOL *This, > > - IN CONST EFI_DEVICE_PATH_PROTOCOL *DevicePath, > > + IN CONST EFI_DEVICE_PATH_PROTOCOL *DevicePath, OPTIONAL > > IN VOID *FileBuffer, > > IN UINTN FileSize, > > IN BOOLEAN BootPolicy > > -- > 2.25.1.windows.1 > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#57460): https://edk2.groups.io/g/devel/message/57460 > Mute This Topic: https://groups.io/mt/73050539/1759384 > Group Owner: devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming....@intel.com] > -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57741): https://edk2.groups.io/g/devel/message/57741 Mute This Topic: https://groups.io/mt/73050539/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-