Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

Any thoughts?  I would like to get this in before any more failures get checked in causing more dependencies. I have a branch here: https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages_v7 but am waiting for more feedback to make V2 patchset. Thanks Sean -=-=-=-

Re: [edk2-devel] [PATCH v4 05/13] OvmfPkg/MptScsiDxe: Install stubbed EXT_SCSI_PASS_THRU

On 04/14/20 19:38, Nikita Leshenko wrote: > Support dynamic insertion and removal of the protocol > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 > Signed-off-by: Nikita Leshenko > Reviewed-by: Laszlo Ersek > --- > OvmfPkg/MptScsiDxe/MptScsi.c | 181 +++

Re: [edk2-devel] [PATCH v1 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

what do you mean "test for the adding pipelines"? The pipeline currently builds the platforms and then runs them to the shell where it has a startup.nsh which does reset -h. If the boot fails or hangs the task will timeout in 1 minute and then fail. Thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [PATCH v4 01/13] OvmfPkg/MptScsiDxe: Create empty driver

On 04/14/20 19:38, Nikita Leshenko wrote: > In preparation for implementing LSI Fusion MPT SCSI devices, create a > basic scaffolding for a driver. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 > Signed-off-by: Nikita Leshenko > Reviewed-by: Liran Alon > --- > Maintainers.txt

Re: [edk2-devel] [Patch V2] MinPlatformPkg/PlatformInitPei: Create Library Instance of ReportCpuHobLib.

Hi Chandana, Your commit message format a little weird, please help to correct it. Please also update MinPlatformPkg.dec/[LibraryClasses] section for new library class this patch introduced. Thanks, Chasel > -Original Message- > From: Kumar, Chandana C > Sent: Tuesday, April 14, 202

Re: [edk2-devel] [edk2-platforms][PATCH v4 0/9]Platform/Arm/Sgi: Add platform support for RD-Daniel

On Tue, Apr 14, 2020 at 6:22 PM Aditya Angadi wrote: > > This patch series adds support for Arm's RD-Daniel platform. There are two > configurations of this platform being added in this series - Config-M and > Config-XLR. RD-Daniel is the next Arm's reference design subsystem. > Config XLR is a mu

Re: [edk2-devel] [EXTERNAL] Re: [PATCH v1 0/9] Add the VariablePolicy feature

Cool. Thank you Bret! From: Bret Barkelew Sent: Tuesday, April 14, 2020 1:25 PM To: Michael Kubacki ; Yao, Jiewen ; devel@edk2.groups.io Cc: Zhang, Chao B ; Wang, Jian J ; Wu, Hao A ; Gao, Liming Subject: RE: [EXTERNAL] Re: [PATCH v1 0/9] Add the VariablePolicy feature Jiewen, Thanks (as al

Re: [edk2-devel] [PATCH] Platform/Intel/Tools: Add scripts to set PACKAGES_PATH environment

Pushed the change, detail below: SHA-1: beecaf5d933bfd49ec0654fe08a473002d27d49c * Platform/Intel/Tools: Add scripts to set PACKAGES_PATH environment Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2656 1. Add GetPackagesPath.py, it will be used to get package pathes from special director

Re: [edk2-devel] [PATCH] Platform/Intel/Tools: Add scripts to set PACKAGES_PATH environment

Attach the patch. Thank Bob and Eric. Best Regards Heng > -Original Message- > From: Dong, Eric > Sent: Wednesday, April 15, 2020 9:07 AM > To: Feng, Bob C ; Luo, Heng ; > devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Liming ; Chan, > Amy > Subject: RE: [PATCH] Platform/Intel/Tools: Add scr

Re: [edk2-devel] [PATCH] Platform/Intel/Tools: Add scripts to set PACKAGES_PATH environment

Reviewed-by: Ray Ni > -Original Message- > From: Luo, Heng > Sent: Friday, April 10, 2020 9:06 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Dong, Eric ; Gao, Liming > ; Feng, Bob C > ; Chan, Amy > Subject: [PATCH] Platform/Intel/Tools: Add scripts to set PACKAGES_PATH > environment >

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Wed, 04/15/2020 9:30am-10:30am #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Wednesday, 15 April 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://zoom.com.cn/j/493235016 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=758252 ) *Organizer:* Brian Richardson brian.richard...@intel.com

Re: [edk2-devel] [PATCH] Platform/Intel/Tools: Add scripts to set PACKAGES_PATH environment

Thanks bob. Heng, Please help to update the patch and send it to me, I will help to push it. Thanks, Eric > -Original Message- > From: Feng, Bob C > Sent: Wednesday, April 15, 2020 9:05 AM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Ni, Ray ; Dong, Eric ; Gao, > Liming ; Chan, Amy >

Re: [edk2-devel] [PATCH] Platform/Intel/Tools: Add scripts to set PACKAGES_PATH environment

A typo in the Readme.md. Others are fine for me. **:+The old PACKAGES_PATH will be replaced by new one.s After fix that typo, Reviewed-by: Bob Feng -Original Message- From: Luo, Heng Sent: Friday, April 10, 2020 9:06 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Dong, Eric ; Gao, Liming ;

Re: [edk2-devel] [edk2-platforms:PATCH v3] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support

Reviewed-by: Sai Chaganty -Original Message- From: Shindo, Miki Sent: Monday, April 06, 2020 12:29 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Agyeman, Prince ; Ni, Ray Subject: [edk2-platforms:PATCH v3] IntelSiliconPkg/DxeAslUpdateL

Re: [edk2-devel] [edk2-platforms:PATCH v3] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support

Reviewed-by: Ray Ni > -Original Message- > From: Shindo, Miki > Sent: Monday, April 6, 2020 3:29 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Agyeman, Prince > ; Ni, Ray > Subject: [edk2-platforms:PATCH v3] IntelSiliconPkg/DxeAslU

[edk2-devel] Updated Event: TianoCore Design Meeting - APAC/NAMO - Friday, 17 April 2020 #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VEVENT UID:g7lq.1578029159272351097.u...@groups.io DTSTAMP:20200414T233326Z ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com DTSTART:20200417T013000Z DTEND:20200417T023000Z SUMMARY:TianoCo

Re: [EXTERNAL] [edk2-devel] BaseTools Win32 binaries repo hasn't been updated for over a year

Agreed. - Bret From: devel@edk2.groups.io on behalf of Rebecca Cran via groups.io Sent: Tuesday, April 14, 2020 2:05:47 PM To: Bret Barkelew ; devel@edk2.groups.io Cc: Bob Feng ; Liming Gao Subject: Re: [EXTERNAL] [edk2-devel] BaseTools Win32 binaries repo h

[edk2-devel] [edk2-platform][PATCH v1 1/1] Maintainers.txt: Update RPi reviewers

Add Andrei to the reviewers list for RPi Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index 0e50b6fdf36a..1fe73e6cedb2 100644 --- a/Maintainers

[edk2-devel] [edk2-platform][PATCH v1 1/1] * Readme.md: Update supported platforms

Update Readme.md with the supported platforms in edk2-platforms: * Added: - Arm: Juno, SGI - Hisilicon: D06, HiKey960 - Intel: Comet Lake - Marvel: Armada 80x0, CN913, Solidrun MacchiatoBin - Raspberry Pi: RPi4 * Removed: - Hisilicon: D02 * Updated - Marvell: Armada 70x0 (fixed broken l

Re: [EXTERNAL] [edk2-devel] BaseTools Win32 binaries repo hasn't been updated for over a year

It would be nice to make that clear on the wiki, or in the repo. -- Rebecca Cran On 4/14/2020 1:56 PM, Bret Barkelew wrote: I seem to recall that, yes, the Win32 binary distribution is deprecated. I’m not a maintainer, but I recall the conversation. - Bret *From: *Rebecca Cran via groups

Re: [EXTERNAL] [edk2-devel] BaseTools Win32 binaries repo hasn't been updated for over a year

I seem to recall that, yes, the Win32 binary distribution is deprecated. I’m not a maintainer, but I recall the conversation. - Bret From: Rebecca Cran via groups.io Sent: Sunday, April 12, 2020 9:21 PM To: devel@edk2.groups.io Cc:

[edk2-devel] OvmfPkg XenPkg: X64 DEBUG GCC5 -DDEBUG_ON_SERIAL_PORT=TRUE build is broken

I was trying to build OvmfPkg/XenPkg -a X64 -t GCC5 -b DEBUG -DDEBUG_ON_SERIAL_PORT=TRUE, but the build fails. Both plain DEBUG and RELEASE builds without trying to put the debug output on the serial port work. [bcran@smic ~/src/tmp/edk2]$ build -p OvmfPkg/OvmfXen.dsc -a X64 -t GCC5 -b DEBUG

[edk2-devel] [PATCH v4 07/13] OvmfPkg/MptScsiDxe: Build and decode DevicePath

Used to identify the individual disks in the hardware tree. Currently we accept only Pun=0 and Lun=0, but we will relax this in a later patch. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Liran Alon --- OvmfPkg/MptScsiDxe/MptScsi.c | 57 +

[edk2-devel] [PATCH v4 04/13] OvmfPkg/MptScsiDxe: Probe PCI devices and look for MptScsi

The MptScsiControllerSupported function is called on handles passed in by the ConnectController() boot service and if the handle is the lsi53c1030 controller the function would return success. A successful return value will attach our driver to the device. Ref: https://bugzilla.tianocore.org/show_

[edk2-devel] [PATCH v4 08/13] OvmfPkg/MptScsiDxe: Open PciIo protocol for later use

This will give us an exclusive access to the PciIo of this device after it was started and until is will be stopped. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Liran Alon --- OvmfPkg/MptScsiDxe/MptScsi.c | 30

[edk2-devel] [PATCH v4 05/13] OvmfPkg/MptScsiDxe: Install stubbed EXT_SCSI_PASS_THRU

Support dynamic insertion and removal of the protocol Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Laszlo Ersek --- OvmfPkg/MptScsiDxe/MptScsi.c | 181 +- OvmfPkg/MptScsiDxe/MptScsiDxe.inf | 5 +- 2 files

[edk2-devel] [PATCH v4 06/13] OvmfPkg/MptScsiDxe: Report one Target and one LUN

Support for multiple targets will be implemented in a later commit in this series. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Laszlo Ersek --- OvmfPkg/MptScsiDxe/MptScsi.c | 40 +-- OvmfPkg/MptScsiDxe/Mpt

[edk2-devel] [PATCH v4 09/13] OvmfPkg/MptScsiDxe: Set and restore PCI attributes

Enable the IO Space and Bus Mastering and restore the original values when the device is stopped. This is a standard procedure in PCI drivers. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Liran Alon --- OvmfPkg/MptScsiDxe/MptScsi.c | 42 ++

[edk2-devel] [PATCH v4 13/13] OvmfPkg/MptScsiDxe: Reset device on ExitBootServices()

This causes the device to forget about the reply frame. We allocated the reply frame in EfiBootServicesData type memory, and code executing after ExitBootServices() is permitted to overwrite it. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko --- OvmfPkg/M

[edk2-devel] [PATCH v4 02/13] OvmfPkg/MptScsiDxe: Install DriverBinding Protocol

In order to probe and connect to the MptScsi device we need this protocol. Currently it does nothing. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Laszlo Ersek Reviewed-by: Liran Alon --- OvmfPkg/MptScsiDxe/MptScsi.c | 67 +++

[edk2-devel] [PATCH v4 00/13] OvmfPkg: Support booting from Fusion-MPT SCSI controllers

This series adds driver support for: - LSI53C1030 - SAS1068 - SAS1068E These controllers are widely supported by QEMU, VirtualBox and VMWare. This work is part of the more general agenda of enhancing OVMF boot device support to have feature parity with SeaBIOS. I pushed a copy of these patches to

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add hash of edkrepo.cfg for commit afb9d871 to sha_data.cfg

Reviewed-by: Ashley DeSimone -Original Message- From: Desimone, Nathaniel L Sent: Monday, April 13, 2020 10:34 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew ; Philippe Mathieu-Daude Subject: [edk2-staging/EdkRepo

[edk2-devel] [PATCH v4 12/13] OvmfPkg/MptScsiDxe: Report multiple targets

The controller supports up to 8 targets (Not reported by the controller, but based on the implementation of the virtual device), report them in GetNextTarget and GetNextTargetLun. The firmware will then try to communicate with them and create a block device for each one that responds. Support for

[edk2-devel] [PATCH v4 10/13] OvmfPkg/MptScsiDxe: Initialize hardware

Reset and send the IO controller initialization request. The reply is read back to complete the doorbell function but it isn't useful to us because it doesn't contain relevant data or status codes. See "LSI53C1030 PCI-X to Dual Channel Ultra320 SCSI Multifunction Controller" technical manual for m

[edk2-devel] [PATCH v4 11/13] OvmfPkg/MptScsiDxe: Implement the PassThru method

Machines should be able to boot after this commit. Tested with different Linux distributions (Ubuntu, CentOS) and different Windows versions (Windows 7, Windows 10, Server 2016). Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko --- .../Include/IndustryStand

[edk2-devel] [PATCH v4 03/13] OvmfPkg/MptScsiDxe: Report name of driver

Install Component Name protocols to have a nice display name for the driver in places such as UEFI shell. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Laszlo Ersek Reviewed-by: Jaben Carsey Reviewed-by: Liran Alon --- OvmfPkg/MptScsiDxe/

[edk2-devel] [PATCH v4 01/13] OvmfPkg/MptScsiDxe: Create empty driver

In preparation for implementing LSI Fusion MPT SCSI devices, create a basic scaffolding for a driver. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 Signed-off-by: Nikita Leshenko Reviewed-by: Liran Alon --- Maintainers.txt | 3 ++- OvmfPkg/MptScsiDxe/MptScsi.c

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Register SnpNotifyExitBootServices at TPL_CALLBACK

Hi Maciej, Thank you for summarizing the background. I would like to get others feedback as well. If the EBS notification is kept, I'd like to request this patch be included in edk2-stable202005. Thanks, Michael On 4/14/2020 2:59 AM, Rabeda, Maciej wrote: Hi Michael, Some time ago we have

Re: [edk2-devel] [edk2-platform][PATCH v2 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe

On 4/14/20 5:43 PM, Samer El-Haj-Mahmoud wrote: Switch RaspberryPi from using a private GraphicsConsoleDxe to the common GraphicsConsoleDxe in MdeModulePkg. Code pushed to https://github.com/samerhaj/edk2-platforms/tree/rpi_switch_graphicsconsole_v2 version 1: https://edk2.groups.io/g/devel/m

Re: [edk2-devel] [edk2-platform][PATCH v1 1/3] Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe

Reviewed-by: Andrei Warkentin Looks good to me - there's little reason for using a custom GraphicsConsoleDxe now (historically, the screenshot facility lived there, there's a private interface there for messing with terminal scrolling (unused) and I moved to a different font with my box drawin

Re: [edk2-devel] [edk2-platform][PATCH v2 2/3] Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe

Reviewed-by: Andrei Warkentin Looks good to me - there's little reason for using a custom GraphicsConsoleDxe now (historically, the screenshot facility lived there, there's a private interface there for messing with terminal scrolling (unused) and I moved to a different font with my box drawin

Re: [edk2-devel] [edk2-platform][PATCH v2 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe

Reviewed-by: Andrei Warkentin Looks good to me - there's little reason for using a custom GraphicsConsoleDxe now (historically, the screenshot facility lived there, there's a private interface there for messing with terminal scrolling (unused) and I moved to a different font with my box drawin

Re: [edk2-devel] [edk2-announce] TianoCore Community Design Meeting Minutes - Apr 3, 2020

Hi Mike, Per to the comment from last TianoCore design meeting, which repo RedfishPkg should stay? Edk2 repo or edk2-platform? Abner > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Wednesday, April 8, 2020 5:53 PM > To: d

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/UefiScsiLib: Set FUA bit for synchronous SCSI Write operations

Reviewed-by: Liming Gao > -Original Message- > From: Zurcher, Christopher J > Sent: Tuesday, March 31, 2020 4:34 AM > To: Gao, Liming ; Liu, Zhiguang > ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Wang, Jian J > > Subject: RE: [PATCH v2 1/1] MdePkg/UefiScsiLib: Set FUA bit for syn

[edk2-devel] [edk2-platform][PATCH v2 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe

Switch RaspberryPi from using a private GraphicsConsoleDxe to the common GraphicsConsoleDxe in MdeModulePkg. Code pushed to https://github.com/samerhaj/edk2-platforms/tree/rpi_switch_graphicsconsole_v2 version 1: https://edk2.groups.io/g/devel/message/57256 version 2 changes: - Set PcdUgaConsu

[edk2-devel] [edk2-platform][PATCH v2 1/3] Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe

Switch from the PI specific GraphicsConsoleDxe driver to the common driver in MdeModulePkg. There is no need to carry RPi specific version. This resolves https://github.com/pftf/RPi4/issues/32 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Ha

[edk2-devel] [edk2-platform][PATCH v2 2/3] Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe

Switch from the PI specific GraphicsConsoleDxe driver to the common driver in MdeModulePkg. There is no need to carry RPi specific version. This resolves https://github.com/pftf/RPi4/issues/32 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Ha

[edk2-devel] [edk2-platform][PATCH v2 3/3] Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe

Remove the PI specific GraphicsConsoleDxe driver, since RPi3/RPi4 switched to using the common driver in MdeModulePkg. This resolves https://github.com/pftf/RPi4/issues/32 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platf

Re: [edk2-devel] [PATCH v6 00/42] SEV-ES guest support

> > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Lendacky, Thomas > > Sent: Thursday, April 2, 2020 4:42 AM > > To: Dong, Eric ; devel@edk2.groups.io > > Cc: Justen, Jordan L ; Laszlo Ersek > > ; Ard Biesheuvel ; > > Kinney, Michael D ; Ga

[edk2-devel] [Patch V2] MinPlatformPkg/PlatformInitPei: Create Library Instance of ReportCpuHobLib.

Create an Library instance of ReportCpuHobLib from PlatformInitPei driver, so that from platform side reporting Physical address bits can be overriden. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674 Signed-off-by: Chandana Kumar Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone

Re: [edk2-devel] [edk2-discuss] Load Option passing. Either bugs or my confusion.

On 04/14/20 02:44, valerij zaporogeci wrote: > 1. what this pointer (OS Loader > ImageHandle)->(LOADED_IMAGE_PROTOCOL)->LoadOptions points to? According to the UEFI spec , section "9.1 EFI Loaded Image Protocol": LoadOptionsSize The size in bytes of LoadOption

Re: [edk2-devel] [edk2-platforms][PATCH v4 0/9]Platform/Arm/Sgi: Add platform support for RD-Daniel

Hi Ard, > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel via groups.io > Sent: 14 April 2020 19:20 > To: devel@edk2.groups.io; Aditya Angadi > Cc: Thomas Abraham ; l...@nuviainc.com > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 0/9]Platform/Arm/Sgi:

Re: [edk2-devel] [edk2-platforms][PATCH v4 0/9]Platform/Arm/Sgi: Add platform support for RD-Daniel

On 4/14/20 2:51 PM, Aditya Angadi via groups.io wrote: This patch series adds support for Arm's RD-Daniel platform. There are two configurations of this platform being added in this series - Config-M and Config-XLR. RD-Daniel is the next Arm's reference design subsystem. Config XLR is a multi chi

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

Thanks Sami for the review Jian, Can we get this patch pushed please? It has been reviewed by Sami, Ard, and Dandan. Thanks, --Samer From: devel@edk2.groups.io On Behalf Of Sami Mujawar via groups.io Sent: Tuesday, April 14, 2020 5:45 AM To: Samer El-Haj-Mahmoud ; devel@edk2.groups.io Subjec

[edk2-devel] [edk2-platforms][PATCH v4 6/9] Platform/ARM/Sgi: Add initial support for RD-Daniel Config-M platform

Arm's RD-Daniel Config-M platform is built using 16 Neoverse cores and connected to 8GB of RAM. Add initial platform support for this platform. Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgMAcpiTables.inf | 2 + Platform/ARM/SgiPkg/Include/SgiPlatform.h

[edk2-devel] [edk2-platforms][PATCH v4 3/9] Platform/ARM/Sgi: Move common platform description to SSDT

Move common platform description entries in platform specific DSDT to a SSDT that can be reused on all SGI/RD platforms. Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Dsdt.asl | 70 +--- Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTable

[edk2-devel] [edk2-platforms][PATCH v4 8/9] Platform/ARM/Sgi: Add initial support for RD-Daniel Config-XLR platform

Arm's RD-Daniel Config-XLR platform is a quad chip platform with each chip having four Neoverse cores and 8GB of RAM attached to it. These chips are coherently connected over CCIX interface. Add initial support for this platform. Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/Rd

[edk2-devel] [edk2-platforms][PATCH v4 5/9] Platform/ARM/Sgi: Add ACPI tables for Rd-Daniel Config-M

Add Madt and Dsdt ACPI tables that are specific for RD-Daniel Config-M platform. Reuse the rest of the shared ACPI tables in SgiPkg. Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgM/Dsdt.asl | 118 Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgM/Mad

[edk2-devel] [edk2-platforms][PATCH v4 4/9] Platform/ARM/Sgi: Add support for remote numa memory nodes

From: Vijayenthiran Subramaniam Add new PCDs that define the base address and size of remote NUMA memory nodes on multi-chip platforms. Use these PCDs to setup system memory resource descriptor HOBs. Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 18

[edk2-devel] [edk2-platforms][PATCH v4 2/9] Platform/ARM/Sgi: Move the GIC related ACPI helper macros

Move the ACPI helper macros defines related to GIC structure, distributor, redistributor and ITS to SgiAcpiHeader.h as these are common across ARM SGI/RD platforms. Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc | 68 +- Platform/ARM/SgiPkg/AcpiTabl

[edk2-devel] [edk2-platforms][PATCH v4 9/9] Platform/ARM/Sgi: Add SRAT table for RdN1Edge dual-chip platform

From: Vijayenthiran Subramaniam The RD-N1-Edge dual chip platform has an additional 8GB of memory connected to the second chip. Add the SRAT ACPI table to describe the proximity domain, base address and size of this memory. Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdN1Ed

[edk2-devel] [edk2-platforms][PATCH v4 7/9] Platform/ARM/Sgi: Add ACPI tables for RD-Daniel Config-XLR

Add Madt, Dsdt and Srat ACPI tables that are specific for RD-Daniel Config-XLR platform. Reuse the rest of the shared ACPI tables in SgiPkg. Signed-off-by: Aditya Angadi --- Platform/ARM/SgiPkg/AcpiTables/RdDanielCfgXlr/Dsdt.asl | 125 Platform/ARM/SgiPkg/AcpiTables/RdDani

[edk2-devel] [edk2-platforms][PATCH v4 1/9] Platform/ARM/Sgi: Create individual Platform Description File

From: Vijayenthiran Subramaniam In preparation for adding support for Reference Design (RD) platforms that have different base addresses for GIC distributor or redistributor, create individual platform description files for all SGI/RD platforms and move GIC related base addresses from the common

[edk2-devel] [edk2-platforms][PATCH v4 0/9]Platform/Arm/Sgi: Add platform support for RD-Daniel

This patch series adds support for Arm's RD-Daniel platform. There are two configurations of this platform being added in this series - Config-M and Config-XLR. RD-Daniel is the next Arm's reference design subsystem. Config XLR is a multi chip platform. The first four patches consolidate the code

[edk2-devel] [Patch V1] MinPlatformPkg/PlatformInitPei: Create an Library Instance of ReportCpuHobLib.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674 Create an Library instance of ReportCpuHobLib from PlatformInitPei driver, so that from platform side reporting Physical address bits can be overriden. --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc

[edk2-devel] [Patch V1 5/5] MinPlatformPkg/PlatformInitPei: Create an Library Instance of ReportCpuHobLib.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674 Create an Library instance of ReportCpuHobLib from PlatformInitPei driver, so that from platform side reporting Physical address bits can be overriden. --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc

Re: [edk2-devel] [edk2][PATCH v2 2/2] Revert "ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher"

On 04/10/20 17:29, Samer El-Haj-Mahmoud wrote: > This reverts commit e0692789058ee2c0099f88852503c16dbb0bae4e. > > The default value for PcdAcpiExposedTableVersions is now set to 0x20 > for Aarch64 systems. Setting this PCD in ArmVirtPkg/ArmVirtQemu.dsc > is no longer necessary. > > Cc: Laszlo Er

[edk2-devel] [PATCH edk2-platforms v3 24/24] Platform/NXP/LS1043aRdbPkg: Add PEI Phase

From: Pankaj Bansal Add PEI phase to LS1043aRdb. This is needed becuase we need to have dynamic PCDs support to be able to reserve memory before reporting memory to UEFI fimrware. Using PEI phase we are now also dynamically setting the PcdSystemMemoryBase and PcdSystemMemorySize depending upon th

[edk2-devel] [PATCH edk2-platforms v3 22/24] Platform/NXP/LS1043aRdbPkg: Add VarStore

From: Pankaj Bansal Add VarStore Fd. This Fd is used to store non volatile variables in flash. Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: - No change Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 3 +- Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc | 91 +

[edk2-devel] [PATCH edk2-platforms v3 21/24] Platform/NXP: Use FV rules from ArmVirtPkg

From: Pankaj Bansal FVRules.fdf.inc is being replaced by the ArmVirtPkg/ArmVirtRules.fdf.inc at commit hash 746c5b6238f1ee55deb4b3ec32a6d732e27eeeaa Signed-off-by: Pankaj Bansal --- Notes: - Modify commit description Platform/NXP/FVRules.fdf.inc | 59 +--- 1 file changed,

[edk2-devel] [PATCH edk2-platforms v3 23/24] Silicon/NXP: move MemoryInitPeiLib as per PEIM structures

From: Pankaj Bansal MemoryInitPeiLib would be linked to MemoryInitPeim, when we implement PEI phase. therefore, move the library to directory of same name. Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: - No change Silicon/NXP/NxpQoriqLs.dsc.inc

[edk2-devel] [PATCH edk2-platforms v3 13/24] Platform/NXP/LS1043aRdbPkg: Add Clock retrieval APIs

From: Pankaj Bansal The SOC takes primary clocking input from the external signal (a clock generator on board). The input (frequency) is multiplied using multiple phase locked loops (PLL) to create a variety of frequencies which can then be passed to a variety of internal logic, including cores a

[edk2-devel] [PATCH edk2-platforms v3 20/24] NXP: LS1043aRdbPkg: Use ArmPlatformHelper.S from ArmPlatformPkg

From: Pankaj Bansal ArmPlatformHelper.S is being replaced by the ArmPlatformPkg version at commit hash f4dfad05dda2c7b29e8105605621f2b413f0af2b. Signed-off-by: Pankaj Bansal --- Notes: - Modify commit description Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf

[edk2-devel] [PATCH edk2-platforms v3 11/24] Platform/NXP: rename the ArmPlatformLib as per ArmPlatformPkg

From: Pankaj Bansal Keep the names and location of files as mentioned in ArmPlatformPkg. This helps in porting the common changes (if any in future) easily. Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: - No change Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc

[edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

From: Pankaj Bansal A Chassis is a base framework used for building SoCs. We can think of Chassis/Soc/Platform(a.k.a Borad) in Object model terms. Chassis is base. Soc is based on some Chassis. Platform is based on some Soc. SOCs that are designed around same chassis, reuse most of the component

[edk2-devel] [PATCH edk2-platforms v3 10/24] Silicon/NXP: Move dsc file

From: Pankaj Bansal As per convention being followed in edk2-platforms, keep the dec file and dsc file together. Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: - No change {Platform => Silicon}/NXP/NxpQoriqLs.dsc.inc | 0 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc

[edk2-devel] [PATCH edk2-platforms v3 12/24] Silicon/NXP: Move RAM retrieval from SocLib

From: Pankaj Bansal RAM retrieval using SMC commands is common to all Layerscape SOCs. Therefore, move it to commom MemoryInit Pei Lib. Signed-off-by: Pankaj Bansal --- Notes: - sort headers alphabetically - Moved DRAM region retrieval and Total DRAM size retrieval to separate fu

[edk2-devel] [PATCH edk2-platforms v3 17/24] Silicon/NXP/LS1043A: Use ChassisLib from Chassis2 Pkg

From: Pankaj Bansal Now the we have added Chassis Package, move the chassis specific common code for all SOCs belonging to same chassis to ChassisLib. Use ChassisLib APIs in SocLib. Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: - No change Silicon/NXP/NxpQoriqLs.de

[edk2-devel] [PATCH edk2-platforms v3 02/24] Silicon/NXP: changes to use I2clib in i2cdxe

From: Pankaj Bansal I2c lib contains the i2c controller functionality. this can be used in I2c DXE driver to communicate with i2c devices. Signed-off-by: Pankaj Bansal --- Notes: - moved I2cLib addition to NxpQoriqLs.dsc.inc Platform/NXP/NxpQoriqLs.dsc.inc | 4 +- Silicon/NXP/Dri

[edk2-devel] [PATCH edk2-platforms v3 14/24] Silicon/NXP: Use Clock retrieval PPI in modules

From: Pankaj Bansal Use NXP_PLATFORM_GET_CLOCK_PPI in various Layerscape IP modules. Signed-off-by: Pankaj Bansal --- Notes: - Added clock retrieval APIs to DUartPortLib Silicon/NXP/NxpQoriqLs.dec| 5 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 2 --

[edk2-devel] [PATCH edk2-platforms v3 15/24] Silicon: NXP: Remove direct calls to SwapMmio* APIs

From: Pankaj Bansal The SwapMmio** APIs are supposed to be called indirectly via GetMmioOperations** APIs. Therefore, remove the SwapMmio** APIs from IoAccessLib.h and make these APIs STATIC to IoAccessLib.c, so that no accidental call can be made to these. Signed-off-by: Pankaj Bansal --- Not

[edk2-devel] [PATCH edk2-platforms v3 04/24] Silicon/Maxim: Fix bug in RtcWrite in Ds1307RtcLib

From: Pankaj Bansal There was a bug in I2C DXE implementation, which caused the Ds1307 RTC device to issue two operation for register write, while this is a single operation task. refer page 12 (Slave Receiver Mode (Write Mode)) on https://datasheets.maximintegrated.com/en/ds/DS1307.pdf Modify

[edk2-devel] [PATCH edk2-platforms v3 03/24] Silicon/NXP/I2cDxe: Fix I2c Timeout with RTC

From: Pankaj Bansal With latest edk2 codebase, sometimes i2c timeout is observed when Network devices are being probed. This is happening when gRT->GetTime request is ongoing. gRT->GetTime triggers a read request to Real Time Clock which is connected to I2c bus. In between read request, if an eve

[edk2-devel] [PATCH edk2-platforms v3 01/24] Silicon/NXP: Add I2c lib

From: Pankaj Bansal I2c lib is going to be used in PrePeiCore sec module to get the System clock information from devices connected to i2c (like fpga or clock generator) since we don't have support of DXE modules this early in boot stage, move the i2c controller functionality in library. This I

[edk2-devel] [PATCH edk2-platforms v3 05/24] Silicon/Maxim: Add comments in Ds1307RtcLib

From: Pankaj Bansal Add comments to explain the register read and write operation on Ds1307. These comments have been referred from data sheet: https://datasheets.maximintegrated.com/en/ds/DS1307.pdf Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: - No change Silicon

[edk2-devel] [PATCH edk2-platforms v3 18/24] Silicon/NXP/LS1043A: Move SocLib to Soc Package

From: Pankaj Bansal The SocLib contains code specific to an Soc. it should be part of SOC package. Therefore, move the SocLib to Soc Package. Since we are moving the files to Soc Package, no need to mention the Soc name in file names. Their location is enough to indicate for which Soc the files a

[edk2-devel] [PATCH edk2-platforms v3 09/24] Silicon/NXP: Remove unnecessary PCDs

From: Pankaj Bansal The memory map of an SOC is fixed in hardware. it doesn't change with platform that uses SOC. So, there is no need to keep PCDs for these values and we can use macros for these in SOC header file. Any Platform using the SOC, can make use of the SOC header file. Signed-off-by

[edk2-devel] [PATCH edk2-platforms v3 19/24] NXP/LS1043aRdbPkg/ArmPlatformLib: Remove extern SocInit

From: Pankaj Bansal SocInit can be defined in SocLib.h No need to make it extern in ArmPlatformLib Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: - Moved commit three commits before in series Silicon/NXP/Include/Library/SocLib.h | 8

[edk2-devel] [PATCH edk2-platforms v3 07/24] Silicon/NXP: remove print information from Soc lib

From: Pankaj Bansal The Soc info being printed can be removed from SOC lib. We are in the process of implementing PEI Phase. After PEI phase implementation this info would be printed in common PEIM based on the information retrieved from PPIs. e.g. gArmMpCoreInfoPpiGuid can be used to print cluse

[edk2-devel] [PATCH edk2-platforms v3 08/24] Silicon/NXP: remove not needed components

From: Pankaj Bansal The structures elements and functions that are not necessary for booting for now are being deleted. Once the directory structure has been changed (i.e. we have clear distinction between chassis code and header files and SOC code and header files), we will put back the code and

[edk2-devel] [PATCH edk2-platforms v3 06/24] NXP/LS1043aRdb: Move Soc specific components to soc files

From: Pankaj Bansal Soc specific components ought to be part of Soc files and not platform files. move the same to SOC files Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: - No change Platform/NXP/NxpQoriqLs.dsc.inc | 2 ++ Silicon/NXP/LS1043A/LS1043A.ds

[edk2-devel] [PATCH edk2-platforms v3 00/24] Add PEI phase to LS1043ARDB Platform

From: Pankaj Bansal This patch series adds PEI phase to NXP LS1043ARDB Platform. V2 series can be referred here: https://edk2.groups.io/g/devel/message/56009 I have taken care of the review comments received on v2 and have removed/added these commits w.r.t V2: Removed in V3 (present in V2): 0

Re: [edk2-devel] [PATCH] MdeModulePkg/DeviceManagerUiLib: connect all before creating menu page

On 04/12/20 10:11, Tian, Hot wrote: > EfiBootManagerConnectAll is kind of BDS policy. Should it be controlled by Ui > App or Ui Lib? I think platform BDS policy applies to normal (non-interactive, non-interrupted) boot. I agree that connect-all should not be forced into that. But, if the user in

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Register SnpNotifyExitBootServices at TPL_CALLBACK

Hi Michael, Some time ago we have introduced a patch in ExitBootServices (EBS) area for SnpDxe to allow for EBS event creation control. Commit: https://github.com/tianocore/edk2/commit/61bb6eeb4d93c0a34c1995d87914ab41398f9550 Patch: https://edk2.groups.io/g/devel/message/48899 Ideally, at EBS

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57303): https://edk2.groups.io/g/devel/message/57303 Mute This Topic: https://groups.io/mt/72923682/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed

Hi, Can I get a review for this patch series? Thanks, Krzysztof -Original Message- From: devel@edk2.groups.io On Behalf Of Krzysztof Koch via Groups.Io Sent: Wednesday, March 25, 2020 9:39 To: devel@edk2.groups.io Cc: ray...@intel.com; zhichao@intel.com; Sami Mujawar ; Matteo Car

Re: [edk2-devel] [PATCH v1 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

Hi Sean/Michael, Did you have test for the added piplines? Thanks, Shenglei > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael Kubacki > Sent: Thursday, April 9, 2020 2:13 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ard Biesheuvel

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

Summarize current status: Problem Statement: Openssl require _fltused to be defined as a constant anywhere floating point is used. It may use float out of edk2 tree and need _fltused, for example, Microsoft’s OnScreenKeyboard and UiToolKit. Current Proposal as below: Proposal 1: Add FltUsed.c