Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

2020-04-08 Thread Laszlo Ersek
On 04/08/20 20:13, michael.kuba...@outlook.com wrote: > From: Sean Brogan > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 > > Add new Azure Pipeline definitions to build and run ArmVirtPkg with: > * Ubuntu GCC5 > Add PyTool based build of ArmVirtPkg > Add extdep for managing the ia

Re: [edk2-devel] [PATCH v2 (add signed-off-by)] OvmfPkg: Add bhyve support into AcpiTimerLib

2020-04-08 Thread Laszlo Ersek
On 04/09/20 07:26, Rebecca Cran wrote: > On 3/27/2020 1:01 PM, Laszlo Ersek wrote: >> >> I'm quite happy about this patch, but perhaps for an unexpected reason: >> namely, because it showcases how non-intuitive and unpredictable it can >> be to customize existent code for a new platform. > > Thank

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/DeveloperBox: omit TPM from DT when building without TPM support

2020-04-08 Thread Ard Biesheuvel
On 4/8/20 10:58 PM, Leif Lindholm wrote: On Wed, Apr 08, 2020 at 19:00:31 +0200, Ard Biesheuvel wrote: The recently added support for TPM2 measured boot added a description of the TPM to the device tree, but failed to take the build configuration into account, and so it adds it unconditionally.

Re: [edk2-devel] [PATCH edk2-platforms 0/2] SynQuacer: fix driver model integration of NetSec

2020-04-08 Thread Ard Biesheuvel
On 4/8/20 6:26 PM, Leif Lindholm wrote: On Wed, Apr 08, 2020 at 18:11:36 +0200, Ard Biesheuvel wrote: Currently, the way the SynQuacer NetSec driver implements the EFI driver model is slightly quirky. Two changes are needed to move it closer to the intent of the driver model, which is the abilit

Re: [edk2-devel] [PATCH v2 (add signed-off-by)] OvmfPkg: Add bhyve support into AcpiTimerLib

2020-04-08 Thread Rebecca Cran
On 3/27/2020 1:01 PM, Laszlo Ersek wrote: I'm quite happy about this patch, but perhaps for an unexpected reason: namely, because it showcases how non-intuitive and unpredictable it can be to customize existent code for a new platform. Thanks! I was wondering if I should try and add new code i

Re: [edk2-devel] [PATCH] .azurepiplines/pr-gate-steps.yml: Update python to 3.8.x for ci build

2020-04-08 Thread Michael Kubacki
Reviewed-by: Michael Kubacki On 4/6/2020 11:47 PM, Zhang, Shenglei wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2617 Update edk2 build and test ci to use Python 3.8.x Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- .a

[edk2-devel] [PATCH v2] EmulatorPkg/WinHost: Enable network support.

2020-04-08 Thread Nickle Wang
Follow the implementation from Unix host to implement SNP EMU_IO_THUNK_PROTOCOL and EMU_SNP_PROTOCOL. The network IO driver is the same one as Nt32. Please refer to NETWORK-IO Subproject for network Io driver(SnpNt32Io.dll). Signed-off-by: Nickle Wang Signed-off-by: Derek Lin --- EmulatorPkg/Em

Re: [edk2-devel] [PATCH] pip-requirements.txt: Update extensions min version to 0.13.3

2020-04-08 Thread Michael Kubacki
Reviewed-by: Michael Kubacki On 4/6/2020 11:47 PM, Zhang, Shenglei wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2616 Pytool extensions are locked on 0.12.x but extensions has moved to 0.13.x. So update the pip-requirements.txt. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Ki

[edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Prevent invalid PCI BAR access

2020-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1563 SnpDxe initializes values for MemoryBarIndex and IoBarIndex to 0 and 1 respectively even if calls to PciIo->GetBarAttributes never return success. Later, if the BAR is used to perform IO/Mem reads/writes, a potentiall

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

2020-04-08 Thread Guomin Jiang
Hi Sean, I think it meet the original code logic more closely. According to the LoadUnitTestCache(), it need pointer to pointer, the defect is resulted by pointer to local pointer and I think the original logical just want use the local variable as pointer to pointer. I have reviewed the sugge

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] MdeModulePkg/ReportStatusCodeRouter: Update RSC Data on reallocation

2020-04-08 Thread Bret Barkelew via groups.io
Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Michael Kubacki via groups.io Sent: Wednesday, April 8, 2020 5:04:47 PM To: devel@edk2.groups.io Cc: Dandan Bi ; Hao A Wu ; Jian J Wang ; Kun Qin ; Liming Gao Subject: [EXTERNAL] [ed

[edk2-devel] [PATCH v1 1/1] MdeModulePkg/ReportStatusCodeRouter: Update RSC Data on reallocation

2020-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2670 The RSC router data buffer may be reallocated when the buffer is nearing exhaustion (7/8 portion of the buffer used). While several pointers are updated to point to the newly allocated buffer, the RscData is not updat

[edk2-devel] [PATCH v1 1/1] MdeModulePkg/ReportStatusCodeRouter: Clear RSC Data buffer if Data is NULL

2020-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1969 ReportDispatcher() may be invoked with a NULL Data argument. When TPL is less than TPL_HIGH_LEVEL and Data is NULL, the EFI_STATUS_CODE_DATA structure inside RscData should be cleared so listeners will not receive data

[edk2-devel] [PATCH v1 1/1] MdeModulePkg/ReportStatusCodeRouter: Take HeaderSize into Consideration

2020-04-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2669 Updates ReportDispatcher() to take the size in the HeaderSize field in a EFI_STATUS_CODE_DATA element into account when walking the data buffer. This size will cause the header size to differ from the compiled sizeof h

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/DeveloperBox: omit TPM from DT when building without TPM support

2020-04-08 Thread Leif Lindholm
On Wed, Apr 08, 2020 at 19:00:31 +0200, Ard Biesheuvel wrote: > The recently added support for TPM2 measured boot added a description of > the TPM to the device tree, but failed to take the build configuration > into account, and so it adds it unconditionally. > > Fix this, by #define'ing a TPM2_E

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 2/2] EdkRepo: Update README.md

2020-04-08 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, April 6, 2020 5:40 PM To: devel@edk2.groups.io Cc: Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew ; Philippe Mathieu-Daude Subject: [edk2-devel] [edk2-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 1/2] EdkRepo: Add setup_git_pyenv_mac.sh

2020-04-08 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, April 6, 2020 5:40 PM To: devel@edk2.groups.io Cc: Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew ; Philippe Mathieu-Daude Subject: [edk2-devel] [edk2-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 0/2] Add documentation for EdkRepo on macOS

2020-04-08 Thread Ashley E Desimone
Reviewed=by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, April 6, 2020 5:40 PM To: devel@edk2.groups.io Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 0/2] Add documentation for EdkRepo on macOS This patch series add setup

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add Support for macOS

2020-04-08 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, April 6, 2020 1:59 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Agyeman, Prince ; Bret Barkelew ; Philippe Mathieu-Daude Subject

[edk2-devel] [PATCH v1 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-08 Thread Michael Kubacki
From: Michael Kubacki The following 6 patches adds support for "Platform CI" for ArmVirtPkg, OvmfPkg, and EmulatorPkg. Each readme has live status and links to the builds as well as details of how to build and run the same way the CI server will. ArmVirtPkg: https://github.com/spbrogan/edk2/blo

[edk2-devel] [PATCH v1 6/6] .azurepipelines: Update Core CI build matrix to include platforms

2020-04-08 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add ArmVirtPkg to Core CI matrix Add EmulatorPkg to Core CI matrix Add OvmfPkg to Core CI matrix Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Sean Brogan --- .azurepipelines/t

[edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

2020-04-08 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add new Azure Pipeline definitions to build and run ArmVirtPkg with: * Ubuntu GCC5 Add PyTool based build of ArmVirtPkg Add extdep for managing the iasl dependency Add ArmVirtPkg.ci.yaml for Core CI Add README-pytools fo

[edk2-devel] [PATCH v1 3/6] EmulatorPkg: Add Platform CI and configuration for Core CI

2020-04-08 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add new Azure Pipeline definitions to build and run EmulatorPkg with: * Ubuntu GCC5 * Windows VS2019 Add PyTool based build of EmulatorPkg Add EmulatorPkg.ci.yaml for Core CI Add README-pytools for details and instruct

[edk2-devel] [PATCH v1 4/6] OvmfPkg: Add Platform CI and configuration for Core CI

2020-04-08 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add new Azure Pipeline definitions to build and run OvmfPkg with: * Ubuntu GCC5 * Windows VS2019 Add PyTool based build of OvmfPkg Add extdep for managing the iasl dependency Add OvmfPkg.ci.yaml for Core CI Add README-

[edk2-devel] [PATCH v1 1/6] .azurepipelines: Add Platform CI template

2020-04-08 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Add template for Platform CI steps for a Pytools based build. Add README to describe the template and how to use it. Add helpful information for working with azurepipelines, templates, and lessons learned. Cc: Sean Brogan

[edk2-devel] [PATCH v1 5/6] .pytool: Update CI Settings to support Emulator, ArmVirt, and Ovmf packages

2020-04-08 Thread Michael Kubacki
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 Update pytools configuration to enable EmulatorPkg, ArmVirtPkg, and OvmfPkg. Update documentation for the status of those packages. Remove future work items that are now complete. Cc: Sean Brogan Cc: Bret Barkelew Cc: M

[edk2-devel] [PATCH] MdeModulePkg/DeviceManagerUiLib: connect all before creating menu page

2020-04-08 Thread Ard Biesheuvel
The device manager UI library creates a UiApp submenu that contains a list of network devices in the system. The logic that creates this menu assumes that all handles have been connected to their drivers, but this is not guaranteed in the general case. So work around this by doing an explicit Conn

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/DeveloperBox: omit TPM from DT when building without TPM support

2020-04-08 Thread Ard Biesheuvel
The recently added support for TPM2 measured boot added a description of the TPM to the device tree, but failed to take the build configuration into account, and so it adds it unconditionally. Fix this, by #define'ing a TPM2_ENABLE CPP macro that can be referenced in the device tree source file.

Re: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files

2020-04-08 Thread Chaganty, Rangasai V
The commit message can be improved to reflect the actual changes correctly. For e.g. " SmmAccessLib.h and ConfigBlockLib.h are the primary header file in IntelSiliconPkg. This commit adds path definitions for these header files in IntelSiliconPkg" With that: Reviewed-by: Sai Chaganty -Ori

Re: [edk2-devel] [PATCH 0/2] .mailmap: Update description and my email address

2020-04-08 Thread Leif Lindholm
On Tue, Apr 07, 2020 at 16:16:49 -0600, Eugene Cohen wrote: > In addition to fixing messed up names, mailmap can be used to record > legitimate email address changes due to change of employers. Update the > description in the mailmap comments section accordingly and then add > a new entry for me r

Re: [edk2-devel] [PATCH edk2-platforms 0/2] SynQuacer: fix driver model integration of NetSec

2020-04-08 Thread Leif Lindholm
On Wed, Apr 08, 2020 at 18:11:36 +0200, Ard Biesheuvel wrote: > Currently, the way the SynQuacer NetSec driver implements the EFI driver > model is slightly quirky. Two changes are needed to move it closer to the > intent of the driver model, which is the ability to boot using only the > drivers th

Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi3: Enable HTTP Boot

2020-04-08 Thread Ard Biesheuvel
On Wed, 8 Apr 2020 at 12:04, Pete Batard wrote: > > On 2020.03.25 15:02, Samer El-Haj-Mahmoud wrote: > > Enable HTTP Boot (with and without TLS) on RPi3 > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Pete Batard > > Signed-off-by: Samer El-Haj-Mahmoud > > --- > > Platform/Raspberry

[edk2-devel] [PATCH edk2-platforms 1/2] Silicon/SynQuacer/PlatformDxe: defer device registration until EndOfDxe

2020-04-08 Thread Ard Biesheuvel
EDK2 carries an interesting quirk which dates back to the EFI 1.02 days, where each protocol that is installed onto a handle during the execution of a DXE driver's entrypoint is connected immediately (in the UEFI driver model sense) after the entry point returns. This means that, depending on the

[edk2-devel] [PATCH edk2-platforms 0/2] SynQuacer: fix driver model integration of NetSec

2020-04-08 Thread Ard Biesheuvel
Currently, the way the SynQuacer NetSec driver implements the EFI driver model is slightly quirky. Two changes are needed to move it closer to the intent of the driver model, which is the ability to boot using only the drivers that are required to drive the devices that are needed at boot. This ser

[edk2-devel] [PATCH edk2-platforms 2/2] Silicon/SynQuacer/NetsecDxe: move device path to root device

2020-04-08 Thread Ard Biesheuvel
Currently, SynQuacer's platform DXE driver installs a non-discoverable device protocol onto a new handle to declare the existence of the NetSec network controller. This protocol is consumed by the NetSec DXE driver in its implementation of the UEFI driver model supported/start/stop routines. Only w

Re: [edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

2020-04-08 Thread Leif Lindholm
On Tue, Apr 07, 2020 at 17:00:50 +, Pankaj Bansal wrote: > > OK, taking another look at this patch, this simply needs to be > > deleted. Here is the sum total relevant difference compared to the > > ArmPlatformPkg one. > > > > DEBUG ((DEBUG_INIT, "Edk2 version is %a\n", XPRINT > > (WORKSPACE

Re: [edk2-devel] [PATCH 0/2] .mailmap: Update description and my email address

2020-04-08 Thread Laszlo Ersek
On 04/08/20 00:16, Eugene Cohen wrote: > In addition to fixing messed up names, mailmap can be used to record > legitimate email address changes due to change of employers. Update the > description in the mailmap comments section accordingly and then add > a new entry for me reflecting my NUVIA em

Re: [edk2-devel] [PATCH] ArmVirtPkg/FdtPciHostBridgeLib: add extra roots for Arm.

2020-04-08 Thread miaoyubo
> -Original Message- > From: miaoyubo > Sent: Friday, April 3, 2020 4:56 PM > To: 'Laszlo Ersek' ; ard.biesheu...@linaro.org; > l...@nuviainc.com > Cc: devel@edk2.groups.io; Xiexiangyou > Subject: RE: [PATCH] ArmVirtPkg/FdtPciHostBridgeLib: add extra roots for > Arm. > > > > > -Or

Re: [edk2-devel] [PATCH] SecurityPkg/MeasureBootLib: Return EFI_ACCESS_DENIED after image check fail

2020-04-08 Thread Laszlo Ersek
Hi, On 04/01/20 03:11, Guomin Jiang wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 > > If check the File at the begin of function, it will only allow the File is > present and forbid image from buffer. > It is possible that image come from the memory buffer, so make it can run

Re: [edk2-devel] [PATCH] ArmVirtPkg/FdtPciHostBridgeLib: add extra roots for Arm.

2020-04-08 Thread Laszlo Ersek
On 04/08/20 05:58, miaoyubo wrote: >>> (2) This code is way too large for my taste to duplicate between >>> ArmVirtPkg and OvmfPkg. I would strongly prefer if we could factor the >>> logic in OvmfPkg out to a separate library, and use that from both >> consumer sites. >>> > > Where should I put t

Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi3: Enable HTTP Boot

2020-04-08 Thread Pete Batard
On 2020.03.25 15:02, Samer El-Haj-Mahmoud wrote: Enable HTTP Boot (with and without TLS) on RPi3 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi3/RPi3.dsc | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-)

Re: [edk2-devel] [edk2-announce] TianoCore Community Design Meeting Minutes - Apr 3, 2020

2020-04-08 Thread Abner Chang
> -Original Message- > From: annou...@edk2.groups.io [mailto:annou...@edk2.groups.io] On > Behalf Of Ni, Ray > Sent: Wednesday, April 8, 2020 9:28 AM > To: annou...@edk2.groups.io > Subject: [edk2-announce] TianoCore Community Design Meeting Minutes - > Apr 3, 2020 > > Topic: > > 1. EDK

Re: [edk2-devel] [PATCH] OvmfPkg: supply missing lib class declarations in the DEC file

2020-04-08 Thread Laszlo Ersek
On 04/07/20 12:05, Laszlo Ersek wrote: > List the header files in the OvmfPkg DEC file for the following lib > classes: > > - MemEncryptSevLib (one instance: BaseMemEncryptSevLib) > > - PlatformFvbLib (two instances: EmuVariableFvbLib, PlatformFvbLibNull) > > - VirtioLib (one instance: VirtioLib

Re: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add link flags for VS2019 tool chains.

2020-04-08 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Jiang, Guomin > Sent: Tuesday, April 7, 2020 10:43 AM > To: devel@edk2.groups.io; Jiang, Guomin > Cc: Justen, Jordan L ; Andrew Fish > ; Ni, Ray > Subject: RE: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add link flags for > VS2019 tool

Re: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add library header files

2020-04-08 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Jiang, Guomin > Sent: Wednesday, April 8, 2020 2:30 PM > To: devel@edk2.groups.io; Jiang, Guomin > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg: Add > library header files >

[edk2-devel] [PATCH V3] BaseTools:Add the spare space FV image size checker

2020-04-08 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2654 If FV is placed in FD region, its FV image size is fixed. When FV image size exceeds it, it will trig the build break. To alert the developer to adjust FV image size earlier, I request to add new checker for the the spare FV space. When the s