Reviewed-by: Ray Ni <ray...@intel.com> > -----Original Message----- > From: Jiang, Guomin <guomin.ji...@intel.com> > Sent: Tuesday, April 7, 2020 10:43 AM > To: devel@edk2.groups.io; Jiang, Guomin <guomin.ji...@intel.com> > Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; Andrew Fish > <af...@apple.com>; Ni, Ray <ray...@intel.com> > Subject: RE: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add link flags for > VS2019 tool chains. > > Hi Justen, Andrew, Ray, > > Could you help review the changes. > > Best Regards > Guomin > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jiang, > > Guomin > > Sent: Friday, March 20, 2020 1:26 PM > > To: devel@edk2.groups.io > > Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; Andrew Fish > > <af...@apple.com>; Ni, Ray <ray...@intel.com> > > Subject: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add link flags for > > VS2019 tool chains. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2604 > > > > The link flags for VS2019 is absent and result the build fail. > > > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > > Cc: Andrew Fish <af...@apple.com> > > Cc: Ray Ni <ray...@intel.com> > > Signed-off-by: Guomin Jiang <guomin.ji...@intel.com> > > --- > > EmulatorPkg/Win/Host/WinHost.inf | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/EmulatorPkg/Win/Host/WinHost.inf > > b/EmulatorPkg/Win/Host/WinHost.inf > > index e0b3ecb15b..44e938761d 100644 > > --- a/EmulatorPkg/Win/Host/WinHost.inf > > +++ b/EmulatorPkg/Win/Host/WinHost.inf > > @@ -87,12 +87,14 @@ > > MSFT:*_VS2015_IA32_DLINK_FLAGS = /LIBPATH:"%VS2015_PREFIX%Lib" > > /LIBPATH:"%VS2015_PREFIX%VC\Lib" > > /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x86" > > /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x86" > > /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP > > /OPT:REF /DEBUG /MACHINE:I386 /LTCG Kernel32.lib MSVCRTD.lib Gdi32.lib > > User32.lib Winmm.lib Advapi32.lib vcruntimed.lib ucrtd.lib > > MSFT:*_VS2015x86_IA32_DLINK_FLAGS = /LIBPATH:"%VS2015_PREFIX%Lib" > > /LIBPATH:"%VS2015_PREFIX%VC\Lib" > > /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x86" > > /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x86" > > /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP > > /OPT:REF /DEBUG /MACHINE:I386 /LTCG Kernel32.lib MSVCRTD.lib Gdi32.lib > > User32.lib Winmm.lib Advapi32.lib vcruntimed.lib ucrtd.lib > > MSFT:*_VS2017_IA32_DLINK_FLAGS = > > /LIBPATH:"%VCToolsInstallDir%lib\x86" > > /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x86" > > /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x86" > > /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP > > /OPT:REF /DEBUG /MACHINE:I386 /LTCG Kernel32.lib MSVCRTD.lib > > vcruntimed.lib ucrtd.lib Gdi32.lib User32.lib Winmm.lib Advapi32.lib+ > > MSFT:*_VS2019_IA32_DLINK_FLAGS = > > /LIBPATH:"%VCToolsInstallDir%lib\x86" > > /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x86" > > /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x86" > > /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP > > /OPT:REF /DEBUG /MACHINE:I386 /LTCG Kernel32.lib MSVCRTD.lib > > vcruntimed.lib ucrtd.lib Gdi32.lib User32.lib Winmm.lib Advapi32.lib > > MSFT:*_*_IA32_ASM_FLAGS == /nologo /W3 /WX /c /coff /Cx /Zd /W0 > > /Zi MSFT:*_*_IA32_ASMLINK_FLAGS == /link /nologo /tiny > > MSFT:*_VS2015_X64_DLINK_FLAGS = > > /LIBPATH:"%VS2015_PREFIX%VC\Lib\AMD64" > > /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x64" > > /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x64" > > /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP > > /OPT:REF /DEBUG /MACHINE:AMD64 /LTCG Kernel32.lib MSVCRTD.lib > > vcruntimed.lib ucrtd.lib Gdi32.lib User32.lib Winmm.lib Advapi32.lib > > MSFT:*_VS2015x86_X64_DLINK_FLAGS = > > /LIBPATH:"%VS2015_PREFIX%VC\Lib\AMD64" > > /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x64" > > /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x64" > > /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP > > /OPT:REF /DEBUG /MACHINE:AMD64 /LTCG Kernel32.lib MSVCRTD.lib > > vcruntimed.lib ucrtd.lib Gdi32.lib User32.lib Winmm.lib Advapi32.lib > > MSFT:*_VS2017_X64_DLINK_FLAGS = > > /LIBPATH:"%VCToolsInstallDir%lib\x64" > > /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x64" > > /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x64" > > /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP > > /OPT:REF /DEBUG /MACHINE:AMD64 /LTCG Kernel32.lib MSVCRTD.lib > > vcruntimed.lib ucrtd.lib Gdi32.lib User32.lib Winmm.lib Advapi32.lib+ > > MSFT:*_VS2019_X64_DLINK_FLAGS = > > /LIBPATH:"%VCToolsInstallDir%lib\x64" > > /LIBPATH:"%UniversalCRTSdkDir%lib\%UCRTVersion%\ucrt\x64" > > /LIBPATH:"%WindowsSdkDir%lib\%WindowsSDKLibVersion%\um\x64" > > /NOLOGO /SUBSYSTEM:CONSOLE /NODEFAULTLIB /IGNORE:4086 /MAP > > /OPT:REF /DEBUG /MACHINE:AMD64 /LTCG Kernel32.lib MSVCRTD.lib > > vcruntimed.lib ucrtd.lib Gdi32.lib User32.lib Winmm.lib Advapi32.lib > > MSFT:*_*_X64_ASM_FLAGS == /nologo /W3 /WX /c /Cx /Zd /W0 /Zi > > MSFT:*_*_X64_ASMLINK_FLAGS == /link /nologo -- > > 2.25.1.windows.1 > > > > > > -=-=-=-=-=-= > > Groups.io Links: You receive all messages sent to this group. > > > > View/Reply Online (#56049): https://edk2.groups.io/g/devel/message/56049 > > Mute This Topic: https://groups.io/mt/72093907/4399222 > > Group Owner: devel+ow...@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [guomin.ji...@intel.com] -=-=-=-=-=-= >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57058): https://edk2.groups.io/g/devel/message/57058 Mute This Topic: https://groups.io/mt/72093907/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
