Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Library is static interface. Protocol is dynamic interface. That is key difference. My understanding for a *private protocol* is that: one module in the package to produce. The other module in the same packet to consume. Both are at runtime. That brings zero impact to other module. It is not th

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Jiewen, In my opinion it's NOT a provide protocol, although it's placed in the private include folder. The intention of this protocol, the crypto DXE driver who produces it, and the set of PEI/Runtime/SMM BaseCryptoLib instances who consume it, is to support the modulization update of crypto serv

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Siyuan If you are just talking *private interface*, it is OK. My concern is raised, when you say: we cannot change a private protocol. That means, we have to keep the ugly interface forever. :-( I am feeling there is some wrong fundamentally. My believe is: If it is private, we can change

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Jiewen, I agree "abstract action not algorithm" is a good design principle, but I'm not sure If there is any plan to move this protocol to the public include so far. For this patch set, my feeling is it should at least do not modify the existing protocol definition, so the modulization update ca

Re: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP

Add commets in your original message > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Yau > Sent: Friday, March 20, 2020 11:42 AM > To: devel@edk2.groups.io > Cc: Yau, KaiX > Subject: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR > di

Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table

Acked-by: Jiewen Yao I cannot remember if there is windows OS still using the properties table. Maybe Microsoft people can comment. If no, I agree we can remove the old code. > -Original Message- > From: Ard Biesheuvel > Sent: Thursday, March 26, 2020 6:25 PM > To: devel@edk2.groups.

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Thanks Siyun. I think probably we need discuss this more. 1) About private v.s. public. The benefit for private include is to isolate external interface and internal interface. A package can keep updating its private interface without impact any other packages. However, in this case, a private

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 10/11] MdePkg/DxeServicesLib: Add RISC-V architecture

Reviewed-by: Liming Gao -Original Message- From: Abner Chang Sent: 2020年3月6日 13:36 To: devel@edk2.groups.io Cc: abner.ch...@hpe.com; Gilbert Chen ; Leif Lindholm ; Kinney, Michael D ; Gao, Liming Subject: [edk2/master PATCH RISC-V CI Code Changes v1 10/11] MdePkg/DxeServicesLib: Add

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 02/11] FmpDevicePkg: Add RISC-V architecture for EDK2 CI.

Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Abner Chang Sent: 2020年3月6日 13:36 To: devel@edk2.groups.io Cc: abner.ch...@hpe.com; Gao, Liming ; Kinney, Michael D ; Leif Lindholm ; Gilbert Chen ; Daniel Schaefer Subject: [edk2-devel] [edk2/master PA

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Hi, Jiewen Although the protocol is private, a corresponding BaseCryptoLib instance is not private, like PeiCryptLib.inf, RuntimeCryptLib, etc. These library instances will be static linked to the consumer driver, for example an iSCSI network driver. So actually it's not a "private" change inside

[edk2-devel] [PATCH] EmulatorPkg/WinHost: Enable network support.

Follow the implementation from Unix host to implement SNP EMU_IO_THUNK_PROTOCOL and EMU_SNP_PROTOCOL. The network IO driver is the same one as Nt32. Please refer to NETWORK-IO Subproject for network Io driver(SnpNt32Io.dll). Signed-off-by: Nickle Wang Signed-off-by: Derek Lin --- EmulatorPkg/Em

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

EDKII_CRYPTO_PROTOCOL is *private*. https://github.com/tianocore/edk2/blob/master/CryptoPkg/Private/Protocol/Crypto.h Why we cannot change? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Siyuan, Fu > Sent: Friday, March 27, 2020 10:47 AM > To: Gao, Zhichao ; devel@edk2.

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Sorry for the mess. I used to view all the dsc as platform side. I would update security pkg as well. Thanks, Zhichao > -Original Message- > From: Yao, Jiewen > Sent: Friday, March 27, 2020 10:51 AM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX > ; Maciej Rab

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

> -Original Message- > From: Yao, Jiewen > Sent: Friday, March 27, 2020 10:21 AM > To: devel@edk2.groups.io; Yao, Jiewen ; Gao, > Zhichao > Cc: Wang, Jian J ; Lu, XiaoyuX > ; Maciej Rabeda ; > Wu, Jiaxin ; Fu, Siyuan > Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the depreca

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

The SHA1 is called explicitly in SecurityPkg. Are you sure we don't need update security pkg? > -Original Message- > From: Gao, Zhichao > Sent: Friday, March 27, 2020 10:44 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Maciej Rabeda ; Wu, Jiaxin > ; Fu,

Re: [edk2-devel] [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

So even though the scope for right now is to build the package only, since these are platforms I think they would better align with a platform build pipeline rather than the stuart_ci_build pipeline. Basically we would setup a new pipeline that builds each platform. To start they can just bui

Re: [edk2-devel] [PATCH 8/8] CryptoPkg/BaseCryptLib: Use Pcd to control the SHA1 enablement

Zhichao, You can just use the PCD in C code "if (PcdGet...){}" instead of macro #if. Regards, Jian > -Original Message- > From: Gao, Zhichao > Sent: Friday, March 27, 2020 10:44 AM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX > Subject: RE: [edk2-deve

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Hi, Zhichao We should never move/delete a member field of a previous defined protocol Interface. Instead, these protocol APIs shall be kept and return an error code If the function is retired. Otherwise the consumer driver may call into an Incorrect function if it's build with different codebase/P

Re: [edk2-devel] [PATCH 8/8] CryptoPkg/BaseCryptLib: Use Pcd to control the SHA1 enablement

Hi Mike, It is better to not compile the deprecated function, i.e. disable the function at build time. Is there another way to disable the function at build time except the #if statement? Thanks, Zhichao > -Original Message- > From: Kinney, Michael D > Sent: Friday, March 27, 2020 10:0

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Jiewen, Thanks for the reminder. But TPM didn't have the inc file as NetWorkPkg to set the pcd for all platform. The change for TPM1.2 should be at platform side. I would change the edk2 platform code as well once the solution is decided. Thanks, Zhichao > -Original Message- > From: Yao,

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Some other comments: 2) You may consider disable those feature in openssl build as well, such as OPENSSL_NO_MD4, OPENSSL_NO_RC4, OPENSSL_NO_DES 3) Is there any usage of HMAC_MD5 or HMAC_SHA1 ? We can remove those if no real usage and just leave HMAC_SHA256 there. > -Original Message- >

Re: [edk2-devel] [Patch V3] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

Thanks Liming. Code pushed: SHA-1: 28d572fb96cd2697d903f6a3af94f6cb76948869 Thanks, Eric > -Original Message- > From: Gao, Liming > Sent: Friday, March 27, 2020 9:56 AM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric ; Ni, > Ray > Subject: RE: [Patch V3] Features/I

Re: [edk2-devel] [PATCH 6/8] NetWorkPkg/Pcd.inc: Enable the MD5 for iSCSI

Reviewed-by: Siyuan Fu > -Original Message- > From: Gao, Zhichao > Sent: 2020年3月27日 9:56 > To: devel@edk2.groups.io > Cc: Maciej Rabeda ; Wu, Jiaxin > ; Fu, Siyuan > Subject: [PATCH 6/8] NetWorkPkg/Pcd.inc: Enable the MD5 for iSCSI > > REF: https://bugzilla.tianocore.org/show_bug.cgi?i

Re: [edk2-devel] [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

BZ 2570 request build test only. The boot functionality test can be added later. Ovmf has three combination for X86, IA32, X64 and IA32X64. Emulator has two combination IA32, and X64. Can they be supported? Thanks Liming From: Kinney, Michael D Sent: 2020年3月27日 9:59 To: Bret Barkelew ; Zhang, S

Re: [edk2-devel] [PATCH 8/8] CryptoPkg/BaseCryptLib: Use Pcd to control the SHA1 enablement

We should not use #if statements in C code. Also, we should not be changing the layout of the structure based on a PCD feature flag. I agree we need to ability to disable the use of some Crypto services, but we need to decide what behavior we want at build time and boot time if there is code tha

Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

Good feature. I believe TPM1.2 still uses SHA1. It should be added as well. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Friday, March 27, 2020 9:56 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Maciej Rabeda ; Wu, Jiaxin >

Re: [edk2-devel] [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

Bret, Yes. Let’s start with build testing. It will be good to boot the shell and run test suites like UEFI SCTs from the shell of OVMF in a CI agent, but that could be a scheduled post-commit task. Booting the shell is fast enough that we could consider it for pre-commit. Mike From: Bret B

[edk2-devel] [PATCH 3/8] CryptoPkg/BaseCryptLib: Retire the Tdes algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Tdes is not secure any longer. Remove the Tdes support from edk2. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Zhichao Gao --- CryptoPkg/Driver/Crypto.c | 221 --- CryptoPkg/Include/Library/BaseCryptLib.h

[edk2-devel] [PATCH 4/8] CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Aes Ecb mode is not secure any longer. Remove the Aes Ecb mode support from edk2. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Zhichao Gao --- CryptoPkg/Driver/Crypto.c | 78 CryptoPkg/Include/Library/B

[edk2-devel] [PATCH 5/8] CryptoPkg/dec: Add pcds to avoid building the deprecated function

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682 Md5 and SHA1 is not secure any longer but uefi spec need to keep them for backwards compatibility. Add two pcds PcdMD5Enable and PcdSHA1Enable to control the function enablement. Set the default value to false to indicate they are deprecated

[edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 MD4, AR4, Tdes, Aes Ecb mode, MD5 and SHA1 is not secure any longer. They are all deprecated. Edk2 would not support them any longer. So remove them. But uefi spec want to keep MD5 and

[edk2-devel] [PATCH 7/8] Crypto/BaseCryptLib: Using pcd to control MD5 enablement

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682 Md5 and SHA1 is not secure any longer but uefi spec need to keep them for backwards compatibility. Use pcd PcdMD5Enable to control the MD5 function enablement. When disable the MD5 functions would not be complied. Cc: Jian J Wang Cc: Xiaoy

[edk2-devel] [PATCH 1/8] CryptoPkg/BaseCrpytLib: Retire MD4 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 MD4 is not secure any longer. Remove the MD4 support from edk2. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Zhichao Gao --- CryptoPkg/Driver/Crypto.c | 165 - CryptoPkg/Include/Library/BaseCryptLib.h

[edk2-devel] [PATCH 2/8] CryptoPkg/BaseCryptLib: Retire ARC4 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 ARC4 is not secure any longer. Remove the ARC4 support from edk2. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Zhichao Gao --- CryptoPkg/Driver/Crypto.c | 153 - CryptoPkg/Include/Library/BaseCryptLib.h

[edk2-devel] [PATCH 6/8] NetWorkPkg/Pcd.inc: Enable the MD5 for iSCSI

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682 iSCSI driver required the MD5 function. Change the PcdMD5Enable to TRUE when NETWORK_ISCSI_ENABLE is TURE. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Zhichao Gao --- NetworkPkg/NetworkPcds.dsc.inc | 5 - 1 file ch

[edk2-devel] [PATCH 8/8] CryptoPkg/BaseCryptLib: Use Pcd to control the SHA1 enablement

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682 Md5 and SHA1 is not secure any longer but uefi spec need to keep them for backwards compatibility. Use pcd PcdSHA1Enable to control the SHA1 function enablement. When disable the SHA1 functions would not be complied. Cc: Jian J Wang Cc: Xi

Re: [edk2-devel] [Patch V3] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers

Reviewed-by: Liming Gao -Original Message- From: Luo, Heng Sent: 2020年3月25日 16:01 To: devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Dong, Eric ; Ni, Ray Subject: [Patch V3] Features/Intel: Add LogoFeaturePkg to provide logo images and drivers REF: https://bugzilla.tianocore.or

Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib

Reviewed-by: jiewen@intel.com > -Original Message- > From: Wang, Jian J > Sent: Thursday, March 26, 2020 3:50 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Zhang, Chao B > ; Mistry, Nishant C > Subject: [PATCH v5 0/3] Add RpmcLib and VariableKeyLib > > > v5: change VariableRootK

Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib

Michael, Good to see you "back"😊 and thanks for the review. Regards, Jian > -Original Message- > From: Michael Kubacki > Sent: Friday, March 27, 2020 1:25 AM > To: devel@edk2.groups.io; Wang, Jian J > Cc: Yao, Jiewen ; Zhang, Chao B > ; Mistry, Nishant C > Subject: Re: [edk2-devel] [P

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:sa...@elhajmahmoud.com] > Sent: Monday, March 23, 2020 12:08 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Wu, Hao A ; Leif Lindholm ; Ard > Biesheuvel > Subject: [PATCH v1

Re: [edk2-devel] [PATCH v3] MdeModulePkg/SdDxe: Check the Token to avoid null pointer

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, > Hao A > Sent: Thursday, March 26, 2020 2:51 PM > To: devel@edk2.groups.io; Jiang, Guomin > Cc: Wang, Jian J; Ni, Ray > Subject: Re: [edk2-devel] [PATCH v3] MdeModulePkg/SdDxe: Check the Token

Re: [edk2-devel] [EXTERNAL] [PATCH 3/4] MdePkg: remove PropertiesTable GUID

Reviewed-by: Bret Barkelew - Bret From: Ard Biesheuvel Sent: Thursday, March 26, 2020 3:24:42 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Laszlo Ersek ; Leif Lindholm ; Kinney, Michael D ; Ray Ni ; Jiewen Yao ; Bret Barkelew Subject: [EXTERNAL] [PATCH

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add native instruction support for IA32 and X64

During the Perlasm generation step, the script attempts to execute NASM from the user's path to see if it's an appropriate version to support AVX instructions: https://github.com/openssl/openssl/blob/OpenSSL_1_1_1-stable/crypto/sha/asm/sha512-x86_64.pl#L129 For now, we could force this check to f

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

> -Original Message- > From: Wu, Hao A > Sent: Wednesday, March 25, 2020 1:07 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Dong, Eric; Ni, Ray; Laszlo Ersek; Kinney, Michael D; Zeng, > Star; > Brian J . Johnson > Subject: [PATCH v4] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status

Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Friday, February 21, 2020 6:11 PM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [PATCH] MdeModulePkg: Remove > gEfiFormBrowserExProtocolGuid Protocol Guid > > R

Re: [edk2-devel] [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

So just clarifying, the only thing in scope right now is a simple build-test against these packages. There’s no desire to run tests within the Ovmf environment itself? - Bret From: Kinney, Michael D Sent: Thursday, March 26, 2020 5:00 PM To: Bret Barkelew

Re: [edk2-devel] [PATCH v2 14/17] OvmfPkg/PvScsiDxe: Introduce DMA communication buffer

On 27/03/2020 0:17, Laszlo Ersek wrote: On 03/25/20 17:10, Liran Alon wrote: PvScsiRestorePciAttributes (Dev); diff --git a/OvmfPkg/PvScsiDxe/PvScsi.h b/OvmfPkg/PvScsiDxe/PvScsi.h index 6d23b6e1eccf..7f91d70fec79 100644 --- a/OvmfPkg/PvScsiDxe/PvScsi.h +++ b/OvmfPkg/PvScsiDxe/PvScsi.h @@ -

Re: [edk2-devel] [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

Bret, I would like to see issues with these platforms packages caught pre-commit. If a core package change breaks one of these platforms, the we can potentially prevent an issue in many other platforms. Mike From: Bret Barkelew Sent: Thursday, March 26, 2020 4:27 PM To: Zhang, Shenglei ; dev

Re: [edk2-devel] [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

Taking a moment to look at this a different way… Is it expected at some point that we would want to run OvmfPkg-based integration tests as part of a “second-pass” automatic validation (maybe not a PR-gate, since those should be as fast as possible, but a nightly CI)? If so, I think I’d rather s

Re: [edk2-devel] [PATCH v2 17/17] OvmfPkg/PvScsiDxe: Enable device 64-bit DMA addresses

On 03/25/20 17:10, Liran Alon wrote: > Enable PCI dual-address cycle attribute to signal device > supports 64-bit DMA addresses. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Signed-off-by: Liran Alon > --- > OvmfPkg/PvScsiDxe/PvScsi.c | 23 +++ > 1 file chan

Re: [edk2-devel] [PATCH v2 14/17] OvmfPkg/PvScsiDxe: Introduce DMA communication buffer

On 03/25/20 17:10, Liran Alon wrote: > In case device is constrained by IOMMU or guest is running under AMD SEV, > input/output buffers provided to device (DataBuffer and SenseData) needs > to be explicitly mapped to device by PciIo->Map(). > > To avoid the overhead of mapping/unmapping the DataBu

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition

Reviewed-by: Prince Agyeman -Original Message- From: Desimone, Ashley E Sent: Thursday, March 26, 2020 2:26 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add mi

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition

Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Thursday, March 26, 2020 2:26 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missi

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing import definition

Add the definition of PIN_FILE_HELP to checkout_pin_args.py to fix import error. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/arguments/checkout_pin_args.py | 1 + 1 file changed, 1 insertion(+)

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

Thanks Ard and Laszlo. Leif, Dandan, Liming, Hao, any objection in merging this patch to edk2? > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, March 25, 2020 5:16 AM > To: Samer El-Haj-Mahmoud > Cc: Laszlo Ersek ; devel@edk2.groups.io; > sa...@elhajmahmoud.com; Dandan B

Re: [edk2-devel] [PATCH v2 13/17] OvmfPkg/PvScsiDxe: Setup requests and completions rings

On 03/25/20 17:10, Liran Alon wrote: > These rings are shared memory buffers between host and device in which > a cyclic buffer is managed to send request descriptors from host to > device and receive completion descriptors from device to host. > > Note that because device may be constrained by IOM

Re: [edk2-devel] [PATCH v3 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test.

On Tue, 17 Mar 2020 at 11:25, Gaurav Jain wrote: > > ASSERT in SetTime_Conf Consistency Test. > SCT Test expect return as Invalid Parameter. > So removed ASSERT(). > > Signed-off-by: Gaurav Jain Thanks Gaurav Reviewed-by: Ard Biesheuvel I will add a note to the commit log describing the other

[edk2-devel] [PATCH] [Tianocore-Docs]: EDK II Python development Process and coding standards spec

Fixing typo in Python development Process and coding standards draft spec Chapter2. Signed-off-by: Purma, Kondal R mailto:kondal.r.pu...@intel.com>> --- README.md | 9 + book.json | 2 +- python_coding_guidelines_and_tools.md | 2

Re: [edk2-devel] [PATCH v2 12/17] OvmfPkg/PvScsiDxe: Reset adapter on init

On 03/25/20 17:10, Liran Alon wrote: > The following commits will complete the implementation of > device initialization. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Signed-off-by: Liran Alon > --- > OvmfPkg/PvScsiDxe/PvScsi.c | 91 ++ > 1 f

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add native instruction support for IA32 and X64

The main issue with use of extended registers is that the default interrupt/exception handler for IA32/X64 does FXSAVE/FXRSTOR. https://github.com/tianocore/edk2/blob/5f7c91f0d72efca3b53628163861265c89306f1f/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHandlerAsm.nasm#L244 https://gith

Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib

For the series: Reviewed-by: Michael Kubacki On 3/26/2020 12:49 AM, Wang, Jian J wrote: v5: change VariableRootKey to VariableKey v4: remove CounterId which should not be exposed v3: update retval description in RpmcLib.h and RpmcLibNull.c v2: change CounterIndex to CounterId in RpmcL

Re: [edk2-devel] [PATCH v2 11/17] OvmfPkg/PvScsiDxe: Define device interface structures and constants

On 03/25/20 17:09, Liran Alon wrote: > These definitions will be used by the following commits to complete the > implementation of PVSCSI device driver. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Signed-off-by: Liran Alon > --- > OvmfPkg/Include/IndustryStandard/PvScsi.h | 16

Re: [edk2-devel] [PATCH v2 10/17] OvmfPkg/PvScsiDxe: Enable MMIO-Space & Bus-Mastering in PCI attributes

On 03/25/20 17:09, Liran Alon wrote: > Enable MMIO-Space & Bus-Mastering PCI attributes when device is started. > Note that original PCI attributes are restored when device is stopped. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Signed-off-by: Liran Alon > --- > OvmfPkg/PvScsi

[edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi4/ConfigDxe: Replace SD Host with eMMC2 SDHCI option

From: Andrei Warkentin SD Host is not usable on Pi 4 so replace it with an eMMC2 option. Note that is a menu only change at this stage, since we don't have eMMC support finalized. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni | 1 + Platform/RaspberryP

Re: [edk2-devel] [PATCH v2 09/17] OvmfPkg/PvScsiDxe: Backup/Restore PCI attributes on Init/UnInit

On 03/25/20 17:09, Liran Alon wrote: > This commit doesn't change semantics. > It is done as a preparation for future commits which will modify > PCI attributes. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Signed-off-by: Liran Alon > --- > OvmfPkg/PvScsiDxe/PvScsi.c | 54 +

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Add Static PPTT tables

On Thu, 26 Mar 2020 at 17:41, Pete Batard wrote: > > On 2020.03.26 16:36, Ard Biesheuvel wrote: > > On Thu, 26 Mar 2020 at 17:30, Pete Batard wrote: > >> > >> From: Jeremy Linton > >> > >> ACPI 6.2 adds a new table, which describes how processing units > >> are related to each other in tree like

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Add Static PPTT tables

On 2020.03.26 16:36, Ard Biesheuvel wrote: On Thu, 26 Mar 2020 at 17:30, Pete Batard wrote: From: Jeremy Linton ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the prope

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Add Static PPTT tables

On Thu, 26 Mar 2020 at 17:30, Pete Batard wrote: > > From: Jeremy Linton > > ACPI 6.2 adds a new table, which describes how processing units > are related to each other in tree like fashion. Caches are > also sprinkled throughout the tree and describe the properties > of the caches in relation to

[edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Add Static PPTT tables

From: Jeremy Linton ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the properties of the caches in relation to other caches and processing units. Add a static PPTT table wi

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Update FADT generator to ACPI 6.3

Reviewed by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56406): https://edk2.groups.io/g/devel/message/56406 Mute This Topic: https://groups.io/mt/61090538/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid

Hi Jian, Hao, Could you please help review the change. Thanks Original message From: "GuoMinJ via Groups.Io" mailto:newexplorerj=gmail@groups.io>> Date: Fri, Feb 21, 2020, 6:10 PM To: devel@edk2.groups.io Cc: GuoMinJ mailto:newexplor...@gmail.co

Re: [edk2-devel] [PATCH v2 01/17] OvmfPkg/PvScsiDxe: Create empty driver

On 03/25/20 17:09, Liran Alon wrote: > In preparation for support booting from PvScsi devices, create a > basic scaffolding for a driver. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567 > Signed-off-by: Liran Alon > --- > OvmfPkg/OvmfPkgIa32.dsc | 8 > OvmfPkg/Ovmf

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

It is a good idea, I have a question: 1. When can detect the jumper signal or register? 2. If the jumper use GPIO, SerialUartClockLib will depend on GpioLib? 3. If the register is inside SIO, how to dispose the dependence? If it is too complex to implement the SerialUartClockLib, the project owne

Re: [edk2-devel] [edk2-platforms][PATCH 0/6] Platforms/RPi/AcpiTables: ACPI platform improvements

On Thu, 26 Mar 2020 at 12:53, Pete Batard wrote: > > This patchset brings additional cleanup and improvements to the factorized > ACPI table generation for the Pi platform by: > > * Updating the Pi 4 interrupts we know of to their proper values. > * Removing VendorLong () sections in the ASL data

Re: [edk2-devel] [PATCH v2 00/28] Add PEI phase to LS1043ARDB Platform

Pankaj, Please Cc Ard on Arm platform patches Leif, Any help in reviewing this big series is appreciated. Thanks, --Samer > -Original Message- > From: Pankaj Bansal > Sent: Friday, March 20, 2020 10:35 AM > To: Leif Lindholm ; Meenakshi Aggarwal > (meenakshi.aggar...@nxp.com) ; Michae

[edk2-devel] [edk2-platforms][PATCH 2/6] Platform/RPi/AcpiTables: Replace VendorLong () blobs with PinFunction ()

From: Andrei Warkentin Per https://github.com/MicrosoftDocs/windows-uwp/issues/1751, MsftFunctionConfig () calls can be replaced by PinFunction () calls. Since these had been converted to VendorLong () blobs due to lack of implementation of MsftFunctionConfig (), we replace them back now that Pi

[edk2-devel] [edk2-platforms][PATCH 1/6] Platform/RPi/AcpiTables: Fix Pi 4 interrupts values

Some of the Pi 4 interrupts were copied from Pi 3 and are incorrect. We fix the ones that can be found by decompiling the official .dtbs. We also add a couple more GPIO interrupts, that are used for both the Pi 3 and the Pi 4, as per the dtbs. Signed-off-by: Pete Batard --- Platform/RaspberryPi/

[edk2-devel] [edk2-platforms][PATCH 4/6] Platform/RPi/AcpiTables: Clean up ACPI IDs

Only apply the "BC2836" override to the one table that needs it for Pi 3, instead of setting it globally. Use more appropriate OEM and Vendor IDs for hardware that is produced by the Raspberry Pi Foundation. Ensure that the Pi 3 and Pi 4 have different OEM IDs. Additionally fix a comment typo (MEMO

[edk2-devel] [edk2-platforms][PATCH 5/6] Platform/RPi/AcpiTables: Move GPU devices into a separate ASL file

From: Andrei Warkentin In order to describe the DMA constraints of legacy devices behind the Raspberry Pi GPU/VideoCore, we move them into their own separate ASL file. This is a straight copy of the existing content from Dsdt.asl, with no alteration, so that the changes applied in the next patch

[edk2-devel] [edk2-platforms][PATCH 6/6] Platform/RPi/AcpiTables: Describe DMA constraints for devices behind GPU

From: Andrei Warkentin Legacy devices on a Raspberry Pi sit behind GPU/VideoCore and can only address the first GB of RAM. This address range of 0xc000-0x requires a translation, since it is aliased to the first GB of memory 0x-0x3fff, which is what this commit accomplish

[edk2-devel] [edk2-platforms][PATCH 3/6] Platform/RPi/AcpiTables: Use PCDs in MADT

Instead of going through a model #ifdef, the call to EFI_ACPI_5_1_GICC_STRUCTURE_INIT () is factorized by setting up a new set of PCDs. Signed-off-by: Pete Batard --- Platform/RaspberryPi/AcpiTables/AcpiTables.inf | 8 + Platform/RaspberryPi/AcpiTables/Madt.aslc | 31 --

[edk2-devel] [edk2-platforms][PATCH 0/6] Platforms/RPi/AcpiTables: ACPI platform improvements

This patchset brings additional cleanup and improvements to the factorized ACPI table generation for the Pi platform by: * Updating the Pi 4 interrupts we know of to their proper values. * Removing VendorLong () sections in the ASL data we inherited from Microsoft. * Improving MADT factorization t

Re: [edk2-devel] [PATCH v3 0/3] ArmPkg/ArmMmuLib AARCH64: correctness fix

On Wed, 25 Mar 2020 at 20:49, Laszlo Ersek wrote: > > On 03/25/20 16:29, Ard Biesheuvel wrote: > > The new ArmMmuLib code is easier to reason about, so that is what I did: > > currently, when we create mappings that cover existing table entries, we > > may end up overwriting those with block entri

Re: [edk2-devel] [PATCH v3 1/3] ArmPkg/ArmMmuLib AARCH64: limit recursion when freeing page tables

On Thu, 26 Mar 2020 at 11:22, Leif Lindholm wrote: > > On Wed, Mar 25, 2020 at 16:29:38 +0100, Ard Biesheuvel wrote: > > FreePageTablesRecursive () traverses the page table tree depth first > > to free all pages that it finds, without taking into account the > > level at which it is operating. > >

[edk2-devel] [PATCH 0/4] remove generation of EFI properties table

The EFI properties table is broken by design, deprecated, and seems to be causing confusion as it is unclear to some how it differs from the memory attributes table (which supersedes it). So let's get rid of the code that generates it entirely, along with the GUID definitions, PCDs etc. Due to how

[edk2-devel] [PATCH 1/4] OvmfPkg: remove handling of properties table

The UEFI properties table and the associated memory protection feature was severely broken from the start, and has been deprecated for a while. Let's drop all references to it from OVMF so we can safely remove it from the DXE core as well. Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633

[edk2-devel] [PATCH 4/4] MdeModulePkg/DxeCore: merge properties table routines into MAT handling

The memory attributes table handling code shared some parts of the properties table handling code when it was introduced. The latter has been dropped, and so we can merge the remaining pieces into the former. Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633 Signed-off-by: Ard Biesheuvel

[edk2-devel] [PATCH 2/4] MdeModulePkg: disable properties table generation but retain the code

This is the minimal change required to stop exposing the EFI properties table, which is deprecated. Given how the implementation is entangled with the code that exposes the related memory attributes table, most of the code is retained, and further cleanups are relegated to subsequent patches. Link

[edk2-devel] [PATCH 3/4] MdePkg: remove PropertiesTable GUID

Remove the GUID definition that describes the deprecated properties table, which is no longer generated by the DXE core. Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633 Signed-off-by: Ard Biesheuvel --- MdePkg/Include/Guid/PropertiesTable.h | 31 MdePkg/MdePkg.dec

Re: [edk2-devel] [PATCH v3 1/3] ArmPkg/ArmMmuLib AARCH64: limit recursion when freeing page tables

On Wed, Mar 25, 2020 at 16:29:38 +0100, Ard Biesheuvel wrote: > FreePageTablesRecursive () traverses the page table tree depth first > to free all pages that it finds, without taking into account the > level at which it is operating. > > Since TT_TYPE_TABLE_ENTRY aliases TT_TYPE_BLOCK_ENTRY_LEVEL3

Re: [edk2-devel] [PATCH V6] BaseTools:GuidedSectionTools.txt is not generated correctly

Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, March 26, 2020 5:48 PM To: devel@edk2.groups.io Cc: Fan, ZhijuX ; Gao, Liming ; Feng, Bob C Subject: [PATCH V6] BaseTools:GuidedSectionTools.txt is not generated correctly REF:https://bugzilla.tianocore.org/sho

[edk2-devel] [PATCH V6] BaseTools:GuidedSectionTools.txt is not generated correctly

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2538 For LzmaCompress or BrotliCompress, the platform may use the different options and add their batch file, such as LzmaCompressPlatform. Then, specify it in platform.dsc [BuildOptions] to override the default one in tools_def.txt. *_*_*_LZMA_P

Re: [edk2-devel] [PATCH V5] BaseTools:GuidedSectionTools.txt is not generated correctly

Zhiju, I have 2 comments on the code style. Inline. On Thu, Mar 26, 2020 at 03:57 PM, Fan, ZhijuX wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2538 > > For LzmaCompress or BrotliCompress, the platform may use the different > options and add their batch file, such as LzmaCompr

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

Hi Mike, > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, March 26, 2020 4:43 PM > To: edk2-devel-groups-io ; Zhang, Shenglei > ; Laszlo Ersek > Cc: Sean Brogan ; Bret Barkelew > ; Kinney, Michael D > ; Gao, Liming > Subject: Re: [edk2-deve

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

(+ Laszlo) On Thu, 26 Mar 2020 at 08:04, Zhang, Shenglei wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2570 > OvmfPkg and EmulatorPkg are mostly used by the developers, so add > them to target list. > > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Ga

Re: [edk2-devel] [PATCH] ArmVirtPkg/PlatformPeiLib: add dummy assignment to work around older GCC

On Wed, 25 Mar 2020 at 20:11, Laszlo Ersek wrote: > > On 03/25/20 10:33, Ard Biesheuvel wrote: > > Older GCC (<= 4.9) fail to infer that Parent is never used unless it > > has been assigned before, and may throw an error like > > > > /work/git/edk2/ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLi

Re: [edk2-devel] [PATCH] OvmfPkg/X86QemuLoadImageLib: add dummy assignment to work around GCC

On Wed, 25 Mar 2020 at 20:08, Laszlo Ersek wrote: > > On 03/25/20 10:12, Ard Biesheuvel wrote: > > GCC 4.8 or 4.9 may throw the following error when building OVMF: > > > > Edk2/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c: > > In function ‘QemuLoadKernelImage’: > > Edk2/Ovmf

Re: [edk2-devel] [PATCH] CryptoPkg: Check the type is data and Support other OID types.

Guomin, Please use edk2 coding style of symbol name and data type as possible as you can in “our” code. Regards, Jian From: guomin jiang Sent: Thursday, March 26, 2020 3:47 PM To: devel@edk2.groups.io Cc: Wang, Jian J ; Lu, XiaoyuX Subject: Re:[edk2-devel] [PATCH] CryptoPkg: Check the type is

[edk2-devel] [PATCH V5] BaseTools:GuidedSectionTools.txt is not generated correctly

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2538 For LzmaCompress or BrotliCompress, the platform may use the different options and add their batch file, such as LzmaCompressPlatform. Then, specify it in platform.dsc [BuildOptions] to override the default one in tools_def.txt. *_*_*_LZMA_P

Re: [EXTERNAL] Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

Currently not necessary unless you have host-based tests in those packages, but it doesn’t hurt. - Bret From: Rebecca Cran Sent: Thursday, March 26, 2020 12:11:06 AM To: devel@edk2.groups.io ; shenglei.zh...@intel.com Cc: Sean Brogan ; Bret Barkelew ; Kinney,

  1   2   >