Michael, Good to see you "back"😊 and thanks for the review.
Regards, Jian > -----Original Message----- > From: Michael Kubacki <michael.kuba...@outlook.com> > Sent: Friday, March 27, 2020 1:25 AM > To: devel@edk2.groups.io; Wang, Jian J <jian.j.w...@intel.com> > Cc: Yao, Jiewen <jiewen....@intel.com>; Zhang, Chao B > <chao.b.zh...@intel.com>; Mistry, Nishant C <nishant.c.mis...@intel.com> > Subject: Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib > > For the series: > > Reviewed-by: Michael Kubacki <michael.kuba...@microsoft.com> > > On 3/26/2020 12:49 AM, Wang, Jian J wrote: > >> v5: change VariableRootKey to VariableKey > > > >> v4: remove CounterId which should not be exposed > > > >> v3: update retval description in RpmcLib.h and RpmcLibNull.c > > > >> v2: change CounterIndex to CounterId in RpmcLib prototype. > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 > > > > Patch branch: https://github.com/jwang36/edk2/tree/bz2594-part1-common- > interfaces-between-platform-and-edk2-v5 > > > > > > > > Cc: Jiewen Yao <jiewen....@intel.com> > > > > Cc: Chao Zhang <chao.b.zh...@intel.com> > > > > Cc: Nishant C Mistry <nishant.c.mis...@intel.com> > > > > Jian J Wang (3): > > SecurityPkg: add RpmcLib and VariableKeyLib public headers > > SecurityPkg: add null version of RpmcLib > > SecurityPkg: add null version of VariableKeyLib > > > > SecurityPkg/Include/Library/RpmcLib.h | 42 ++++++++++++ > > SecurityPkg/Include/Library/VariableKeyLib.h | 59 ++++++++++++++++ > > SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++ > > .../Library/RpmcLibNull/RpmcLibNull.inf | 33 +++++++++ > > .../VariableKeyLibNull/VariableKeyLibNull.c | 67 +++++++++++++++++++ > > .../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++ > > SecurityPkg/SecurityPkg.dec | 8 +++ > > SecurityPkg/SecurityPkg.dsc | 8 +++ > > 8 files changed, 297 insertions(+) > > create mode 100644 SecurityPkg/Include/Library/RpmcLib.h > > create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h > > create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > > create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf > > create mode 100644 > SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c > > create mode 100644 > SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56437): https://edk2.groups.io/g/devel/message/56437 Mute This Topic: https://groups.io/mt/72559442/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
