Vitaly,
Sorry after I sent the mail I realized it may come across as me asking you to
do work and that was not my intent.
I will point out though that a non backward compatible change to something as
fundamental as the DebugLib is a very big deal. I've got a few different custom
implementati
Hi Andrew,
While your suggestions look interesting, I am afraid they are not particularly
what we want to cover with this discussion at the moment.
Making assertions go through DEBUG printing functions/macros is what we have to
strongly disagree about. Assertions and debug prints are separate t
Jim,
Sorry I forgot to hit send on this
We have scripts that run under OS and the EFI Shell that we use for debugging.
So like Python in the OS you can just type the name of the script and it works,
so folks expect the same behavior at the EFI shell :).
Also as I mentioned in our case the
This patch implements the fixes and enhancement to BaseHashApiLib in
the following manner:
- Remove reference to MD4 and MD5 hashing algorithms as they are
deprecated;
- Align the enumeration for hashing algorithmswith the one used in
TPM 2.0 implementation defined in IndustryStandard/Tpm20.h;
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511
This commit changes the PCD PcdHashApiLibPolicy to the type
PcdsFixedAtBuild so as to be able to optimize away the unused hashing
algorithms in HashApiLib instance used by a driver.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Michael D Kinney
Sig
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511
This commit aligns the baseHashApiLib with TPM 2.0 Implementation
as follows:
- Remove reference to MD4 and MD5 algorithms as they are deprecated
- Align the enumerations for hashing algoerithms with the one used
in TPM 2.0 implementation
Yes. That is correct.
Mike
> -Original Message-
> From: Sukerkar, Amol N
> Sent: Friday, February 14, 2020 4:12 PM
> To: Kinney, Michael D ;
> devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J
> ; Agrawal, Sachin
> ; Gao, Liming
> ; Sukerkar, Amol N
>
> Subject: RE: [edk2-devel] [P
Hi Mike,
Although the values were listed in 8-digit hex format, the PCD,
PcdHashApiLibPolicy itself was of type UINT8 earlier that was changed to
UINT16. I agree changing the type to UINT32 will align with all the other PCDs
implementing TCG spec (and using Tpm20.h defines). Can you confirm my
Amol,
Thanks for the quick update.
I see you changed the PCD to type UINT16. I think this was
based on Jiewen feedback to use a set of TPM specific
algorithms defines that were UINT16.
However, the HASH define values being used are 32-bits
and everywhere else that those defines values are used
> On Feb 14, 2020, at 2:50 PM, Michael D Kinney
> wrote:
>
> Hi Vitaly,
>
> I agree that this proposal makes a lot of sense. We recently added a new
> assert type called STATIC_ASSERT() for assert conditions that can be tested
> at build time.
>
> A new assert type for checks that can be re
On Fri, Feb 14, 2020 at 02:14 PM, Laszlo Ersek wrote:
>
> I think Bugzilla tickets are the best place to capture the focused
> analysis of a bug. I write a *lot* of text in Red Hat bugzillas (most of
> them are public, luckily!) -- I want to document my own "adventure" with
> the issue, even if m
Hi Mike,
Addressed all the comments and sent newer version of patch.
Thanks,
Amol
-Original Message-
From: Kinney, Michael D
Sent: Friday, February 14, 2020 3:38 PM
To: Sukerkar, Amol N ; devel@edk2.groups.io; Kinney,
Michael D
Cc: Yao, Jiewen ; Wang, Jian J ;
Agrawal, Sachin ; Gao,
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511
This commit aligns the baseHashApiLib with TPM 2.0 Implementation
as follows:
- Remove reference to MD4 and MD5 algorithms as they are deprecated
- Align the enumerations for hashing algoerithms with the one used
in TPM 2.0 implementation
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511
This commit changes the PCD PcdHashApiLibPolicy to the type
PcdsFixedAtBuild so as to be able to optimize away the unused hashing
algorithms in HashApiLib instance used by a driver.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Michael D Kinney
Sig
This patch implements the fixes and enhancement to BaseHashApiLib in
the following manner:
- Remove reference to MD4 and MD5 hashing algorithms as they are
deprecated;
- Align the enumeration for hashing algorithmswith the one used in
TPM 2.0 implementation defined in IndustryStandard/Tpm20.h;
Siyuan,
If the FIT is not valid, then the API should just return
an error without ASSERT(). Not all system support FIT or
fill in FIT. The code is more generic if it just does
the check and returns an error.
The check looks incomplete to me. We know that max physical
address of the CPU from th
Michael,
The suggested changes make sense to me. I will prepare the patch in the next
days. I guess the only question left is whether disabling assertions also
disables constraint assertions. I think this should be the case for backwards
compatibility, despite being slightly unintuitive.
Best,
Hi Vitaly,
I agree that this proposal makes a lot of sense. We recently added a new
assert type called STATIC_ASSERT() for assert conditions that can be tested at
build time.
A new assert type for checks that can be removed and the API still guarantees
that it fails gracefully with a proper r
Amol,
One additional comment.
You added #include to the
HashApiLib.h class. The public APIs do not depend on
any definitions from so this
line should ne removed from CryptoPkg/Include/Library/HashApiLib.h.
Instead, #include should
be added to the BaseHashApiLib implementation in
the file C
Amol,
Comments included below.
Mike
> -Original Message-
> From: Sukerkar, Amol N
> Sent: Friday, February 14, 2020 10:06 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ;
> Yao, Jiewen ; Wang, Jian J
> ; Agrawal, Sachin
> ; Gao, Liming
>
> Subject: [PATCH v2 1/2] CryptoPkg/BaseH
Amol,
Comments included below.
Mike
> -Original Message-
> From: Sukerkar, Amol N
> Sent: Friday, February 14, 2020 10:06 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ;
> Yao, Jiewen ; Wang, Jian J
> ; Agrawal, Sachin
> ; Gao, Liming
>
> Subject: [PATCH v2 2/2] CryptoPkg/BaseH
On 02/14/20 19:50, Rebecca Cran wrote:
> On 2/14/20 11:25 AM, Sean via Groups.Io wrote:
>
>>
>> 3. Discussions: I wanted to know if anyone has experience with user
>> forums like https://www.discourse.org/. Again the rust community uses
>> this and it is a pretty nice interface for async communic
On 02/14/20 19:25, Sean via Groups.Io wrote:
> Soumya,
> I would like to add three things to community discussions especially around
> governance and process.
>
> 1. RFC: The RFC process seems to get only minimal comments and a lot gets
> lost in the noise of the lists. There isn't a good "fina
On 02/14/20 16:05, Ard Biesheuvel wrote:
> On Fri, 14 Feb 2020 at 15:45, Laszlo Ersek wrote:
>> (5) Can you please explain how EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL
>> relates to Secure Boot and/or Trusted Boot?
>>
>> (5a) Is the ".compat" section included in the image hashing?
>>
>
> Yes.
>
>>
Hi Marc-André,
On 02/13/20 14:12, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Enable TcgPei & TcgDxe modules to initialize a TPM 1.2 device and
> measure boot environment.
>
> Tpm12RequestUseTpm() returns success on any TPM interface, including
> FIFO & CRB which are TPM 2.
Liming --
Is there any plan to list all of the security fixes related CVEs that are
being checked in to the list of official features for this stable tag? We
have listed the Boot Guard one.
Thanks,
Tim Lewis
CTO, Insyde Software
www.insyde.com
-Original Message-
From: annou...@edk2.group
On 2/14/20 11:25 AM, Sean via Groups.Io wrote:
3. Discussions: I wanted to know if anyone has experience with user
forums like https://www.discourse.org/. Again the rust community uses
this and it is a pretty nice interface for async communication that
doesn't involve mail server and client
Soumya,
I would like to add three things to community discussions especially around
governance and process.
1. RFC: The RFC process seems to get only minimal comments and a lot gets lost
in the noise of the lists. There isn't a good "final" state where all approved
RFCs can be seen. The proce
On 02/13/20 14:12, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> A following patch is going to use the same configuration for TPM1.2
> and TPM2.0, and it's simpler to support both than variable
> configurations.
>
> Signed-off-by: Marc-André Lureau
> ---
> OvmfPkg/OvmfPkgIa3
This patch implements the fixes and enhancement to BaseHashApiLib in
the following manner:
- Remove reference to MD4 and MD5 hashing algorithms as they are
deprecated;
- Align the enumeration for hashing algorithmswith the one used in
TPM 2.0 implementation defined in IndustryStandard/Tpm20.h;
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511
This commit changes the PCD PcdHashApiLibPolicy to the type
PcdsFixedAtBuild so as to be able to optimize away the unused hashing
algorithms in HashApiLib instance used by a driver.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Michael D Kinney
Sig
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511
This commit aligns the baseHashApiLib with TPM 2.0 Implementation
as follows:
- Remove reference to MD4 and MD5 algorithms as they are deprecated
- Align the enumerations for hashing algoerithms with the one used
in TPM 2.0 implementation
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511
This commit changes the PCD PcdHashApiLibPolicy to the type
PcdsFixedAtBuild so as to be able to optimize away the unused hashing
algorithms in HashApiLib instance used by a driver.
Cc: Jiewen Yao
Cc: Michael D Kinney
Signed-off-by: Amol
This patch implements the fixes and enhancement to BaseHashApiLib in
the following manner:
- Remove reference to MD4 and MD5 hashing algorithms as they are
deprecated;
- Align the enumeration for hashing algorithmswith the one used in
TPM 2.0 implementation defined in IndustryStandard/Tpm20.h;
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511
This commit aligns the baseHashApiLib with TPM 2.0 Implementation
as follows:
- Remove reference to MD4 and MD5 algorithms as they are deprecated
- Align the enumerations for hashing algoerithms with the one used
in TPM 2.0 implementation
On 2/13/20 6:42 PM, Dong, Eric wrote:
> Hi Tom,
>
> For this patch, I found the function implementations not have function header
> comments for them. This is not follow edk2 coding style, please update them.
Yup, missed them, will do.
Thanks,
Tom
>
> Thanks,
> Eric
>
> -Original Message
Michael,
Generalising the approach makes good sense to me, but we need to make an
obvious distinguishable difference between:
- precondition and invariant assertions (i.e. assertions, where function will
NOT work if they are violated)
- constraint asserts (i.e. assertions, which allow us to spot
Hi Felix,
Try building with VS2015. There's a known issue with VS2017 builds as
documented here https://bugzilla.tianocore.org/show_bug.cgi?id=2408
Thanks
Prince
From: devel@edk2.groups.io On Behalf Of Felix Polyudov
Sent: Friday, February 14, 2020 8:01 AM
To: Agyeman, Prince ; devel@edk2.gro
Vitaly,
I want to make sure a feature PCD can be used to disable ASSERT() behavior in
more than just safe string functions in BaseLib.
Can we consider changing the name and description of
PcdAssertOnSafeStringConstraints to be more generic, so if we find other lib
APIs, the name will make sens
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2527
One BIOS image may have more than FVs with SEC module.
FCE tool should find the latest FV with SEC module as BFV image.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yunhua Feng
---
BaseTools/Source/C/BfmLib/BinFileManager.c | 11 +
This is the UEFI counterpart to my Linux series [0] which generalizes
mixed mode support into a feature that requires very little internal
knowledge about the architecture specifics of booting Linux on the
part of the bootloader or firmware.
Instead, we add a .compat PE/COFF section containing an
Hi Andrew,
On 02/14/20 04:11, Andrew Fish via Groups.Io wrote:
> I'm trying to understand the constraints around the value used with
> MEMFD_BASE_ADDRESS?
>
> The reason I'm asking is I've been asked to remove firmware from using lower
> memory addresses in the low 0x80 range as it is takin
On 02/14/20 01:40, Zurcher, Christopher J wrote:
> This prevents the .inf files from being randomized after every run
> of process_files.pl.
>
> Cc: Jian J Wang
> Cc: Xiaoyu Lu
> Signed-off-by: Christopher J Zurcher
> ---
> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 66 ++-
I'm using the latest version for all the repositories:
ed2 : f1d78c489a399
edk2-platofrms: 41c1d9ba33046637e
edk2-non-osi: c10580aea501ee
FSP : e6177bb3bb57747d
I'm building the project using command "build_bios.py -p WhiskeylakeURvp -t
VS2017 -r"
Her
Leif,
>The process does not in fact change the UEFI bylaws - the change is that the
>development (of both specification and code) happens in the open. The resulting
>specification update is then submitted to the appropriate working goup as an
>Engineering Change Request (ECR), and voted on. For th
On Fri, 14 Feb 2020 at 15:45, Laszlo Ersek wrote:
>
> On 02/14/20 12:41, Ard Biesheuvel wrote:
> > This is the UEFI counterpart to my Linux series [0] which generalizes
> > mixed mode support into a feature that requires very little internal
> > knowledge about the architecture specifics of bootin
On Fri, 14 Feb 2020 at 15:17, Laszlo Ersek wrote:
>
> On 02/14/20 01:55, Ni, Ray wrote:
> >
> >
> >> -Original Message-
> >> From: Laszlo Ersek
> >> Sent: Friday, February 14, 2020 7:15 AM
> >> To: Ni, Ray ; devel@edk2.groups.io; Ard Biesheuvel
> >>
> >> Cc: l...@nuviainc.com; phi...@red
On 02/14/20 12:41, Ard Biesheuvel wrote:
> This is the UEFI counterpart to my Linux series [0] which generalizes
> mixed mode support into a feature that requires very little internal
> knowledge about the architecture specifics of booting Linux on the
> part of the bootloader or firmware.
>
> Ins
On 02/14/20 01:55, Ni, Ray wrote:
>
>
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Friday, February 14, 2020 7:15 AM
>> To: Ni, Ray ; devel@edk2.groups.io; Ard Biesheuvel
>>
>> Cc: l...@nuviainc.com; phi...@redhat.com; Gao, Zhichao
>>
>> Subject: Re: [edk2-devel] [RFC PATCH 1/1
Extend validation of ACPI structure lengths which are read from the
ACPI table being parsed. Additionally check if the structure 'Length'
field value is positive. If not, stop parsing the faulting table.
Some ACPI tables define internal structures of variable size. The
'Length' field inside the su
Hi Leif,
On Thu, Feb 13, 2020 at 5:31 PM Leif Lindholm wrote:
>
> On the whole, looks good.
> If you can resubmit v3 versions of patches 2-3 only based on feedback,
> that would suffice.
Thanks for reviewing. I have sent out v3 retaining R-b in all patch
except in patch 2. There's no change in p
For RD-N1-Edge platforms, use multi-chip-mode information from the
SGI platform descriptor HOB to pick the correct ACPI table to be
installed.
Signed-off-by: Vijayenthiran Subramaniam
Reviewed-by: Leif Lindholm
---
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
Platform/ARM/SgiP
RD-N1-Edge supports a dual-chip configuration in which two RD-N1-Edge
platforms are connected through high speed CCIX link. In this dual-chip
configuration, the CPU and core GIC Redistributors count are doubled.
Add ACPI tables for dual-chip RD-N1-Edge platform.
Signed-off-by: Vijayenthiran Subram
Add the `DISABLE_NEW_DEPRECATED_INTERFACES` build option in DSC file to
make sure that the deprecated APIs are not used SgiPkg.
Signed-off-by: Vijayenthiran Subramaniam
Reviewed-by: Leif Lindholm
---
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 3 +++
Platform/ARM/SgiPkg/SgiPlatform.dsc
The 'system-id' node of HW_CONFIG device tree has been updated to have
a new property 'multi-chip-mode' which holds the information about the
multi-chip-mode support. To adapt to this change, add 'MultiChipMode'
member to SGI_PLATFORM_DESCRIPTOR structure to get 'multi-chip-mode'
property from fdt.
Use lookup table to identify the platform and install corresponding ACPI
tables. As the number of supported platforms grow, the existing platform
identification using if..else does not scale well.
Signed-off-by: Vijayenthiran Subramaniam
---
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
Changes since v2:
- Rename i to Idx in Patch 2/5
- Retaining R-b in rest of the patches as there's no change
Changes since v1:
- Fix typo which caused build error
This patch series adds support for RD-N1-Edge platform with multi-chip
capability. The first patch in this series is an improvement to
On Fri, 14 Feb 2020 at 07:44, Gaurav Jain wrote:
>
> GetBarAttributes, MemRead, MemWrite consistency test failed
> with Invalid BarIndex.
> Added check for BarIndex and return Invalid Parameter.
>
> PCI Controller Attribute operation with Unsupported Attributes
> is failing.
> Added check to retur
Replying as per Liming's request for this to be merged into edk2-stable202002.
On Mon, Feb 10, 2020 at 13:18, Vitaly Cheptsov wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2510
>
> Some firmwares:
> - Report Shift modifier even when they report upper-case unicode letter.
> - Repor
Replying as per Liming's request for this to be merged into edk2-stable202002.
On Mon, Feb 10, 2020 at 14:12, vit9696 wrote:
> Hello,
>
> It has been quite some time since we submitted the patch with so far no
> negative response. As I mentioned previously, my team will strongly benefit
> from
On Tue, 28 Jan 2020 at 18:20, Pete Batard wrote:
>
> The Raspberry Pi platform contains two UARTs, one PL011-based and the
> other (called miniUART) 16650-compatible, that are pinmuxed to the GPIO
> serial port according to whether a Device Tree overlay is present in
> config.txt or not. In most c
On Wed, 8 Jan 2020 at 18:00, Pete Batard wrote:
>
> This series of patches improves the reporting of the firmware version
> and platform serial number for the Raspberry Pi platforms.
>
> Since there is only so much we can do with 16 bits and the firmware revision
> reported by the VideoCore mailbo
On Mon, 30 Dec 2019 at 15:16, Jared McNeill wrote:
>
> According to the bcm2711 devicetree, the Arasan SDHCI uses GIC SPI 126
> and the Broadcom SDHost uses GIC SPI 120.
>
> Signed-off-by: Jared McNeill
Reviewed-by: Ard Biesheuvel
Pushed as cc7a0c68618c..314c45bc620b
(apologies - in my haste,
On Mon, 3 Feb 2020 at 14:40, Pete Batard wrote:
>
> The Raspberry Pi 4 platforms uses a Broadcom Genet network interface, for
> which we need ACPI entries in order to make it usable under Linux.
>
> This patch adds these entries, including a max-dma-burst-size DSD attribute
> aimed at simplifying
Zurcher:
Seemly, this is like an enhancement in OpensslLib. Please submit one BZ
(https://bugzilla.tianocore.org/) for this change.
And today, edk2 enters into the soft feature freeze for edk2-stable202002
stable tag. So, this change may not catch this stable tag.
Thanks
Liming
> -Orig
Hi, all
We will enter into Soft Feature Freeze phase. In this phase, the feature
under review will not be allowed to be pushed. The patch review can continue
without break in edk2 community.
If the patch is sent before Soft Feature Freeze, and plans to catch this
stable tag, the patch contr
66 matches
Mail list logo
