> -Original Message-
> From: Albecki, Mateusz
> Sent: Tuesday, January 07, 2020 7:06 PM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming
> Subject: [PATCH 0/3] MdeModulePkg/SdMmcPciHcDxe: Retry the
> commands that failed due to CRC error
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1792
Hmac(Md5|Sha1|Sha256)GetContextSize() use a deprecated macro
HMAC_MAX_MD_CBLOCK defined in openssl. They should be dropped to
avoid misuses in the future. For context allocation and release,
use HmacXxxNew() and HmacXxxFree() instead.
Since
Reviewed-by: Liming Gao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Vitaly Cheptsov
via Groups.Io
Sent: 2020年1月7日 18:51
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v2 1/1] MdePkg: Do not use CreateEventEx unless
required
REF: https://bugzilla.tianocore.org/sho
Hello Hao/Jian,
As per Maintainers.txt, I think you guys are the overall maintainers of
MdeModulePkg. Bringing this patch to your attention so that it could be
submitted. Ray who is the reviewer of BDS changes has already reviewed this
patch.
Thanks
Ashish
From: Ni, Ray
Sent: Wednesday, Janu
This patch add FirmwareInterfaceTable.h for the Firmware Interface Table
BIOS specification.
This is to remove future edk2 dependency on edk2-platforms repo. The file
content comes from
edk2-platforms\Silicon\Intel\IntelSiliconPkg\Include\IndustryStandard
BZ link: https://tianocore.acgmultimedia
The existing MpInitLib will shadow the microcode update patches from
flash to memory and this is done by searching microcode region specified
by PCD PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize.
This brings a limition to platform FW that all the microcode patches must
be placed in
The existing MpInitLib will shadow the microcode update patches from
flash to memory and this is done by searching microcode region specified
by PCD PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize.
This brings a limition to platform FW that all the microcode patches must
be placed in
On 01/07/20 17:55, Ard Biesheuvel wrote:
> On Tue, 7 Jan 2020 at 17:50, Laszlo Ersek wrote:
>>
>> On 01/07/20 10:47, Ard Biesheuvel wrote:
>>> Extend the existing DT traversal routine in PlatformPeiLib with
>>> discovery of the PSCI method, and expose an implementation of the
>>> Reset2 PPI based
I think I may have found the problem. I can write the file_name.signed created
by your scripts in NT32 emulated environment and in EDKII on Minnow board that
I build myself. However, I cannot write the file_name.signed on a commercial
device. I can write the same authenticate variable with the s
On 01/07/20 10:48, Ard Biesheuvel wrote:
> Duplicate the TPM2_ENABLE and TPM2_CONFIG_ENABLE build time flags that
> already exist in OvmfPkg, and wire them up in the .DSC and .FDF so
> that setting those flags produces a ArmVirtQemu build that implements
> measured boot using a TPM provided by QEMU
On Tue, 7 Jan 2020 at 17:50, Laszlo Ersek wrote:
>
> On 01/07/20 10:47, Ard Biesheuvel wrote:
> > Extend the existing DT traversal routine in PlatformPeiLib with
> > discovery of the PSCI method, and expose an implementation of the
> > Reset2 PPI based on the method found.
> >
> > This satisfies a
On 01/07/20 10:47, Ard Biesheuvel wrote:
> Extend the existing DT traversal routine in PlatformPeiLib with
> discovery of the PSCI method, and expose an implementation of the
> Reset2 PPI based on the method found.
>
> This satisfies a dependency of Tcg2Pei, which needs to reset the
> platform in
Reviewed-by: Guo Dong
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, January 6, 2020 8:13 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice ; Dong, Guo ;
> You, Benjamin ; Ni, Ray ; Gao,
> Liming ; Wu, Hao A ;
> ler...@redhat.com; Ard Biesheuvel
> Subject: [PATCH 3/5] UefiP
On 01/07/20 10:47, Ard Biesheuvel wrote:
> Introduce a boolean PCD that tells us whether TPM support is enabled
> in the build, and if it is, record the TPM base address in the existing
> routine that traverses the device tree in the platform PEIM.
>
> Signed-off-by: Ard Biesheuvel
> ---
> ArmVir
Hi Ard,
I have uploaded Intel Ethernet UNDI driver's open source code from latest Intel
Ethernet driver's release to edk2-staging.
https://github.com/tianocore/edk2-staging/tree/Intel_UNDI
It should contain the fixes for ARM/GCC build.
Thanks,
Maciej
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: Yo
For NetworkPkg patches: <29, 53>
Reviewed-by: Maciej Rabeda
Thank you, Antoine & Philippe :)
On 03-Jan-20 10:06, Philippe Mathieu-Daudé wrote:
Around February of this year, Antoine posted various patches fixing
a huge quantity of typos, over 8000+ lines (such [1]).
This series salvages a thi
On Tue, 7 Jan 2020 at 12:55, Laszlo Ersek wrote:
>
> On 01/07/20 10:47, Ard Biesheuvel wrote:
> > Wire up the various existing pieces so that we can implemented measured
> > boot on ArmVirtQemu based on the TPM support in QEMU, just like it has
> > been implemented for x86 in OvmfPkg.
> >
> > The
On 01/07/20 10:47, Ard Biesheuvel wrote:
> On ARM systems, the TPM does not live at a fixed address, and so we
> need the platform to discover it first. So introduce a PPI that signals
> that the TPM address has been discovered and recorded in the appropriate
> PCD, and make Tcg2ConfigPei depex on
On 01/07/20 10:47, Ard Biesheuvel wrote:
> Wire up the various existing pieces so that we can implemented measured
> boot on ArmVirtQemu based on the TPM support in QEMU, just like it has
> been implemented for x86 in OvmfPkg.
>
> The main difference is that on ARM, we first need to discover the T
Missed github info:
Clean patch series is here: https://github.com/malbecki/edk2/tree/sdmmc_retries
Patch series with the applied CRC simulation code is here:
https://github.com/malbecki/edk2/tree/sdmmc_retries_with_test_code
Thanks,
Mateusz
> -Original Message-
> From: Albecki, Mateusz
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1140
Error detection function will now check if the command
failure has been caused by one of the errors that can
appear randomly on link(CRC error + end bit error). If
such an error has been a cause of failure function will
return EFI_CRC_ERROR
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1140
To increase the resiliency driver will now attempt to
retry the commands that failed due to the CRC error up
to 5 times. This should address the problems with the commands
that fail due to random condition on links. This should also
help the
This patch adds retries for async execution for commands that
failed due to the CRC errors.
Cc: Hao A Wu
Cc: Marcin Wojtas
Cc: Zhichao Gao
Cc: Liming Gao
Signed-off-by: Mateusz Albecki
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 6 --
1 file changed, 4 insertions(+), 2 dele
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1140
Some of the boards report that just after we change the clock frequency to
200MHz link is
unable to stabilize fast enough and when driver sends the CMD13 it will often
fail
randomly with CRC error. To protect against this kind of random fa
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2446
Changes from V1:
- Dropped GUIDs from inf files
Requesting for merge in edk2-stable202002
Vitaly Cheptsov (1):
MdePkg: Do not use CreateEventEx unless required
MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2446
There are many firmwares in the wild not supporting CreateEventEx,
including devices less than 5 years old.
Signed-off-by: Vitaly Cheptsov
---
MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf
| 3 ---
MdePk
Sorry Guys, I did not see the previous email. I don't claim my clang-format is
perfect, you might need to tweak it a little.
---
BasedOnStyle: LLVM
AlignAfterOpenBracket: Align
AlignConsecutiveDeclarations: false
AlignEscapedNewlines: Left
AlignOperand
Reviewed-by: Maciej Rabeda
Thanks!
Maciej
-Original Message-
From: Philippe Mathieu-Daude
Sent: Thursday, January 2, 2020 20:24
To: devel@edk2.groups.io
Cc: Leif Lindholm ; Kinney, Michael D
; Andrew Fish ; Laszlo Ersek
; Philippe Mathieu-Daude ; Rabeda, Maciej
Subject: [PATCH v3 1
On ARM systems, the TPM does not live at a fixed address, and so we
need the platform to discover it first. So introduce a PPI that signals
that the TPM address has been discovered and recorded in the appropriate
PCD, and make Tcg2ConfigPei depex on it when built for ARM or AARCH64.
Signed-off-by:
Introduce a boolean PCD that tells us whether TPM support is enabled
in the build, and if it is, record the TPM base address in the existing
routine that traverses the device tree in the platform PEIM.
Signed-off-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirtPkg.dec| 5 ++
Wire up the various existing pieces so that we can implemented measured
boot on ArmVirtQemu based on the TPM support in QEMU, just like it has
been implemented for x86 in OvmfPkg.
The main difference is that on ARM, we first need to discover the TPM base
address from the device tree provided by QE
Duplicate the TPM2_ENABLE and TPM2_CONFIG_ENABLE build time flags that
already exist in OvmfPkg, and wire them up in the .DSC and .FDF so
that setting those flags produces a ArmVirtQemu build that implements
measured boot using a TPM provided by QEMU and described in the device
tree.
Note that the
Extend the existing DT traversal routine in PlatformPeiLib with
discovery of the PSCI method, and expose an implementation of the
Reset2 PPI based on the method found.
This satisfies a dependency of Tcg2Pei, which needs to reset the
platform in some cases. Since there are no other uses for system
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2142
gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType0BiosInformation|
{0x0}|SMBIOS_TABLE_TYPE0|0x8001 {
IndustryStandard/SmBios.h
MdePkg/MdePkg.dec
AdvancedFeaturePkg/AdvancedFeaturePkg.dec
}
If there's a PcdStruc
The PCD PcdArmReenterPeiForCapsuleWarmReboot is going away so drop the
definition for DeveloperBox.
Signed-off-by: Ard Biesheuvel
---
Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
b/Pl
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2087
In CryptHkdf.c line 42
EVP_PKEY_CTX *pHkdfCtx;
Variable pHkdfCtx begins with lower case 'p',
which should be acceptable because it it is a pointer.
(Refer to CCS_2_1_Draft, 4.3.3.3)
So ECC tool should be improved to handle issues like th
Some preparatory fixes for TPM measured boot on ARM systems.
Patch #1 removes EnterS3WithImmediateWake() with the associated support
code from ArmSmcPsciResetSystemLib. EnterS3WithImmediateWake () is no
longer being called anywhere, and will be removed from ResetSystemLib,
and the support code dep
EnterS3WithImmediateWake () no longer has any callers, so remove it
from ResetSystemLib. Note that this means the hack to support warm
reboot by jumping to the SEC entry point with the MMU and caches off
is also no longer used, and can be removed as well, along with the PCD
PcdArmReenterPeiForCapsu
While the alternative PEI-less SEC implementation in PrePi already
takes the EnableVFP PCD into account, the PrePeiCore code does not,
and so we may end up triggering synchronous exception when code
attempts to use FP or SIMD registers, which is permitted by the spec.
So enable the VFP as early as
On 01/07/20 01:53, Eric Dong wrote:
> This patch serial used to update the commit message.
>
> Rollback the old change and resend it with new commit message.
>
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Eric Dong (2):
> Revert "UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow issue."
> UefiCpuPkg/PiSm
Hello Mike,
On 01/06/20 19:17, Kinney, Michael D wrote:
> Laszlo,
>
> Sorry for the delay in getting to these PactchCheck.py updates.
> I know it is frustrating to be blocked by these types of issues.
> I try to look at 2406 tomorrow.
Thanks!
> I think the manual override is
> potentially more
Below:
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, January 7, 2020 4:06 PM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Zhang, Chao B
> ; Justen, Jordan L ;
> Laszlo Ersek ; Ard Biesheuvel ;
> Marc-André Lureau ; Stefan Berger
>
> Subject: RE: [edk2-devel]
Reviewed-by: Eric Dong
> -Original Message-
> From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Philippe
> Mathieu-Daude
> Subject: [PATCH v2 78/78] Uefi
Reviewed-by: Eric Dong
I'm not sure whether you can submit the changes.
If you need my help to check in the code for UefiCpuPkg, please send mail to me.
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Philippe Mathieu-Daudé
>
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Philippe Mathieu-Daudé
> Sent: Friday, January 3, 2020 5:08 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Philippe
> Mathieu-
> -Original Message-
> From: Yao, Jiewen
> Sent: Friday, January 3, 2020 1:59 PM
> To: devel@edk2.groups.io; Yao, Jiewen ; Gao, Zhichao
>
> Cc: Wang, Jian J ; Zhang, Chao B
> ; Justen, Jordan L ;
> Laszlo Ersek ; Ard Biesheuvel ;
> Marc-André Lureau ; Stefan Berger
>
> Subject: RE: [ed
Hi Siyuan,
Thanks for your patch.
Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Siyuan, Fu
> Sent: Friday, January 3, 2020 2:59 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray
> Subject: [edk
47 matches
Mail list logo
