Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Tuesday, December 17, 2019 1:54 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH] BaseTools:replaces the two offending quotes by ascii quotes
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2423
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2423
That commit 13c5e34a1b introduces the first two UTF-8
characters (the quote ') in an otherwise all-ascii file.
In Conf\tools_def.template
There is tow lines of
Notes: Since this tool chain is obsolete, it doesn't enable
the compiler optio
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Agyeman, Prince
> Sent: Saturday, December 14, 2019 9:33 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 08/11] WhiskeylakeOpenBoardPkg: Add BDS
> H
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Agyeman, Prince
> Sent: Saturday, December 14, 2019 9:33 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 05/11] MinPlatformPkg: Add BDS Hook
> Poi
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Agyeman, Prince
> Sent: Saturday, December 14, 2019 9:33 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms] [PATCH 07/11] KabylakeOpenBoardPkg: Add BDS
> Ho
Hi Prince,
BoardBootManagerLib.c is added as new file so it should have 2019 in copyright.
With that Reviewed-by: Chasel Chiu
> -Original Message-
> From: Agyeman, Prince
> Sent: Saturday, December 14, 2019 9:33 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ;
My response in line.
Thanks
Ashraf
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, December 17, 2019 7:08 AM
> To: Javeed, Ashraf ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/12]
> PciBusDxe: Separation
Yeah, if we don't want to carry Cmocka in edk2, there's a necessary trade off
of having to keep a dependency for the host-based tests. You wouldn't need this
dependency for a simple shell-based test, I'm pretty sure.
- Bret
From: Kinney, Michael D
Sent: Monday,
Done.
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, December 17, 2019 1:15 AM
> To: Ni, Ray ; devel@edk2.groups.io; Kinney, Michael D
>
> Cc: Feng, Bob C ; Gao, Liming
> ; Sean Brogan ; Bret
> Barkelew
> Subject: RE: [edk2-devel] [Patch 1/1] BaseTools/Scripts: Add pack
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Wednesday, December 11, 2019 11:25 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; Shi, Steven ;
>Ard Biesheuvel
>Subject: [Patch 1/1] BaseTools: Fix build failure when multiple build targets
>given
>
>BZ: https://bugz
Hi Bret,
No. I did not do that step yet. I will try that next.
I was just trying to build the new DSC in the MdePkg. The external dependency
for a set of simple lib API unit tests in MdePkg was not expected. A
Readme.md in MdePkg/Test might help.
The RFC and Usage guide links in this thre
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2311
In patch set 13c5e34a - 0c3e8e99, we implemented incremental build with
using compiler/pre-processor generate dependent header file function.
A issue is found for MSVC compiler, that the cl.exe /showIncludes
build option generate header file
Ashraf,
The change looks good.
2 minor comments:
1. StartPciRootPortsOnBridge()
Can it be renamed to EnablePciDevicesOnBridge()?
Because it basically calls PciIo.Attribute() to enable the devices. And I
am not sure the enable only applies to PCI root ports. There could be PCI
devices b
I'll create patch to fix this issue.
Thanks,
Bob
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, December 17, 2019 7:30 AM
To: devel@edk2.groups.io; anthony.per...@citrix.com; Feng, Bob C
; Kinney, Michael D
Cc: Gao, Liming ; Shi, Steven
Subject: RE: [edk2-devel] [Patch 1/4
Did you make sure to stuart_update? It will pull a dependency repo that is only
needed for CI.
- Bret
From: Kinney, Michael D
Sent: Monday, December 16, 2019 2:31:13 PM
To: r...@edk2.groups.io ; Bret Barkelew
; devel@edk2.groups.io ;
Andrew Fish ; Kinney, Mich
I recommend you use the ASCII ' character.
We want all source code files to be ASCII and we will be
updating CI checkers to enforce this. Only UNI string files
are allowed to use UTF-8 characters.
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Anthony PERARD
> S
Hi Bret,
I am looking at the latest version of the content on your branch.
I am confused by MdePkg/Test/MdePkgTest.dsc. It makes references
to lib classes and packages that do not exist.
CmockaLib|CmockaHostUnitTestPkg/Library/CmockaLib/CmockaLib.inf
OsServiceLib|HostBasedUnitTestPkg/Libra
Hi Jiaxin,
I have sent the PR to your edk2 fork. Any chance to get that to
tianocore/edk2? :)
Thanks,
Maciej
On 13-Dec-19 03:58, Wu, Jiaxin wrote:
Reviewed-by: Jiaxin Wu
Thanks,
Jiaxin
-Original Message-
From: Maciej Rabeda
Sent: Wednesday, December 11, 2019 5:54 PM
To: devel@e
No problem for me.
Thank you
Yao Jiewen
From: Kinney, Michael D
Sent: Tuesday, December 17, 2019 5:28 AM
To: Yao, Jiewen ; devel@edk2.groups.io;
bret.barke...@microsoft.com; Andrew Fish ; Kinney, Michael D
Cc: r...@edk2.groups.io
Subject: RE: [EXTERNAL] Re: [edk2-devel] EDK2 Host-Based Unit T
Mike/Steven/Ray,
We have had a tool for a couple of years with similar functionality. It is a
python tool you run on your code base and it creates a single (local) webpage
that you can then use to build charts.
Please give it a try and see if you think it is useful.
Here is the tool.
https://
It's a careful balancing act. The more you allocate to temp ram the less will
be available to cache the SPI flash, which can impact responsiveness depending
on the size of your IBB. I agree that 192KB is probably a good compromise.
Thanks,
Nate
-Original Message-
From: Kubacki, Michael
Reviewed-by: Puja Pandya
-Original Message-
From: devel@edk2.groups.io On Behalf Of Desimone,
Nathaniel L
Sent: Monday, December 9, 2019 4:02 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Pandya, Puja
; Desimone, Nathaniel L
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH]
I agree with Chasel. There should be enough T-RAM available to expand this to
0x3 without a problem and reduce potential thrash in the future.
Thanks,
Michael
> -Original Message-
> From: Chiu, Chasel
> Sent: Sunday, December 15, 2019 4:32 PM
> To: Agyeman, Prince ; Desimone, Nathan
Ray,
Yes. More features can be added. Can you add to the BZ some
examples of the output you would like to see.
https://bugzilla.tianocore.org/show_bug.cgi?id=2161
Thanks,
Mike
> -Original Message-
> From: Ni, Ray
> Sent: Monday, December 16, 2019 12:41 AM
> To: devel@edk2.groups.io;
On Wed, Dec 04, 2019 at 22:48:14 +0530, Tanmay Jagdale wrote:
> Add fip.bin and bl1.bin binaries for the Qemu Sbsa model
>
> Signed-off-by: Tanmay Jagdale
> ---
> The bl1.bin and fip.bin binaries are present in the following git repository
> https://git.linaro.org/people/tanmay.jagdale/edk2-non-o
On Sun, Dec 15, 2019 at 17:46:25 +0530, Tanmay Jagdale wrote:
> From: Radoslaw Biernacki
>
> Linaro enterprise group is coordinating work for adding SBSA compliant
> virtual platform for QEMU. This patch adds initial support for platform
> with nondiscoverable AHCI, VGA and single DRAM window ove
On Wed, Dec 11, 2019 at 17:04:01 +, Pete Batard wrote:
> From: Ard Biesheuvel
Oops - sorry, I missed the From: - thanks for the poke.
Yeah, I'm good with this change:
Reviewed-by: Leif Lindholm
> This is an improvement of e9db04631b63574b090aeab769cc47dcb75a29f7
> where we inhibit serial o
On Fri, Dec 06, 2019 at 11:26:55PM +0800, Bob Feng wrote:
> BaseTools/Conf/tools_def.template | 181 --
Hi Bob,
That patch introduces the first two UTF-8 characters (the quote ’ ) in
an otherwise all-ascii file. And that prevent our CI from building OVMF.
Part of the e
With comments in https://bugzilla.tianocore.org/show_bug.cgi?id=1954,
a new PCIE Override protocol will be added.
So this patch review is skipped.
> -Original Message-
> From: Javeed, Ashraf
> Sent: Wednesday, November 13, 2019 11:24 AM
> To: devel@edk2.groups.io; Javeed, Ashraf
> Cc: W
With the new protocol discussed in
https://bugzilla.tianocore.org/show_bug.cgi?id=1954,
this patch review is skipped.
> -Original Message-
> From: Javeed, Ashraf
> Sent: Wednesday, November 13, 2019 11:22 AM
> To: devel@edk2.groups.io; Javeed, Ashraf
> Cc: Wang, Jian J ; Wu, Hao A ; Ni
Hello All:
Need clarification on the Certificate Validation Procedure used in HTTP Boot.
The certificate parsing done at HttpDxe in file HttpsSupport.c in the function
TlsConfigCertificate().
The below code snippet is TlsSetSessionData call for each certificate data.
while ((ItemDataSize > 0
From: Radoslaw Biernacki
Linaro enterprise group is coordinating work for adding SBSA compliant
virtual platform for QEMU. This patch adds initial support for platform
with nondiscoverable AHCI, VGA and single DRAM window over 32bit
address space.
Using FDF to compose EFI flash images with ATF i
Using event for callbacks has a limitation: The event callback has to run at
TPL >= TPL_CALLBACK.
Some of the services like gBS->LoadImage()/StartImage(),
SimpleTextIn->ReadKeyStroke(),
FormBrowser->SendForm() can ONLY be called at TPL_APPLICATION.
So those services cannot be called from the eve
Ray,
I think you are asking for a module-level dependency tool. 😊
Mike,
This tool is cool. Besides the package level, do you think we can go further to
figure out a module level dependency tool? With module level dependency info,
we can define more interesting and comprehensive Modularity Me
Mike,
This pkg dep tool can tell through weight when a module depends on a new pkg.
But it cannot tell when a module depends on another
PCD/Protocol/Guid/Ppi/Library which belongs to an already-depended pkg.
Failure to tell such information may make a bad module (that violates the
dependency rul
35 matches
Mail list logo
