Ashraf,
The change looks good.
2 minor comments:
1. StartPciRootPortsOnBridge()
Can it be renamed to EnablePciDevicesOnBridge()?
Because it basically calls PciIo.Attribute() to enable the devices. And I
am not sure the enable only applies to PCI root ports. There could be PCI
devices behind P2P bridge.
2. + if (EFI_ERROR (Status) == EFI_NOT_FOUND) {
Should be "if (EFI_ERROR (Status)) {"
> > EFI_STATUS
> > -StartPciDevicesOnBridge (
> > +StartPciRootPortsOnBridge (
> > + IN EFI_HANDLE Controller,
> > + IN PCI_IO_DEVICE *RootBridge
> > + )
> + if (EFI_ERROR (Status) == EFI_NOT_FOUND) {
> > + return Status;
> > + } else {
> > + //
> > + // finally start those PCI bridge port devices only
> > + //
> > + return StartPciRootPortsOnBridge (
> > + Controller,
> > + RootBridge
> > + );
> > + }
> > +}
> > +
> > /**
> > Start to manage all the PCI devices it found previously under
> > the entire host bridge.
> > --
> > 2.21.0.windows.1
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52268): https://edk2.groups.io/g/devel/message/52268
Mute This Topic: https://groups.io/mt/55155883/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
