Update openssl from 1.1.1b to 1.1.1d.
Something needs to be noticed is that, there is a bug existing in the
released 1_1_1d version(894da2fb7ed5d314ee5c2fc9fd2d9b8b74111596),
which causes build failure. So we switch the code base to a usable
version, which is 2 commits later than the stable tag.
No
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2320
Add support for parseing map files generated by CLANG9 in GenFv
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiguang Liu
---
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 28 +++-
1 file changed, 23 insertions(+)
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiguang Liu
---
BaseTools/Source/Python/Common/Misc.py | 9 ++---
BaseTools/Source/Python/GenPatchPcdTable/GenPatchPcdTable.py | 9 ++---
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/BaseTools/Source/P
EsrtRepository might be NULL. So return EFI_OUT_OF_RESOURCES
when it is NULL.
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
Reviewed-by: Hao A Wu
---
MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdeModulePkg/Universal/Es
The caller of CompareAndMergeDefaultString has checked that
AltCfgResp must contain AltConfigHdr. So we add ASSERT to assume
StringPtr is not NULL.
Cc: Dandan Bi
Cc: Eric Dong
Signed-off-by: Shenglei Zhang
Reviewed-by: Dandan Bi
---
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 1 +
Before called by GetBufferForValue(), Value has already been called
function IsTypeInBuffer to make sure the value must be buffer type.
So GetBufferForValue can not return NULL.
This commit adds ASSERT to assume (GetBufferForValue (&Value) is not
NULL.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by:
Entry and RetEntry might be NULL before used.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
Reviewed-by: Hao A Wu
---
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 2 +-
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c| 2 +-
2 files changed, 2 insertions(+)
Add error handling and ASSERT to ensure the variables are
usable when called.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Eric Dong
Cc: Hao A Wu
Cc: Liming Gao
Shenglei Zhang (4):
v2: Update the checking method in 02/04.
v3: Add ASSERT instead of error handling in 04/04.
Shenglei Zhang
On Thu, Oct 31, 2019 at 5:44 PM Andrew Fish via Groups.Io
wrote:
>
> Jon,
>
> Its a little confusing but gBS->GetMemoryMap () only returns information
> about DRAM and any address that requires a kernel virtual address mapping in
> EFI. The OS calls EFI Runtime Services from a kernel virtual map
Hi Laszlo,
===
Note for all reviewers:
---
Pull requests against edk2-staging/edk2-ci are not
being processed right now. We are working on some
configuration changes after noticing that all the
checks
Hi Bhupesh,
On Fri, Nov 1, 2019 at 1:59 AM Bhupesh Sharma wrote:
>
> Hi Prabhakar,
>
> On Wed, Oct 30, 2019 at 1:47 PM Prabhakar Kushwaha
> wrote:
> >
> > On Wed, Oct 30, 2019 at 1:14 PM Ard Biesheuvel
> > wrote:
> > >
> > > On Wed, 30 Oct 2019 at 08:36, Prabhakar Kushwaha
> > > wrote:
> > > >
On Fri, Nov 1, 2019 at 2:04 AM dann frazier wrote:
>
> On Thu, Oct 31, 2019 at 12:55:10PM -0600, dann frazier wrote:
> > On Thu, Oct 31, 2019 at 6:16 AM Leif Lindholm
> > wrote:
> > >
> > > On Thu, Oct 31, 2019 at 11:07:52AM +0100, Laszlo Ersek wrote:
> > > > +Leif, comment at bottom
> > >
> > >
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, October 30, 2019 9:46 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Dong, Eric
> Subject: [PATCH v2] MdeModulePkg/HiiDatabaseDxe: Add check for 'Private-
> >Attribute >> 4'
>
> The size of mHiiEfiColors is 16.
> mHiiEfiCol
Hi Shenglei,
Please update the commit message and subject before commit, since we have added
ASSERT code for this case that the StringPtr cannot be NULL instead of adding
check.
With the commit message updated, Reviewed-by: Dandan Bi .
Thanks,
Dandan
> -Original Message-
> From: Zhang
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, October 30, 2019 10:09 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Gao, Liming
> Subject: [PATCH v2 3/3] MdeModulePkg/Mem: Initialize the variable
> MapMemory
>
> MapMemory is not
For this patch series,
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kubacki,
> Michael A
> Sent: Thursday, October 31, 2019 2:45 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Ard Biesheuvel
> ; Dong, Eric ; Laszlo Ersek
> ; Ga
Thanks Michael!
I will update function description.
> -Original Message-
> From: Kubacki, Michael A
> Sent: Friday, November 1, 2019 1:02 AM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Desimone, Nathaniel L ; Gao, Liming
>
> Subject: RE: [edk2-devel] [edk2-platforms: PATCH v3 1/6]
Sorry for missing this one.
Reviewed-by: Zhichao Gao
> -Original Message-
> From: Marvin Häuser [mailto:marvin.haeu...@outlook.com]
> Sent: Sunday, October 20, 2019 8:09 PM
> To: devel@edk2.groups.io
> Cc: vit9...@protonmail.com; Ni, Ray ; Gao, Zhichao
>
> Subject: [PATCH] ShellPkg/Ls: R
*Reminder:* TianoCore Bug Triage - APAC / NAMO
*When:* Thursday, 31 October 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los
Angeles
*Where:* https://bluejeans.com/889357567?src=calendarLink
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503255 )
*Organizer:* Stephano Cetola ste
Reviewed-by: Ashley DeSimone
-Original Message-
From: Desimone, Nathaniel L
Sent: Wednesday, October 30, 2019 4:49 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Pandya, Puja
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Make Installer use ProductCode
from Vendor Customizer
Reviewed-by: Ashley DeSimone
-Original Message-
From: Desimone, Nathaniel L
Sent: Wednesday, October 30, 2019 4:48 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Pandya, Puja
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Python 2.x deprecation warning
in pip breaks EdkRepoIns
On Thu, Oct 31, 2019 at 12:55:10PM -0600, dann frazier wrote:
> On Thu, Oct 31, 2019 at 6:16 AM Leif Lindholm
> wrote:
> >
> > On Thu, Oct 31, 2019 at 11:07:52AM +0100, Laszlo Ersek wrote:
> > > +Leif, comment at bottom
> >
> > Thanks Laszlo. +Dann, -kexec.
> >
> > > On 10/30/19 09:16, Prabhakar
Hi Prabhakar,
On Wed, Oct 30, 2019 at 1:47 PM Prabhakar Kushwaha
wrote:
>
> On Wed, Oct 30, 2019 at 1:14 PM Ard Biesheuvel
> wrote:
> >
> > On Wed, 30 Oct 2019 at 08:36, Prabhakar Kushwaha
> > wrote:
> > >
> > > On Wed, Oct 30, 2019 at 12:43 PM Ard Biesheuvel
> > > wrote:
> > > >
> > > > On Tu
Reviewed-by: Prince Agyeman
-Original Message-
From: Chiu, Chasel
Sent: Thursday, October 31, 2019 3:28 AM
To: devel@edk2.groups.io
Cc: Wei, David Y ; Agyeman, Prince
Subject: [edk2-platforms: PATCH v3 6/6] SimicsOpenBoardPkg/BoardX58Ich10: Add
SetCacheMtrrLib library class.
REF:
On Thu, Oct 31, 2019 at 6:16 AM Leif Lindholm wrote:
>
> On Thu, Oct 31, 2019 at 11:07:52AM +0100, Laszlo Ersek wrote:
> > +Leif, comment at bottom
>
> Thanks Laszlo. +Dann, -kexec.
>
> > On 10/30/19 09:16, Prabhakar Kushwaha wrote:
> > >> So if you want to add these properties, you should add the
Thanks for updating the name.
Platform\Intel\MinPlatformPkg\Include\Library\SetCacheMtrrLib.h:
* The function description for SetCacheMtrrAfterEndOfPei () is
constraining the implementation in a way that I don't believe
is required:
/**
Update MTRR setting and set write back as default m
Jon,
Its a little confusing but gBS->GetMemoryMap () only returns information about
DRAM and any address that requires a kernel virtual address mapping in EFI. The
OS calls EFI Runtime Services from a kernel virtual mapping so the memory map
is also involved in the hand shake to communicate the
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
This driver is to do the PCI device authentication
based upon Intel PCIe Security Specification.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Yun Lou
Signed-off-by: Jiewen Yao
Signed-off-by: Yun Lou
---
Silicon/Intel/IntelSiliconPkg/Featur
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Yun Lou
Signed-off-by: Jiewen Yao
---
Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc
b/S
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
This patch series add support for device security based
upon the DMTF SPDM specification.
https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_0.95a.zip
We did design review at 18 Oct, 2019.
https://edk2.groups.io/g/devel/fi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
This driver provides the platform sample policy to measure
a NVMe card.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Yun Lou
Signed-off-by: Jiewen Yao
---
Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/SamplePlatformDevicePolicyDxe/Samp
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Yun Lou
Signed-off-by: Jiewen Yao
---
Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
b/Sili
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Yun Lou
Signed-off-by: Jiewen Yao
---
Silicon/Intel/IntelSiliconPkg/Include/Protocol/PlatformDeviceSecurityPolicy.h
| 84
1 file changed, 84 insertions(+)
diff --git
a/Silic
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Yun Lou
Signed-off-by: Jiewen Yao
---
Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IntelPciSecurity.h | 66
1 file changed, 66 insertions(+)
diff --git
a/Silicon/I
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Yun Lou
Signed-off-by: Jiewen Yao
---
MdePkg/Include/IndustryStandard/Spdm.h | 203
1 file changed, 203 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/Spdm.h
b/M
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Yun Lou
Signed-off-by: Jiewen Yao
---
MdeModulePkg/MdeModulePkg.dec | 5 +
1 file changed, 5 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index d6bac974da
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
EDKII_DEVICE_SECURITY_PROTOCOL is used for device
measurement and/or authentication.
It is similar to EFI_SECURITY_ARCH_PROTOCOL.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Yun Lou
Signed-off-by: Jiewen Yao
---
MdeModulePkg/Include/Protocol/Devi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
Whenever a PCI device is discovered, PCI bus calls the
EDKII_DEVICE_SECURITY_PROTOCOL to authenticate it.
If the function returns success, the PCI bus allocates
the resource and installs the PCI_IO for the device.
If the function returns fai
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
This patch series add support for device security based
upon the DMTF SPDM specification.
https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_0.95a.zip
We did design review at 18 Oct, 2019.
https://edk2.groups.io/g/devel/fi
On Thu, Oct 31, 2019 at 11:07:52AM +0100, Laszlo Ersek wrote:
> +Leif, comment at bottom
Thanks Laszlo. +Dann, -kexec.
> On 10/30/19 09:16, Prabhakar Kushwaha wrote:
> >> So if you want to add these properties, you should add them there.
> >>
> >> Can you explain why doing this is necessary?
> >
Hello Liming,
Please find my answers marked [PIERRE] inline.
>> Can you give the whole solution for this usage model?
[Pierre]
We are planning to modify specific values in pre-compiled AML definition blocks
at run-time, and then install these AML definition blocks as SSDT tables.
Instead of havin
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCEL
CALSCALE:GREGORIAN
BEGIN:VEVENT
STATUS:CANCELLED
UID:calendar.14...@groups.io
DTSTAMP:20191031T110751Z
ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com
DTSTART:20191101T013000Z
DTEND:20191101T023000Z
SUMMARY:TianoC
Hi, Liming:
I have a question about smbus access during pei phase.
I found there was not smbus ppi reference implementation in edk2-platform code
base.
And there was a SmbusLib reference implementation lib.
So, PEIMs usually use functions provided by SmbusLib?
Not use PeiSmbusPpi’s interface fun
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
MinPlatformPkg should contain the library class header (API)
and the NULL library class instance.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Chasel Chiu
---
Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Whiskeylake board relying on FSP to configure MTRRs so
it can include SetCacheMtrrLibNull.
Test: internal platform can boot with FSP API modes.
Cc: Michael Kubacki
Cc: Nate DeSimone
Signed-off-by: Chasel Chiu
---
Platform/Intel/Whiskey
V3 updates:
. Rename SetCacheLib to SetCacheMtrrLib
. SetCacheMtrrLib.inf base name and type changed to PeiSetCacheMtrrLib and PEIM
. SetCacheMtrrLibNull.inf base name changed to BaseSetCacheMtrrlibNull
. Add SetCacheMtrrLib.h to MinPlatformPkg.dec
. Add usage description to SetCacheMtrrLib.c and S
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
MinPlatformPkg PlatformInit modules to consume
SetCacheMtrrLib.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Chasel Chiu
---
Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPostMem.c
|
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Kabylake boards are relying on FSP to configure MTRRs so
they can include SetCacheMtrrLibNull.
Test: internal platform can boot with FSP API and Dispatch modes.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Jeremy Soller
Sig
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Include SetCacheMtrrLib from MinPlatformPkg.
Cc: Shifei A Lu
Cc: Xiaohu Zhou
Cc: Isaac W Oram
Signed-off-by: Chasel Chiu
---
Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 d
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2314
Include SetCacheMtrrLib from MinPlatformPkg.
Cc: Wei David Y
Cc: Agyeman Prince
Signed-off-by: Chasel Chiu
---
Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform
Thanks for the suggestions, will update them in V3.
Thanks!
Chasel
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, October 31, 2019 2:01 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Gao, Liming
>
> Subject: RE: [edk2-platforms: PATCH v2
Agreed. Will rename in V3.
Thanks!
Chasel
> -Original Message-
> From: Kubacki, Michael A
> Sent: Thursday, October 31, 2019 1:50 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Gao, Liming
> ; Jeremy Soller ; Lu, Shifei A
> ; Zhou, Bowen ; Oram, Isaac
> W ;
I am working on sorting out a failure on test 605 of the SBSA test.
The test is "Where a memory access is to an unpopulated part of the
addressable memory space, accesses must be terminated in a manner that
is presented to the PE as either a precise Data Abort or that causes a
system error interrup
Reviewed-by: Lu, shifei
-Original Message-
From: Chiu, Chasel
Sent: Thursday, October 31, 2019 8:30 AM
To: devel@edk2.groups.io
Cc: Lu, Shifei A ; Zhou, Bowen ;
Oram, Isaac W
Subject: [edk2-platforms: PATCH v2 5/6] PurleyOpenBoardPkg/BoardMtOlympus: Add
SetCacheLib library class.
REF
Reviewed-by: Xiaohu Zhou
-Original Message-
From: Chiu, Chasel
Sent: Thursday, October 31, 2019 8:30 AM
To: devel@edk2.groups.io
Cc: Lu, Shifei A ; Zhou, Bowen ;
Oram, Isaac W
Subject: [edk2-platforms: PATCH v2 5/6] PurleyOpenBoardPkg/BoardMtOlympus: Add
SetCacheLib library class.
RE
+Ray, +Zhichao
(although, the actual patch seems to be missing from the posting)
Thanks
Laszlo
On 10/30/19 04:47, Ashish Singhal wrote:
> Right now, any and every handle with a BlockIO or SimpleFileSystem or
> LoadFile protocol installed on the system is used to enumerate BM
> automatically. The
+Leif, comment at bottom
On 10/30/19 09:16, Prabhakar Kushwaha wrote:
> On Wed, Oct 30, 2019 at 1:14 PM Ard Biesheuvel
> wrote:
>>
>> On Wed, 30 Oct 2019 at 08:36, Prabhakar Kushwaha
>> wrote:
>>>
>>> On Wed, Oct 30, 2019 at 12:43 PM Ard Biesheuvel
>>> wrote:
On Tue, 29 Oct 2019 at 18
On 10/29/19 20:54, Michael D Kinney wrote:
> Active branch for testing/evaluation:
> * https://github.com/tianocore/edk2-staging/tree/edk2-ci
> * To test, fork edk2-staging repo, create a branch with a change, and submit
> a pull request targeting edk2-staging/edk2-ci. NOTE: the default branch
On 10/26/19 07:37, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: bz960_with_inet_pton_v2
> Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=960
> In v2, I have inserted 4 new patches in the middle, to satisfy two
> additional requirements raised by Siva and David
On 10/30/19 10:52, Ray Ni wrote:
> MpInitLib sets X2ApicEnable in two places.
> 1. CollectProcessorCount()
>This function is called when MpInitLibInitialize() hasn't been
>called before.
>It sets X2ApicEnable and later in the same function it configures
>all CPUs to operate in X2 AP
On 10/30/19 10:52, Ray Ni wrote:
> Today's logic sets X2ApicEnable flag in each AP's initialization
> path when InitFlag == ApInitConfig.
> Since all CPUs update the same global data, a spin-lock is used
> to avoid modifications from multiple CPUs happen at the same time.
> The spin-lock causes two
On 10/30/19 03:34, Leif Lindholm wrote:
> On Tue, Oct 29, 2019 at 12:54:56PM -0700, Michael D Kinney wrote:
>> https://bugzilla.tianocore.org/show_bug.cgi?id=2315
>>
>> Add maintainers and reviewers for the directories associated
>> with continuous integration steps.
>> * .azurepipelines
>> * .merg
On 10/31/19 05:43, Kinney, Michael D wrote:
> Leif,
>
> Thanks. I agree. I will split it out.
I would further suggest alphabetical sorting for the .gitignore lines.
Thanks!
Laszlo
>
> Mike
>
>> -Original Message-
>> From: Leif Lindholm
>> Sent: Tuesday, October 29, 2019 7:30 PM
>>
On 10/30/19 03:27, Leif Lindholm wrote:
> On Tue, Oct 29, 2019 at 12:54:58PM -0700, Michael D Kinney wrote:
>> From: Sean Brogan
>>
>> https://bugzilla.tianocore.org/show_bug.cgi?id=2315
>>
>> Add pip requirements file that is used to install the
>> python pip modules build from the edk2-pytool-li
On 10/29/19 20:55, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2315
>
> Add YAML file to the package directory with the
> configuration of the checks to perform during a
> CI build.
>
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Signed-off-by: Michael D Kinney
On 10/29/19 03:01, Leif Lindholm wrote:
> On Tue, Oct 29, 2019 at 02:07:20AM +0100, Laszlo Ersek wrote:
>>> diff --git a/Readme.md b/Readme.md
>>> index 27e4ce0..4b3d2a5 100644
>>> --- a/Readme.md
>>> +++ b/Readme.md
>>> @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains two
>>>
I still see custom implementation of CMOS functions and usage of those
functions in SimicsOpenBoardPkg. Examples:
1.
Platform\Intel\SimicsOpenBoardPkg\BoardX58Ich10\Library\BoardInitLib\PeiX58Ich10InitPreMemLib.c:
* CmosRead8 ()
* CmosWrite8 ()
2. Platform\Intel\SimicsOpenBoardPkg\SimicsPei
I tested using "#" character to indicate the line was a comment. I did this
for a copyright, license identifier, and some text. On Windows pip -r had no
issues installing, upgrading, or uninstalling and didn't show any output
related to those lines.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: Yo
Please check whitespace and formatting in the future. I agree with Nate
that it can be fixed when pushed but there's quite a few errors here.
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Wednesday, October 30, 2019 10:05 AM
> To: devel@edk2.groups.io
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Tuesday, October 29, 2019 1:36 PM
> To: devel@edk2.groups.io
> Cc: Sinha, Ankit ; Desimone, Nathaniel L
> ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Change Build
> Outpu
70 matches
Mail list logo
