Re: [edk2-devel] [Patch 0/1] BaseTools: Using compiler to generate source code dependency files.

2019-10-28 Thread Andrew Fish via Groups.Io
Bob, I was trying to point out the .d file extension also implies a C dependency file in Gcc world. So to me I would have picked .d. But other choices are OK too. > On Oct 28, 2019, at 6:12 PM, Feng, Bob C wrote: > >  > Yes. For Gcc and Clang, we can use –MMD –MF to generate > custom name

Re: [edk2-devel] [PATCH v2 4/8] CryptoPkg/Crt: satisfy "inet_pton.c" dependencies (CVE-2019-14553)

2019-10-28 Thread Wang, Jian J
Hi Jiaxin, > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, October 29, 2019 10:45 AM > To: devel@edk2.groups.io; ler...@redhat.com; David Woodhouse > > Cc: Wang, Jian J ; Sivaraman Nainar > ; Lu, XiaoyuX > Subject: RE: [edk2-devel] [PATCH v2 4/8] CryptoPkg/Crt: satisfy "inet_pt

Re: [edk2-devel] [PATCH v2 4/8] CryptoPkg/Crt: satisfy "inet_pton.c" dependencies (CVE-2019-14553)

2019-10-28 Thread Wu, Jiaxin
> > Hm. > > > > If you're porting a whole standard C library to EDK2 then I suppose it > > makes sense to build up all this infrastructure for it. > > > > But in this case when it's only the single inet_pton() function that > > you need, perhaps it makes more sense to 'port' that one function to >

Re: [edk2-devel] [PATCH v2 0/8] support server identity validation in HTTPS Boot (CVE-2019-14553)

2019-10-28 Thread Wu, Jiaxin
Test matrix - that's a great summary! The result is also good to me. Thanks Laszlo's patches to fix the gap. Series Reviewed-by: Jiaxin Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Saturday, October 26, 2019 1:37 PM > To: edk2-devel-groups-

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md

2019-10-28 Thread Leif Lindholm
On Tue, Oct 29, 2019 at 02:07:20AM +0100, Laszlo Ersek wrote: > > diff --git a/Readme.md b/Readme.md > > index 27e4ce0..4b3d2a5 100644 > > --- a/Readme.md > > +++ b/Readme.md > > @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains two > > submodules > > > > - CryptoPkg/Library/

Re: [edk2-devel] [Patch] NetworkPkg/SnpDxe: Use PcdGetBool() instead of FixedPcdGetBool in Snp.c

2019-10-28 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Fu, Siyuan > Sent: Tuesday, October 29, 2019 9:41 AM > To: devel@edk2.groups.io > Cc: Wu, Jiaxin > Subject: [Patch] NetworkPkg/SnpDxe: Use PcdGetBool() instead of > FixedPcdGetBool in Snp.c > > This patch fixes a problem introduced

[edk2-devel] [Patch] NetworkPkg/SnpDxe: Use PcdGetBool() instead of FixedPcdGetBool in Snp.c

2019-10-28 Thread Siyuan, Fu
This patch fixes a problem introduced by commit 61bb6eeb4d93c0a34c1995d87914ab41398f9550. The PcdSnpCreateExitBootServicesEvent is not guaranteed to be FixedAtBuild, so use PcdGetBool() to supports both fixed and patchable PCD. Change-Id: Ic1791bb598306e9251792113797c3bad317d0dda Cc: Jiaxin Wu

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md

2019-10-28 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Tuesday, October 29, 2019 9:07 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Andrew Fish ; Leif Lindholm > ; Michael D Kinney ; > Chen, Gilbe

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 38/39] edk2-staging: Revise Maintainers.txt for RISC-V packages

2019-10-28 Thread Abner Chang
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, October 29, 2019 9:06 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Andrew Fish ; Leif Lindholm > ; Michael D Kinney ; > Chen, Gilbert > Subject: Re: [edk2-devel] [edk2-s

Re: [edk2-devel] [PATCH] Maintainers.txt: Update my e-mail address

2019-10-28 Thread Laszlo Ersek
On 10/28/19 11:34, Julien Grall wrote: > I will soon lose access to my Arm e-mail address. Update it to my > xen.org one. > > Signed-off-by: Julien Grall > --- > Maintainers.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > inde

Re: [edk2-devel] [Patch 0/1] BaseTools: Using compiler to generate source code dependency files.

2019-10-28 Thread Bob Feng
Yes. For Gcc and Clang, we can use –MMD –MF to generate custom name dependency file for each source file. For example, gcc main.c –MMD –MF main.deps. For MSVC and Intel compiler, there is a build option /showIncludes which makes compiler print the dependency files on stdout but not a file. Th

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md

2019-10-28 Thread Laszlo Ersek
On 10/28/19 02:59, Abner Chang wrote: > Add opensbi submodule. > > Signed-off-by: Abner Chang > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Gilbert Chen > --- > Readme.md | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Readme.md b/Readme.

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 38/39] edk2-staging: Revise Maintainers.txt for RISC-V packages

2019-10-28 Thread Laszlo Ersek
On 10/28/19 02:59, Abner Chang wrote: > Add maintainers of RiscVPkg and RiscVPlatformPkg. > > Signed-off-by: Abner Chang > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Gilbert Chen > --- > Maintainers.txt | 15 +++ > 1 file changed, 15 i

Re: [edk2-devel] [PATCH v2 4/8] CryptoPkg/Crt: satisfy "inet_pton.c" dependencies (CVE-2019-14553)

2019-10-28 Thread Laszlo Ersek
On 10/28/19 14:06, David Woodhouse wrote: > On Sat, 2019-10-26 at 07:37 +0200, Laszlo Ersek wrote: >> In a later patch in this series, we're going to resurrect "inet_pton.c" >> (originally from the StdLib package). That source file has a number of >> standard C and BSD socket dependencies. Provide

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 2/3] EdkRepo: Multiple Command Package Command Factory Update

2019-10-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Desimone, Ashley E Sent: Monday, October 28, 2019 4:23 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja Subject: [edk2-staging/EdkRepo] [PATCH 2/3] EdkRepo: Multiple Command Package Command Factory Update Add su

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Preferred Entry Point Support

2019-10-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Desimone, Ashley E Sent: Monday, October 28, 2019 4:25 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Preferred Entry Point Support Add support for defining and

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 3/3] EdkRepo: Multiple Command Package Build Script Update

2019-10-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Desimone, Ashley E Sent: Monday, October 28, 2019 4:23 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 3/3] EdkRepo: Multiple

Re: [edk2-devel] [edk2-staging/EdkRepo][PATCH 1/3] EdkRepo: Multiple Command Package Configuration Support

2019-10-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Desimone, Ashley E Sent: Monday, October 28, 2019 4:23 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja Subject: [edk2-devel] [edk2-staging/EdkRepo][PATCH 1/3] EdkRepo: Multiple

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Preferred Entry Point Support

2019-10-28 Thread Desimone, Ashley E
Add support for defining and selecting a preferred entry point. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- edkrepo/__main__.py | 4 +- edkrepo/config/config_factory.py | 7 ++- edkrepo/edkrepo_cli.py | 55 ---

[edk2-devel] [edk2-staging/EdkRepo][PATCH 1/3] EdkRepo: Multiple Command Package Configuration Support

2019-10-28 Thread Desimone, Ashley E
Add support for a new required sections, command-packages and preferred-command-packages,to the GlobalConfig class. Additionaly update the existing edkrepo.cfg file. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- edkrepo/config/config_factory.py | 12 +++- e

[edk2-devel] [edk2-staging/EdkRepo] [PATCH 3/3] EdkRepo: Multiple Command Package Build Script Update

2019-10-28 Thread Desimone, Ashley E
Add support for building extension packages. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- build-scripts/set_version_and_build_wheels.py | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/build-scripts/set_version_and_build_wh

[edk2-devel] [edk2-staging/EdkRepo] [PATCH 2/3] EdkRepo: Multiple Command Package Command Factory Update

2019-10-28 Thread Desimone, Ashley E
Add support for iterating through a list of command packages from the global config file and generate a list of commands to be included. Improve the the _is_command() function to succesfully inspect command classes which do not derive from the edkrepo base command class Add support to list a comma

Re: [edk2-devel] [Patch 0/1] BaseTools: Using compiler to generate source code dependency files.

2019-10-28 Thread Andrew Fish via Groups.Io
The .d is the default file name extension used by GCC for dependency files. Given the dependency files are in the build output and the makefiles reference them explicitly I'm not sure there is going to be lots of confusion. But I think it is likely the default dependency file name is mostly jus

Re: [edk2-devel] [Patch 0/1] BaseTools: Using compiler to generate source code dependency files.

2019-10-28 Thread Bob Feng
OK. I'll change the .d in V2. -Original Message- From: Yao, Jiewen Sent: Monday, October 28, 2019 11:04 PM To: devel@edk2.groups.io; Feng, Bob C ; Ryszard Knop Subject: RE: [edk2-devel] [Patch 0/1] BaseTools: Using compiler to generate source code dependency files. I think we need av

Re: [edk2-devel] [Patch 0/1] BaseTools: Using compiler to generate source code dependency files.

2019-10-28 Thread Yao, Jiewen
I think we need avoid confusing for future. I don’t believe .d is good choice, since it is a known conflict. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Bob Feng > Sent: Monday, October 28, 2019 10:57 PM > To: Ryszard Knop ; devel@edk2.groups.io >

Re: [edk2-devel] [Patch 0/1] BaseTools: Using compiler to generate source code dependency files.

2019-10-28 Thread Bob Feng
Thanks for your comment. I think .d file should be fine since edk2 does not support D language. Thanks, Bob -Original Message- From: Ryszard Knop Sent: Monday, October 28, 2019 8:24 PM To: devel@edk2.groups.io; Feng, Bob C Subject: Re: [edk2-devel] [Patch 0/1] BaseTools: Using compile