On Tue, Oct 29, 2019 at 02:07:20AM +0100, Laszlo Ersek wrote: > > diff --git a/Readme.md b/Readme.md > > index 27e4ce0..4b3d2a5 100644 > > --- a/Readme.md > > +++ b/Readme.md > > @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains two > > submodules > > > > - CryptoPkg/Library/OpensslLib/openssl > > - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 > > +- RiscVPkg/Library/RiscVOpensbiLib/opensbi > > > > The latter one is actually required by previous one. It's inevitable > > in openssl-1.1.1 (since stable201905) for floating point parameter > > This will take an update that's a bit more extensive -- please see "two > submodules" just above the listing, and "latter one" right after the > listing. Adding opensbi in the proposed spot breaks both statements.
This suggests the surrounding language should change. Could we merge this to master?: >From 39f08033c934b3e631c40e373aa6a351323ab4aa Mon Sep 17 00:00:00 2001 From: Leif Lindholm <leif.lindh...@linaro.org> Date: Tue, 29 Oct 2019 09:54:36 +0800 Subject: [PATCH 1/1] Readme.md: remove positional references from submodule description Remove references to the number of submodules in the tree, as well as reword the referring to specific submodules as "former" and "previous". This means we won't need to keep updating the surrounding text if we add/remove submodules. Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org> --- Readme.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Readme.md b/Readme.md index 27e4ce07719b..9bf60bede8ec 100644 --- a/Readme.md +++ b/Readme.md @@ -144,12 +144,12 @@ Signed-off-by: Contributor Name <contribu...@example.com> # Submodules Submodule in EDK II is allowed but submodule chain should be avoided -as possible as we can. Currently EDK II contains two submodules +as possible as we can. Currently EDK II contains the following submodules - CryptoPkg/Library/OpensslLib/openssl - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 -The latter one is actually required by previous one. It's inevitable +ArmSoftFloatLib is actually required by OpensslLib. It's inevitable in openssl-1.1.1 (since stable201905) for floating point parameter conversion, but should be dropped once there's no such need in future release of openssl. -- 2.20.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49574): https://edk2.groups.io/g/devel/message/49574 Mute This Topic: https://groups.io/mt/38757610/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
