REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2108
SmramMemoryReserve.h has been added into
Edk2\MdePkg\Include\Guid\SmramMemoryReserve.h.
The following duplicated header file can be clean up.
Edk2Platforms\Platform\Intel\MinPlatformPkg\Include\Guid\SmramMemoryReserve.h
Edk2Platforms\Silicon
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2099
This is a regression issue introduced by commit e8449e.
This patch is to fix this issue.
Signed-off-by: Bob Feng
Cc: Liming Gao
---
V2: We need to check if a inf is a Library or a Module.
BaseTools/Source/Python/AutoGen/DataPipe.py
Patch looks good.
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Steven Shi
Sent: Thursday, August 22, 2019 10:44 AM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C ;
Shi, Steven
Subject: [edk2-devel] [PATCH] [edk2
From: "Shi, Steven"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2103
Current CopyFileOnChange() and SaveFileOnChange() in
BaseTools\Source\Python\Common\Misc.py don't use the dedicated
long file path API to handle the file path strings and cannot
support the long file path copy and save i
Update use of SecPrint() to consistently use \n\r for
line endings to fix formatting issues in the debug log.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Andrew Fish
Cc: Tim Lewis
Signed-off-by: Michael D Kinney
---
EmulatorPkg/Win/Host/WinHost.c | 26 +-
1 file changed, 13 inse
https://bugzilla.tianocore.org/show_bug.cgi?id=2104
When UEFI Applications or UEFI Drivers are unloaded,
the PeCoffLoaderUnloadImageExtraAction() needs to unload
the image using FreeLibrary() if the image was successfully
loaded using LoadLibrrayEx().
This is a regression from the Nt32Pkg that su
https://bugzilla.tianocore.org/show_bug.cgi?id=2104
When UEFI Applications or UEFI Drivers are unloaded,
the PeCoffLoaderUnloadImageExtraAction() needs to unload
the image using FreeLibrary() if the image was successfully
loaded using LoadLibrrayEx().
This is a regression from the Nt32Pkg that su
Rebecca:
I am glad that you add this support. But, I want to confirm whether someone
still uses VS2008 or VS2010.
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>rebe...@bsdio.com
>Sent: Thursday, August 22, 2019 8:17 AM
>To: de
Hij Supreeth,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Supreeth Venkatesh
> Sent: Thursday, August 22, 2019 12:43 AM
> To: Jin, Eric ; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-test][Patch 1/1] uefi-sct/SctPkg: Eliminate
>
Reviewed-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Evelyn Wang
> Sent: Wednesday, August 21, 2019 1:50 AM
> To: devel@edk2.groups.io
> Cc: Huang, Jenny ; Shih, More
> ; Ni, Ray ; Chaganty, Rangasai V
>
> Subject: [edk2-d
Tim,
Thanks. We must have been typing at same time. J
I will mark my 2105 as a dup of your 2104.
I have a patch I will send in a minute. I have tested unload and load multiple.
Mike
From: tim.le...@insyde.com [mailto:tim.le...@insyde.com]
Sent: Wednesday, August 21, 2019 5:47 PM
To: devel@e
Mike –
Ok, it is bug 2104.
From: devel@edk2.groups.io On Behalf Of Michael D Kinney
Sent: Wednesday, August 21, 2019 3:08 PM
To: devel@edk2.groups.io; af...@apple.com; tim.le...@insyde.com; Kinney,
Michael D
Subject: Re: [edk2-devel] EmulatorPkg does not unload DLL after exit
Tim,
T
The parameter to select which version of Visual Studio to use when
building BaseTools only goes back to VS2012. Add support for VS2008 and
VS2010 and fix the code to avoid selecting a newer version if the user
has requested a specific version.
Signed-off-by: Rebecca Cran
---
BaseTools/get_vsvars
Tim,
Thanks for the analysis.
Looks like we need to fix PeCoffLoaderUnloadImageExtraAction()
for winhost to unload the DLL to keep compatibility with Nt32. This is
important
for both apps and unloadable drivers.
Please enter a BZ. This looks like a critical enough regression bug that we
may
On 2019-08-21 07:21:25, Laszlo Ersek wrote:
> On 08/19/19 23:35, Lendacky, Thomas wrote:
> > From: Tom Lendacky
> >
> > Currently, the OVMF code relies on the hypervisor to enable the cache
> > support on the processor in order to improve the boot speed. However,
> > with SEV-ES, the hypervisor i
Tim,
Sounds like you are on to something
The Unix side [1] does a dlclose() to undo a dlsym().
I seem to remember this code flow is very very old, I wonder if it is possible
to do better? For lldb (Xcode) I skipped the LoadLibraryEx()/dlsym() action and
wrote a debugger script to load sym
On 8/21/19 9:31 AM, Laszlo Ersek wrote:
> On 08/19/19 23:35, Lendacky, Thomas wrote:
>> From: Tom Lendacky
>>
>> Allocate memory for the GHCB pages during SEV initialization for use
>> during Pei and Dxe phases. Since the GHCB pages must be mapped as shared
>> pages, modify CreateIdentityMappingPa
On 2019-08-16 18:09, rebe...@bsdio.com wrote:
> Yes, that's going to be important. Given
> https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-change-history-2003-2015?view=vs-2019,
> I suspect support for VS2008 might already have been broken, since it
> reports that "static_assert" was introd
On 8/21/19 9:25 AM, Laszlo Ersek via Groups.Io wrote:
> On 08/19/19 23:35, Lendacky, Thomas wrote:
>> From: Tom Lendacky
>>
>> A GHCB page is needed during the Sec phase, so this new page must be
>> created. Since the GHCB must be marked as an un-encrypted, or shared,
>> page, an additional paget
On 8/21/19 9:21 AM, Laszlo Ersek wrote:
> On 08/19/19 23:35, Lendacky, Thomas wrote:
>> From: Tom Lendacky
>>
>> Currently, the OVMF code relies on the hypervisor to enable the cache
>> support on the processor in order to improve the boot speed. However,
>> with SEV-ES, the hypervisor is not allo
When running a shell app twice, I ran into an interesting problem: global
variables that had initializers were not initialized to the defaults specified
in the source. Running the same shell app under the old NT32 seems to work. It
turns out that the shell app was not being reloaded, but rather
Jaben,
We will miss you from community.
Reviewed-by: Ray Ni
> -Original Message-
> From: Carsey, Jaben
> Sent: Wednesday, August 21, 2019 1:40 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Zhichao ; Kinney,
> Michael D
> Subject: [Patch v1] Maintainers.txt update for ShellPkg
>
>
removing myself from maintainer
promoting Zhichao
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Mike Kinney
Signed-off-by: Jaben Carsey
---
Maintainers.txt | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 919baccc56..1dcc6c64ed 100644
--- a/Mai
Paolo,
It makes sense to match real HW. That puts us back to
the reset vector and handling the initial SMI at
3000:8000. That is all workable from a FW implementation
perspective. It look like the only issue left is DMA.
DMA protection of memory ranges is a chipset feature.
For the current QEM
> On Aug 21, 2019, at 11:55 AM, Rafael Machado
> wrote:
>
> Hi everyone
>
> I would like to ask for some help regarding one question.
> How do I know how the memory communication was set by the BIOS/MRC/FSP during
> the initialization process?
> For example, I would like to know if the memor
Hi everyone
I would like to ask for some help regarding one question.
How do I know how the memory communication was set by the BIOS/MRC/FSP
during the initialization process?
For example, I would like to know if the memory controller is working with
the memories in single channel or dual channel
On 21/08/19 17:48, Kinney, Michael D wrote:
> Perhaps there is a way to avoid the 3000:8000 startup
> vector.
>
> If a CPU is added after a cold reset, it is already in a
> different state because one of the active CPUs needs to
> release it by interacting with the hot plug controller.
>
> Can th
From: "Shi, Steven"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2103
Current CopyFileOnChange() and SaveFileOnChange() in
BaseTools\Source\Python\Common\Misc.py don't use the dedicated
long file path API to handle the file path strings and cannot
support the long file path copy and save i
Could we have an initial SMBASE that is within TSEG.
If we bring in hot plug CPUs one at a time, then initial
SMBASE in TSEG can reprogram the SMBASE to the correct
value for that CPU.
Can we add a register to the hot plug controller that
allows the BSP to set the initial SMBASE value for
a hot
On Wed, 2019-08-21 at 01:24 -0500, Eric Jin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2098
Please add the details of the patch to the commit message.
"In the ExitBootServices() test, after ExitBootServices() call, all
boot services are forbidden. The original design is to save th
Hi Anthony,
On 08/13/19 13:30, Anthony PERARD wrote:
> This patch allows the ResetVector to be run indenpendently from build
> time addresses.
>
> The goal of the patch is to avoid having to create RAM just below 4G
> when creating a Xen PVH guest while being compatible with the way
> hvmloader c
On 08/15/19 13:03, Laszlo Ersek wrote:
> On 08/13/19 13:30, Anthony PERARD wrote:
>> Patch series available in this git branch:
>> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
>> br.platform-xen-pvh-v5
>>
>> Changes in v5:
>> - patch 23 got a rework of the lapic range skipping
>> - sma
Perhaps there is a way to avoid the 3000:8000 startup
vector.
If a CPU is added after a cold reset, it is already in a
different state because one of the active CPUs needs to
release it by interacting with the hot plug controller.
Can the SMRR for CPUs in that state be pre-programmed to
match the
On 08/19/19 23:35, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> The SEV support will clear the C-bit from non-RAM areas. The early GDT
> lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT
> will be read as un-encrypted even though it is encrypted. This will result
> in
On Tue, 2019-08-20 at 20:36 -0500, Eric Jin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1571
>
> Cc: Supreeth Venkatesh
> Signed-off-by: Eric Jin
Matches UEFI v2.7 Specification.
Reviewed-by: Supreeth Venkatesh
> ---
> uefi-sct/SctPkg/UEFI/UEFI.dec | 2 +-
> 1 file change
On Tue, 2019-08-20 at 20:36 -0500, Eric Jin wrote:
> Cc: Supreeth Venkatesh
> Signed-off-by: Eric Jin
Reviewed-by: Supreeth Venkatesh
> ---
> uefi-sct/SctPkg/UEFI/UEFI.dec | 206 +---
> --
> 1 file changed, 103 insertions(+), 103 deletions(-)
>
> diff --git a/uefi-
Thanks Liming help :)
Donald
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, August 21, 2019 9:46 PM
> To: Zeng, Star ; Kuo, Donald ;
> devel@edk2.groups.io; ler...@redhat.com; Dong, Eric
>
> Cc: Ni, Ray ; Chan, Amy ;
> Chaganty, Rangasai V ; Lai, Luke
> ; Li, Kevin Y ;
> leif
Add a function that checks if a target language is in the supported
languages list. Add some calls to this function where appropriate in
UefiLib.c
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Tom Zhao
---
MdePkg/Include/Library/UefiLib.h | 16 ++
MdePkg/Library/UefiLib/UefiLib.c | 59
On 08/19/19 23:35, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> Allocate memory for the GHCB pages during SEV initialization for use
> during Pei and Dxe phases. Since the GHCB pages must be mapped as shared
> pages, modify CreateIdentityMappingPageTables() so that pagetable entries
> are cre
Hi Liming
The function is only used inside UefiLib in the edk2 package, however,
the intent was to use this in our UEFI implementation. I figured that
others might find this functionality useful. The functions inside
UefiLib were only modified for consistency.
Tom
On 21/08/2019 14:34, Limin
On 08/19/19 23:35, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> A GHCB page is needed during the Sec phase, so this new page must be
> created. Since the GHCB must be marked as an un-encrypted, or shared,
> page, an additional pagetable page is required so break down the 2MB
> region where t
On 08/19/19 23:35, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> Currently, the OVMF code relies on the hypervisor to enable the cache
> support on the processor in order to improve the boot speed. However,
> with SEV-ES, the hypervisor is not allowed to change the CR0 register
> to enable cac
Hi Tom,
On 08/19/19 23:35, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> This patch series provides support for running EDK2/OVMF under SEV-ES.
>
> Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the
> SEV support to protect the guest register state from the hypervisor.
Laszlo:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, August 21, 2019 4:46 PM
> To: Gao, Liming ; devel@edk2.groups.io; Kinney, Michael
> D
> Cc: Mike Turner ; Wang, Jian J
> ; Wu, Hao A ; Bi, Dandan
>
>
Yes. I'll double check this patch.
Thanks,
Bob
-Original Message-
From: Gao, Liming
Sent: Wednesday, August 21, 2019 9:59 PM
To: Feng, Bob C ; devel@edk2.groups.io
Subject: RE: [Patch][edk2-stable201908] BaseTools: Incorrect error message for
library instance not found
Bob:
After I a
Bob:
After I apply this patch, I will meet with build failure to build -p
MdePkg\MdePkg.dsc. Can you help check it?
Thanks
Liming
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, August 21, 2019 2:27 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [P
Done. And, push @30781febe2106cc0d7186e70136120353cd67df2
Thanks
Liming
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, August 20, 2019 10:00 PM
> To: Gao, Liming ; Kuo, Donald ;
> devel@edk2.groups.io; ler...@redhat.com; Dong, Eric
>
> Cc: Ni, Ray ; Chan, Amy ; Chaganty,
> Ran
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng
> Sent: Wednesday, August 21, 2019 5:57 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C
> Subject: [edk2-devel] [Patch][edk2-stable201908] BaseTools
Tom:
Can you send the patch by the command 'git send-email xxx.patch'? If so, I
can extract the patch from the mail.
If this function is only used in UefiLib, how about define it as the internal
function?
Thanks
Liming
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of To
Forwarded Message
Subject: [PATCH v1 0/1] MdePkg: UefiLib: Add a function to check if a
language is supported
Date: Tue, 20 Aug 2019 17:13:09 +0100
From: Tom Zhao
To: edk2-de...@lists.01.org
CC: michael.d.kin...@intel.com, liming@intel.com
Add a functi
Forwarded Message
Subject: [PATCH v1 1/1] MdePkg: UefiLib: Add a function to check if a
language is supported
Date: Tue, 20 Aug 2019 17:13:19 +0100
From: Tom Zhao
To: edk2-de...@lists.01.org
CC: michael.d.kin...@intel.com, liming@intel.com
Add a function
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770
1) IOMMU PMR feature should be generic to support different hardware
architecture. Platforms may request no overlap between PMR regions
and system reserve memory. Create an interface to control PLMR/PHMR
regions. It allows silicon code to ad
On 08/19/19 16:10, Paolo Bonzini wrote:
> On 19/08/19 01:00, Yao, Jiewen wrote:
>> in real world, we deprecate AB-seg usage because they are vulnerable
>> to smm cache poison attack. I assume cache poison is out of scope in
>> the virtual world, or there is a way to prevent ABseg cache poison.
>
>
Hi Leif, Laszlo
śr., 21 sie 2019 o 11:11 Laszlo Ersek napisał(a):
>
> On 08/19/19 19:14, Leif Lindholm wrote:
> > +Stewards (don't panic!)
> >
> > On Fri, Aug 16, 2019 at 11:03:42PM +0200, Marcin Wojtas wrote:
> >> Hi Leif,
> >>
> >> pt., 16 sie 2019 o 19:10 Leif Lindholm
> >> napisał(a):
> >>>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2090
This is a regression issue introduced by commit e8449e.
This patch is going to fix this issue.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/build/build.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
On 08/19/19 19:14, Leif Lindholm wrote:
> +Stewards (don't panic!)
>
> On Fri, Aug 16, 2019 at 11:03:42PM +0200, Marcin Wojtas wrote:
>> Hi Leif,
>>
>> pt., 16 sie 2019 o 19:10 Leif Lindholm napisał(a):
>>>
>>> On Thu, Aug 15, 2019 at 04:54:07AM +0200, Marcin Wojtas wrote:
This patch adds de
Hi Liming,
On 08/19/19 02:40, Gao, Liming wrote:
>> ... Ugh, wait. I've actually implemented this for OVMF almost 2 years
>> ago! And the answer to my question is "yes":
>>
>> https://bugzilla.tianocore.org/show_bug.cgi?id=386
>> https://lists.01.org/pipermail/edk2-devel/2017-November/018312.ht
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
---
UefiCpuPkg/Application/Cpuid/Cpuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c
b/UefiCpuPkg/Application/Cpuid/Cpuid.c
index f39a7fb33ae5..cee64f2fb5fc 100
Some of files touched by this patch still having old copyright year, please
help to extend.
With above update: Reviewed-by: Chasel Chiu
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, August 21, 2019 4:01 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, C
The header file is used but missing in INF,which causes
warning message when building them.
https://bugzilla.tianocore.org/show_bug.cgi?id=2037
Cc: Michael Kubacki
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf
The header files are used but missing in INF,which causes
warning message when building them.
https://bugzilla.tianocore.org/show_bug.cgi?id=2037
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.../MinPlatformPkg/Flash/SpiFvbService/SpiF
There are some header files used but not included in INF
files. This causes warings are generated when building the
packages. So now add them into INF files.
https://bugzilla.tianocore.org/show_bug.cgi?id=2037
Cc: Sai Chaganty
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Ga
62 matches
Mail list logo