> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Wednesday, August 07, 2019 12:20 PM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L; Andrew Fish; Ni, Ray
> Subject: [edk2-devel] [Patch 2/3] EmulatorPkg: Remove
> UNIX_
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Wednesday, August 07, 2019 12:20 PM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L; Andrew Fish; Ni, Ray
> Subject: [edk2-devel] [Patch 1/3] EmulatorPkg: Fix VS20xx IA3
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, August 06, 2019 12:46 PM
> To: Wu, Hao A; Jin, Eric; devel@edk2.groups.io; Kinney, Michael D
> Cc: Sean Brogan; Bret Barkelew; Wang, Jian J; Gao, Liming; af...@apple.com;
> ler...@redhat.com; leif.lindh...@linaro.org
> Subject:
Ray:
I agree Marc option to keep SMM definition and keep SmmAccess.h in
MdeModulePkg.
And, this header file can be updated to refer the definition in MmAccess.h
from MdePkg.
This way aligns to current SMM definition in MdePkg.
Thanks
Liming
>-Original Message-
>From: Ni, Ray
>Se
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
python3 change the module name of Queue to queue.
python3 add a new log handler of QueueHandler.
This patch is to make Multiple process AutoGen
feature work for python2
Cc: Liming Gao
Signed-off-by: Bob Feng
---
.../Source/Python/AutoGen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
These functions are used for get platform scope
build options. They will be used in later patches.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/AutoGen.py| 10 +-
.../Source/Python/Workspace/DscBu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
The build config files are target.txt, build rule, tooldef
During a build, the config is not changed, so the object to
handle them need to be singleton.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/AutoGen.py
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Assign the Module AutoGen tasks into multiple
sub process.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
.../Source/Python/AutoGen/AutoGenWorker.py| 191 ++
BaseTools/Source/Python/AutoGen/DataPipe.py | 17 +-
BaseTool
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Add shared data for autogen processes.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ++-
BaseTools/Source/Python/build/build.py | 10 ++
2 files changed, 8 insertions(+
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
The WorkspaceAutoGen.__InitWorker function is too long, it's hard
to read and understand.
This patch is to separate the __InitWorker into multiple small ones.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/Auto
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
In order to improve the build performance, we implemented
multiple-processes AutoGen. This change will reduce 20% time
for AutoGen phase.
The design document can be got from:
https://edk2.groups.io/g/devel/files/Designs/2019/0627/Multiple-th
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Build tool supports user to specify the conf folder.
To make the build options be evaluated at the beginning
of launching build, extract the buildoption function
from build.py to a new .py file.
Signed-off-by: Bob Feng
Cc: Liming Gao
---
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
To support Ctrl+S and Ctrl+Q, we enable block queue
for log.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
.../Source/Python/AutoGen/AutoGenWorker.py| 6 ++-
BaseTools/Source/Python/Common/EdkLogger.py | 10 +++--
BaseTools/Source/Pyt
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
AutoGen processes race the logfile. To resolve this issue,
this patch create a LogAgent thread in main process to write
the log content to console or file, Other process will send
the log content to the LogAgent.
Cc: Liming Gao
Signed-off-b
https://bugzilla.tianocore.org/show_bug.cgi?id=2055
Remove the use of the defines UNIX_SEC_BUILD and
WIN_SEC_BUILD. This simplifies the build command
for the EmulatorPkg. Instead, use !if statements
in the DSC file using (ARCH) and $(FAMILY) to
determine if the build is for a Windows or POSIX
en
https://bugzilla.tianocore.org/show_bug.cgi?id=2056
The IA32 build of the EmulatorPkg for VS20xx does not boot
because the default value of PCD PcdPeiServicesTablePage
is set for X64 Windows Host environments. If the
EmulatorPkg is build for an IA32 Windows Host environment,
then set this PCD to
https://bugzilla.tianocore.org/show_bug.cgi?id=162
https://bugzilla.tianocore.org/show_bug.cgi?id=2055
https://bugzilla.tianocore.org/show_bug.cgi?id=2056
* Fix VS20xx IA32 boot failure
* Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
* Add -D DISABLE_NEW_DEPRECATED_INTERFACES
Cc: Jordan Justen
Cc: Andrew
https://bugzilla.tianocore.org/show_bug.cgi?id=162
Update EmulatorPkg specific modules and libraries to use
safe string functions in BaseLib and safe PcdSetxx()
functions in PcdLib. With these updates, the define
DISABLE_NEW_DEPRECATED_INTERFACES is enabled in the DSC
file.
Cc: Jordan Justen
Cc
If this is considered as a security bug, we need fix all possible information
leak. Not only this one.
For example, the SMM data is installed the DXE database, such as loaded image
protocol.
Just fixing in one place is not good enough to resolve all concern.
To me, this patch is like to harden th
This is still a security bug fix, which needs CVE number added in title. With it
addressed,
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Wednesday, August 07, 2019 8:18 AM
> To: devel@edk2.groups
1. Update CPUStatus to CpuStatus in comments to align comments
with code.
2. Add "OUT" attribute for "ProcedureArguments" parameter in function
header.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
---
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 6 +++---
1 fi
OK. I got your point.
1. The length of debug device info structure indicate the correct length should
be parsed. I'd prefer to see this as a backward compatibility as you mentioned.
See below:
The ACPI table may be updated to extend some of the table. For example, if
DBG2->Debug Device Info str
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Tuesday, August 06, 2019 10:17 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Gao, Liming
>
>Subject: [edk2-devel] [PATCH] MdePkg/BaseUefiDecom
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Kubacki, Michael A
>Sent: Wednesday, August 07, 2019 4:34 AM
>To: devel@edk2.groups.io
>Cc: Chiu, Chasel ; Desimone, Nathaniel L
>; Gao, Liming
>Subject: [edk2-devel] [edk2
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2002
This commit will update the logic in function SmmVariableGetStatistics()
so that the pointer fields ('Next' and 'Name') in structure
VARIABLE_INFO_ENTRY will not be copied into the SMM communication buffer.
Doing so will prevent SMM pointers
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, August 06, 2019 10:56 PM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: Gao, Liming; Wang, Jian J; Zeng, Star
> Subject: RE: [edk2-devel] [PATCH v1] MdeModulePkg/Variable/RuntimeDxe:
> Not copy SMM pointers in comm buffer
>
> The DstInf
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1983
PeiLib.inf and TestPointCheckLibNull.inf currently have the same GUID.
This patch assigns a unique GUID to each library INF file.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Platform/Intel/MinPlat
Minor suggestions inline:
On Thu, Jul 25, 2019 at 04:22:48PM +0100, Pete Batard wrote:
> This documents the installation of vanilla Debian 10.0 ARM64 (netinst),
> which we validated for both Model B and Model B+.
> Also fix an erroneous reference in an RPi3.fdf comment.
>
> Signed-off-by: Pete Ba
On Thu, Jul 25, 2019 at 11:27:15AM +0100, Michael Brown wrote:
> Most functions in FdtDxe currently return VOID and report errors using
> only DEBUG. Update functions to return EFI_STATUS and report errors
> using Print() so that errors are at least visible in non-debug builds.
>
> Signed-off-by:
> On Aug 6, 2019, at 3:15 AM, via Groups.Io
> wrote:
>
>Hello All,
>
>I am new to EDKII (UEFI) development. Cloned UDK2018 branch and modified
> Conf/target.txt to build OVMF package. OVMF.fd boots up fine on QEMU
>
Shakthi,
Conf/target.txt is just the default arguments for the b
On Thu, Jul 25, 2019 at 10:10:58AM +0900, Masahisa Kojima wrote:
> This is a refactoring of phy address handling in Netsec driver.
> NETSEC SDK, low level driver for NetsecDxe, did not store phy address.
> User should specify the phy address as an argument to
> the SDK public functions.
> It preven
*Reminder:* TianoCore Design / Bug Triage - EMEA
*When:* Wednesday, 7 August 2019, 8:00am to 9:00am, (GMT-07:00) America/Los
Angeles
*Where:* https://zoom.us/j/695893389
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=502934 )
*Organizer:* Stephano Cetola stephano.cet...@linux.i
The DstInfoEntry is better to have identifer [out] instead of [in]?
Thanks,
Star
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu,
> Hao A
> Sent: Tuesday, August 6, 2019 3:19 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming ;
> Wa
Hi Zhichao,
Thanks for the feedback. I had a look at your code and I have put comments
inline (in GitHub) to describe why I think it does not achieve the same
functionality as the patch I've submitted.
I copied my comments below as well, so that they're easier to access:
"""
The ParseAcpi() ca
Hello All,
I am new to EDKII (UEFI) development. Cloned UDK2018 branch and modified
Conf/target.txt to build OVMF package. OVMF.fd boots up fine on QEMU
Now I am trying to create a new package and build. I am following EDK II
Module Writer's Guide v 7.0
I have crea
Laszlo,
Do you want to avoid touching the OvmfPkg due the file removal in MdeModulePkg?
I prefer to remove the files in MdeModulePkg to avoid future confusion.
Thanks,
Ray
> -Original Message-
> From: Chen, Marc W
> Sent: Tuesday, August 6, 2019 4:57 PM
> To: devel@edk2.groups.io; ler...
Reviewed-by: Jeff Booher-Kaeding
On Thu, 2019-08-01 at 12:33 +0530, shrishail wrote:
> From: Shrishail Patil
>
> Adding HII Config Access Protocol to IHVSCT.
> This patch includes the Image information.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shrishail patil
Reviewed-by: Jeff Booher-Kaeding
On Thu, 2019-08-01 at 12:33 +0530, shrishail wrote:
> From: Shrishail Patil
>
> Adding Firmware Management Protocol to IHVSCT.
> This patch includes the Image information.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shrishail pati
Reviewed-by: Jeff Booher-Kaeding
On Thu, 2019-08-01 at 12:33 +0530, shrishail wrote:
> From: Shrishail Patil
>
> Adding HII Config Access Protocol to IHVSCT
> This patch contains the changes to build/compilation Changes.
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by:
From: Damian Nikodem
Reclaim may free page table pages that are required to handle current page
fault. This causes a page leak, and, after sufficent number of specific
page fault+reclaim pairs, we run out of reclaimable pages and hit:
ASSERT (MinAcc != (UINT64)-1);
To remedy, prevent pages esse
Reviewed-by: Jeff Booher-Kaeding
On Thu, 2019-08-01 at 12:33 +0530, shrishail wrote:
> From: Shrishail Patil
>
> Adding Firmware Management Protocol to IHVSCT.
> This patch contains the changes to build/compilation Changes.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off
My comments are inline, and my review is condtional upon fixing them
Reviewed-by: Jeff Booher-Kaeding
On Thu, 2019-08-01 at 12:33 +0530, shrishail wrote:
> From: Shrishail Patil
>
> Adding HII Config Access Protocol to IHVSCT
> This patch contains source code which is copied from
> UEFISCT and
Hi Liming and Ray
Do you also agree?
Thanks,
Marc
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Friday, August 2, 2019 10:14 AM
> To: devel@edk2.groups.io; Chen, Marc W ; Ni, Ray
> ; Gao, Liming
> Cc: Kinney, Michael D
> Subject: Re: [edk2-devel
Hi Eric,
This patch series also can be consolidated to a smaller patch set.
Please help double check.
Thanks,
Dandan
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Eric Jin
> Sent: Thursday, August 1, 2019 4:39 PM
> To: devel@edk2.groups.i
For 3 - 6: Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Krzysztof Koch
> Sent: Thursday, August 1, 2019 4:44 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao ; sami.muja
I got your point. How about this:
https://github.com/ZhichaoGao/edk2/commit/112a41255cb775f5ebede089b8b07ba7b836ec44
I make a minor change of it. But I can't test it because I don't have a
platform that implement DBG2 table.
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2002
This commit will update the logic in function SmmVariableGetStatistics()
so that the pointer fields ('Next' and 'Name') in structure
VARIABLE_INFO_ENTRY will not be copied into the SMM communication buffer.
Doing so will prevent SMM pointers
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
These functions are used for get platform scope
build options. They will be used in later patches.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/AutoGen.py| 10 +-
.../Source/Python/Workspace/DscBu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Add shared data for autogen processes.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ++-
BaseTools/Source/Python/build/build.py | 10 ++
2 files changed, 8 insertions(+
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
The build config files are target.txt, build rule, tooldef
During a build, the config is not changed, so the object to
handle them need to be singleton.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/AutoGen.py
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
python3 change the module name of Queue to queue.
python3 add a new log handler of QueueHandler.
This patch is to make Multiple process AutoGen
feature work for python2
Cc: Liming Gao
Signed-off-by: Bob Feng
---
.../Source/Python/AutoGen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Assign the Module AutoGen tasks into multiple
sub process.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
.../Source/Python/AutoGen/AutoGenWorker.py| 191 ++
BaseTools/Source/Python/AutoGen/DataPipe.py | 17 +-
BaseTool
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
AutoGen processes race the logfile. To resolve this issue,
this patch create a LogAgent thread in main process to write
the log content to console or file, Other process will send
the log content to the LogAgent.
Cc: Liming Gao
Signed-off-b
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
In order to improve the build performance, we implemented
multiple-processes AutoGen. This change will reduce 20% time
for AutoGen phase.
The design document can be got from:
https://edk2.groups.io/g/devel/files/Designs/2019/0627/Multiple-th
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
To support Ctrl+S and Ctrl+Q, we enable block queue
for log.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
.../Source/Python/AutoGen/AutoGenWorker.py| 6 ++-
BaseTools/Source/Python/Common/EdkLogger.py | 10 +++--
BaseTools/Source/Pyt
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
The WorkspaceAutoGen.__InitWorker function is too long, it's hard
to read and understand.
This patch is to separate the __InitWorker into multiple small ones.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/Auto
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Build tool supports user to specify the conf folder.
To make the build options be evaluated at the beginning
of launching build, extract the buildoption function
from build.py to a new .py file.
Signed-off-by: Bob Feng
Cc: Liming Gao
---
57 matches
Mail list logo
