[edk2-devel] [PATCH 2/3] UefiCpuPkg/PiSmmCpu: Refine CR2 save/restore logic

2019-07-26 Thread Ni, Ray
Because IsStaticPageTableEnabled() is added for both IA32 and x64 build, the CR2 save/restore logic can be refined: 1. Remove arch specific SaveCr2() / RestoreCr2() implementation; 2. Conditionally save and restore CR2 in SmiRendezvous(). Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc

[edk2-devel] [PATCH 0/3] Allow SMM access-out when static paging is OFF

2019-07-26 Thread Ni, Ray
The patch set refines the original CR2 save/restore logic by adding a new internal function IsStaticPageTableEnabled() because now there are two use cases that need to conditionally do something based on whether static page table is enabled. Based on the refine, the patch changes the policy to allo

[edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Allow SMM access-out when static paging is OFF

2019-07-26 Thread Ni, Ray
Commit c60d36b4d1ee1f69b7cca897d3621dfa951895c2 * UefiCpuPkg/SmmCpu: Block access-out only when static paging is used updated page fault handler to treat SMM access-out as allowed address when static paging is not used. But that commit is not complete because the page table is still updated in Se

[edk2-devel] [PATCH 1/3] UefiCpuPkg/PiSmmCpu: Add Internal function IsStaticPageTableEnabled

2019-07-26 Thread Ni, Ray
The internal function reflects the status whether static page table is enabled. Signed-off-by: Ray Ni Cc: Laszlo Ersek Cc: Eric Dong https://edk2.groups.io/g/devel/message/44468 Mute This Topic: https://groups.io/mt/32616001/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2

Re: [edk2-devel] [PATCH V2 0/6] Support 5-level paging in DXE long mode

2019-07-26 Thread Michael D Kinney
Ray, The .h files represent information from specifications and components that include the include files do so because their source code depends on definitions associated with those specifications. It does not represent what CPUs are present in the platform. It may represent what CPUs the modu

Re: [edk2-devel] [edk2-non-osi] [PATCH 6/6] Cleanup maintainers, contributions, and licenses

2019-07-26 Thread Leif Lindholm
On Thu, Jul 25, 2019 at 10:35:48AM -0700, Nate DeSimone wrote: > - Merged Maintainers.txt from devel-MinPlatform branch with > Maintainers.txt in master branch and updated to match the maintainers > in the equivalent edk2-platforms Maintainers.txt > > - Removed the old Contributions.txt files

Re: [edk2-devel] [PATCH v3 33/35] OvmfPkg: Introduce XenIoPvhDxe to initialize Grant Tables

2019-07-26 Thread Laszlo Ersek
On 07/26/19 18:06, Anthony PERARD wrote: > On Wed, Jul 10, 2019 at 04:05:02PM +0200, Laszlo Ersek wrote: >> On 07/04/19 16:42, Anthony PERARD wrote: >>> + if (State == NULL) { >>> +Status = EFI_OUT_OF_RESOURCES; >>> +goto Error; >>> + } >>> + >>> + Allocation = AllocateReservedPages (XE

Re: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring

2019-07-26 Thread Krzysztof Koch
Hi, Is there any way I can help get this patch merged? I have a couple of small patch sets ready to submit but they are pending on this series. These small sets of patches are a result of me breaking down the "[PATCH v1 00/11] Add security checks in the Acpiview table parsers" series into smal

Re: [edk2-devel] [PATCH v3 33/35] OvmfPkg: Introduce XenIoPvhDxe to initialize Grant Tables

2019-07-26 Thread Anthony PERARD
On Wed, Jul 10, 2019 at 04:05:02PM +0200, Laszlo Ersek wrote: > On 07/04/19 16:42, Anthony PERARD wrote: > > + > > +STATIC > > +VOID > > +EFIAPI > > +XenIoPvhDxeNotifyExitBoot ( > > + IN EFI_EVENT Event, > > + IN VOID *Context > > + ) > > +{ > > + XEN_IO_PVH_STATE *State; > > + EFI_STAT

[edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Add display support

2019-07-26 Thread Agyeman, Prince
Added vbt and configured gpio to enable N1xxxW display. Cc: Liming Gao Cc: Ankit Sinha Cc: Nate DeSimone Cc: Michael Kubacki Cc: Chasel Chiu Signed-off-by: Prince Agyeman --- .../N1xxWU/Library/BoardInitLib/N1xxWUGpioTable.c | 2 +- Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Op

Re: [edk2-devel] [Patch v3 6/6] UefiCpuPkg/RegisterCpuFeaturesLib: Start all processors simultaneously.

2019-07-26 Thread Laszlo Ersek
On 07/24/19 09:07, Dong, Eric wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973 > > For semaphore type register, it required all processors to do the > task at the same time. > Current logic begins BSP's task after all APs have finished their tasks. > This will caused set semaphore

Re: [edk2-devel] [Patch v3 5/6] UefiCpuPkg/CpuMpPei: Produce EDKII_PEI_MP_SERVICES2_PPI.

2019-07-26 Thread Laszlo Ersek
On 07/24/19 09:07, Dong, Eric wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973 > > Produce new EDKII_PEI_MP_SERVICES2_PPI service. > > It includes all APIs existed in EFI_PEI_MP_SERVICES_PPI > and add new API EDKII_PEI_MP_SERVICES_STARTUP_ALL_CPUS. > > Cc: Ray Ni > Cc: Laszlo E

Re: [edk2-devel] [Patch v3 4/6] UefiCpuPkg: Add new EDKII_PEI_MP_SERVICES2_PPI

2019-07-26 Thread Laszlo Ersek
On 07/24/19 09:07, Dong, Eric wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973 > > Add definition for new EDKII_PEI_MP_SERVICES2_PPI. > > It includes all APIs existed in EFI_PEI_MP_SERVICES_PPI > and add new API EDKII_PEI_MP_SERVICES_STARTUP_ALL_CPUS. > > Cc: Ray Ni > Cc: Laszl

Re: [edk2-devel] [Patch v3 2/6] UefiCpuPkg/MpInitLib: Add MpInitLibStartupAllCPUs API.

2019-07-26 Thread Laszlo Ersek
On 07/24/19 09:07, Dong, Eric wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973 > > Add new MpInitLibStartupAllCPUs API uses to start all processors > at the same time. > > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Chandana Kumar > Cc: Star Zeng > Signed-off-by: Eric Dong > Reviewe

Re: [edk2-devel] [Patch v3 3/6] UefiCpuPkg/MpInitLibUp: Add MpInitLibStartupAllCPUs API.

2019-07-26 Thread Laszlo Ersek
On 07/24/19 09:07, Dong, Eric wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973 > > Add new MpInitLibStartupAllCPUs API uses to start all processors > at the same time. > > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Chandana Kumar > Cc: Star Zeng > Signed-off-by: Eric Dong > --- >

Re: [edk2-devel] [Patch v3 1/6] UefiCpuPkg/Include/MpInitLib.h: Add MpInitLibStartupAllCPUs API.

2019-07-26 Thread Laszlo Ersek
On 07/24/19 09:07, Dong, Eric wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973 > > Add new MpInitLibStartupAllCPUs API uses to start all processors > at the same time. > > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Chandana Kumar > Cc: Star Zeng > Signed-off-by: Eric Dong > Reviewe

Re: [edk2-devel] [PATCH V2 0/6] Support 5-level paging in DXE long mode

2019-07-26 Thread Laszlo Ersek
On 07/24/19 12:00, Ni, Ray wrote: > v2: >Refined the patch according to reviewers' all comments except: > 0A0h cannot be changed to A0h or build fails. >A big change in this patch is Cpuid.h is moved from UefiCpuPkg to MdePkg. >The move is based on real requirement when certain mo

[edk2-devel] [PATCH] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file

2019-07-26 Thread Marc W Chen
This is a special GUID extension Hob to describe SMRAM memory regions Cc: Michael D Kinney Cc: Liming Gao Cc: Ray Ni Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2020 Signed-off-by: Marc W Chen --- MdePkg/Include/Guid/SmramMemoryReserve.h | 45 MdePkg/M

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Allow SMM access-out when static paging is OFF

2019-07-26 Thread Laszlo Ersek
On 07/26/19 11:58, Laszlo Ersek wrote: > Ray, > > On 07/18/19 08:58, Ni, Ray wrote: >> Commit c60d36b4d1ee1f69b7cca897d3621dfa951895c2 >> * UefiCpuPkg/SmmCpu: Block access-out only when static paging is used >> >> updated page fault handler to treat SMM access-out as allowed >> address when static

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Allow SMM access-out when static paging is OFF

2019-07-26 Thread Laszlo Ersek
Ray, On 07/18/19 08:58, Ni, Ray wrote: > Commit c60d36b4d1ee1f69b7cca897d3621dfa951895c2 > * UefiCpuPkg/SmmCpu: Block access-out only when static paging is used > > updated page fault handler to treat SMM access-out as allowed > address when static paging is not used. > > But that commit is not co

Re: [edk2-devel][Patch 0/3] Add destructor to CloseEvent

2019-07-26 Thread Liming Gao
Thanks for your fix. The patch set is good. Reviewed-by: Liming Gao >-Original Message- >From: Xu, Wei6 >Sent: Friday, July 26, 2019 11:11 AM >To: devel@edk2.groups.io >Cc: Kinney, Michael D ; Gao, Liming > >Subject: [edk2-devel][Patch 0/3] Add destructor to CloseEvent > >REF: https://b

FW: [edk2-devel] [PATCH V2] ShellPkg/Pci.c: Update supported link speed to PCI4.0

2019-07-26 Thread Gao, Zhichao
Ping. Please help to review it. Thanks, Zhichao -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, Zhichao Sent: Monday, July 22, 2019 2:58 PM To: devel@edk2.groups.io Cc: Carsey, Jaben ; Ni, Ray ; Oleksiy Subject: [edk2-devel] [PATCH V2] Shel

FW: [edk2-devel] [PATCH V2] ShellPkg/UefiShellDriver1CommandsLib: Make array big enough

2019-07-26 Thread Gao, Zhichao
Ping. Please help to review it. Thanks, Zhichao -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, Zhichao Sent: Monday, July 22, 2019 2:58 PM To: devel@edk2.groups.io Cc: Carsey, Jaben ; Ni, Ray ; Oleksiy Subject: [edk2-devel] [PATCH V2] Shel

FW: [edk2-devel] [PATCH V2] ShellPkg/UefiHandleParsingLib: Fix incorrect reallocate pool

2019-07-26 Thread Gao, Zhichao
Ping. Please help to review it. Thanks, Zhichao -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, Zhichao Sent: Monday, July 22, 2019 2:58 PM To: devel@edk2.groups.io Cc: Carsey, Jaben ; Ni, Ray ; Andrew Fish Subject: [edk2-devel] [PATCH V2]

Re: [edk2-devel] [PATCH edk2-platforms 2/4] Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp

2019-07-26 Thread Gary Lin
On Fri, Jul 26, 2019 at 07:06:39AM +, Gary Lin wrote: > BootManagerMenuApp wasn't imported so the Boot Device Menu never showed > correctly. > I should add more details for the fix below. > Also fix the description of UiApp. In the "Rule.Common.UEFI_APPLICATION.UI" section, it intends to ch

[edk2-devel] [PATCH edk2-platforms 1/4] Vlv2TbltDevicePkg: Adjust the device priority

2019-07-26 Thread Gary Lin
In BootOptionPriority(), the higher number implies the lower boot priority. This commit lowers the priority of network booting and raises the priority of the local devices. Besides, SD and EMMC are also added to BootOptionPriority() since Minnowboard comes with a SD card slot. Cc: Zailiang Sun Cc

[edk2-devel] [PATCH edk2-platforms 4/4] Vlv2TbltDevicePkg: Clean up the unused variables and function

2019-07-26 Thread Gary Lin
In PlatformBootOption.c: * mContinueBoot and mBootMenuBoot were assigned as "!EnterSetup" before being used. However, EnterSetup is always "FALSE", so it's meaningless to keep those variables. * mPxeBoot is defined but never used. * DetectKeypressCallback() is never used. So we can remove it

[edk2-devel] [PATCH edk2-platforms 3/4] Vlv2TbltDevicePkg: Only sort boot options when necessary

2019-07-26 Thread Gary Lin
* PlatformBootManagerAfterConsole() always sorted the boot options at the end, and this would invalidate the BootOrder created by the user. Besides, the current implementation would sort the boot options twice, and this is not efficient. We should just sort the boot options once at the end

[edk2-devel] [PATCH edk2-platforms 2/4] Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp

2019-07-26 Thread Gary Lin
BootManagerMenuApp wasn't imported so the Boot Device Menu never showed correctly. Also fix the description of UiApp. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 3 ++- Platform/Intel/Vlv2TbltDevicePkg/P

[edk2-devel] [PATCH edk2-platforms 0/4] Fix the boot order and the boot menu

2019-07-26 Thread Gary Lin
After switching to MdeModulePkg BdsDxe, the boot option created by OS was always put at the end of BootOrder after reboot. Besides, the PXE boot options were always the first boot options. This series fixes the priority of boot options and stops sorting the boot options after the first boot. The m