Ping. Please help to review it. Thanks, Zhichao
-----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, Zhichao Sent: Monday, July 22, 2019 2:58 PM To: devel@edk2.groups.io Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com>; Oleksiy <oleks...@ami.com> Subject: [edk2-devel] [PATCH V2] ShellPkg/Pci.c: Update supported link speed to PCI4.0 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1955 Refer PCI express base specification Reversion 4.0, Version 1.0, Table 7-32, Supported Link Speeds Vector bit 3 indicate the speed 16 GT/s. Add it to shell command 'pci ...'. Change the MaxLinkSpeed other values' result from 'Unknown' to 'Reserved'. Cc: Jaben Carsey <jaben.car...@intel.com> Cc: Ray Ni <ray...@intel.com> Cc: Oleksiy <oleks...@ami.com> Signed-off-by: Zhichao Gao <zhichao....@intel.com> --- V2: Update the copyright. And remind that this patch isn't update the code to match PCI 5.0. I didn't find edk repo update the related code to PCI 5.0. Please let me know if there is a requirement to update this code to PCI 5.0. ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c index ba9caa7743..b58ce3c2f0 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c @@ -1,7 +1,7 @@ /** @file Main file for Pci shell Debug1 function. - Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2005 - 2019, Intel Corporation. All rights + reserved.<BR> (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> SPDX-License-Identifier: BSD-2-Clause-Patent @@ -4515,8 +4515,11 @@ ExplainPcieLinkCap ( case 3: MaxLinkSpeed = L"8.0 GT/s"; break; + case 4: + MaxLinkSpeed = L"16.0 GT/s"; + break; default: - MaxLinkSpeed = L"Unknown"; + MaxLinkSpeed = L"Reserved"; break; } ShellPrintEx (-1, -1, @@ -4672,6 +4675,9 @@ ExplainPcieLinkStatus ( case 3: CurLinkSpeed = L"8.0 GT/s"; break; + case 4: + CurLinkSpeed = L"16.0 GT/s"; + break; default: CurLinkSpeed = L"Reserved"; break; -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44449): https://edk2.groups.io/g/devel/message/44449 Mute This Topic: https://groups.io/mt/32607151/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
