Re: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode

2019-07-03 Thread Lin, Derek (HPS SW)
Add SecurityPkg maintainers. Thanks, Derek From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of derek.l...@hpe.com Sent: Tuesday, July 2, 2019 1:25 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode Patch is attach

Re: [edk2-devel] [Patch v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.

2019-07-03 Thread Ni, Ray
1. mMaxNumberOfCpus and gSmmCpuPrivate->SmmCoreEntryContext.NumberOfCpus are both used. Can you please refine the code to use only one? 2. I do think that MM_MP code needs to maintain a internal linked list containing all created tokens. Because it's possible that caller is written in below way:

Re: [edk2-devel] [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64

2019-07-03 Thread Wu, Hao A
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, July 03, 2019 6:44 PM > To: Wu, Hao A > Cc: devel@edk2.groups.io > Subject: Re: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association > for Arm/AArch64 > > On Wed, Jul 03, 2019 at 07:52

[edk2-devel] [PATCH v2] OvmfPkg: use DxeTpmMeasurementLib if and only if TPM2_ENABLE

2019-07-03 Thread Gary Lin
(a) OvmfPkg first had to resolve the TpmMeasurementLib class -- for SECURE_BOOT_ENABLE only -- when the DxeImageVerificationLib instance became dependent on TpmMeasurementLib. For details, refer to commit 0d28d286bf4d ("OvmfPkg: resolve TpmMeasurementLib dependency introduced in r14

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Only import DxeTpmMeasurementLib when TPM is enabled

2019-07-03 Thread Gary Lin
On Wed, Jul 03, 2019 at 09:49:26PM +0200, Laszlo Ersek wrote: > Hi Gary, > > On 07/03/19 12:22, Gary Lin wrote: > > DxeTpmMeasurementLib is only useful when TPM is enabled. > > > > Cc: Jordan Justen > > Cc: Laszlo Ersek > > Cc: Marc-André Lureau > > Cc: Stefan Berger > > Signed-off-by: Gary

Re: [edk2-devel] [Patch v3 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo

2019-07-03 Thread Liming Gao
Push @03835a8c7325d5ddd0b03ee412a8a08d88258128..080981d72dcbb782ad73716c439639324b0aa4dd If you meet with the issue, please let me know. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Monday, July 01, 2019 7:27

Re: [edk2-devel] [Patch v3 1/2] MdePkg: Add new MM MP Protocol definition.

2019-07-03 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dong, > Eric > Sent: Wednesday, July 3, 2019 10:43 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: [edk2-devel] [Patch v3 1/2] MdePkg: Add new MM MP Protocol > definition. > > V2 ch

Re: [edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch files

2019-07-03 Thread Bob Feng
OK. Thanks. I just noticed my local repo is still in devel-minplatform branch. Thanks, Bob -Original Message- From: Bi, Dandan Sent: Thursday, July 4, 2019 8:55 AM To: Feng, Bob C ; Gao, Liming ; devel@edk2.groups.io Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files H

Re: [edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch files

2019-07-03 Thread Dandan Bi
Hi Bob, I have updated GitEdk2MinMtOlympus.bat for minpurely via https://github.com/tianocore/edk2-platforms/commit/e7fc97a3f9045c35a077ab0151c696aeba722417 And GitEdk2MinKabylake.bat for minkabylake has been removed via https://github.com/tianocore/edk2-platforms/commit/acbd81a92de1b4213f272a2

[edk2-devel] [PATCH v5 5/5] OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe

2019-07-03 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch link

[edk2-devel] [PATCH v5 1/5] MdePkg/Protocol/Hash: introduce GUID for SM3 digest algorithm

2019-07-03 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch adds

[edk2-devel] [PATCH v5 0/5] Implement SM3 measured boot

2019-07-03 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. Cc: Michael D K

[edk2-devel] [PATCH v5 2/5] SecurityPkg: introduce the SM3 digest algorithm

2019-07-03 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch add

[edk2-devel] [PATCH v5 3/5] SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest algorithm

2019-07-03 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch ad

[edk2-devel] [PATCH v5 4/5] SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default

2019-07-03 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch sets

Re: [edk2-devel] [PATCH v4 2/5] SecurityPkg: introduce the SM3 digest algorithm

2019-07-03 Thread Imran Desai
Thanks I will follow the convention next time. Best Regards, Imran Desai From: Wang, Jian J Sent: Wednesday, July 03, 2019 1:33 AM To: devel@edk2.groups.io; Wang, Jian J; Desai, Imran Subject: RE: [edk2-devel] [PATCH v4 2/5] SecurityPkg: introduce the SM3

Re: [edk2-devel] [RFC][PATCH 1/1] Maintainers.txt: Drop deprecated SourceForge SVN link

2019-07-03 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Wednesday, July 03, 2019 3:21 PM > To: devel@edk2.groups.io; r...@edk2.groups.io > Cc: ler...@redhat.com; Gao, Liming; Andrew Fish; Leif Lindholm; Kinney, > Michael D; Justen, Jo

Re: [edk2-devel] [PATCH v2 5/5] OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe

2019-07-03 Thread Imran Desai
Hello Lersek/ Leif, Like Lersek hinted, this in fact was an inadvertent issue with the git configuration. I suspect the suppresscc in my configuration may have been the source of all confusion. My apologies. I will send in a new version v5 of the full series of the patches. I appreciate all

Re: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol

2019-07-03 Thread Laszlo Ersek
On 07/03/19 04:42, Dong, Eric wrote: > v3 changes: > 1. Fix Token clean up too early caused CheckProcedure return error. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1937 > > PI spec added a new protocol named MM MP protocol. This protocol > allows for better remote queuing of execution of

Re: [edk2-devel] [PATCH v2 5/5] OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe

2019-07-03 Thread Leif Lindholm
On Wed, Jul 03, 2019 at 10:37:40PM +0200, Laszlo Ersek wrote: > On 05/28/19 22:40, Imran Desai wrote: > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 > > > > EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR > > banks. This digest algorithm is part of the

Re: [edk2-devel] [Patch v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.

2019-07-03 Thread Laszlo Ersek
On 07/03/19 04:42, Dong, Eric wrote: > v3 changes: > 1. Fix Token clean up too early caused CheckProcedure return error. > > v2 changes: > 1. Remove some duplicated global variables. > 2. Enhance token design to support multiple task trig for different APs at > the same time. > > V1 changes: > REF

Re: [edk2-devel] [PATCH v2 5/5] OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe

2019-07-03 Thread Laszlo Ersek
On 05/28/19 22:40, Imran Desai wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 > > EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR > banks. This digest algorithm is part of the China Crypto algorithm suite. > This integration has dependency on the ope

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Only import DxeTpmMeasurementLib when TPM is enabled

2019-07-03 Thread Laszlo Ersek
Hi Gary, On 07/03/19 12:22, Gary Lin wrote: > DxeTpmMeasurementLib is only useful when TPM is enabled. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Marc-André Lureau > Cc: Stefan Berger > Signed-off-by: Gary Lin > --- > OvmfPkg/OvmfPkgIa32.dsc| 10 +++--- > OvmfPkg/OvmfPkgIa32X64.d

Re: [edk2-devel] [PATCH] EmbeddedPkg: Fix various typos

2019-07-03 Thread Cœur
On Wed, Jul 3, 2019 at 11:30 PM, Leif Lindholm wrote: > > Normally, we expect patches to be submitted via git send-email, as > opposed to through the groups.io web interface (it introduces > spectacular levels of corruption to the original patch). Hello Leif, and thank you for the message and th

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Platform/ARM: Disable deprecated APIs for Arm Platforms

2019-07-03 Thread Leif Lindholm
On Thu, Jun 27, 2019 at 02:12:11PM +0100, Sami Mujawar wrote: > edk2 implements the DISABLE_NEW_DEPRECATED_INTERFACES macro that prevents the > usage of unsafe/deprecated APIs/macros by reporting errors at build time. > > This patch series: > - defines DISABLE_NEW_DEPRECATED_INTERFACES macro as p

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: add Leif Lindholm as Package Reviewer of ArmVirtPkg

2019-07-03 Thread Leif Lindholm
On Wed, Jul 03, 2019 at 04:47:35PM +0200, Laszlo Ersek wrote: > On 07/03/19 12:36, Leif Lindholm wrote: > > ArmVirtPkg was created before we introduced the Package Reviewer (R:) > > role in Maintainers.txt. However, we have always had an informal > > agreement that if Ard or Laszlo is absent, I can

Re: [edk2-devel] [PATCH] EmbeddedPkg: Fix various typos

2019-07-03 Thread Leif Lindholm
Hi Cœur, Thank you for your contribution. Normally, we expect patches to be submitted via git send-email, as opposed to through the groups.io web interface (it introduces spectacular levels of corruption to the original patch). However, as this is a first submission, and it actually worked surpr

Re: [edk2-devel] [PATCH v2] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds

2019-07-03 Thread Tomas Pilar (tpilar)
Fair enough, I'll spin a new patch. -Original Message- From: Laszlo Ersek Sent: 03 July 2019 15:46 To: Tomas Pilar ; Devel EDK2 Cc: jordan.l.jus...@intel.com; Ard Biesheuvel ; Michael Kinney Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp

[edk2-devel] [PATCH] BaseTools: Fix various typos

2019-07-03 Thread Cœur
Fix various typos in BaseTools. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- BaseTools/Conf/XMLSchema/DistributionPackage.xsd          | 8 .../plugins/EdkPlugins/edk2/model/doxygengen.py           | 2 +- .../plugins/EdkPlugins/edk2/model/doxygengen_spe

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: add Leif Lindholm as Package Reviewer of ArmVirtPkg

2019-07-03 Thread Laszlo Ersek
On 07/03/19 12:36, Leif Lindholm wrote: > ArmVirtPkg was created before we introduced the Package Reviewer (R:) > role in Maintainers.txt. However, we have always had an informal > agreement that if Ard or Laszlo is absent, I can review patches by > the still present one for going into ArmVirtPkg.

Re: [edk2-devel] [PATCH v2] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds

2019-07-03 Thread Laszlo Ersek
On 07/03/19 13:31, Tomas Pilar (tpilar) wrote: > On 24/06/2019 22:28, Laszlo Ersek wrote: >> (+Mike) >> >> On 06/24/19 17:53, Tomas Pilar (tpilar) wrote: >>> Switching to this library enables capsule support for FMP devices. >>> This will allow testing of FMP for PCI devices using OVMF and PCI >>>

Re: [edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch files

2019-07-03 Thread Bob Feng
Hi Dandan, I found the GitEdk2MinMtOlympus.bat for minpurely and GitEdk2MinKabylake.bat for minkabylake need to update. Would you update it? Thanks, Bob -Original Message- From: Gao, Liming Sent: Friday, June 28, 2019 9:12 AM To: Bi, Dandan ; Feng, Bob C ; devel@edk2.groups.io Subject

Re: [edk2-devel] [edk2-platforms: PATCH 2/2] Platform/Rpi3: Add custom CPU frequency support

2019-07-03 Thread Pete Batard
Hi Leif, On 2019.07.03 12:42, Leif Lindholm wrote: On Tue, Jul 02, 2019 at 05:13:41PM +0100, Pete Batard wrote: Allow users to set a custom CPU frequency [100 - 1600 MHz] in 'Device Manager' -> 'Raspberry Pi Configuration'. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/Co

Re: [edk2-devel] [edk2-platforms: PATCH 1/2] Platform/RPi3: Set the boot option of UEFI Shell as non-active

2019-07-03 Thread Leif Lindholm
On Tue, Jul 02, 2019 at 05:13:40PM +0100, Pete Batard wrote: > This makes boot from SD/USB the default, which is what most users > should expect. Pressing F1 at boot still boots to UEFI Shell. > > Signed-off-by: Pete Batard > --- > Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/Platfor

Re: [edk2-devel] [edk2-platforms: PATCH 2/2] Platform/Rpi3: Add custom CPU frequency support

2019-07-03 Thread Leif Lindholm
On Tue, Jul 02, 2019 at 05:13:41PM +0100, Pete Batard wrote: > Allow users to set a custom CPU frequency [100 - 1600 MHz] > in 'Device Manager' -> 'Raspberry Pi Configuration'. > > Signed-off-by: Pete Batard > --- > Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.c | 13 > ++

Re: [edk2-devel] [PATCH v2] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds

2019-07-03 Thread Tomas Pilar (tpilar)
On 24/06/2019 22:28, Laszlo Ersek wrote: > (+Mike) > > On 06/24/19 17:53, Tomas Pilar (tpilar) wrote: >> Switching to this library enables capsule support for FMP devices. >> This will allow testing of FMP for PCI devices using OVMF and PCI >> passthrough as well as software parts of the FMP API. >

Re: [edk2-devel] [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64

2019-07-03 Thread Leif Lindholm
On Wed, Jul 03, 2019 at 07:52:46AM +, Wu, Hao A wrote: > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Saturday, June 15, 2019 4:21 AM > > To: devel@edk2.groups.io > > Cc: Feng, Bob C; Gao, Liming; Andrew Fish; Laszlo Ersek; Kinney, Michael D;

[edk2-devel] [PATCH 1/1] Maintainers.txt: add Leif Lindholm as Package Reviewer of ArmVirtPkg

2019-07-03 Thread Leif Lindholm
ArmVirtPkg was created before we introduced the Package Reviewer (R:) role in Maintainers.txt. However, we have always had an informal agreement that if Ard or Laszlo is absent, I can review patches by the still present one for going into ArmVirtPkg. Plus, as one of the ArmPkg maintainers, it make

[edk2-devel] [PATCH 1/1] OvmfPkg: Only import DxeTpmMeasurementLib when TPM is enabled

2019-07-03 Thread Gary Lin
DxeTpmMeasurementLib is only useful when TPM is enabled. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Marc-André Lureau Cc: Stefan Berger Signed-off-by: Gary Lin --- OvmfPkg/OvmfPkgIa32.dsc| 10 +++--- OvmfPkg/OvmfPkgIa32X64.dsc | 10 +++--- OvmfPkg/OvmfPkgX64.dsc | 10 +++---

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

2019-07-03 Thread Laszlo Ersek
Hi Ray, On 07/02/19 17:20, Laszlo Ersek wrote: > On 07/02/19 17:18, Laszlo Ersek wrote: >> On 07/02/19 16:44, Ni, Ray wrote: >>> Laszlo, >>> I agree with your changes. >>> Will include your changes in V2. >> >> Thanks, Ray -- currently waiting for suitable hardware (with 5-level >> paging support)

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type.

2019-07-03 Thread Xiaoyu Lu
Liming, I filed two BZ, One for this, and another one for INF/BUILD spec. https://bugzilla.tianocore.org/show_bug.cgi?id=1956 https://bugzilla.tianocore.org/show_bug.cgi?id=1952 Thanks, Xiaoyu > -Original Message- > From: Gao, Liming > Sent: Monday, July 1, 2019 6:18 PM > To: Lu, XiaoyuX

Re: [edk2-devel] [PATCH v4 2/5] SecurityPkg: introduce the SM3 digest algorithm

2019-07-03 Thread Wang, Jian J
Pushed at a7c7d21ffa9ad14b418e728a882df0a9b8815bf6 Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Wednesday, July 03, 2019 10:55 AM > To: devel@edk2.groups.io; Desai, Imran > Subject: Re: [edk2-devel] [PA

[edk2-devel] [edk2-BuildSpecification PATCH] Document: Support HOST_APPLICATION ModuleType

2019-07-03 Thread Xiaoyu Lu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1952 INF spec add a new MODULE_TYPE HOST_APPLICATION, it indicate those modules that can run directly in OS environment. So BUILD spec also need be updated to support HOST_APPLICATION build. Cc: Liming Gao Cc: Jiewen Yao Signed-off-by: Xiaoyu L

[edk2-devel] [edk2-InfSpecification PATCH] Document: Add new MODULE_TYPE HOST_APPLICATION

2019-07-03 Thread Xiaoyu Lu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1952 Background: Host-based Firmware Analyzer (HBFA) is a opensouce tools enables advanced testing of UEFI and UEFI PI drivers in developer's OS environment. It will generate OS application which can run directly in OS environment. But there is no

Re: [edk2-devel] [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64

2019-07-03 Thread Wu, Hao A
> -Original Message- > From: Wu, Hao A > Sent: Wednesday, July 03, 2019 3:53 PM > To: 'Leif Lindholm' > Cc: devel@edk2.groups.io > Subject: RE: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association > for Arm/AArch64 > > > -Original Message- > > From: Leif Lindholm [mailto:

Re: [edk2-devel] [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64

2019-07-03 Thread Wu, Hao A
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Saturday, June 15, 2019 4:21 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C; Gao, Liming; Andrew Fish; Laszlo Ersek; Kinney, Michael D; > Wu, Hao A > Subject: [RFC PATCH 2/3] Maintainers.txt: add wildcard

Re: [edk2-devel] [RFC][PATCH 1/1] Maintainers.txt: Drop deprecated SourceForge SVN link

2019-07-03 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Thursday, June 27, 2019 7:59 PM > To: Wu, Hao A; devel@edk2.groups.io; r...@edk2.groups.io > Cc: Gao, Liming; Andrew Fish; Leif Lindholm; Kinney, Michael D; Justen, > Jordan L