> -Original Message-
> From: Wu, Hao A
> Sent: Monday, April 22, 2019 10:18 PM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Dong, Eric ; Wang, Jian J
> Subject: RE: [PATCH v2 0/2] Add PEI BlockIO support for ATA AHCI mode
> devices
>
> > -Original Message-
> > From: Ni, Ray
> > S
Shenglei:
Please also remove MS_ASL_ or WIN_ASL_ definitions in tools_def.template.
After ASL tool chain is removed, those definitions will not be required.
Thanks
Liming
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, April 16, 2019 11:54 AM
> To: devel@edk2.groups.io
>
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Zhang,
> Shenglei
> Sent: Tuesday, April 9, 2019 11:21 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming ;
> Zhu, Yonghong
> Subject: [edk2-devel] [PATCH 3/3
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, April 23, 2019 4:20 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Dong, Eric; Wang, Jian J
> Subject: RE: [PATCH v2 0/2] Add PEI BlockIO support for ATA AHCI mode
> devices
>
> Comments:
> 1. Can we add EFI_PEI_PPI_DESCRIPTOR_TERMINATE
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1737
User may add other commands before CC command from build_rule.txt
for specific purpose. It worked fine before commit 05217d210e.
This patch is going to fix the bug in commit 05217d210e to
support customized CC command.
Signed-off-by: Bob Fen
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,
> Zhichao
> Sent: Tuesday, April 23, 2019 10:35 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Bi, Dandan
> Subject: [edk2-devel] [PATCH 0/
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
The DebugLib instances of DebugPortProtocol use a global
variable "mExitBootServicesEvent" which is in conflict with
the same variable in StatusCodeHandlerRuntimeDxe.inf.
That would cause a build error through GCC5. So change the
name to the
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
The DebugLib instances of StdErr use a global variable
"mExitBootServicesEvent" which is in conflict with the
same variable in StatusCodeHandlerRuntimeDxe.inf.
That would cause a build error through GCC5. So change the
name to the "mDebugLib
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
The DebugLib instances of DebugPortProtocol, ConOut and StdErr
use a global variable "mExitBootServicesEvent" which is in
conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf.
That would cause a build error through GCC5. So cha
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
The DebugLib instances of ConOut use a global variable
"mExitBootServicesEvent" which is in conflict with
the same variable in StatusCodeHandlerRuntimeDxe.inf.
That would cause a build error through GCC5. So change the
name to the "mDebugLib
Reviewed-by: Jian J Wang
> -Original Message-
> From: Ye, Ting
> Sent: Tuesday, April 23, 2019 10:18 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Ye, Ting
> Subject: FW: [PATCH] Change package maintainer and reviewer of CryptoPkg.
>
> Fwd to new EDKII development mailing list.
>
Fwd to new EDKII development mailing list.
-Original Message-
From: Ye, Ting
Sent: Monday, April 22, 2019 5:36 PM
To: edk2-de...@lists.01.org
Cc: Wang, Jian J ; Ye, Ting
Subject: [PATCH] Change package maintainer and reviewer of CryptoPkg.
Removed Gang Wei from reviewer as he already le
Assuming Laszlo's comment is addressed.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Bi, Dandan
> Sent: Wednesday, April 17, 2019 6:12 PM
> To: Laszlo Ersek ; Ard Biesheuvel
>
> Cc: edk2-devel-groups-io ; Carsey, Jaben
> ; Ni, Ray ; Leif Lindholm
> ; Gao, Liming
> Subject: RE:
Dandan:
I have no other comments. Reviewed-by: Liming Gao
> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, April 18, 2019 9:12 AM
> To: Laszlo Ersek ; Ard Biesheuvel
>
> Cc: edk2-devel-groups-io ; Carsey, Jaben
> ; Ni, Ray ; Leif Lindholm
> ; Gao, Liming
> Subject: RE: [pat
> On Apr 22, 2019, at 3:02 PM, Ard Biesheuvel wrote:
>
> On Mon, 22 Apr 2019 at 23:53, Michael D Kinney
> wrote:
>>
>> Ard,
>>
>> This seems to be a common limitation seen in some
>> static analyzers. We have not found a workaround
>> that does not involve code changes to quiet the
>> fals
Ard,
I agree. Only consumer is only the DxeCapsuleLibFmp
itself.
I see I had a typo on the second option. The
statement to add after the copy and ASSERT()
would be:
mEsrtTable->FwResourceCountMax = FwResourceCount;
Mike
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.bieshe
On Tue, 23 Apr 2019 at 00:37, Michael D Kinney
wrote:
>
> Ard,
>
> I only see one potential issue.
>
> The size of the buffer copied is based on the FwResourceCount field.
> The actual size of based on the FwResourceCountMax field. Your patch
> does not set FwResourceCountMax to FwResourceCount,
Ard,
I only see one potential issue.
The size of the buffer copied is based on the FwResourceCount field.
The actual size of based on the FwResourceCountMax field. Your patch
does not set FwResourceCountMax to FwResourceCount, so this may confuse
the OS consumers that may think the buffer alloca
On Mon, 22 Apr 2019 at 09:14, Wu, Hao A wrote:
>
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard
> > Biesheuvel
> > Sent: Saturday, April 20, 2019 6:35 PM
> > To: devel@edk2.groups.io
> > Cc: Wu, Hao A; Wang, Jian J; Kinney, Michael D; A
On Mon, 22 Apr 2019 at 23:53, Michael D Kinney
wrote:
>
> Ard,
>
> This seems to be a common limitation seen in some
> static analyzers. We have not found a workaround
> that does not involve code changes to quiet the
> false positives.
>
> For this specific case, I think the code change I
> sugg
Ard,
This seems to be a common limitation seen in some
static analyzers. We have not found a workaround
that does not involve code changes to quiet the
false positives.
For this specific case, I think the code change I
suggest is correct.
Best regards,
Mike
> -Original Message-
> F
On Mon, 22 Apr 2019 at 16:41, Kinney, Michael D
wrote:
>
> Hi Hao,
>
> I think a cleaner fix to this issues is replace both
> ASSERT() statements with the following:
>
> if (EFI_ERROR (Status) || Entry->Emulator == NULL) {
> FreePool (Entry);
> continue;
> }
>
> We do n
Comments:
1. Can we add EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST to
mAhciAtaPassThruPpiListTemplate/mAhciBlkIoPpiListTemplate as well? I understand
that requires calling PeiServicesInstallPpi() 3 times instead of once. But I
see the benefit of change is the code is more understandable and potentia
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Jin, Eric
> Sent: Sunday, April 21, 2019 10:48 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D
> Subject:
> [Staging/Bug_1525_FmpDevicePkg_MultipleControllers][PAT
> CH] MdeModulePkg/EsrtFmpDxe: Detect duplicate
> GUID/Hard
Hi Hao,
I think a cleaner fix to this issues is replace both
ASSERT() statements with the following:
if (EFI_ERROR (Status) || Entry->Emulator == NULL) {
FreePool (Entry);
continue;
}
We do not expect the emulator protocol to disappear between
finding the handle and l
crypto/uid.c is needed by VS201x toolchain on Windows. Let's still keep it in
inf.
That means we need this patch for build on FreeBSD.
Reviewed-by: Jian J Wang
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> rebecca via Groups.Io
> Se
"TianoCore Bug Triage - EMEA / NAMO" Reminder
When: Monday, 22 April 2019
7:00am to 8:00am
(GMT-07:00) America/Los Angeles
Where: https://zoom.us/j/670172897
Description: Join Zoom Meeting
https://zoom.us/j/670172897 ( https://zoom.us/j/670172897 )
One tap mobile
+1720707269
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Monday, April 22, 2019 6:12 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
Subject: [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730
Internal code quality check failed after this commit:
68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those
coding style issues.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrap
Yes, Please.
BestRegards
Fu Siyuan
From: Gao, Liming
Sent: Monday, April 22, 2019 2:13 PM
To: Fu, Siyuan ; devel@edk2.groups.io
Cc: Wu, Jiaxin
Subject: RE: [RFC] Propose to remove IpSecDxe
Siyuan:
Is this change for edk2 Q2 stable tag? If yes, I will add it into edk2
https://github.com/tiano
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, April 22, 2019 9:56 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ni, Ray; Gao, Liming
> Subject: [patch] MdeModulePkg/HiiDatabaseDxe: Release lock on all error
> return path
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=16
After commit 57df17fe26, some static check reports suspicous NULL pointer
deference at line:
Entry->MachineType = Entry->Emulator->MachineType;
^^^
within function PeCoffEmuProtocolNotify().
However, 'Entry->Emulator' is guaranteed to have a non-NULL value wh
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard
> Biesheuvel
> Sent: Saturday, April 20, 2019 6:35 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Wang, Jian J; Kinney, Michael D; Ard Biesheuvel
> Subject: [edk2-devel] [PATCH v2] MdeModulePkg/
33 matches
Mail list logo
