crypto/uid.c is needed by VS201x toolchain on Windows. Let's still keep it in inf. That means we need this patch for build on FreeBSD.
Reviewed-by: Jian J Wang <jian.j.w...@intel.com> Jian > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > rebecca via Groups.Io > Sent: Sunday, April 21, 2019 1:18 AM > To: devel@edk2.groups.io; ard.biesheu...@linaro.org > Cc: Ye, Ting <ting...@intel.com>; Gang Wei <gang....@intel.com>; Wang, Jian > J <jian.j.w...@intel.com> > Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix > openssl build on FreeBSD > > On 2019-04-20 05:28, Ard Biesheuvel wrote: > > > > This is slightly odd. The host architecture shouldn't really matter, > > and so if we end up calling different code in UEFI when built on *BSD, > > there is differently something wrong. Or am I missing something? > > > No, that's a good point. I guess it's something we don't ever call. > > In fact, OVMF continues to build after removing crypto/uid.c (which > contains the OPENSSL_issetugid definition) from > CryptoPkg/Library/OpensslLib/OpensslLib.inf and > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf . > > > -- > > Rebecca Cran > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39368): https://edk2.groups.io/g/devel/message/39368 Mute This Topic: https://groups.io/mt/31250604/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
