Re: Disabling tests

2012-07-24 Thread Ted Mielczarek
On Tue, Jul 24, 2012 at 8:05 PM, ben turner wrote: > Any thoughts or objections? This sums up my feelings on the matter pretty well. If we disable tests we lose test coverage. Sometimes flaky tests just means we have flaky tests, but sometimes it means we're shipping flaky features, which is the

Re: Explicitly-sized arguments (e.g. PRInt32) versus implicitly-sized arguments (e.g. long) in IDL

2012-08-03 Thread Ted Mielczarek
On Fri, Aug 3, 2012 at 11:35 AM, Justin Lebar wrote: > Do we have a preference between using explicitly-sized arguments (e.g. > PRInt32) and implicitly-sized arguments (e.g. long) in XPIDL? Is it really implicitly-sized? It's actually defined as PRInt32 by XPIDL. I agree that it sucks as a type n

Re: New MFBT features: enum underlying type and enum classes

2012-08-09 Thread Ted Mielczarek
On Thu, Aug 9, 2012 at 5:29 AM, Aryeh Gregor wrote: > This instructs the compiler to allocate only one byte of storage for Foo, to > save space. Otherwise, the compiler is entitled to allocate anywhere from > one byte to the size of an int, and gcc in practice will allocate four bytes. > Comp

Re: LinuxGL widget backend for Mozilla

2012-08-22 Thread Ted Mielczarek
On Fri, Aug 17, 2012 at 1:48 PM, romaxa wrote: > Hi, > > Recently I have been working on B2G port to mobile Linux which would be > widget toolkit-independent (qt/gtk/cocoa/etc). Some time ago Chris Lord did work on a widget toolkit independent backend that had a similar focus[1]. His work was t

Re: Moving Away from Makefile's

2012-08-23 Thread Ted Mielczarek
On Thu, Aug 23, 2012 at 9:39 AM, David Rajchenbach-Teller wrote: > Generally, this design is rather good at separating tasks that need a > full language (implemented as rules) from tasks that only need a trivial > description (implemented as description files). This discussion is focused solely o

Re: Moving Away from Makefile's

2012-08-24 Thread Ted Mielczarek
On Fri, Aug 24, 2012 at 9:17 AM, qheaden wrote: > Is there any special reason why an existing build system such as SCcons > couldn't be used as a new build system for Mozilla? I know the Mozilla source > has a lot of special build instructions, but SCons does allow you to create > your own spec

Re: Proposal: Remove Linux PGO Testing

2012-10-10 Thread Ted Mielczarek
On Wed, Oct 10, 2012 at 5:57 PM, Justin Lebar wrote: > By "turning off Linux PGO testing", you really mean "stop making and > distributing Linux PGO builds," right? > > The main reason I'd want Linux PGO is for mobile. On desktop Linux, > most users (I expect) don't run our builds, so it's not a

Re: Imported code

2012-10-11 Thread Ted Mielczarek
On Thu, Oct 11, 2012 at 4:20 PM, Ehsan Akhgari wrote: > What I really don't want us to do is to prohibit people from fixing things > in the imported code. That is the absolute worst situation we can face with > a given piece of code, as we already have learned painfully. This should absolutely b

Re: nsresult is now a strongly typed enum

2012-10-15 Thread Ted Mielczarek
On Sat, Oct 13, 2012 at 12:48 PM, Ehsan Akhgari wrote: > This is currently enabled on all compilers which support strongly typed > enums (recent clang, gcc >= 4.4, and Visual C++ 2012). So this is all of our official builds except for Windows right now? -Ted _

Re: Call for help landing b2g patches on aurora

2012-10-15 Thread Ted Mielczarek
On Sat, Oct 13, 2012 at 10:18 AM, Justin Lebar wrote: > Landing on Aurora should be a simple matter of > > $ hg transplant -se /path/to/your/m-i/repo rev-to-land > # edit the commit message to include a=whoever > $ hg push Just wanted to point out that I have a little script you can configu

Re: nsresult is now a strongly typed enum

2012-10-15 Thread Ted Mielczarek
On Mon, Oct 15, 2012 at 8:11 AM, Aryeh Gregor wrote: > On Mon, Oct 15, 2012 at 2:09 PM, Ted Mielczarek wrote: >> On Sat, Oct 13, 2012 at 12:48 PM, Ehsan Akhgari >> wrote: >>> This is currently enabled on all compilers which support strongly typed >>> enums (rec

Re: Are crashtests allowed to access chrome (e.g. set preferences)?

2012-10-15 Thread Ted Mielczarek
On Mon, Oct 15, 2012 at 8:09 AM, Henrik Skupin wrote: > Hi all, > > I want to start with crashtests for webrtc crashes which have been fixed > recently. Sadly this feature is disabled on mozilla-central and > mozilla-aurora. So I would have to set two preferences to get access to > all the feature

Re: Benefits of PGO on Windows

2012-10-18 Thread Ted Mielczarek
On 10/17/2012 9:55 PM, Dave Mandelin wrote: Following the recent discussion about PGO, I really wanted to understand what benefits PGO gives Firefox on Windows, if any--I was skeptical. Rafael (IIRC) posted some Talos numbers, but I didn't know how to interpret them. So I decided to try a few s

Re: Easiest way to start using httpd.js?

2012-10-21 Thread Ted Mielczarek
On 10/20/2012 8:29 PM, Jim Porter wrote: > On 10/17/2012 06:27 PM, Gregory Szorc wrote: >> Let me know if you have any questions. > > I have a followup question: is there an easy way to use https with > httpd.js? ActiveSync Autodiscovery requires https. (I don't absolutely > need to test Autodisco

Re: PGO: another test + PGO topcrashes

2012-11-02 Thread Ted Mielczarek
On 11/1/2012 9:19 PM, Dave Mandelin wrote: > (a) How about building Windows with a newer version of MSVC, say 2012? (What > version are we using now, anyway? The build instructions page says 2010 is > official, but a tbpl log showed Visual Studio 9.0 on the path.) Maybe they > have fixed bugs i

Re: XULRunner on OS X, Why is not supported?

2012-11-08 Thread Ted Mielczarek
On 11/8/2012 2:06 PM, richardson.balca...@gmail.com wrote: > I believe my question is, if Mozilla is taking out their app development > platform not 'XUL' per se. How would they promote "openness, innovation and > opportunity on the web", only by giving us the opportunity of doing so in > extens

Re: Proposal: move content JS interpretation to a background thread

2012-11-09 Thread Ted Mielczarek
On 11/9/2012 8:26 AM, Robert Kaiser wrote: > AFAIK, the major reason why we did abandon doing that was because moving > all our interaction with the content to be async was too much work for > the moment. Isn't that same work required for what you propose?\ No. AIUI, the reason we abandoned electr

Re: Proposed policy change: reusability of tests by other browsers

2012-11-13 Thread Ted Mielczarek
On 11/12/2012 9:53 PM, Jeff Walden wrote: > At the time the web server was introduced I don't believe we had > Python as a build requirement, so we couldn't have used some > Python-based server (the option most likely to be somehow portable > across browsers/engines). That probably could be address

Re: passing command line and filenames as parameters to nsiProcess

2012-12-22 Thread Ted Mielczarek
On 12/22/2012 1:02 PM, rvj wrote: > its a while since I used the ns interfaces. I want to run > >gambit-enumpure < e02.nfg > numerate.txt > > how do I pass as arguments in nsiProcess? > > I asssume the file names must be prefixed with c:\\ > > is this correct? > > > > >

Re: Building the Mozilla platform on Darwin/X11

2013-01-02 Thread Ted Mielczarek
On 12/28/2012 8:52 PM, Jashank Jeremy wrote: > G'day, > > I'm experimenting with building the Mozilla platform for Darwin/X11. > More specifically, I want my Thunderbird instance, which currently > happily sits in Aqua, to live in my X session. > <...> > There's remarkably little documentation of t

Re: IID Change Hook

2013-01-22 Thread Ted Mielczarek
On 1/22/2013 5:51 PM, Scott Johnson wrote: > Hello Dev-Platform: > > tl;dr: > As discussed in the platform meeting today, we're looking at adding a > checking script to verify that IIDs are changed along with interfaces > from now on. The relevant bug is > https://bugzilla.mozilla.org/show_bug.cgi?

Re: Bringing Marionette and Mochitest closer

2013-01-30 Thread Ted Mielczarek
On 1/30/2013 5:56 AM, Neil wrote: > Jonas Sicking wrote: > >> The fact that we are using gecko as the http server means a whole lot >> of complications on mobile. In short, we currently need gecko both >> compiled for android, which is the version of gecko being tested, and >> compiled for a deskto

Re: The future of PGO on Windows

2013-01-31 Thread Ted Mielczarek
On 1/31/2013 6:39 AM, jmath...@mozilla.com wrote: >> We then tried to get a sense of how much of a win the PGO optimizations >> are. Thanks to a series of measurements by dmandelin, we know that >> disabling PGO/LTCG will result in a regression of about 10-20% on >> benchmarks which examine DOM

Re: The future of PGO on Windows

2013-01-31 Thread Ted Mielczarek
On 1/31/2013 8:22 AM, papal...@gmail.com wrote: > How separate the analysis phase from the optimization based on the collected > data? How are the results of the PGO runs stored? Can the optimization part > be run independently? If yes would it be possible to collect the data through > other mea

Re: The future of PGO on Windows

2013-01-31 Thread Ted Mielczarek
On 1/31/2013 11:38 AM, jmath...@mozilla.com wrote: > http://graphs.mozilla.org/graph.html#tests=[[83,94,12],[83,1,12]]&sel=none&displayrange=365&datatype=running > > Ts, Paint shows an improvement of 14%. This is with Firefox and > Firefox-Non-PGO, which I believe to be mc. Also while I can't seem

Re: The future of PGO on Windows

2013-01-31 Thread Ted Mielczarek
On 1/30/2013 11:03 PM, Ehsan Akhgari wrote: > (Follow-ups to dev-platform, please) > > Dear all, > > This email summarizes the results of our investigation on our options > with regard to the future of PGO optimizations on Windows. I will > first describe the work that happened as part of the inve

Re: The future of PGO on Windows

2013-02-01 Thread Ted Mielczarek
On 2/1/13 10:52 AM, Jean-Marc Desperrier wrote: Ehsan Akhgari a écrit : I don't have a lot of experience with mingw32, but to the best of my knowledge, it's based on older versions of gcc (4.6?), and lacks 64-bit support Ehsan, did you forget that there would be no memory problem with 64-bits

Re: The future of PGO on Windows

2013-02-01 Thread Ted Mielczarek
On 2/1/2013 1:51 PM, Daniel Veditz wrote: > On 1/30/2013 8:03 PM, Ehsan Akhgari wrote: >> It turns out that disabling PGO but keeping LTCG enabled reduces the >> memory usage by ~200MB, which means that it's not an effective >> measure. Disabling both LTCG and PGO brings down the linker's >> virtu

obsoleting automation.py in the near future

2013-02-20 Thread Ted Mielczarek
This came up in the platform meeting yesterday, and apparently there were some concerns, so I'd like to talk a little more about what we're doing and answer any questions that people have. The A-Team is undertaking a project to move our test harnesses away from using automation.py[1]. The primary

<    1   2   3