Re: A reminder about MOZ_MUST_USE and [must_use]

2017-01-20 Thread Ted Mielczarek
On Thu, Jan 19, 2017, at 07:00 PM, gsquel...@mozilla.com wrote: > > I think the point is that it's not obvious that "must check the return > > value" is a sufficiently-dominant common case for arbitrary return values. > > FWIW, Rust took the [must_use] rather than [can_ignore] approach too. > > Th

Re: A reminder about MOZ_MUST_USE and [must_use]

2017-01-20 Thread Ted Mielczarek
On Fri, Jan 20, 2017, at 08:19 AM, Nicolas B. Pierron wrote: > > The Rust case is helped by the fact that `Result` is the defacto type > > for returning success or error, and it's effectively `must_use`. We > > don't have a similar default convention in C++. > > We have > > http://searchfox.org/m

Re: Decision owner for Rust usage in Gecko.

2017-02-07 Thread Ted Mielczarek
On Tue, Feb 7, 2017, at 03:50 PM, Johnny Stenback wrote: > Hey all, > > Over the coming weeks/months/years we'll be adding more and more Rust > code > into Gecko. As that work progresses (it's already in full swing in case > you > haven't been paying attention) it'll become more and more important

FYI: We've forked the Breakpad client code

2017-02-09 Thread Ted Mielczarek
FYI, I landed a patch[1] yesterday that forked the Breakpad client code. Everything that was in toolkit/crashreporter/google-breakpad/src/client is now in toolkit/crashreporter/breakpad-client. Google has switched Chromium to using Crashpad (their new crash reporting library) on Windows, OS X and A

Re: FYI: We've forked the Breakpad client code

2017-02-09 Thread Ted Mielczarek
On Thu, Feb 9, 2017, at 02:47 PM, Aaron Klotz wrote: > This is great news, Ted! > > Are you going to be creating a module for this? Who are the peers? I don't think a new module is necessary, we've covered the existing integration code (nsExceptionHandler.cpp etc) under the Toolkit module for a l

Re: Doxygen output?

2017-02-21 Thread Ted Mielczarek
We have auto-generated docs using Sphinx on ReadTheDocs[1]. If someone was motivated, it looks like there does exist code[2] to bridge doxygen docs into Sphinx, so it should be possible to get those docs into the existing RTD setup. There are even docs on RTD[3] for how to add new docs! -Ted 1. h

Re: Should cheddar-generated headers be checked in?

2017-02-22 Thread Ted Mielczarek
On Wed, Feb 22, 2017, at 07:11 AM, Henri Sivonen wrote: > Looking at mp4parse, the C header is generated: > https://searchfox.org/mozilla-central/source/media/libstagefright/binding/mp4parse_capi/build.rs > But also checked in: > https://searchfox.org/mozilla-central/source/media/libstagefright/bin

Re: Should cheddar-generated headers be checked in?

2017-02-23 Thread Ted Mielczarek
On Thu, Feb 23, 2017, at 08:27 AM, Nathan Froyd wrote: > On Thu, Feb 23, 2017 at 1:25 AM, Henri Sivonen > wrote: > >> Alternately you could just generate it at build time, and we could pass > >> the path to $(DIST)/include in a special environment variable so you > >> could put the header in the r

Re: Should cheddar-generated headers be checked in?

2017-02-23 Thread Ted Mielczarek
On Thu, Feb 23, 2017, at 06:40 AM, Emilio Cobos Álvarez wrote: > On Thu, Feb 23, 2017 at 08:25:30AM +0200, Henri Sivonen wrote: > > On Wed, Feb 22, 2017 at 5:49 PM, Ted Mielczarek wrote: > > > Given that > > > the C API here is under your complete control, it seems

Re: Editing vendored crates

2017-02-27 Thread Ted Mielczarek
On Mon, Feb 27, 2017, at 12:32 PM, Henri Sivonen wrote: > On Mon, Feb 27, 2017 at 7:04 PM, Ralph Giles wrote: > > On Mon, Feb 27, 2017 at 4:03 AM, Henri Sivonen wrote: > > > >> I find this level of difficulty (self-inflicted quasi-Tivoization > >> practically) an unreasonable impediment to practi

Re: Is there a way to improve partial compilation times?

2017-03-09 Thread Ted Mielczarek
On Wed, Mar 8, 2017, at 05:43 PM, Ehsan Akhgari wrote: > On 2017-03-08 11:31 AM, Simon Sapin wrote: > > On 08/03/17 15:24, Ehsan Akhgari wrote: > >> What we did in the Toronto office was walked to people who ran Linux on > >> their desktop machines and installed the icecream server on their > >> co

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Ted Mielczarek
On Fri, Mar 17, 2017, at 01:12 PM, Chris Peterson wrote: > On 3/17/2017 1:45 AM, Honza Bambas wrote: > > I have a very similar setup, with even way more exceptions added, but > > none of them has the desired effect. Unfortunately, the only way to make > > MsMpEng shut up is to disable run-time prot

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Ted Mielczarek
On Fri, Mar 17, 2017, at 02:20 PM, Ben Kelly wrote: > On Fri, Mar 17, 2017 at 1:36 PM, Ted Mielczarek > wrote: > > > Back to the original topic, I recently set up a fresh Windows machine > > and I followed the same basic steps (enable performance power mode, > > wh

Re: Third Party Library Alert Service

2017-03-17 Thread Ted Mielczarek
On Fri, Mar 17, 2017, at 02:40 PM, trit...@mozilla.com wrote: > On Friday, March 17, 2017 at 1:35:15 PM UTC-5, Sylvestre Ledru wrote: > > Looks like we are duplicating some contents and efforts with: > > https://dxr.mozilla.org/mozilla-central/source/tools/rewriting/ThirdPartyPaths.txt > > Any plan

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Ted Mielczarek
On Fri, Mar 17, 2017, at 03:16 PM, Ben Kelly wrote: > On Fri, Mar 17, 2017 at 2:52 PM, Ben Kelly wrote: >> On Fri, Mar 17, 2017 at 2:43 PM, Ted Mielczarek >> wrote: >> >> >> >> >> >>> Yeah, I specifically meant "CPU-bound duri

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Ted Mielczarek
On Fri, Mar 17, 2017, at 02:43 PM, Ted Mielczarek wrote: > Similarly, I heard from someone (I can't remember who it was) that said > they could do a Linux Firefox build in ~8(?) minutes on the same > hardware. (I will try to track down the source of that number.) That > gives us a

Re: Faster gecko builds with IceCC on Mac and Linux

2017-03-24 Thread Ted Mielczarek
On Fri, Mar 24, 2017, at 12:10 AM, Jeff Muizelaar wrote: > I have a Ryzen 7 1800 X and it does a Windows clobber builds in ~20min > (3 min of that is configure which seems higher than what I've seen on > other machines). This compares pretty favorably to the Lenovo p710 > machines that people are g

FYI: Visual C++ 2017 build system support landing

2017-04-25 Thread Ted Mielczarek
I'm about to land some patches[1] that will allow configure to detect a Visual C++ 2017 installation. You should be able to launch a MozillaBuild `start-shell.bat` shell and build without having to have the Visual C++ environment configured. The only thing that will change from the current state of

Re: Editing vendored crates take #2

2017-05-02 Thread Ted Mielczarek
On Tue, May 2, 2017, at 02:54 PM, Josh Matthews wrote: > On 2017-04-28 3:07 PM, Boris Zbarsky wrote: > > On 4/28/17 1:05 PM, Josh Matthews wrote: > > 2) Run "cargo vendor" and watch it fail because of something I never > > figured out. > > My cargo from April 19 claims that "cargo vendor" isn't a

Re: CodeCoverage Monthly Update

2017-05-09 Thread Ted Mielczarek
On Tue, May 9, 2017, at 05:48 AM, Henri Sivonen wrote: > On Thu, Apr 6, 2017 at 6:26 AM, Kyle Lahnakoski > wrote: > > * Getting Rust to emit coverage artifacts is important: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1335518 > > Is there a plan to factor "cargo test" of individual vendored

Re: Have you run 'mach bootstrap' lately?

2017-05-12 Thread Ted Mielczarek
On Fri, May 12, 2017, at 10:45 AM, Sylvestre Ledru wrote: > Would it be possible to add a check like: > "You haven't updated your local configuration since XX days, please > consider running > mach bootstrap ?" We've had mach produce nag messages like that in the past and they have been universall

Re: Linux builds now default to -O2 instead of -Os

2017-06-01 Thread Ted Mielczarek
On Thu, Jun 1, 2017, at 09:23 PM, Mike Hommey wrote: > On Thu, Jun 01, 2017 at 09:09:44PM -0400, Nathan Froyd wrote: > > Could we try to make a bare --enable-optimize --enable-debug build use > > -Og if it was available? > > It might make sense, but we need to be careful that this will affect the

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Ted Mielczarek
On Tue, Jun 20, 2017, at 03:59 AM, Julian Seward wrote: > I've used VTune on Linux and have some idea what it can and can't do. > I have tried it on Mac, but my impression, from the Intel web site, is > that it is at least available for Mac. Apparently the version for Mac is just a GUI for viewing

Re: switch to macosx cross-compiled builds on taskcluster on trunk

2017-06-22 Thread Ted Mielczarek
On Thu, Jun 22, 2017, at 01:08 AM, Ralph Giles wrote: > On Wed, Jun 21, 2017 at 9:47 PM, Randell Jesup > wrote: > > > > Does this have affect on our still using the 10.7 Mac SDK? > > > We are still building against the macOS 10.7 SDK, but we can update to > 10.9 > once we've confirmed transiti

Re: More Rust code

2017-07-17 Thread Ted Mielczarek
On Wed, Jul 12, 2017, at 07:41 PM, Mike Hommey wrote: > On Wed, Jul 12, 2017 at 04:06:39PM -0700, Eric Rahm wrote: > > Interesting points. > > > >- *using breakpad* - was the problem that creating wrappers to access > >the c/c++ code was too tedious? Could bindgen help with that, if not it

Re: More Rust code

2017-07-17 Thread Ted Mielczarek
Nick, Thanks for kicking off this discussion! I felt like a broken record talking to people about this in SF. From my perspective Rust is our single-biggest competitive advantage for shipping Firefox, and every time we choose C++ over Rust we throw that away. We know the costs of shipping complica

sccache as ccache

2017-07-26 Thread Ted Mielczarek
Yesterday I published sccache 0.2 to crates.io, so you can now `cargo install sccache` and get the latest version (it'll install to ~/.cargo/bin). If you build Firefox on Linux or OS X you can (and should) use sccache in place of ccache for local development. It's as simple as adding this to your m

Re: sccache as ccache

2017-07-26 Thread Ted Mielczarek
On Wed, Jul 26, 2017, at 10:46 AM, Kan-Ru Chen wrote: > Windows support sounds very exciting! Will it support cache sharing? Currently sccache supports a few different cache storage backends: * local disk * Amazon S3 * Google Cloud Storage * Redis However, the cache keys currently wind up with fu

Re: sccache as ccache

2017-07-26 Thread Ted Mielczarek
On Wed, Jul 26, 2017, at 12:57 PM, Simon Sapin wrote: > On 26/07/2017 15:05, Ted Mielczarek wrote: > >ac_add_options --with-ccache=sccache > > When used together with icecc, this appears to force all jobs to run > locally which makes icecc pointless. We should figure o

Re: refcounting [WAS: More Rust code]

2017-08-02 Thread Ted Mielczarek
On Wed, Aug 2, 2017, at 08:32 AM, Nathan Froyd wrote: > On Wed, Aug 2, 2017 at 7:37 AM, Enrico Weigelt, metux IT consult > wrote: > > On 31.07.2017 13:53, smaug wrote: > >> Reference counting is needed always if both JS and C++ can have a > >> pointer to the object. > > > > Anybody already thought

Re: sccache as ccache

2017-08-02 Thread Ted Mielczarek
On Wed, Aug 2, 2017, at 12:26 PM, Ben Kelly wrote: > On Wed, Jul 26, 2017 at 9:05 AM, Ted Mielczarek > wrote:>> Yesterday I published sccache 0.2 to > crates.io, so you can now `cargo>> install sccache` and get the latest > version (it'll install to >> ~/.

Re: Firefox and clang-cl

2017-08-15 Thread Ted Mielczarek
On Mon, Aug 14, 2017, at 04:36 PM, Ehsan Akhgari wrote: > > * Performance: We switched from msvc+pgo to clang without pgo and got > > comparable perf. We did have to use an order file (/order: flag to > > link.exe) to get comparable startup perf. > That is very interesting! This is one of the as

Re: sccache as ccache

2017-08-18 Thread Ted Mielczarek
On Thu, Aug 17, 2017, at 10:01 PM, Mike Hommey wrote: > On Wed, Jul 26, 2017 at 09:54:14AM -0400, Alex Gaynor wrote: > > If you're on macOS, you can also get sccache with `brew install sccache`. > > If you're on macOS and were hitting errors building openvr, this is > fixed in sccache master. I'v

Re: Implementing a Chrome DevTools Protocol server in Firefox

2017-08-31 Thread Ted Mielczarek
On Wed, Aug 30, 2017, at 08:20 PM, Eric Rescorla wrote: > I assume this is going to involve TLS (generally this is a requirement > for > H2). In Firefox, this is done with NSS. Does Tokio/Hyper cleanly separate > out the TLS stack so that you can do that? This was mostly answered in another reply,

PSA: symbol server now available via https

2017-09-01 Thread Ted Mielczarek
Just an FYI, yesterday the symbol server (symbols.mozilla.org) was moved to a different server backend[1], and as a result it's now also available via https. It should continue to work seamlessly at the existing URL, but you can update your symbol server paths to https://symbols.mozilla.org/ if you

Re: Firefox 55.* in Windows/Ubuntu - every day CPU 100%/Hangs Up. Please to do something!

2017-09-08 Thread Ted Mielczarek
On Wed, Sep 6, 2017, at 03:45 AM, Alexey Zvyagin wrote: > Dear developers of Firefox, > > I have 55.* version of Firefox at work and at home > At work i have Windows 7 OS, at home the Ubuntu 16.04 LTE > I have my own synced profile. I don't have problem with syncing... > > In both OSes i regulary

Re: Re-visiting the DOM tree depth limit in layout

2017-09-15 Thread Ted Mielczarek
On Thu, Sep 14, 2017, at 02:23 AM, Henri Sivonen wrote: > Do I understand correctly that this is an address space issue only and > Windows doesn't actually physically map the pages belonging to the > stack until they are written to? That is, do I understand correctly > that there's no obstacle for

Re: How to get pretty stack trace on Linux?

2017-09-21 Thread Ted Mielczarek
On Thu, Sep 21, 2017, at 08:51 PM, Masayuki Nakano wrote: > I'd like to get pretty stack trance which shows method names rather than > only address with tryserver build on Linux. However, > nsTraceRefcnt::WalkTheStack() cannot get method names on Linux as you > know. > > The reason why I need to

Re: MinGW Target on TaskCluster

2017-10-09 Thread Ted Mielczarek
On Mon, Oct 9, 2017, at 01:31 AM, Tom Ritter wrote: > As part of our work with Tor, we’ve been working on getting a MinGW-based > build of Windows into TaskCluster. Tor is currently using ESR releases, > and > every ESR they have to go through a large amount of work to get the build > working under

Re: We need better canaries for JS code

2017-10-19 Thread Ted Mielczarek
On Wed, Oct 18, 2017, at 07:51 AM, Mark Banner wrote: > Looping in firefox-dev as well, as I thin this is an important > discussion. > > On 18/10/2017 09:28, David Teller wrote: > > Hi everyone, > > > >Yesterday, Nightly was broken on Linux and MacOS because of a typo in > > JS code [1].

Re: We need better canaries for JS code

2017-10-19 Thread Ted Mielczarek
On Thu, Oct 19, 2017, at 03:19 PM, Mark Banner wrote: > The only thing that might help (that has been discussed) is something > along the lines of flow - an analyser that could work out that 'spice()' > didn't exist, but Dave Townsend mentioned these don't seem to be viable > for us. > > Theref

Re: Visual Studio 2017 coming soon

2017-10-25 Thread Ted Mielczarek
On Wed, Oct 25, 2017, at 05:48 PM, David Major wrote: > I'm planning to move production Windows builds to VS2017 (15.4.1) in bug > 1408789. Thanks for doing the work on this! > VS2017 has optimizer improvements that produce faster code. I've seen > 3-6% > improvement on Speedometer. There is als

Re: How much context does CF_HTML really need?

2017-10-31 Thread Ted Mielczarek
On Tue, Oct 31, 2017, at 05:46 AM, Henri Sivonen wrote: > (Context: I'm trying to understand the requirements for our > serializers in case we rewrite them [in Rust].) > > The HTML fragment parsing algorithm can have only one context node. > The context is never a chain of nodes towards to the roo

Re: Firefox 55.* in Windows/Ubuntu - every day CPU 100%/Hangs Up. Please to do something!

2017-11-21 Thread Ted Mielczarek
On Tue, Nov 21, 2017, at 06:54 AM, Alexey Zvyagin wrote: > Hi! > > I made some crashes by hands (crashfirefox.exe) in Windows 7 and in Unix > through kill -ABRT > > What are the symptoms? In random moments the Firefox v56.* has only-one > core CPU 100% eating. In Windows 7 (64bit) & Linux (Ubuntu

Re: Faster gecko builds with IceCC on Mac and Linux

2018-01-16 Thread Ted Mielczarek
On Tue, Jan 16, 2018, at 10:51 AM, Jean-Yves Avenard wrote: > Sorry for resuming an old thread. > > But I would be interested in knowing how long that same Lenovo P710 > takes to compile *today*….> In the past 6 months, compilation times have > certainly increased > massively.> > Anyhow, I’ve re

Re: Ci, Cr, Cc, and Cu are now automatically defined in all chrome scopes

2018-02-02 Thread Ted Mielczarek
On Thu, Feb 1, 2018, at 5:11 PM, Andrew McCreight wrote: > Bug 767640 just merged to mozilla-central. This patch makes it so that Ci, > Cr, Cc, and Cu are automatically defined in any chrome scope that has a > Components object. Rejoice, because you no longer need to add "var Ci = > Components.inte

Re: gkrust compilation RAM requirements and 32-bit systems

2018-02-09 Thread Ted Mielczarek
On Fri, Feb 9, 2018, at 4:49 AM, Henri Sivonen wrote: > Is it expected that Firefox can no longer be built on a 32-bit system? Yes. > The cross-compilation documentation on MDN seems to predate Rust code > in Firefox. Is there an up-to-date guide for compiling Firefox for > ARMv7+NEON (or aarch6

Debugging Try server builds

2018-02-12 Thread Ted Mielczarek
If you've debugged builds from the try server in the past (or wanted to but found the process too difficult) I'd be interested to hear from you. Historically this has been a painful process with many manual steps[1], but thanks to some work done[2] by Peter Bengtsson on the new symbols.mozilla.o

Re: PSA: Chrome-only WebIDL interfaces no longer require DOM peer review

2018-03-09 Thread Ted Mielczarek
On Thu, Mar 8, 2018, at 7:41 PM, Bobby Holley wrote: > (C) The API uses complex arguments like promises that XPIDL doesn't handle > in a nice way. I think this is an understated point. WebIDL was designed explicitly to allow expressing the semantics of JS APIs, where XPIDL is some arbitrary set o

FYI: sccache 0.2.6 released, contains fix for frequent hang in 0.2.5

2018-03-13 Thread Ted Mielczarek
Hello, Yesterday I tagged and released sccache 0.2.6: https://github.com/mozilla/sccache/releases/tag/0.2.6 This contains a fix for a hang that users were encountering with sccache 0.2.5 due to the make jobserver support added in that version. If you are using 0.2.5 you will want to update. If

Re: Reading data needed by MOZ_GTEST_BENCH outside the timed benchmark

2018-03-15 Thread Ted Mielczarek
On Thu, Mar 15, 2018, at 7:22 AM, Henri Sivonen wrote: > Do we have a way to read the prerequisite data for MOZ_GTEST_BENCH > outside MOZ_GTEST_BENCH so that the disk IO doesn't get timed? I don't know that we have any stock way to do this. I can offer three plausible solutions: 1) If putting the

Re: Reading data needed by MOZ_GTEST_BENCH outside the timed benchmark

2018-03-15 Thread Ted Mielczarek
On Thu, Mar 15, 2018, at 9:07 AM, Henri Sivonen wrote: > On Thu, Mar 15, 2018 at 2:51 PM, Ted Mielczarek wrote: > > On Thu, Mar 15, 2018, at 7:22 AM, Henri Sivonen wrote: > >> Do we have a way to read the prerequisite data for MOZ_GTEST_BENCH > >> outside MOZ_GTES

Re: incremental compilation for opt Rust builds

2018-04-09 Thread Ted Mielczarek
On Thu, Apr 5, 2018, at 8:19 AM, Henri Sivonen wrote: > For encoding_rs, -O2 vs -O3 has pretty big performance effects in both > directions. (Didn't measure code size.) I think I'd rather have the > -O3 scenario than the -O2 scenario for encoding_rs. > > Can we make a particular vendored crate (en

Re: Intent To Require Manifests For Vendored Code In mozilla-central

2018-04-10 Thread Ted Mielczarek
On Tue, Apr 10, 2018, at 9:23 AM, James Graham wrote: > On 10/04/2018 05:25, glob wrote: > > mozilla-central contains code vendored from external sources. Currently > > there is no standard way to document and update this code. In order to > > facilitate automation around auditing, vendoring, and

Re: Editing a vendored crate for a try push

2018-04-10 Thread Ted Mielczarek
On Mon, Apr 9, 2018, at 7:18 AM, Henri Sivonen wrote: > What's the current status of tooling for editing vendored crates for > local testing and try pushes? > > It looks like our toml setup is too complex for cargo edit-locally to > handle (or, alternatively, I'm holding it wrong). It also seems t

Re: Default Rust optimization level decreased from 2 to 1

2018-04-25 Thread Ted Mielczarek
On Wed, Apr 25, 2018, at 12:32 PM, Jeff Muizelaar wrote: > At minimum we should make --enable-profiling build with rust-opt. This sounds reasonable, although the quirk is that we default --enable-profiling on for nightly[1], so anyone building m-c will have it enabled. We could make the build sy

Uploading symbols from try builds

2018-05-08 Thread Ted Mielczarek
Hello, I landed some patches yesterday[1] that have now merged to m-c to allow uploading symbols from try builds to the symbol server. Previously if you wanted to debug a try server build it involved a bunch of annoying manual steps, but now you can simply ask for symbol upload tasks to run and

Re: Removing tinderbox-builds from archive.mozilla.org

2018-05-09 Thread Ted Mielczarek
On Wed, May 9, 2018, at 1:11 PM, L. David Baron wrote: > > mozregression won't be able to bisect into inbound branches then, but I > > believe we've always been expiring build artifacts created from integration > > branches after a few months in any case. > > > > My impression was that people use

Gecko natvis file now in-tree

2018-05-09 Thread Ted Mielczarek
Hello, I recently landed a patch[1] that added a Gecko.natvis file[2] to the tree. natvis files[3] are Microsoft's current way of providing nicer views of data types for their debuggers. The file as-landed was written by Vlad a few years ago so it could definitely use some changes (there's a fo

Re: Gecko natvis file now in-tree

2018-05-09 Thread Ted Mielczarek
gt; > On 5/9/2018 1:17 PM, Ted Mielczarek wrote: > > Hello, > > > > I recently landed a patch[1] that added a Gecko.natvis file[2] to the tree. > > natvis files[3] are Microsoft's current way of providing nicer views of > > data types for their debuggers. Th

Re: Rust crate approval

2018-07-05 Thread Ted Mielczarek
On Sun, Jul 1, 2018, at 7:56 PM, Xidorn Quan wrote: > The point is that adding a new crate dependency is too easy > accidentally, and it is very possible for reviewers to overlook that. So > it may make sense to introduce a blacklist-ish thing to avoid that to > happen. FYI, we had some discuss

Re: PSA: Automated code analysis now also in Phabricator

2018-07-17 Thread Ted Mielczarek
On Tue, Jul 17, 2018, at 9:22 AM, Jan Keromnes wrote: > TL;DR -- “reviewbot” is now enabled in Phabricator. It reports potential > defects in pending patches for Firefox. Great work! This sounds super useful! -Ted ___ dev-platform mailing list dev-platf

Re: C++ standards proposal for a embedding library

2018-07-19 Thread Ted Mielczarek
On Wed, Jul 18, 2018, at 12:45 PM, Botond Ballo wrote: > Hi everyone, > > With the proposal for a standard 2D graphics library now on ice [1], > members of the C++ standards committee have been investigating > alternative ways of giving C++ programmers a standard way to write > graphical and inter

Re: Stopgap for Commit Series in Phabricator

2018-08-06 Thread Ted Mielczarek
Thanks for this, Kris! Just an FYI for anyone planning to try this: I was behind a few versions on Mercurial (at 4.3) and I had to update to 4.7 for this extension to work. -Ted On Thu, Jul 26, 2018, at 12:09 PM, Kris Maglione wrote: > Here's an approximate equivalent for hg which doesn't requi

Can we make a plan to retire Universal Mac builds?

2015-08-05 Thread Ted Mielczarek
Our Universal Mac builds are a frequent headache for build system work, being a special snowflake in many ways. They also use twice as much machine time as other builds, since they do a separate build for each architecture. I think it's time to make a plan to retire them and ship single-architectur

Re: Can we make a plan to retire Universal Mac builds?

2015-08-05 Thread Ted Mielczarek
On Wed, Aug 5, 2015, at 07:28 PM, Martin Thomson wrote: > On Wed, Aug 5, 2015 at 3:59 PM, Matthew N. wrote: > > If we have data on CPU architecture I don't think the OS version is relevant > > unless I'm missing something. > > My understanding is that OS version is all that matters. 64-bit apps

Re: Can we make a plan to retire Universal Mac builds?

2015-08-05 Thread Ted Mielczarek
On Wed, Aug 5, 2015, at 05:14 PM, Syd Polk wrote: > I don’t think we can do this until we stop supporting Mac OS X 10.6. Last > time we calculated percentage of users, this was still over 15%. I don’t > think that very many of them would be running 64-bit, either. 10.7 has > that problem as well, b

Re: Can we make a plan to retire Universal Mac builds?

2015-08-05 Thread Ted Mielczarek
On Wed, Aug 5, 2015, at 06:59 PM, Matthew N. wrote: > Assuming our FHR data is gathering correct data: > > 1.5% of our OS X users are on x86. (There is no date on the dashboard > I'm looking at) > > If we have data on CPU architecture I don't think the OS version is > relevant unless I'm missin

Re: I need to give my 2–coins–worth on this topic, please. (Re: Can we make a plan to retire Universal Mac builds?)

2015-08-12 Thread Ted Mielczarek
On Wed, Aug 12, 2015, at 03:56 AM, SciFi wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > > > > > Hello, > > > I need to give my 2–coins–worth on this topic, please. > > > If Mozilla decides to drop the 32–bit Mac users, > then also drop the 32–bit Windows users > and the 32–

Re: MozPromises are now in XPCOM

2015-08-19 Thread Ted Mielczarek
On Tue, Aug 18, 2015, at 11:17 PM, Bobby Holley wrote: > I gave a lightning talk at Whistler about MozPromise and a few other new > tools to facilitate asynchronous and parallel programming in Gecko. There > was significant interest, and so I spent some time over the past few > weeks > untangling t

Re: The opt-in FAIL_ON_WARNINGS has been replaced with the opt-out ALLOW_COMPILER_WARNINGS

2015-08-31 Thread Ted Mielczarek
On Mon, Aug 31, 2015, at 01:47 PM, Chris Peterson wrote: > Should we hold third-party code to the same warning levels as Mozilla's > home-grown code? When we find warnings in third-party code, we typically > just suppress them because they weren't serious issues and fixing them > upstream is ext

Re: Disabling C++ tests by default?

2015-10-02 Thread Ted Mielczarek
On Fri, Oct 2, 2015, at 04:40 PM, Bobby Holley wrote: > On Fri, Oct 2, 2015 at 1:03 PM, Ehsan Akhgari > wrote: > > > On 2015-10-02 2:42 PM, Jonas Sicking wrote: > > > >> It might still mean that we can save time on tryserver if we only > >> build these by default if the user has opted in to runni

Re: Merging comm-central into mozilla-central

2015-10-23 Thread Ted Mielczarek
On Fri, Oct 23, 2015, at 02:17 PM, Joshua Cranmer 🐧 wrote: > Except that to demand contributors don't care about comm-central would > be to demand of your employees that they should be jerks to the wider > open-source community. Merging comm-central into mozilla-central, with > the exception of

Re: Using the Taskcluster index to find builds

2015-12-02 Thread Ted Mielczarek
On Wed, Dec 2, 2015, at 09:52 AM, Benjamin Smedberg wrote: > In order to correlate telemetry data, I need a time series of all > mozilla-central nightly builds (with version and buildid). It's > important that when there are multiple nightlies on a given date, that I > get all of them. You shou

Re: Proposal to a) rewrite Gecko's encoding converters and b) to do it in Rust

2015-12-04 Thread Ted Mielczarek
On Fri, Dec 4, 2015, at 06:53 AM, Henri Sivonen wrote: > Hi, > > I have written a proposal to a) rewrite Gecko's encoding converters > and b) to do it in Rust: > https://docs.google.com/document/d/13GCbdvKi83a77ZcKOxaEteXp1SOGZ_9Fmztb9iX22v0/edit > > I'd appreciate comments--especially from the o

Re: Proposal to a) rewrite Gecko's encoding converters and b) to do it in Rust

2015-12-14 Thread Ted Mielczarek
On Sun, Dec 13, 2015, at 09:27 PM, Nicholas Nethercote wrote: > On Sun, Dec 13, 2015 at 11:28 AM, Bobby Holley > wrote: > >> > >> I've been wondering about this. There's a big difference between (a) > >> permitting Rust components (while still allowing fallback C++ > >> equivalents) and (b) mand

Re: Status: ASan builds on Windows

2015-12-15 Thread Ted Mielczarek
On Tue, Dec 15, 2015, at 09:36 AM, Nicolas B. Pierron wrote: > The crash reporter is currently disabled on ASan builds, we need to > figure > out why, one hypothesis (I do not recall the author) was that we have > issues > with the SEGV handler. That was my hypothesis. I remember talking to deco

Re: Does js-ctypes supports for nsISupports objects.

2015-12-23 Thread Ted Mielczarek
No, js-ctypes does not have any support for calling methods on C++ classes. In fact, that functionality was WONTFIXed a while back: https://bugzilla.mozilla.org/show_bug.cgi?id=505907. -Ted ___ dev-platform mailing list dev-platform@lists.mozilla.org htt

Non-tier 1 builders: NSPR usage?

2016-01-15 Thread Ted Mielczarek
Hello, I'm interested in feedback from anyone out there that's doing builds on non-Tier 1 platforms. Specifically, I want to know if you build --with-system-nspr or not. I've got patches[1] to stop using NSPR's autoconf build system in favor of moz.build files, but I've only made them support our

Re: Taking screenshots of single elements (XUL/XULRunner)

2016-01-19 Thread Ted Mielczarek
On Tue, Jan 19, 2016, at 01:39 AM, m.bauermeis...@sto.com wrote: > As part of my work on a prototyping suite I'd like to take screenshots > (preferably retaining the alpha channel) of single UI elements. I'd like > to do so on an onclick event. > > Is there a straightforward way to accomplish this

Re: Use of C++11 std::unique_ptr for the WOFF2 module

2016-02-01 Thread Ted Mielczarek
On Mon, Feb 1, 2016, at 04:29 AM, Frédéric Wang wrote: > Dear all, > > I'm trying to upgrade our local copy of OTS to version 5.0.0 [1]. OTS > relies on the Brotli and WOFF2 libraries, whose source code we currently > include in mozilla-cental. > > I tried updating the source code of WOFF2 to the

Re: Using rr chaos mode to find intermittent bugs

2016-02-10 Thread Ted Mielczarek
On Wed, Feb 10, 2016, at 03:04 PM, Robert O'Callahan wrote: > Background: > http://robert.ocallahan.org/2016/02/introducing-rr-chaos-mode.html > > I just landed on rr master support for a "-h" option which enables a > chaos > mode for rr recording. This is designed to help reproduce intermittent

Re: rr chaos mode update

2016-02-16 Thread Ted Mielczarek
I've heard of other companies putting new tests into "quarantine" like this, it's a reasonable idea. I think the suggestion of running new tests under rr chaos mode is to explicitly find timing bugs of the type that chaos mode exposes, which tend to be hard to reproduce otherwise (but manifest as

Re: Status Notifications for New Bugs in DOM, DevTools, and Hello

2016-03-04 Thread Ted Mielczarek
On Fri, Mar 4, 2016, at 07:48 AM, Philip Chee wrote: > On 01/03/2016 03:25, Emma Humphries wrote: > > > With the help of dedicated triage teams for each component, starting this > > week when you file a bug against the DOM, Developer Tools, or Hello in > > Bugzilla you’ll receive an email explaini

Re: Setting property on the element is no longer working on Firefox 45

2016-03-10 Thread Ted Mielczarek
On Thu, Mar 10, 2016, at 01:23 PM, Devan Shah wrote: > hello > > When I set a custom property such as element.listofSomething = [] and > then build the list and add it back to the same element. Then this > element is passed to a function, now in that function I am no longer to > access this proper

Re: Mapping Rust panics to MOZ_CRASH on non-Rust-created threads

2016-03-22 Thread Ted Mielczarek
On Tue, Mar 22, 2016, at 06:51 PM, Brian Smith wrote: > On Tue, Mar 22, 2016 at 3:03 AM, Henri Sivonen > wrote: > > > It seems that the Rust MP4 parser is run a new Rust-created thread in > > order to catch panics. > > > > Is the Rust MP4 parser using panics for flow control (like is common in >

Re: Why is Mozreview hassling me about squashed commits?

2016-04-04 Thread Ted Mielczarek
On Sun, Apr 3, 2016, at 09:09 PM, L. David Baron wrote: > On Saturday 2016-04-02 18:51 -0300, Eric Rescorla wrote: > > 1. I write a bunch of code, committing along the way, so I have a lot of > > commits named "Checkpoint" and "Fix bug" and the like. > > 2. When it works, I push the code up to the

Re: Why is Mozreview hassling me about squashed commits?

2016-04-04 Thread Ted Mielczarek
On Mon, Apr 4, 2016, at 12:46 PM, Steve Fink wrote: > I should clarify that by "non-mq", I really mean using mutable-history > aka evolve. And yes, my workflow does depend on some extensions, > including some local stuff that I haven't cleaned up enough to publish. > (As does my mq workflow; I h

Re: Build System Project - Update from the last 2 weeks

2016-04-08 Thread Ted Mielczarek
No. GCC *has* an LTO optimizer, but we're not using it. We're just doing a PGO build. MSVC requires enabling LTO to use their PGO, so the resulting build has both. -Ted On Fri, Apr 8, 2016, at 05:08 PM, Jeff Gilbert wrote: > I thought Linux did LTO but not PGO? > > On Tue, Apr 5, 2016 at 3:53 PM

Re: Moving XP to ESR?

2016-04-19 Thread Ted Mielczarek
On Tue, Apr 19, 2016, at 04:14 PM, Nils Ohlmeier wrote: > The good news is that dxr does not find anything using IsXPSP3OrLater(). > But this looks like we have a bit of version specific code in our tree: > https://dxr.mozilla.org/mozilla-central/search?q=XP_WIN&redirect=false&case=true FYI, the "

Re: Can MAX_REFLOW_DEPTH be increased?

2016-05-02 Thread Ted Mielczarek
On Mon, May 2, 2016, at 12:51 PM, L. David Baron wrote: > Do you happen to know what the main thread stack size is on the > platforms that we run on? On Windows/x86 it's 1MB, Windows/x86-64 it's 2MB, on Linux and OS X it's 8MB (all reserved, not committed, AIUI). > One risk of such a change: I'm

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-05-03 Thread Ted Mielczarek
On Mon, May 2, 2016, at 08:26 PM, Chris Peterson wrote: > We're tentatively planning to remove NPAPI support (for plugins other > than Flash) in 53 because 52 is the next ESR. We'd like ESR 52 to > support NPAPI as a transition option for enterprise users that rely on > Java. Then we should plan

Updating 32-bit Windows users to 64-bit Windows builds?

2016-05-12 Thread Ted Mielczarek
Hello, Given all the discussion around SSE[2] lately, I was curious as to whether we had made any plans to update Windows users that are running 32-bit Windows builds on a 64-bit Windows OS to our 64-bit Windows builds. The 64-bit Windows builds do use SSE2, since that's a baseline requirement for

Re: Updating 32-bit Windows users to 64-bit Windows builds?

2016-05-12 Thread Ted Mielczarek
ndows through the build target, but information about > plugins or RAM is not something we know about when serving updates. > > On 2016-05-12 11:45 AM, Ted Mielczarek wrote: > > Hello, > > > > Given all the discussion around SSE[2] lately, I was curious as to > > w

Re: Updating 32-bit Windows users to 64-bit Windows builds?

2016-05-12 Thread Ted Mielczarek
On Thu, May 12, 2016, at 12:22 PM, L. David Baron wrote: > On Thursday 2016-05-12 11:45 -0400, Ted Mielczarek wrote: > > requirement for x86-64 processors, and the overall performance should > > generally be better (modulo memory usage, I'm not sure if we have an

Re: How should I measure responsiveness?

2016-05-17 Thread Ted Mielczarek
On Tue, May 17, 2016, at 05:13 PM, Jason Orendorff wrote: > Hi everyone. > > I'm trying to figure out how to measure the effects of a possible change > Morgan Phillips is making to the Slow Script dialog.[1] One specific > thing > we want to measure is "responsiveness" in the few seconds after a u

Re: pushPrefEnv/popPrefEnv/flushPrefEnv now return Promises

2016-05-20 Thread Ted Mielczarek
On Thu, May 19, 2016, at 07:09 PM, Matthew N. wrote: > Hello, > > One of the reasons developers have been avoiding pushPrefEnv compared to > the synchronous set*Pref (with a registerCleanupFunction) is because > pushPrefEnv required using a callback function to wait for the > preference change

Re: Readable Bug Statuses in Bugzilla

2016-05-24 Thread Ted Mielczarek
On Tue, May 24, 2016, at 11:45 AM, Emma Humphries wrote: > Last week the bugzilla.mozilla.org team had a work week in the San > Francisco office. They were finishing the work on the modal edit view in > Bugzilla, and joined them to land another new feature: Readable Statuses. > > Bugs in bugzilla.

Re: Common crashes due to MOZ_CRASH and MOZ_RELEASE_ASSERT

2016-06-01 Thread Ted Mielczarek
On Tue, May 31, 2016, at 09:26 PM, Jeff Gilbert wrote: > On Tue, May 31, 2016 at 4:39 PM, Nicholas Nethercote > wrote: > > On Wed, Jun 1, 2016 at 1:05 AM, Benjamin Smedberg > > wrote: > >> You shouldn't need to annotate the file/line separately, because that is > >> (or at least should be!) the

Re: All about crashes

2016-06-03 Thread Ted Mielczarek
On Wed, May 25, 2016, at 10:27 PM, Eric Rescorla wrote: > - Making it so that certain kinds of defects still happen but they are > safer. > For instance, in C writing dereferencing past the end of an array is > undefined behavior and may well cause something horrible, in Python > you get an e

  1   2   3   >