Re: FYI: We've forked the Breakpad client code

2017-02-13 Thread Nick Fitzgerald
I can review the DWARF related bits in a pinch, too. On Thu, Feb 9, 2017 at 2:04 PM, Mike Hommey wrote: > On Thu, Feb 09, 2017 at 12:41:07PM -0800, Jim Blandy wrote: > > Under the circumstances, I'll volunteer to review, if that's feasible. > > I can too. > > > On Thu, Feb 9, 2017 at 12:37 PM, T

Re: Intent to ship: SourceMap header

2017-05-17 Thread Nick Fitzgerald
Error().stack is not affected by source maps (nor should it be IMO). This is just devtools facing with nothing that is web observable. On Wed, May 17, 2017 at 9:06 AM, Boris Zbarsky wrote: > On 5/17/17 11:01 AM, Tom Tromey wrote: > >> In this case I think this does not apply, because as far as I

Re: Intent to ship: SourceMap header

2017-05-17 Thread Nick Fitzgerald
On Wed, May 17, 2017 at 10:51 AM, Tom Tromey wrote: > > "Boris" == Boris Zbarsky writes: > > >> https://github.com/source-map/source-map-rfc > > Boris> Are there any plans to have a standard here? > > All I found was this: > https://groups.google.com/forum/#!topic/mozilla.dev.js- > sourcemap

Rust bindings to SpiderMonkey on inbound

2017-09-01 Thread Nick Fitzgerald
(cc dev-servo, dev-platfrom; reply to js-engine-internals) Hello everyone! The Rust bindings to SpiderMonkey that Servo uses just landed in mozilla-inbound[0]! You can monitor their test results on taskcluster as the `SM-tc[tier-2](rust)` job. If any of your patches break these tests, please pin

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Nick Fitzgerald
Does `mach try` still require `git cinnabar` when using a `git` checkout of m-c, or does it work with `moz-git-tools` now too? Thanks, Nick On Fri, Sep 15, 2017 at 3:30 PM, Gregory Szorc wrote: > The Try Service ("Try") is a mechanism that allows developers to schedule > tasks in automation. T

Re: Website memory leaks

2017-11-02 Thread Nick Fitzgerald
We have https://bugzilla.mozilla.org/show_bug.cgi?id=1243091 on file for automatic leak detection in the DevTools' memory panel. I'd have liked to try implementing http://www.cs.utexas.edu/ftp/techreports/tr06-07.pdf because it can see through frameworks/libraries (or claims to in a convincing way

Re: Website memory leaks

2017-11-06 Thread Nick Fitzgerald
On Mon, Nov 6, 2017 at 1:53 AM, David Teller wrote: > I wanted to add something like that to about:performance, but at the > time, my impression was that we did not have sufficient platform data on > where allocations come from to provide something convincing. > ​The SpiderMonkey Debugger API ha

Re: easily getting allocation stacks for leaking objects

2015-09-17 Thread Nick Fitzgerald
Note that for JS objects (and JS strings very soon), you can track allocation stacks with the Debugger API: https://developer.mozilla.org/en-US/docs/Tools/Debugger-API/Debugger.Memory On Thu, Sep 17, 2015 at 10:55 AM, Andrew McCreight wrote: > On Thu, Sep 17, 2015 at 7:42 AM, Andrew McCreight

New heap snapshots tool in the developer tools

2015-11-03 Thread Nick Fitzgerald
Hi folks! (Jordan Santell made an announcement on the devtools mailing list[0], but I thought I'd spread the word around.) The first iteration of the new heap snapshots memory tools landed on m-c in the middle of the last cycle and rode the train to Developer Edition with the merge. This tool is

Re: New heap snapshots tool in the developer tools

2015-11-04 Thread Nick Fitzgerald
​On Wed, Nov 4, 2015 at 11:07 AM, David Rajchenbach-Teller < dtel...@mozilla.com> wrote: > That sounds very useful. > > Any chance we can get the same kind of output on the console in case of > mochitest memory leak? > ​I've filed ​https://bugzilla.mozilla.org/show_bug.cgi?id=1221704 to track thi

Dominator tree memory analysis now in Nightly

2016-01-14 Thread Nick Fitzgerald
Hi folks! Dominator trees give you fine-grained insight into memory retention. In a graph rooted by some node R, a node A is said to dominate B iff every path to B starting from R passes through A. In the context of a heap graph, another way to say this would be that A is retaining B: if the garb

Re: Dominator tree memory analysis now in Nightly

2016-01-14 Thread Nick Fitzgerald
Reply inline below. On Thu, Jan 14, 2016 at 2:49 PM, Jared Wein wrote: > From your screenshot, there are a lot of instances of "objects > Array", > "objects > Object", etc. Is the a way to display the variable name used for > those objects? > ​The node might not be in a JS variable (eg​ is a C+

Re: Dominator tree memory analysis now in Nightly

2016-01-19 Thread Nick Fitzgerald
On Sat, Jan 16, 2016 at 5:41 AM, Philip Chee wrote: > This is great! Is there a way of expanding/collapsing the whole tree? > Thunderbird uses "\" (collapse) and "*" (expand). > ​You can use ALT+click on an arrow to expand a​ whole subtree. However, because after a certain depth we start increme

Re: rr chaos mode update

2016-02-16 Thread Nick Fitzgerald
It seems like try/tbpl could automatically detect new test files and run them N times. That way, the developer doesn't have to do it manually, so it is less "intimidating" and also less likely to be skipped by accident or forgotten. Running under rr would be nice, but even without rr this seems li

Re: #include sorting: case-sensitive or -insensitive?

2016-03-28 Thread Nick Fitzgerald
Any reason not to adopt SpiderMonkey's check_spidermonkey_style.py? It deals almost exclusively with header and include related things, and not indent levels, line lengths, or other things that gecko style disagrees with. https://dxr.mozilla.org/mozilla-central/source/config/check_spidermonkey_sty

Re: Coding style for C++ enums

2016-04-08 Thread Nick Fitzgerald
On Fri, Apr 8, 2016 at 9:29 AM, Birunthan Mohanathas < birunt...@mohanathas.com> wrote: > On 8 April 2016 at 18:10, Kartikaya Gupta wrote: > > Others? > > enum class OptionD { > SentenceCaseValues, > ThisWontBeConfusedWithOtherThings > // ... because you need to use OptionD::ThisWontBeConfu

Re: Build System Project - Update from the last 2 weeks

2016-04-08 Thread Nick Fitzgerald
Is there a reason why we aren't using LTO? On Fri, Apr 8, 2016 at 4:35 PM, Ted Mielczarek wrote: > No. GCC *has* an LTO optimizer, but we're not using it. We're just doing > a PGO build. MSVC requires enabling LTO to use their PGO, so the > resulting build has both. > > -Ted > > On Fri, Apr 8, 2

Re: Proposal: use nsresult& outparams in constructors to represent failure

2016-04-21 Thread Nick Fitzgerald
On Thu, Apr 21, 2016 at 3:24 AM, Nicholas Nethercote wrote: > On Thu, Apr 21, 2016 at 7:38 PM, Nicolas Silva > wrote: > > Fallible construction (even with a way to report failure) is annoying if > > only because the object's destructor has to account for the possible > > invalid states. I much p

PSA: Dump GC's retaining paths for any GC thing while debugging with JS::ubi::dumpPaths

2016-04-25 Thread Nick Fitzgerald
Hi everyone! Friendly PSA: sometimes you're debugging a "leak" where the GC considers something reachable and therefore won't collect it, and this happens at an inopportune time for using the devtools memory panel (eg right before a DESTROY_RUNTIME collection), so you can't use the nice GUI for vi

Re: PSA: Dump GC's retaining paths for any GC thing while debugging with JS::ubi::dumpPaths

2016-04-25 Thread Nick Fitzgerald
uses this? > > On Mon, Apr 25, 2016 at 10:19 AM, Nick Fitzgerald > wrote: > >> Hi everyone! >> >> Friendly PSA: sometimes you're debugging a "leak" where the GC considers >> something reachable and therefore won't collect it, and this happen

Re: Static analysis for "use-after-move"?

2016-04-27 Thread Nick Fitzgerald
We could create a MoveGuard, similar to ReentrancyGuard, that sets a `moved = true` flag in debug builds and make methods assert against that. (But it isn't nearly as nice as having borrowck...) On Wed, Apr 27, 2016 at 5:53 PM, smaug wrote: > On 04/28/2016 08:00 AM, Gerald Squelart wrote: > > B

Re: Intent to implement and ship: Changing the toString result on DOM prototype objects

2016-06-03 Thread Nick Fitzgerald
On Fri, Jun 3, 2016 at 8:41 AM, Boris Zbarsky wrote: > Devtools bug: none so far, but maybe we need one? Does devtools rely on > the JSClass name or Object.prototype.toString anywhere? > ​I think we are fine. There are certainly places where we use the `Object.prototype.toString.call(thing) ===

Re: Intent to implement and ship: Changing the toString result on DOM prototype objects

2016-06-06 Thread Nick Fitzgerald
> On Fri, Jun 3, 2016 at 8:21 PM, Nick Fitzgerald > wrote: > >> On Fri, Jun 3, 2016 at 8:41 AM, Boris Zbarsky wrote: >> >> > Devtools bug: none so far, but maybe we need one? Does devtools rely on >> > the JSClass name or Object.prototype.toString anywhere

Re: Intent to implement and ship: Changing the toString result on DOM prototype objects

2016-06-06 Thread Nick Fitzgerald
Ok, I've filed this bug to use @@toStringTag in the debugger instead of Debugger.Object.prototype.class: https://bugzilla.mozilla.org/show_bug.cgi?id=1278310 On Mon, Jun 6, 2016 at 10:35 AM, Boris Zbarsky wrote: > On 6/6/16 12:23 PM, Nick Fitzgerald wrote: > >

Re: New [must_use] property in XPIDL

2016-08-22 Thread Nick Fitzgerald
On Mon, Aug 22, 2016 at 4:39 PM, R Kent James wrote: > On 8/21/2016 9:14 PM, Nicholas Nethercote wrote: > > I strongly encourage people to do likewise on > > any IDL files with which they are familiar. Adding appropriate checks > isn't > > always easy > > Exactly, and I hope that you and others r

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

2016-08-27 Thread Nick Fitzgerald
Thanks Kan-Ru! I've personally tried to include the header with the wrong case multiple times, so I appreciate this change a lot. On Fri, Aug 26, 2016 at 7:54 PM, Kan-Ru Chen wrote: > Hello, > > In Bug 1297276 I landed a patch to rename mozilla/unused.h to > mozilla/Unused.h to make it more cons

Re: So, what's the point of Cu.import, these days?

2016-09-28 Thread Nick Fitzgerald
On Wed, Sep 28, 2016 at 1:19 AM, David Teller wrote: > > * CommonJS > ​Just a heads up: the devtools have been using CommonJS modules and lazily requiring modules for a couple years now. If you don't want to jump directly to ES modules, reusing our infrastructure is probably a good idea. We also

Re: Introducing mozilla::Result for better error handling

2016-12-20 Thread Nick Fitzgerald
Thanks for getting this landed! Hooray for better error handling! \o/ On Tue, Dec 20, 2016 at 5:46 AM, Jan de Mooij wrote: > Hi all, > > A few weeks ago we added mozilla::Result to MFBT [0][1]. I was asked > to inform dev-platform about this, so here's a quick overview. > mozilla::Result is base

Re: Introducing mozilla::Result for better error handling

2016-12-22 Thread Nick Fitzgerald
FWIW, you can also avoid the check-for-error-and-early-return-or-else-unwrap dance that is being "hidden" within MOZ_TRY by using `mozilla::Result::andThen` (and `mozilla::Result::map`) which are on inbound and will be on m-c soon. The patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1324829

Re: Is anyone still using JS strict warnings?

2014-12-19 Thread Nick Fitzgerald
I generally don't find them useful, but instead annoying, and that they provide a lot of noise to filter out to find actual relevant errors. This is including the undefined property errors. It is a common JS style to pass around configuration/option objects that will be missing many properties that

Re: Is anyone still using JS strict warnings?

2014-12-24 Thread Nick Fitzgerald
x27;t use the flag (because that imposes on everyone), and if you want them for your development, you should still be able to use them, but in a way that doesn't force those who don't want them to do so. On Fri, Dec 19, 2014 at 7:05 PM, Jim Blandy wrote: > On Fri, Dec 19, 2014 at 2:22

Re: Good ways to view Firefox compile errors in a terminal?

2015-01-13 Thread Nick Fitzgerald
For those of us using Emacs: I use M-x shell as my terminal, and when combined with compilation-shell-minor-mode, I get the following goodies: * Compilation errors get "syntax" highlighted * Putting the cursor on an error line and pressing RET opens the file in a new (or its existing) buffer and

Compiling m-c within Emacs (was: Re: Good ways to view Firefox compile errors in a terminal?)

2015-01-13 Thread Nick Fitzgerald
​On Tue, Jan 13, 2015 at 10:01 AM, Nathan Froyd wrote: > On Tue, Jan 13, 2015 at 11:52 AM, Nick Fitzgerald > wrote: > >> For those of us using Emacs: >> >> I use M-x shell as my terminal, and when combined with >> compilation-shell-minor-mode, I get the followin

Re: JavaScript code coverage

2015-01-20 Thread Nick Fitzgerald
​On Mon, Jan 19, 2015 at 12:36 PM, Joshua Cranmer 🐧 wrote: > Getting good code coverage (line and branch coverage) ultimately requires > fine-grained instrumentation (ideally bytecode-level) not presented by the > current Debugger. > ​I think you can get fine-grained enough data with the existi

Re: JavaScript code coverage

2015-01-20 Thread Nick Fitzgerald
I recommend reading https://developer.mozilla.org/en-US/docs/Tools/Debugger-API or js/src/doc/Debugger/ for more information. On Tue, Jan 20, 2015 at 1:29 PM, Nick Fitzgerald wrote: > ​On Mon, Jan 19, 2015 at 12:36 PM, Joshua Cranmer [image: 🐧] < > pidgeo...@gmail.com> wrote: >

Re: It is now possible to apply arbitrary tags to tests/manifests and run all tests with a given tag

2015-03-31 Thread Nick Fitzgerald
On Tue, Mar 31, 2015 at 9:30 AM, Andrew Halberstadt < ahalberst...@mozilla.com> wrote: > > ​For example, we may implement a way to run all tests with a given tag > across multiple different suites. > > ​Does this mean that I can't do `./mach​ test --tag foobar` to run both xpcshell and mochitests

Re: The e10s throbber

2015-04-08 Thread Nick Fitzgerald
Yes they are built on the same SPS profiler backend. However, the gecko profiler addon will do things the builtin devtools can't, like open a shell and call `atos` to symbolicate C++ function addresses. See https://bugzilla.mozilla.org/show_bug.cgi?id=1132529 for some context. For the time being

Re: Excessive inbound bustage

2015-04-21 Thread Nick Fitzgerald
On Tue, Apr 21, 2015 at 3:22 PM, Bobby Holley wrote: > It's not about making mistakes - it's about being mis-calibrated with > respect to the rest of the development community. And it's not about > shaming - it's about making people (both the developer and others) aware of > these mismatches so t

Re: Excessive inbound bustage

2015-04-21 Thread Nick Fitzgerald
On Tue, Apr 21, 2015 at 3:39 PM, Bobby Holley wrote: > On Tue, Apr 21, 2015 at 3:32 PM, Nick Fitzgerald > wrote: > >> >> >> ​And this can surely be done via private channels​, without public >> shaming and the potential negatives people have listed elsewhere in

Announcing Operation Instrument

2015-04-27 Thread Nick Fitzgerald
Hello platform hackers!​ ​[​ Operation Instrument ​] (htt ​​ ps://wiki.mozilla.org/DevTools/OperationInstrument)​ is a project that aims to add tracing instrumentation to Gecko and provide a holistic view of where time is being spent and why. Examples of traced operations include: * ​ ​ ​ Style

Re: Announcing Operation Instrument

2015-04-27 Thread Nick Fitzgerald
Wow. Email formatting fail. Hopefully this turns out a little better: """ Hello platform hackers! [Operation Instrument](https://wiki.mozilla.org/DevTools/OperationInstrument) is a project that aims to add tracing instrumentation to Gecko and provide a holistic view of where time is being spent a

Re: Announcing Operation Instrument

2015-04-28 Thread Nick Fitzgerald
This is built on top of the docshell ProfileTimelineMarkers. There is a marker for the start of the traced operation and another for the end of the traced operation. The RAII class mozilla::AutoTimelineMarker simply adds these start and end markers on construction and destruction respectively (but

Re: DXR 2.0 staged. Feedback please!

2015-06-03 Thread Nick Fitzgerald
Looking forward to eventually getting better JS searching via the multi-language support! What is the relative priority of permalinks to specific revisions? On Wed, Jun 3, 2015 at 12:10 PM, Erik Rose wrote: > DXR 2.0 is about to land! This is a major revision touching every part of > the system

Re: Announcing the Content Performance program

2015-06-26 Thread Nick Fitzgerald
From your blog post: > Heavy activity in background tabs badly affects desktop Firefox’s scrolling performance1 (much worse than other browsers — we need E10S) I was under the impression that because e10s is only a single process for all content (at least right now) a background tab can still neg

Re: Announcing the Content Performance program

2015-06-29 Thread Nick Fitzgerald
On Sun, Jun 28, 2015 at 5:14 PM, Nathan Froyd wrote: > On Sun, Jun 28, 2015 at 5:23 PM, Mike Hommey wrote: > > > > BTW, wasn't there an effort a few couple years ago, to move content > > event loop in different threads for different tabs? What happened to > > that? > > > > If you are referring t

Re: GTK3 linux builds

2015-07-07 Thread Nick Fitzgerald
One more group of defectors within Mozilla. From the DevTools coding standards[0]: """ - aArguments aAre the aDevil (don't use them please) """ Although, there are still some files in tree with the legacy style. [0] https://wiki.mozilla.org/DevTools/CodingStandards#Code_style On Tue, Jul 7

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread Nick Fitzgerald
(Posted this reply to the wrong thread, reposting to the right one... >_<) One more group of defectors within Mozilla. From the DevTools coding standards[0]: """ - aArguments aAre the aDevil (don't use them please) """ Although, there are still some files in tree with the legacy style. [0]